mariadb

Tree: 241d30d3fa

Author	SHA1	Message	Date
Eugene Kosov	4c80dcda46	fix gcc optimized build ../sql/spatial.cc: In member function ‘double Gis_point::calculate_haversine(const Geometry, double, int)’: ../sql/spatial.cc:1093:45: error: ‘y1r’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 1093 \| res= 2sphere_radiusasin((sqrt(dlat + cos(y1r)cos(y2r)dlong))); \| ~~~^~~~~ ../sql/spatial.cc:1092:20: error: ‘x1r’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 1092 \| dlong= sin((x2r - x1r)/2)sin((x2r - x1r)/2); \| ~~~~~^~~~~~ ../sql/spatial.cc:1093:54: error: ‘y2r’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 1093 \| res= 2sphere_radiusasin((sqrt(dlat + cos(y1r)cos(y2r)dlong))); \| ~~~^~~~~ ../sql/spatial.cc:1092:20: error: ‘x2r’ may be used uninitialized in this function [-Werror=maybe-uninitialized] 1092 \| dlong= sin((x2r - x1r)/2)sin((x2r - x1r)/2); \| ~~~~~^~~~~~ c	5 years ago
Srinidhi Kaushik	5bc5ecce08	MDEV-24197: Add "innodb_force_recovery" for "mariabackup --prepare" During the prepare phase of restoring backups, "mariabackup" does not seem to allow (or recognize) the option "innodb_force_recovery" for the embedded InnoDB server instance that it starts. If page corruption observed during page recovery, the prepare step fails. While this is indeed the correct behavior ideally, allowing this option to be set in case of emergencies might be useful when the current backup is the only copy available. Some error messages during "--prepare" suggest to set "innodb_force_recovery" to 1: [ERROR] InnoDB: Set innodb_force_recovery=1 to ignore corruption. For backwards compatibility, "mariabackup --innobackupex --apply-log" should also have this option. Signed-off-by: Srinidhi Kaushik <shrinidhi.kaushik@gmail.com>	5 years ago
mkaruza	f93e087d74	MDEV-25047: SIGSEGV in mach_read_from_n_little_endian Virtual column fields are not found in prebuilt data type, so we should match InnoDB fields with `get_innobase_type_from_mysql_type` method. Reviewed-by: Jan Lindström <jan.lindstrom@mariadb.com>	5 years ago
Aleksey Midenkov	77ffbbca49	MDEV-25172 Wrong error message for ADD COLUMN .. AS ROW START Handle one more condition in fix_alter_info() for non-versioned table and produce ER_VERS_NOT_VERSIONED error.	5 years ago
Aleksey Midenkov	0c99e6e9a6	MDEV-22562 Assertion `next_insert_id == 0' upon UPDATE on system-versioned table Don't update autoinc counter on history row insert. Uniqueness is kept due to merge with row_end.	5 years ago
Aleksey Midenkov	af52a0e516	MDEV-24690 Dropping primary key column from versioned table always fails with 1072 Exclude system-invisible key-parts from MDEV-11114 (`04b288ae`) restriction.	5 years ago
Aleksey Midenkov	b9d1c6574b	MDEV-23446 goto error cleanup	5 years ago
Vladislav Vaintroub	453bac08c2	CMake - when searching bison, look also for win_bison win_bison belongs winflexbison project, which is Windows most up-to-date bison distro.	5 years ago
Vladislav Vaintroub	08cb5d8483	MDEV-25221 Do not remove source file, if copy_file() fails in mariabackup --move-back Remove an incompletely copied destination file.	5 years ago
Marko Mäkelä	35ee4aa4e3	MDEV-13103 fixup: Actually fix a crash during IMPORT TABLESPACE	5 years ago
Marko Mäkelä	d6d3d9ae2f	Merge 10.2 into 10.3	5 years ago
David CARLIER	99945d77d7	MDEV-25294 signal handler display coredump on mac	5 years ago
Thirunarayanan Balathandayuthapani	b771ab242b	MDEV-25200 Index count mismatch due to aborted FULLTEXT INDEX - Aborting of fulltext index creation fails to remove the index from sys indexes table. When we try to reload the table definition, InnoDB fails with index count mismatch error. InnoDB should remove the index from sys indexes while rollbacking the secondary index creation.	5 years ago
Thirunarayanan Balathandayuthapani	108ba4c380	MDEV-15527 page_compressed compressed page partially during import tablespace - Post push to address 32-bit build failure.	5 years ago
Marko Mäkelä	7c423c26d9	Add missing have_perfschema.inc	5 years ago
Thirunarayanan Balathandayuthapani	c468d5cb50	MDEV-15527 page_compressed compressed page partially during import tablespace - Importing table operation fails to punch the hole in the filesystem when page compressed table is involved. To achieve that, InnoDB firstly punches the hole for the IOBuffer size(1MB). After that, InnoDB should write page by page when page compression is involved.	5 years ago
Jan Lindström	dfda1c9283	Add supression for warning.	5 years ago
Jan Lindström	d217a925b2	MDEV-24923 : Port selected Galera conflict resolution changes from 10.6 Add condition on trx->state == TRX_STATE_COMMITTED_IN_MEMORY in order to avoid unnecessary work. If a transaction has already been committed or rolled back, it will release its locks in lock_release() and let the waiting thread(s) continue execution. Let BF wait on lock_rec_has_to_wait and if necessary other BF is replayed. wsrep_trx_order_before If BF is not even replicated yet then they are ordered correctly. bg_wsrep_kill_trx Make sure victim_trx is found and check also its state. If state is TRX_STATE_COMMITTED_IN_MEMORY transaction is already committed or rolled back and will release it locks soon. wsrep_assert_no_bf_bf_wait Transaction requesting new record lock should be TRX_STATE_ACTIVE Conflicting transaction can be in states TRX_STATE_ACTIVE, TRX_STATE_COMMITTED_IN_MEMORY or in TRX_STATE_PREPARED. If conflicting transaction is already committed in memory or prepared we should wait. When transaction is committed in memory we held trx mutex, but not lock_sys->mutex. Therefore, we could end here before transaction has time to do lock_release() that is protected with lock_sys->mutex. lock_rec_has_to_wait We very well can let bf to wait normally as other BF will be replayed in case of conflict. For debug builds we will do additional sanity checks to catch unsupported bf wait if any. wsrep_kill_victim Check is victim already in TRX_STATE_COMMITTED_IN_MEMORY state and if it is we can return. lock_rec_dequeue_from_page lock_rec_unlock Remove unnecessary wsrep_assert_no_bf_bf_wait function calls. We can very well let BF wait here.	5 years ago
Daniel Black	c44273329e	remove broken tests/grant.pl	5 years ago
Daniel Black	fb3b2eb517	mallinfo2: whitespace fix	5 years ago
Vladislav Vaintroub	add24e7889	Windows - suppress nonsensical(for this OS) system check. Amends `48141f3c17`	5 years ago
Daniel Black	85b6a81805	MDEV-24586: remove mysql_to_mariadb.sql This script is unused and unmaintained. The logic is implemented in scripts/mysql_system_tables_fix.sql that forms part of mysql_upgrade Its components: alter table mysql.user drop column `password_last_changed`, drop column `password_lifetime`, drop column `account_locked`; has a friendlier migration path coming MDEV-24122 alter table mysql.user change column `authentication_string` `auth_string` text COLLATE utf8_bin NOT NULL; Already part of scripts/mysql_system_tables_fix.sql alter table mysql.user add column `Password` char(41) CHARACTER SET latin1 COLLATE latin1_bin NOT NULL DEFAULT '' after `user`, add column `is_role` enum('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N' after `auth_string`; alter table mysql.user add column `default_role` char(80) COLLATE utf8_bin NOT NULL DEFAULT '', add column `max_statement_time` decimal(12,6) NOT NULL DEFAULT '0.000000'; corrected in MDEV-23201 to be in the right order. update mysql.user set `password`=`auth_string`, plugin='' where plugin="mysql_native_password"; Is handled in server in the function acl_load.	5 years ago
Alexey Yurchenko	4d870b591d	Don't pass password to innobackup via command line, use environment instead Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	5 years ago
Alexey Botchkov	94dea8ef5b	MDEV-25457 CREATE / DROP PROCEDURE not logged with audit plugin. CREATE/DROP PROCEDIRE/FUNCTION is now treated as DDL.	5 years ago
Alexey Bychko	c0ca3c4ffa	MDEV-25240 minor upgrade does not perform server restart we need to stop server instance on upgrade, but it may be started either by SysV init script or by SystemD. this commit adds `mysql` target to `systemctl stop` call. `mysql` may be the name of initscript or an alias while `mariadb` is a systemd unit file.	5 years ago
Anel Husakovic	2fc76a5022	MDEV-13467: Feature request: Support for ST_Distance_Sphere() - jump to label ‘handle_errors’ can enter to the scope of non-POD ‘Geometry_buffer buffer2’	5 years ago
Alexey Botchkov	96475b78c5	MDEV-25457 CREATE / DROP PROCEDURE not logged with audit plugin. CREATE/DROP PROCEDIRE/FUNCTION is now treated as DDL.	5 years ago
Marko Mäkelä	3157fa182a	Merge 10.2 into 10.3	5 years ago
Anel Husakovic	5eda18f0ca	MDEV-25272: Wrong function name in error messages upon ST_GeomFromGeoJSON call - Invalid function name during ER_WRONG_VALUE_FOR_TYPE and ER_GIS_INVALID_DATA	5 years ago
Anel Husakovic	6769d1a078	MDEV-13467: Feature request: Support for ST_Distance_Sphere() - Cherry-pick `51e48b9f89` - vscode gitignore - Thanks Robin Dupret for the review. Reviewed by:daniel@mariadb.org holyfoot@mariadb.com	5 years ago
Michael Okoko	48141f3c17	Replace mallinfo with mallinfo2 on supported systems `mallinfo` is deprecated since glibc 2.33 and has been replaced by mallinfo2. The deprecation causes building the server to fail if glibc version is > 2.33. Check if mallinfo2 exist on the system and use it instead.	5 years ago
Eugene Kosov	36a05268e7	cmake cleanup: drop support for ancient clang in WITH_ASAN option	5 years ago
Eugene Kosov	dfae51de36	MDEV-25238 add support for -fsanitize-address-use-after-scope Use like this: cmake -DWITH_ASAN=ON -DWITH_ASAN_SCOPE=ON	5 years ago
Marko Mäkelä	a6d66fe75e	MDEV-24786: row_upd_clust_step() skips mtr_t::commit() on virtual column error The function row_upd_clust_step() is invoking several static functions, some of which used to commit the mini-transaction in some cases. If innobase_get_computed_value() would fail due to some reason, we would fail to invoke mtr_t::commit() and release buffer pool page latches. This would likely lead to a hanging server later. This regression was introduced in commit `97db6c15ea` (MDEV-20618). row_upd_index_is_referenced(), row_upd_sec_index_entry(), row_upd_sec_index_entry(): Cleanup: Replace some ibool with bool. row_upd_clust_rec_by_insert(), row_upd_clust_rec(): Guarantee that the mini-transaction will always remain in active state. row_upd_del_mark_clust_rec(): Guarantee that the mini-transaction will always remain in active state. This fixes one "leak" of mini-transaction on DB_COMPUTE_VALUE_FAILED. row_upd_clust_step(): Use only one return path, which will always invoke mtr.commit(). After a failed row_upd_store_row() call, we will no longer "leak" the mini-transaction. This fix was verified by RQG on 10.6 (depending on MDEV-371 that was introduced in 10.4). Unfortunately, it is challenging to create a regression test for this, and a test case could soon become invalid as more bugs in virtual column evaluation are fixed.	5 years ago
Vladislav Vaintroub	da26e2e673	Cleanup - reduce duplicate code, in SSL IO error handling.	5 years ago
Sergei Golubchik	5a79807119	MDEV-25242 Server crashes in check_grant upon invoking function with userstat enabled use check_grant(..., number_of_tables=1, ...) if you only need to check privileges for one table	5 years ago
Vladislav Vaintroub	cdb86faf82	MDEV-23740 postfix - potentially uninitialized variable passed to vio_socket_io_wait. Thanks to Daniel Black for reporting.	5 years ago
Igor Babaev	480a06718d	MDEV-25128 Wrong result from join with materialized semi-join and splittable derived If one of joined tables of the processed query is a materialized derived table (or view or CTE) with GROUP BY clause then under some conditions it can be subject to split optimization. With this optimization new equalities are injected into the WHERE condition of the SELECT that specifies this derived table. The injected equalities are generated for all join orders with which the split optimization can employed. After the best join order has been chosen only certain of this equalities are really needed. The others can be safely removed. If it's not done and some of injected equalities involve expressions over semi-joins with look-up access then the query may return a wrong result set. This patch effectively removes equalities injected for split optimization that are needed only at the optimization stage and not needed for execution. Approved by serg@mariadb.com	5 years ago
Sergei Golubchik	c4807c107a	MDEV-24879 Client crash on undefined charsetsdir	5 years ago
Daniele Sciascia	3dae564703	Follow up fixes for making @@wsrep_provider read-only * Remove usage of wsrep_provider variable in galera_ist_restart_joiner * Rename galera_load_provider.inc and galera_unload_provider.inc to galera_stop_replication.inc and galera_start_replication.inc. Their original names were no longer reflecting what these include files do. followup for `ce3a2a688d` Reviewed-by: Jan Lindström <jan.lindstrom@mariadb.com>	5 years ago
Alexey Bychko	7d5ec9f1ae	fixed typo in postinst script	5 years ago
Alexey Bychko	9e57bd278f	fixed typo in postinst script	5 years ago
Igor Babaev	8f7a6cde58	MDEV-24767 Wrong result when forced BNLH is used for join supported by compound index This typo bug may lead to wrong result sets for equi-join queries where the join operation is supported by a compound index such that the order of its components differs from the order of the corresponding columns in the table the index belongs to. The bug manifests itself only when usage of the BNLH algorithm is forced. The fix for the bug was provided by Chu Huaxing.	5 years ago
Marko Mäkelä	56274bd5e4	MDEV-23076 Misleading "InnoDB: using atomic writes" As suggested by Vladislav Vaintroub, let us remove misleading and malformatted startup messages. Even if the global variable srv_use_atomic_writes were set, we would still invoke my_test_if_atomic_write() to check if writes are atomic with a particular page size. When using the default innodb_page_size=16k, page writes should be atomic on NTFS when using ROW_FORMAT=COMPRESSED and KEY_BLOCK_SIZE<=4. Disabling srv_use_atomic_writes when innodb_file_per_table=OFF does not make sense, because that is a dynamic parameter. We also correct the documentation string of innodb_use_atomic_writes and remove the duplicate variable innobase_use_atomic_writes.	5 years ago
Marko Mäkelä	0f8caadc96	MDEV-22653: Remove the useless parameter innodb_simulate_comp_failures The debug parameter innodb_simulate_comp_failures injected compression failures for ROW_FORMAT=COMPRESSED tables, breaking the pre-existing logic that I had implemented in the InnoDB Plugin for MySQL 5.1 to prevent compressed page overflows. A much better check is already achieved by defining UNIV_ZIP_COPY at the compilation time. (Only UNIV_ZIP_DEBUG is part of cmake -DWITH_INNODB_EXTRA_DEBUG=ON.)	5 years ago
Marko Mäkelä	61e00db6ad	MDEV-24796 Assertion `page_has_next... failed in btr_pcur_store_position() In commit `eaeb8ec4b8` (MDEV-24653) an incorrect debug assertion was introduced. btr_pcur_store_position(): If the only record in the page is the instant ALTER TABLE metadata record, we cannot expect there to be a successor page. The situation could be improved by MDEV-24673 later.	5 years ago
Dmitry Shulga	0e96570171	Added missed ' -- ' between the end of the lldb command options and the beginning of the arguments.	5 years ago
Daniel Black	b58b289827	MDEV-25195: pam check getgrouplist function AIX doesn't have getgrouplist so ensure function is checked. The HAVE_POSIX_GETGROUPLIST check was insufficient.	5 years ago
Alexey Yurchenko	209e8ecf9a	MDEV-22240: don't use pc.splitbrain=true on node2 in galera.galera_gcache_recover	5 years ago
Alice Sherepa	0f3045e432	fix for engines/funcs/rpl_sp.test	5 years ago

... 4 5 6 7 8 ...

188297 Commits (241d30d3faac0fbbcb7bcfad3dcc118bb03eceb0) All Branches Search

188297 Commits (241d30d3faac0fbbcb7bcfad3dcc118bb03eceb0)

All Branches