mariadb

Tree: 241d30d3fa

Author	SHA1	Message	Date
Marko Mäkelä	241d30d3fa	After-merge fixes for MDEV-14180	4 years ago
Marko Mäkelä	c9a85fb1b1	Merge 10.2 into 10.3	4 years ago
Marko Mäkelä	773a07b655	Remove Travis CI status Builds on travis-ci.org ceased on 2021-06-15.	4 years ago
Sergei Golubchik	068246c006	fix spider tests for --ps spider tests use --let $var= many;sql;statements --eval $var and this doesn't work in ps	4 years ago
Sergei Golubchik	a5f6eca50d	spider tests aren't big and never disable tests in suite.pm based on $::opt_big_test, this will make the test skipped both as too big (for ./mtr) and as too small (for ./mtr --big --big).	4 years ago
Thirunarayanan Balathandayuthapani	cd1a195b22	MDEV-25947 innodb_fts.misc_debug fails in buildbot - Make innodb_fts.misc_debug test case more stable.	4 years ago
Sergei Golubchik	35b57c37bb	MDEV-25617 10.5.10 upgrade: "scriptlet / line 6 : [: is-active : binary operator expected"	5 years ago
Marko Mäkelä	c307dc6efd	Remove a unused variable In commit `1c35a3f6fd` a useless computation that used the variable was removed.	4 years ago
Julius Goryavsky	2edb8e12e1	MDEV-25880 part 2: Improving reliability of the SST scripts Additional improvements aimed at improving operational reliability of the SST scripts: 1) Script need to give rsync and stunnel a short time to terminate after "kill -9" before the first PID check using ps utility; 2) The temporary file used to create the binlog index could sometimes remain in the data directory if tar failed and then may be reused without being cleaned up (the next time when SST was run) - now it's fixed; 3) The temporary file used to build the binlog index is now created using mktemp and, if this variable is present in the configuration file, in tmpdir; 4) Checking the secret tag in SST via rsync is made faster and does not require creating a temporary file, which could remain in the data directory in case of failure; 5) Added "-F" option to grep to check the tag when using mariabackup/xtrabackup-v2 - to avoid possible collisions in case of special characters in the tag value (unlikely scenario, but the new check is more reliable).	4 years ago
Julius Goryavsky	18d5be5b54	MDEV-25880: rsync may be mistakenly killed when overlapping SST This commit fixes a bug was originally discovered during the galera_nbo_sst_slave mtr test for 10.6 branch. However it is relevant for all versions and can lead to intermittent SST crashes via rsync on very fast server restarts - when a new SST process (for example, after starting a new server instance) overlaps the old SST process started by the previous, already terminated server. This overlap can result in the new rsync being killed instead of the old rsync, or the pid file from the new rsync being killed, which then lead to problems.	5 years ago
Eugene Kosov	1c35a3f6fd	fix clang build a new warning -Wunused-but-set-variable was introduced recently to clang	4 years ago
Thirunarayanan Balathandayuthapani	7d591cf850	MDEV-24713 Assertion `dict_table_is_comp(index->table)' failed in row_merge_buf_add() - During online alter conversion from compact to redundant, virtual column field length already set during innobase_get_computed_value(). Skip the char(n) check for virtual column in row_merge_buf_add()	4 years ago
Thirunarayanan Balathandayuthapani	7229107e3e	MDEV-25872 InnoDB: Assertion failure in row_merge_read_clustered_index upon ALTER on table with indexed virtual columns - InnoDB fails to check DB_COMPUTE_VALUE_FAILED error in row_merge_read_clustered_index() and wrongly asserts that the buffer shouldn't be ran out of memory. Alter table should give warning when the column value is being truncated.	4 years ago
Thirunarayanan Balathandayuthapani	8c7d8b716c	MDEV-14180 Automatically disable key rotation checks for file_key_managment plugin Problem: ======= - InnoDB iterates the fil_system space list to encrypt the tablespace in case of key rotation. But it is not necessary for any encryption plugin which doesn't do key version rotation. Solution: ========= - Introduce a new variable called srv_encrypt_rotate to indicate whether encryption plugin does key rotation fil_space_crypt_t::key_get_latest_version(): Enable the srv_encrypt_rotate only once if current key version is higher than innodb_encyrption_rotate_key_age fil_crypt_must_default_encrypt(): Default encryption tables should be added to default_encryp_tables list if innodb_encyrption_rotate_key_age is zero and encryption plugin doesn't do key version rotation fil_space_create(): Add the newly created space to default_encrypt_tables list if fil_crypt_must_default_encrypt() returns true Removed the nondeterministic select from innodb-key-rotation-disable test. By default, InnoDB adds the tablespace to the rotation list and background crypt thread does encryption of tablespace. So these select doesn't give reliable results.	4 years ago
Thirunarayanan Balathandayuthapani	7d2c338c48	MDEV-14180 preparation: Rename key_rotation_list - Rename the rotation list to default_encrypt_tables in fil_system_t. Because rotation list naming could be misleading when it comes to key version rotation - Rename is_in_rotation_list to is_in_default_encrypt in fil_space_t - Rename keyrotate_next function to default_encrypt_next fil_system_t::default_encrypt_next(): Find the next suitable default encrypt table if beginning of default_encrypt_tables list has been scheduled to be deleted	5 years ago
Daniel Black	be243ed9e3	cmake OpenBSD copyright notice correction Brad Smith made this OpenBSD file based of the FreeBSD cmake directives in commit `ab58904367` by the Monty Program Ab. As such the Oracle Copyright header isn't really applicable.	4 years ago
Jordy Zomer	ec4df51414	eventscheduler mismatch of my_{malloc,free}, delete Fix malloc/delete mismatch. This causes a double free in the cleanup. closes #1845	4 years ago
Vladislav Vaintroub	2e33f574b3	update libmariadb	4 years ago
Sergei Golubchik	c9f9e38bb5	fix mysqlest crash on ./mtr --sp innodb_fts.innodb-fts-stopword	5 years ago
Sergei Golubchik	887f46a618	fix mysqltest crash report output * read_command_buf is a pointer now, sizeof() no longer reflects its length, read_command_buflen is. * my_safe_print_str() prints multiple screens of '\0' bytes after the query end and up to read_command_buflen. Use fprintf() instead. * when setting connection->name to "-closed_connection-" update connection->name_len to match.	5 years ago
Brad Smith	4352c77c5a	Link with libexecinfo on OpenBSD for stacktrace functionality.	5 years ago
Otto Kekäläinen	152c83d49c	MDEV-20392: Skip ABI check if 'diff' is not found Not all environments have 'diff' installed. Most notably CentOS 8 does not have diff out-of-the-box. Thus users running 'cmake .' and 'make' would fail to build MariaDB, and they would think the error was in ABI incompatibilities due to the error message emitted by CMake when in reality simply 'diff' was missing. This fixes it and makes the developer experience better by simply skipping the diffing if 'diff' is not found. Closes #1846	5 years ago
Marko Mäkelä	396864c6b3	Remove orphan type name trx_sig_t This was missed in commit `1d0f70c2f8`.	5 years ago
Elena Stepanova	7a1eff0a9d	MDEV-25884 Tests use environment $USER variable without quotes	5 years ago
Sergei Petrunia	c872125a66	MDEV-25630: Crash with window function in left expr of IN subquery * Make Item_in_optimizer::fix_fields inherit the with_window_func attribute of the subquery's left expression (the subquery itself cannot have window functions that are aggregated in this select) * Make Item_cache_wrapper::Item_cache_wrapper() inherit with_window_func attribute of the item it is caching.	5 years ago
Marko Mäkelä	75a65d3201	MDEV-25886 CHECK TABLE crash with DB_MISSING_HISTORY if innodb_read_only Occasionally, the test innodb.alter_copy would fail in MariaDB 10.6.1, reporting DB_MISSING_HISTORY during CHECK TABLE. It started to occur during the development of MDEV-25180, which introduced purge_sys.stop_SYS(). If we delay purge more during DDL operations, then the test would almost always fail. The reason is that during startup we will restore a purge view, and CHECK TABLE would still use REPEATABLE READ even though innodb_read_only is set and other isolation levels than READ UNCOMMITTED are not guaranteed to work. ha_innobase::check(): Use READ UNCOMMITTED isolation level if innodb_read_only is set or innodb_force_recovery exceeds 3. dict_set_corrupted(): Do not update the persistent data dictionary if innodb_force_recovery exceeds 3.	5 years ago
Marko Mäkelä	6e9642beb2	Merge 10.2 into 10.3	5 years ago
Marko Mäkelä	dfa2d0bc13	MDEV-25869 Change buffer entries are lost on InnoDB restart buf_read_ibuf_merge_pages(): If space->size is 0, invoke fil_space_get_size() to determine the size of the tablespace by reading the header page. Only after that proceed to delete any entries that are beyond the end of the tablespace. Otherwise, we could be deleting valid entries that actually need to be applied. This fixes a regression that had been introduced in commit `b80df9eba2` (MDEV-21069), which aimed to avoid crashes during DROP TABLE of corrupted tables.	5 years ago
Igor Babaev	8149e4d0a1	MDEV-25682 Explain shows an execution plan different from actually executed If a select query contained an ORDER BY clause that followed a LIMIT clause or an ORDER BY clause or ORDER BY with LIMIT the EXPLAIN output for the query showed an execution plan different from that was actually executed. Approved by Roman Nozdrin <roman.nozdrin@mariadb.com>	5 years ago
Otto Kekäläinen	3c922d6def	Revert "CONNECT: move jar files to /usr/share and include them in DEBs" This partially reverts commit `d7321893d8`. The *.jar files are not being built and all Debian builds are failing as dh_install stops on missing files. To build them we would need to also add new Java build dependencies. In a stable release (10.2->10.5) we shouldn't add new files and certainly not any new build dependencies, so reverting commit. Also, the files are located in a different path, and already included in the mariadb-test-data package: /usr/share/mysql/mysql-test/plugin/connect/connect/std_data/JavaWrappers.jar /usr/share/mysql/mysql-test/plugin/connect/connect/std_data/JdbcMariaDB.jar /usr/share/mysql/mysql-test/plugin/connect/connect/std_data/Mongo2.jar /usr/share/mysql/mysql-test/plugin/connect/connect/std_data/Mongo3.jar This change needs to be redesigned and applies only on 10.6 or newer.	5 years ago
Vladislav Vaintroub	9f9a925c39	MDEV-23815 Windows : mysql_upgrade_wizard fails, if service name has spaces The fix is to quote service name parameter, when it is passed to mysql_upgrade_service subprocess.	5 years ago
Vladislav Vaintroub	cebc435592	MDEV-25859 - HeidiSQL 11.3	5 years ago
Vladislav Vaintroub	b1b4d67bcd	MDEV-21373 DBUG compilation - bad synchronization in ha_heap::external_lock() ha_heap::external_lock contains some consistency checks for the table,# in a debug compilation. This code suffers from lack of synchronization, in a rare case where mysql_lock_tables() fail, and unlock is forced, even if lock was not previously taken. To workaround, require EXTRA_DEBUG compile definition in order to activate the consistency checks.The code still might be useful in some cases - but the audience are developers looking for errors in single-threaded scenarios, rather than multiuser stress-tests.	5 years ago
Anel Husakovic	7eed97ed9f	MDEV-25777: JAVA_INCLUDE_PATH and JAVA_INCLUDE_PATH2 not found with out of source configuration and Ninja generator - As solution `PLUGIN_CONNECT=NO` use early check to disable plugin: Solution suggested by wlad@mariadb.com - `JNI_FOUND` is a internal result variable and should be set with cached library and header variables (like `JAVA_INCLUDE_PATH`) defined. * Note: wrapper cmake/FindJNI.cmake runs first time and cmake native Find<module> returns only cached variable, like `JAVA_INCLUDE_PATH`, results variable are not cached). Reviewed by: serg@mariadb.com	5 years ago
Marko Mäkelä	2d38c5e64e	MDEV-17749 fixup: ./mtr --embedded main.lock_kill (again)	5 years ago
Igor Babaev	663bc849b5	MDEV-25714 Join using derived with aggregation returns incorrect results If a join query uses a derived table (view / CTE) with GROUP BY clause then the execution plan for such join may employ split optimization. When this optimization is employed the derived table is not materialized. Rather only some partitions of the derived table are subject to grouping. Split optimization can be applied only if: - there are some indexes over the tables used in the join specifying the derived table whose prefixes partially cover the field items used in the GROUP BY list (such indexes are called splitting indexes) - the WHERE condition of the join query contains conjunctive equalities between columns of the derived table that comprise major parts of splitting indexes and columns of the other join tables. When the optimizer evaluates extending of a partial join by the rows of the derived table it always considers a possibility of using split optimization. Different splitting indexes can be used depending on the extended partial join. At some rare conditions, for example, when there is a non-splitting covering index for a table joined in the join specifying the derived table usage of a splitting index to produce rows needed for grouping may be still less beneficial than usage of such covering index without any splitting technique. The function JOIN_TAB::choose_best_splitting() must take this into account. Approved by Oleksandr Byelkin <sanja@mariadb.com>	5 years ago
Sergei Golubchik	5c896472b6	MDEV-25672 table alias from previous statement interferes later commands only perform the "correct table name" check for new generated columns, but not for already existing ones - they're guaranteed to be valid	5 years ago
Igor Babaev	2e78910806	MDEV-25635 Assertion failure when pushing from HAVING into WHERE of view This bug could manifest itself after pushing a where condition over a mergeable derived table / view / CTE DT into a grouping view / derived table / CTE V whose item list contained set functions with constant arguments such as MIN(2), SUM(1) etc. In such cases the field references used in the condition pushed into the view V that correspond set functions are wrapped into Item_direct_view_ref wrappers. Due to a wrong implementation of the virtual method const_item() for the class Item_direct_view_ref the wrapped set functions with constant arguments could be erroneously taken for constant items. This could lead to a wrong result set returned by the main select query in 10.2. In 10.4 where a possibility of pushing condition from HAVING into WHERE had been added this could cause a crash. Approved by Sergey Petrunya <sergey.petrunya@mariadb.com>	5 years ago
Marko Mäkelä	aa70690e9a	Merge 10.2 into 10.3	5 years ago
Marko Mäkelä	4847a2e730	MDEV-17749 fixup: ./mtr --embedded main.lock_kill	5 years ago
Marko Mäkelä	a8434c6c59	MDEV-25730 fixup: GCC -Og -Wmaybe-uninitialized Silence a warning about an uninitialized variable that was introduced by commit `d8fa71a089`.	5 years ago
Marko Mäkelä	950a220060	Merge 10.2 into 10.3	5 years ago
Julius Goryavsky	2fb4407827	MDEV-25818: RSYNC SST failed due to busy port This commit reduces the likelihood of getting a busy port on quick restarts with rsync SST (problem MDEV-25818) and fixes a number of other flaws in SST scripts, adds new functionality, and also synchronizes the xtrabackup-v2 script with the mariabackup script (the latter applies only to the 10.2 branch): 1) SST via rsync: rsync and stunnel does not always get the right time to complete by correctly handling SIGTERM. These utilities are now given more time to complete normally (via normal SIGTERM processing) before we move on to using "kill -9"; 2) SST via rsync: attempts to terminate an rsync or stunnel process (via "kill" utility) are only made if it did not terminated on its own; 3) SST via rsync: if a combination of stunnel and rsync is used, then we need to wait for both utilities to finish or stop, not just one of them; 4) The config file and pid file for stunnel are now deleted after successful completion of SST on the donor node; 5) The configs and pid files from rsync and stunnel should not be deleted unless these utilities succeed (or are sucessfully terminated) on the joiner node; 6) The configs and pid files now excluded from transfer via rsync; 7) Spaces in paths are now valid for config files as well (when used with SST via rsync or mariabackup / xtrabackup[-v2]); 8) SST via mariabackup: added preliminary verification of keys and certificates that are used when establishing a connection using SSL (to avoid long timeouts and improve diagnostics) - by analogy with how it is done for the xtrabackup-v2 (plus check for CA file), while that check is skipped if the user does not have openssl installed (or does not have diff utility); 9) Added backup-threads=<n> configuration option which adds "--parallel=<n>" for mariabackup / xtrabackup at backup and move-back stages; 10) Added encrypt-threads and encrypt-chunk-size configuration options for xbcrypt management (when xbcrypt is used); 11) Small optimization: checking the socat version and adding a file with parameters for 2048-bit Diffie-Hellman (if necessary) is done only if the user has not specified "dhparam=" in the "sockopt" option value; 12) SST via rsync now supports "backup-threads" configuration option (in server-related sections or in the "[sst]"); 13) Determining the number of available processors is now supported for FreeBSD + mariabackup/xtrabackup: before that we might have problems with "--compact" (rebuild indexes) or qpress on FreeBSD; 14) The check_pid() function should not raise an error state in the rare cases when the pid file was created, but it is empty, or if it is deleted right during the check, or when zero is read from the pid file; 15) Iproved templates that are used to check if a requested socket is "listening" when using the ss utility; 16) Shortened some other templates for socket state utilities; 17) Temporary files created by mariabackup / xtrabackup are moved to a separate subdirectory inside tmpdir (so they don't get mixed with other temporary files, which can make debugging more difficult); 18) 10.2 only: the script for SST via xtrabackup-v2 has been brought in full compliance with all the bugfixes made for mariabackup (as it previously contained many flaws compared to the updated script for mariabackup).	5 years ago
Vladislav Vaintroub	d3c77e08ae	MDEV-20556 Remove references to "xtrabackup" and "innobackupex" in mariabackup --help	5 years ago
Dmitry Shulga	91bde0fb67	MDEV-25576: The statement EXPLAIN running as regular statement and as prepared statement produces different results for UPDATE with subquery Both EXPLAIN and EXPLAIN EXTENDED statements produce different results set in case it is run in normal way and in PS mode for the statements UPDATE/DELETE with subquery. The use case below reproduces the issue: MariaDB [test]> CREATE TABLE t1 (c1 INT KEY) ENGINE=MyISAM; Query OK, 0 rows affected (0,128 sec) MariaDB [test]> CREATE TABLE t2 (c2 INT) ENGINE=MyISAM; Query OK, 0 rows affected (0,023 sec) MariaDB [test]> CREATE TABLE t3 (c3 INT) ENGINE=MyISAM; Query OK, 0 rows affected (0,021 sec) MariaDB [test]> EXPLAIN EXTENDED UPDATE t3 SET c3 = -> ( SELECT COUNT(d1.c1) FROM ( SELECT a11.c1 FROM t1 AS a11 -> STRAIGHT_JOIN t2 AS a21 ON a21.c2 = a11.c1 JOIN t1 AS a12 -> ON a12.c1 = a11.c1 ) d1 ); +------+-------------+-------+------+---------------+------+---------+------+------+----------+--------------------------------+ \| id \| select_type \| table \| type \| possible_keys \| key \| key_len \| ref \| rows \| filtered \| Extra \| +------+-------------+-------+------+---------------+------+---------+------+------+----------+--------------------------------+ \| 1 \| PRIMARY \| t3 \| ALL \| NULL \| NULL \| NULL \| NULL \| 0 \| 100.00 \| \| \| 2 \| SUBQUERY \| NULL \| NULL \| NULL \| NULL \| NULL \| NULL \| NULL \| NULL \| Impossible WHERE noticed after reading const tables +------+-------------+-------+------+---------------+------+---------+------+------+----------+--------------------------------+ 2 rows in set (0,002 sec) MariaDB [test]> PREPARE stmt FROM -> EXPLAIN EXTENDED UPDATE t3 SET c3 = -> ( SELECT COUNT(d1.c1) FROM ( SELECT a11.c1 FROM t1 AS a11 -> STRAIGHT_JOIN t2 AS a21 ON a21.c2 = a11.c1 JOIN t1 AS a12 -> ON a12.c1 = a11.c1 ) d1 ); Query OK, 0 rows affected (0,000 sec) Statement prepared MariaDB [test]> EXECUTE stmt; +------+-------------+-------+------+---------------+------+---------+------+------+----------+--------------------------------+ \| id \| select_type \| table \| type \| possible_keys \| key \| key_len \| ref \| rows \| filtered \| Extra \| +------+-------------+-------+------+---------------+------+---------+------+------+----------+--------------------------------+ \| 1 \| PRIMARY \| t3 \| ALL \| NULL \| NULL \| NULL \| NULL \| 0 \| 100.00 \| \| \| 2 \| SUBQUERY \| NULL \| NULL \| NULL \| NULL \| NULL \| NULL \| NULL \| NULL \| no matching row in const table \| +------+-------------+-------+------+---------------+------+---------+------+------+----------+--------------------------------+ 2 rows in set (0,000 sec) The reason by that different result sets are produced is that on execution of the statement 'EXECUTE stmt' the flag SELECT_DESCRIBE not set in the data member SELECT_LEX::options for instances of SELECT_LEX that correspond to subqueries used in the UPDTAE/DELETE statements. Initially, these flags were set on parsing the statement PREPARE stmt FROM "EXPLAIN EXTENDED UPDATE t3 SET ..." but latter they were reset before starting real execution of the parsed query during handling the statement 'EXECUTE stmt'; So, to fix the issue the functions mysql_update()/mysql_delete() have been modified to set the flag SELECT_DESCRIBE forcibly in the data member SELECT_LEX::options for the primary SELECT_LEX of the UPDATE/DELETE statement.	5 years ago
Sergei Golubchik	d06205ba37	CONNECT: use my_snprintf	5 years ago
Sergei Golubchik	1638241e31	mtr: fix the debug printout to print all arguments of _verbose(), not just the number of them	5 years ago
Robert Bindar	ef0d883903	Revert "Add Pull Request template file to the MariaDB/server repository" This reverts commit `17106c984b`.	5 years ago
Thirunarayanan Balathandayuthapani	c11c5f36d8	MDEV-25758 InnoDB spatial indexes miss large geometry fields after MDEV-25459 InnoDB should calculate the MBR for the first field of spatial index and do the comparison with the clustered index field MBR. Due to MDEV-25459 refactoring, InnoDB calculate the length of the first field and fails with too long column error.	5 years ago
Marko Mäkelä	ab87fc6c7a	Cleanup: Remove handler::update_table_comment() The only call of the virtual member function handler::update_table_comment() was removed in commit `82d28fada7` (MySQL 5.5.53) but the implementation was not removed. The only non-trivial implementation was for InnoDB. The information is now returned via handler::get_foreign_key_create_info() and ha_statistics::delete_length.	5 years ago

1 2 3 4 5 ...

188297 Commits (241d30d3faac0fbbcb7bcfad3dcc118bb03eceb0) All Branches Search

188297 Commits (241d30d3faac0fbbcb7bcfad3dcc118bb03eceb0)

All Branches