mariadb

Tree: 1fec4fc4f8

Author	SHA1	Message	Date
Sergei Golubchik	1fec4fc4f8	more C API methods in the service_sql for columnstore	3 years ago
Sergei Golubchik	ffff702623	C/C 3.1.27	9 months ago
Sergei Golubchik	fafa10dbc4	update HeidiSQL to 12.10 also, switch to https	9 months ago
Sergei Golubchik	66cf3c6974	MDEV-35612 fix for system-versioning only ignore fully invisible fields	9 months ago
Sergei Golubchik	c1933b46e4	MDEV-33285 make the test deterministic need to clear old signals before waiting for new signals with the same name	9 months ago
Sergei Golubchik	caec03cb79	MDEV-35907 debian-start script fails when using non-standard socket path consistently use --defaults-extra-file for all command-line tools	9 months ago
Sergei Golubchik	9a0ac0cdf7	MDEV-35911 Assertion `marked_for_write_or_computed()' failed in bool Field_new_decimal::store_value(const my_decimal, int) disable the assert. also, use the same check for check_that_all_fields_are_given_values() as it's used in not_null_fields_have_null_values() - to avoid issuing the same warning twice.	9 months ago
Dave Gosselin	b8b77177c2	MDEV-35964 fix cast warnings on mac in mysql_file.h Cast create_flags to mode_t when passing to my_create and my_create_with_symlink	9 months ago
Julius Goryavsky	bcb87f5ccb	fix for galera_query_cache_invalidate test results	9 months ago
Daniele Sciascia	0018df2b55	galera fix: Assertion `WSREP(thd)` failed in wsrep_restore_kill_after_commit() Wsrep_commit_empty happens too early when wsrep is disabled. Let the cleanup happen at end of statement. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	2 years ago
Julius Goryavsky	50d49493db	galera: fixes for mtr test for performance schema	2 years ago
Daniele Sciascia	c43db43a7c	MENT-2038 Assert WSREP(thd) fails in wsrep_restore_kill_after_commit Fix wrong assertion: function wsrep_restore_kill_after_commit() asserts `WSREP(thd)`, however for the caller (wsrep_after_statement()) it is enough that the THD has an active transaction. Fixed the assertion accordingly. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	2 years ago
Julius Goryavsky	479a5832f0	galera fix: MSAN reports use-of-uninitialized-value on binlog_encryption This commit fixes a bug in MSAN verification in debug builds related to the member of a lex->definer structure field that may be uninitialized for some SET statements. The bug is caused by debug output in a wsrep-specific insert and does not affect server functionality.	1 year ago
Julius Goryavsky	862d1be2e6	MDEV-25718 addendum: stabilization of test success (especially for 11.4+) Added DEBUG_SYNC_С("ha_write_row_end") in the WSREP branch, and added a new status to the list of pending statuses in the mtr test.	9 months ago
Julius Goryavsky	779ae4c511	wsrep mtr tests: fix for MDEV-23081 failure Sometimes a database can be created with --log-bin but then the .combinations file causes a switch to start without --log-bin causing a failure on recovery. This commit fixes this issue.	9 months ago
Julius Goryavsky	331975c5c5	galera: disable problematic test (galera_nbo_master_non_prim_failure)	9 months ago
Julius Goryavsky	5af1f69a84	MDEV-26266 addendum: more stable test This test must be performed on newly launched nodes and then a restart must be performed.	9 months ago
Julius Goryavsky	0a5d6cf478	galera: disable problematic test (galera_sequences)	9 months ago
Julius Goryavsky	acf7b000ff	fixes for galera_as_slave replication tests	9 months ago
Jan Lindström	e53ffdee96	MDEV-35804 : galera_ddl_fk_conflict test failed due to timeout Test case changes only. Use better wait_conditions. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	10 months ago
Julius Goryavsky	2cfad396ee	galera tests: more informative messages about the number of variables	9 months ago
Jan Lindström	0ddaefcc76	galera fix : MW-402 galera test fails sporadically Test was using after certification sync point when it was intended to use before certification sync point. This caused sporadic failures. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	11 months ago
Jan Lindström	6e3274e814	MENT-31857 post-fix: fix for timeouts in the galera_as_slave_ctas test Caused by MDEV-31857 enable --ssl-verify-server-cert by default in the internal client. Fixed by disabling master_ssl_verify_server_cert because account is passwordless. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	11 months ago
Hemant Dangi	c0b11e75ff	MDEV-34218: Mariadb Galera cluster fails when replicating from Mysql 5.7 on use of DDL Issue: Mariadb Galera cluster fails to replicate from Mysql 5.7 when configured with MASTER_USE_GTID=no option for CHANGE MASTER. HOST: mysql, mysql 5.7.44 binlog_format=ROW HOST: m1, mariadb 10.6 GALERA NODE replicating from HOST mysql, Using_Gtid: No (log file and position) HOST: m2 mariadb 10.6 GALERA NODE HOST: m3 mariadb 10.6 GALERA NODE Error on m1: 2024-05-22 16:11:07 1 [ERROR] WSREP: Vote 0 (success) on 78cebda7-1876-11ef-896b-8a58fca50d36:2565 is inconsistent with group. Leaving cluster. Error on m2 and m3: 2024-05-22 16:11:06 2 [ERROR] Error in Log_event::read_log_event(): 'Found invalid event in binary log', data_len: 42, event_type: -94 2024-05-22 16:11:06 2 [ERROR] WSREP: applier could not read binlog event, seqno: 2565, len: 482 It fails in Gtid_log_event::is_valid() check on secondary node when sequence number sent from primary is 0. On primary for applier or slave thread sequence number is set to 0, when both thd->variables.gtid_seq_no and thd->variables.wsrep_gtid_seq_no have value 0. Solution: Skip adding Gtid Event on primary for applier or slave thread when both thd->variables.gtid_seq_no and thd->variables.wsrep_gtid_seq_no have value 0. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	9 months ago
Marko Mäkelä	746471b8d8	MDEV-33978 P_S.THREADS is not showing all server threads page_encrypt_thread_key: The key for fil_crypt_thread(). All other InnoDB threads should already have been registered for performance_schema ever since commit `a2f510fccf`	9 months ago
Galina Shalygina	dffe3d1fb2	MDEV-35910 Conditions with SP local variables are not pushed into derived table This bug prevented building conditions that could be pushed into a derived table if the derived table was used in a query of a stored procedure and the conditions contained local variables of the procedure. This could lead to a slow execution of the procedure. Also in some cases the bug prevented building conditions that could be pushed from the HAVING condition into the WHERE condition of a query if the conditions to be built used local variables of a stored procedure. To failure to build such pushable conditions was due to lack of a proper implementation of the virtual method to copy items for the objects of the class Item_splocal. Approved by Igor Babaev <igor@mariadb.com> who had to change the original fix that just added the regular copying of the nodes of the Item_splocal class to take into account the wrappers do_get_copy() and do_build_clone() introduced after the fix had been prepared. He also changed the test case to demonstrate that the fix was really needed for pushdown from HAVING into WHERE.	9 months ago
Nikita Malyavin	765458c93c	fix my_error usage	5 years ago
Nikita Malyavin	e7cc1a3047	MDEV-33658 2/2 Cannot add a foreign key on a table with a matching long UNIQUE Cannot add a foreign key on a table with a long UNIQUE multi-column index, that contains a foreign key as a prefix. Check that index algorithms match during the "generated" keys duplicate removal.	1 year ago
Nikita Malyavin	ecaedbe299	MDEV-33658 1/2 Refactoring: extract Key length initialization mysql_prepare_create_table: Extract a Key initialization part that relates to length calculation and long unique index designation. append_system_key_parts call also moves there. Move this initialization before the duplicate elimination. Extract WITHOUT OVERPLAPS check into a separate function. It had to be moved earlier in the code to preserve the order of the error checks, as in the tests.	1 year ago
Nikita Malyavin	e33064e0fc	MDEV-27769 Assertion failed in Field::ptr_in_record upon UPDATE in ORACLE mode table->move_fields has some limitations: 1. It cannot be used in cascade 2. It should always have a restoring pair In this case, an error has occurred before the field ptr was restored, returning from the function in that state. Even in case of an error, the table can be reused afterwards and table->field[i]->ptr is not reset in between. The solution is to restore the field pointers immanently whenever they've been deviated. Also add an assertion that ensures that table fields are restored after the use in close_thread_tables.	9 months ago
Brandon Nesterenko	cb5dd76959	MDEV-35938: rpl.rpl_parallel_gco_wait_kill fails - "Can't initialize replace ..." Test rpl.rpl_parallel_gco_wait_kill has a race condition where it identifies that SQL using its state as "Slave has read all relay log", and immediately tries to save the thread id of the SQL thread by querying for threads with that same state. However, the state of the SQL thread may change in-between this time, leading to the query that saves the SQL thread finding no thread id that matches that state. Commit `3ee6f69d49` aimed to fix this in 10.11+ by simplifying the query string to "%relay log%"; however, it could still fail (though less often). This commit instead changes the query to find the SQL thread from using some state, to using the command "Slave_SQL", which will not change	9 months ago
Oleksandr Byelkin	47f87c5f88	MDEV-20281 "[ERROR] Failed to write to mysql.slow_log:" without error reason Add "backup" (in case of absence issued by error) reasons for failed logging.	9 months ago
Jan Lindström	d598ee3cf9	MDEV-32780 : galera_as_slave_replay: assertion in the wsrep::transaction::before_rollback() Test changes only because assertion reported is not reproducable anymore. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	1 year ago
sjaakola	552cba92de	MDEV-35710 support for threadpool When client connections use threadpool, i.e. configuration has: thread_handling = pool-of-threads it turned out that during wsrep replication shutdown, not all client connections could be closed. Reason was that some client threads has stmt_da in state DA_EOF, and this state was earlier used to detect if client connection was issuing SHUTDOWN command. To fix this, the connection executing SHUTDOWN is now detected by looking at the actual command being executed: thd->get_command() == COM_SHUTDOWN During replication shutdown, all other connections but the SHUTDOWN executor, are terminated. This commit has new mtr test galera.galera_threadpool, which opens a number of threadpool client connections, and then restarts the node to verify that connections in threadpool are terminated during shutdown. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	10 months ago
Julius Goryavsky	50cf189717	MDEV-35018 addendum: improved warnings handling Fixed regression after original MDEV-35018 fix related to warnings appearing when running MDEV-26266 test and other possible problems with warnings.	9 months ago
Daniele Sciascia	841a7d391b	MDEV-35018 MDL BF-BF conflict on DROP TABLE DROP TABLE on child and UPDATE of parent table can cause an MDL BF-BF conflict when applied concurrently. DROP TABLE takes MDL locks on both child and its parent table, however it only it did not add certification keys for the parent table. This patch adds the following: * Append certification keys corresponding to all parent tables before DROP TABLE replication. * Fix wsrep_append_fk_parent_table() so that it works when it is given a table list containing temporary tables. * Make sure function wsrep_append_fk_parent_table() is only called for local transaction. That was not the case for ALTER TABLE. * Add a test case that verifies that UPDATE parent depends on preceeding DROP TABLE child. * Adapt galera_ddl_fk_conflict test to work with DROP TABLE as well. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	1 year ago
Vladislav Vaintroub	40a23e08e6	WolfSSL - make it compilable also with older versions of Windows SDK. followup `136e866119` Remove HAVE_CONFIG_H from wolfssl compilation. WolfSSL knows about it, and would include server's config.h, which is mostly fine, but server pretends to have HAVE_GMTIME_R on Windows, which leads to compilation problems. In any case, on Windows, there is no need for config.h for WolfSSL, and no need for gmtime_r/_s(), as gmtime() is thread-safe on Windpows (it returns pointer to thread-local struct)	9 months ago
Dmitry Shulga	73f415c955	MDEV-24935: Server crashes in Field_iterator_natural_join::next or Field_iterator_table_ref::set_field_iterator upon 2nd execution of SP Calling a stored routine that executes a join on three or more tables and referencing not-existent column name in the USING clause resulted in a crash on its second invocation. Server crash taken place by the reason of dereferencing null pointer in condition of DBUG_ASSERT inside the method Field_iterator_natural_join::next() There the data member cur_column_ref->table_field->field has the nullptr value that was reset at the end of first execution of a stored routine when the standalone procedure cleanup_items() called by the method sp_head::execute. Later this data member is not re-initialized and never referenced in any place except the DBUG_ASSERT on second and later invocations of the stored routine. To fix the issue, the assert's condition should be augmented by a condition '\|\| !cur_column_ref->table_field' before dereferencing cur_column_ref->table_field. Such extra checking is aligned with conditions used by DBUG_ASSERT macros used by implementation of the class Field_iterator_table_ref that aggregated the class Field_iterator_natural_join.	9 months ago
Alexander Barkov	d261fa5c70	MDEV-30111 InnoDB: Failing assertion: update->n_fields == 0 in row_ins_sec_index_entry_by_modify Also fixes: MDEV-32190 Index corruption with unique key and nopad collation (without DESC or HASH keys) MDEV-28328 Assertion failures in btr0cur.cc upon INSERT or in row0sel.cc afterwards The code in strings/strcoll.inl when comparing an empty string to a string like 0x0001050001 did not take into account that the leftmost weight in the latter can be zero, while there are some more weights can follow the zero weight. Rewriting the code to treat the shorter string as smaller than a longer string.	11 months ago
Igor Babaev	77ea99a4b5	MDEV-35869 Wrong result using degenerated subquery with window function This bug affected queries containing degenerated single-value subqueries with window functions. The bug led mostly to wrong results for such queries. A subquery is called degenerated if it is of the form (SELECT <expr>...). For degenerated subqueries of the form (SELECT <expr>) the transformation (SELECT <expr>) => <expr> usually is applied. However if <expr> contains set functions or window functions such rewriting is not valid for an obvious reason. The code before this patch erroneously applied the transformation when <expr> contained window functions and did not contain set functions. Approved by Rex Johnston <rex.johnston@mariadb.com>	9 months ago
Vladislav Vaintroub	136e866119	Update WolfSSL to the latest release 5.7.6 Workaround build bugs with preprocessor flags du-jour 1. OPENSSL_ALL does not work anymore (error in ssl.h) nor WOLFSSL_MYSQL_COMPATIBLE, would work, when building library. 2. OPENSSL_EXTRA has to be used instead of OPENSSL_ALL now. WOLFSSL_MYSQL_COMPATIBLE needs to be used to workaround their conflicting definition of protocol_version, which is used in server code. 3. -D_CRT_USE_CONFORMING_ANNEX_K_TIME to force C11-correct definition of gmtime_s on Windows, set some other flags WOLFSSL_MYSQL_COMPATIBLE was previously defining 4. Use HAVE_EMPTY_AGGREGATES=0 to workaround build error on clang (error: struct has size 0 in C, size 1 in C++ [-Werror,-Wextern-c-compat] WOLF_AGG_DUMMY_MEMBER;)	9 months ago
Oleksandr Byelkin	b214ca7219	MDEV-35090 (Item_func_current_user) Assertion `typeid(copy) == typeid(this)' failed in Item_func_or_sum::do_build_clone Added missing do_get_copy of Item_func_current_user.	9 months ago
Marko Mäkelä	82310f926b	MDEV-29182 Assertion fld->field_no < table->n_v_def failed on cascade row_ins_cascade_calc_update_vec(): Skip any virtual columns in the update vector of the parent table. Based on mysql/mysql-server@0ac176453bfef7fb1fdfa70af74618c32910181c Reviewed by: Debarun Banerjee	9 months ago
Sergey Vojtovich	b730abda09	MDEV-33285 - Assertion `m_table' failed in ha_perfschema::rnd_end on CHECKSUM TABLE CHECKSUM TABLE causes variety of crashes when killed. This bug it not specific to PERFORMANCE_SCHEMA. Removed duplicate handler::ha_rnd_end() call.	11 months ago
Alexander Barkov	aef6f35989	MDEV-35549 UBSAN: runtime error: applying zero offset to null pointer on XA RECOVER With UBSAN builds the function my_string_repertoire_8bit() failed on "runtime error: applying zero offset to null pointer" when NULL wad passed as the str parameter. Fix: test str for NULL, and return MY_REPERTOIRE_ASCII if str is NULL. MTR: This problem made MTR tests - main.xa_sync - innodb.xa_debug - main.xa fail with the nullptr-with-offset UNSAN error. After this commit these tests do not fail anymore. This commit does not need any new MTR tests.	9 months ago
Yuchen Pei	1f306d395d	MDEV-34849 Spider: update conn->queue_connect_share when needed Update conn->queue_connect_share in spider_check_trx_and_get_conn to avoid use-after-free. There are two branches in spider_check_trx_and_get_conn, often called at the beginning of a spider DML, depending on whether an update of various spider fields is needed. If it is determined to be needed, the updating may NULL the connections associated with the spider handler, which subsequently causes a call to spider_get_conn() which updates conn->queued_connect_share with the SPIDER_SHARE associated with the spider handler. We make it so that conn->queued_connect_share is updated regardless of the branch it enters, so that it will not be a stale and potentially already freed one.	9 months ago
Yuchen Pei	e3c768dc8a	MDEV-34849 Clean up spider_check_trx_and_get_conn() Factoring out parts and documentation. Does not change the logic of the code.	9 months ago
Yuchen Pei	402b1374a7	MDEV-34849 Spider: do not change the first byte of a connection key Each spider connection is identified with a connection key, which is an encoding of the backend parameters. The first byte of the key is by default 0, and in rare circumstances it is changed to a different value: when semi_table_lock is set to 1; and when using casual read. When this happens, often a new connection is created with the new key. Neither case is useful: the description of semi_table_lock has nothing to do with creation of new connections and the parameter itself was deprecated for 10.7+ (MDEV-28829) and marked for deletion (MDEV-28830); while new threads created by non-zero spider_casual_read causes only threads to be idle, thus not achieving any gain, see MDEV-26151, and the param has also been deprecated in 11.5+ (MDEV-31789). The relevant code adds unnecessary complexity to the spider code. This change does not reduce parallelism, because already when bgs mode is on a background thread is created per partition, and there is no evidence spider creates multiple threads for one partition. If the needs of such cases arise it will be a separate issue.	9 months ago
Yuchen Pei	7358cbe627	MDEV-28526 Spider: remove conn_kind member variables The conn_kind, which stands for "connection kind", is no longer useful because the HandlerSocket support is deleted and Spider now has only one connection kind, SPIDER_CONN_KIND_MYSQL. Remove conn_kind and related code. Signed-off-by: Yuchen Pei <yuchen.pei@mariadb.com> Reviewed-by: Nayuta Yanagisawa <nayuta.yanagisawa@mariadb.com>	9 months ago
Yuchen Pei	068d061454	MDEV-34813 A simple implementation of ha_partition::compare_key_parts It is not clear that the three Compare_key enums form a hierarchy like alter algorithms do. So on the safe side (in case MDEV-22168 gets implemented without looking at this code) we should return NotEqual if partition engines do not return the same enum value. There's a static merge function that merges these enums, but it is used to merge the Compare_keys of different key parts (horizontally), rather than different partitions (vertically).	10 months ago

1 2 3 4 5 ...

196897 Commits (1fec4fc4f81b2a16ec887855ef3a1d05387bb9ea) All Branches Search

196897 Commits (1fec4fc4f81b2a16ec887855ef3a1d05387bb9ea)

All Branches