mariadb

Tree: 1f372cf1de

Author	SHA1	Message	Date
Sergei Golubchik	1f372cf1de	MDEV-11439 No data type JSON, but CAST(something AS JSON) pretends to work remove CAST(... AS JSON) from the grammar for 10.2.4	9 years ago
Sergei Golubchik	87075e7f87	MDEV-11704 InnoDB: Failing assertion: dfield_is_null(dfield2) \|\| dfield2->data relax innodb assertion, because Field_blob::store() clearly says that a data pointer can be zero if the length is zero.	9 years ago
Sergei Golubchik	239790d92f	MDEV-11604 Assertion `!check_datetime_range(ltime)' failed in TIME_to_longlong_datetime_packed	9 years ago
Sergei Golubchik	1afb11074e	MDEV-11582 InnoDB: Failing assertion: !((field)->vcol_info && !(field)->stored_in_db()) change the parser not to allow SERIAL as a normal data type. make a special rule for it, where it could be used for define fields, but not generated fields, not return type of a stored function, etc.	9 years ago
Sergei Golubchik	ca503e830b	mtr: make sphinx skipping a bit less verbose	9 years ago
Sergei Golubchik	0df39e6037	bugfix: uninit variable	9 years ago
Sergei Golubchik	8d99166c69	MDEV-11640 gcol.gcol_select_myisam fails in buildbot on Power JOIN_CACHE's were initialized in check_join_cache_usage() from make_join_readinfo(). After that make_join_readinfo() was looking whether it's possible to use keyread. Later, after make_join_readinfo(), optimizer decided whether to use filesort. And even later, at the execution time, from join_read_first(), keyread was actually enabled. The problem is, that if a query uses a vcol, base columns that it depends on are automatically added to the read_set - because they're needed to calculate the vcol. But if we're doing keyread, vcol is taken from the index, not calculated, and base columns do not need to be in the read set (even should not be - as they aren't getting values). The bug was that JOIN_CACHE used read_set with base columns, they were not read because of keyread, so it was caching garbage. So read_set is only known after the keyread was decided. And after the filesort was decided, as filesort doesn't use keyread. But check_join_cache_usage() needs to be done in make_join_readinfo(), as the code below depends on these checks, Fix: keep JOIN_CACHE checks where they were, but move initialization down to the very end of JOIN::optimize_inner. If keyread was enabled, update the read_set to include only columns that are part of the index. Copy the keyread logic from join_read_first() to happen at optimize time.	9 years ago
Sergei Golubchik	0e5230e12d	support keyread in READ_RECORD make init_read_record() to detect enabled keyread and use index_* access methods, not rnd_* this makes MariaDB to use keyread a lot more often than before	9 years ago
Sergei Golubchik	1913daf42c	bugfix: disable ICP in InnoDB for indexes on virtual columns because it doesn't work, vcols are never calculated for ICP	9 years ago
Sergei Golubchik	01dd355635	cleanup: make a couple of tests more robust with --sorted_result	9 years ago
Sergei Golubchik	cff144a8ea	cleanup: handler::key_read * rename to "keyread" (to avoid conflicts with tokudb), * change from bool to uint and store the keyread index number there * provide a bool accessor to check if keyread is enabled	9 years ago
Sergei Golubchik	dafb507e3e	find_all_keys: add an assert, remove current_thd Filesort temporarily changes read_set to be tmp_set and marks only fields needed for filesort. Add an assert to ensure that it doesn't overwrite the old value of tmp_set, that is that read_set was not already tmp_set when filesort was invoked. Fix sql_update.cc that was was doing exactly that - changing read_set to tmp_set, configuring tmp_set for keyread, and then invoking filesort.	9 years ago
Sergei Golubchik	e46c42217f	cleanup: TABLE::mark_columns_used_by_index() mark_columns_used_by_index used to do reset + mark_columns_used_by_index_no_reset + start keyread + set bitmaps Now prepare_for_keyread does that, while mark_columns_used_by_index does only reset + mark_columns_used_by_index_no_reset, just as its name suggests.	9 years ago
Sergei Golubchik	460ff39871	bugfix: don't calculate vcols if doing keyread old code didn't calculate vcols that were part of keyread, but calculated other vcols. It was wrong - there was no guarantee that vcol's base columns were part of keyread. Technically it's possible for the vcol not be a part of keyread, but all its base columns being part of keyread. But currently the optimizer doesn't do that, keyread is only used if it covers all columns used in the query. This fixes crashes of vcol.vcol_trigger_sp_innodb	9 years ago
Sergei Golubchik	3cae225b0f	cleanup: remove TABLE::add_read_columns_used_by_index TABLE::add_read_columns_used_by_index() is conceptually wrong, it adds columns used by index to the bitmap, without clearing it first. But it also enables keyread, meaning that only columns from the index will be read. It is supposed to be used to add columns used by an index to a bitmap that already has columns of a primary key - for engines where a primary key is part of every index. The correct fix is to change mark_columns_used_by_index() to take into account extended keys. this reverts `1d0acc7754` and `cf97cbd1db`	9 years ago
Sergei Golubchik	9fa6589f64	bugfix: TABLE::mark_columns_used_by_index_no_reset it should not mark base columns that a vcol depends on, because keyread (on a vcol) will not read them	9 years ago
Sergei Golubchik	4dd7e11332	cleanup: mark_columns_used_by_index_no_reset in handler::get_auto_increment use table->mark_columns_used_by_index, don't copy it	9 years ago
Sergei Golubchik	bf8f70a47c	cleanup: mark_columns_used_by_index_no_reset in opt_range.cc use table->mark_columns_used_by_index, don't copy it	9 years ago
Sergei Golubchik	0254f1a6e0	bugfix: TABLE::mark_columns_used_by_index Do not modify write_set. keyread only affects what columns are read, UPDATE statement can write into columns that aren't part of the keyread.	9 years ago
Sergei Golubchik	5d7607f340	cleanup: style fixes, sql_join_cache.cc	9 years ago
Sergei Golubchik	8246b0ac50	cleanup: TABLE::non_determinstic_insert move the check where it make sense, remove incorrect comment	9 years ago
Sergei Golubchik	6c4144a468	InnoDB: suppress posix_fallocate() failure errors when EINVAL EINVAL means that the filesystem doesn't support posix_fallocate(). There were two places where this error was issued, one checked for EINVAL, the other did not. This commit fixed the other place to also check for EINVAL. Also, remove the space after the REFMAN to get the valid url with no space in the middle. Also don't say "Make sure the file system supports this function." when posix_fallocate() fails, because this message is only shown when the filesystem does support this function.	9 years ago
Sergei Golubchik	ef0db6bfd1	fix rpl_binlog_errors test not to leave dbug enabled	9 years ago
Sergei Golubchik	d2f84ab978	MDEV-10352 Server crashes in Field::set_default on CREATE TABLE fix Item_default_value not to pretend being const_item if the field's default_value expression isn't parsed yet	9 years ago
Sergei Golubchik	b6a3917b05	MDEV-11750 Assertion `vfield' failed in TABLE::update_virtual_fields after crash recovery on corrupted MyISAM table Adjust the length of the BIT field (same as in _mi_put_key_in_record())	9 years ago
Sergei Golubchik	29ed440d44	MDEV-11836 vcol.vcol_keys_myisam fails in buildbot and outside move TABLE::key_read into handler. Because in index merge and DS-MRR there can be many handlers per table, and some of them use key read while others don't. "keyread" is really per handler, not per TABLE property.	9 years ago
Sergei Golubchik	4cf4b61b24	oqgraph: remove redundant update_virtual_fields() calls	9 years ago
Sergei Golubchik	eda2ebefba	MDEV-11784 View is created with invalid definition which causes ERROR 1241 (21000): Operand should contain 1 column(s) set the correct print precedence for IN subqueries	9 years ago
Sergei Golubchik	cf00393378	Race condition in DEFAULT() with expressions Item_default_value::calculate was updating table->s->default_values, but it is supposed to be read-only	9 years ago
Sergei Golubchik	cd4dd2b62d	MDEV-10201 Bad results for CREATE TABLE t1 (a INT DEFAULT b, b INT DEFAULT 4) Optionally do table->update_default_fields() even for INSERT that supposedly provides values for all column. Because these "values" might be DEFAULT, which would need table->update_default_fields() at the end. Also set Item_default_value::used_tables() from the default expression. Non-zero used_field() means that mysql_insert() will initialize all fields to their default values (with restore_record()) even if all columns are later provided with values. Because default expressions may refer to other columns and they must be initialized.	9 years ago
Marko Mäkelä	588eca31e3	Post-fix for MDEV-12050 Remove unused InnoDB Memcached hooks Remove also the field trx_t::read_write that was only used by the Memcached hooks.	9 years ago
Marko Mäkelä	a45866c6db	MDEV-12050 Remove unused InnoDB Memcached hooks Oracle introduced a Memcached plugin interface to the InnoDB storage engine in MySQL 5.6. That interface is essentially a fork of Memcached development snapshot 1.6.0-beta1 of an old development branch 'engine-pu'. To my knowledge, there have not been any updates to the Memcached code between MySQL 5.6 and 5.7; only bug fixes and extensions related to the Oracle modifications. The Memcached plugin is not part of the MariaDB Server. Therefore it does not make sense to include the InnoDB interfaces for the Memcached plugin, or to have any related configuration parameters: innodb_api_bk_commit_interval innodb_api_disable_rowlock innodb_api_enable_binlog innodb_api_enable_mdl innodb_api_trx_level Removing this code in one commit makes it possible to easily restore it, in case it turns out to be needed later.	9 years ago
Marko Mäkelä	3272a19741	MDEV-11782 preparation: Add separate code for validating the 10.1 redo log. log_crypt_101_read_checkpoint(): Read the encryption information from a MariaDB 10.1 checkpoint page. log_crypt_101_read_block(): Attempt to decrypt a MariaDB 10.1 redo log page. recv_log_format_0_recover(): Only attempt decryption on checksum mismatch. NOTE: With the MariaDB 10.1 innodb_encrypt_log format, we can actually determine from the cleartext portion of the redo log whether the redo log is empty. We do not really have to decrypt the redo log here, if we did not want to determine if the checksum is valid.	9 years ago
Marko Mäkelä	96c4b9d49f	MDEV-11782 preparation: Remove recv_sys_t::last_block. We can use log_sys->buf instead of recv_sys->last_block during crash recovery. Remove the redundant buffer.	9 years ago
Marko Mäkelä	412ee0330c	Fix a memory leak on aborted InnoDB startup. innodb_shutdown(), trx_sys_close(): Startup may be aborted between purge_sys and trx_sys creation. Therefore, purge_sys must be freed independently of trx_sys. innobase_start_or_create_for_mysql(): Remember to free purge_queue if it was not yet attached to purge_sys.	9 years ago
Igor Babaev	d35aea5407	Fixed bugs mdev-12051, mdev-10885. These are different bugs, but the fixing code is the same: if window functions are used over implicit grouping then now the execution should follow the general path calling the function set in JOIN::first_select.	9 years ago
Nirbhay Choubey	f04efa839d	MDEV-7635: Fix for ctype_gbk_export_import.test	9 years ago
Sergei Golubchik	f3914d10b6	Merge branch 'bb-10.2-serg-merge' into 10.2	9 years ago
Igor Babaev	5593458062	Fixed bug mdev-12015. Corrected an assertion in JOIN::create_postjoin_aggr_table(): JOIN::join_tab[0] can be the first aggregation table if the query uses window functions.	9 years ago
Sergei Golubchik	2195bb4e41	Merge branch '10.1' into 10.2	9 years ago
Vladislav Vaintroub	1b4f694adf	MDEV-10291 : Fix race condition in bootstrap main thread may destroy mutexes that bootstrap is using in THD destructor.	9 years ago
Nirbhay Choubey	6f42c3c5a4	MDEV-7635: Fix for mroonga 32-bit test failures.	9 years ago
Elena Stepanova	c513c4cbf5	MDEV-7635: Additional test fixes	9 years ago
Nirbhay Choubey	c0209f8736	MDEV-11908: New default configuration produces warnings about itself upon startup Print the message as a note instead of warning.	9 years ago
Nirbhay Choubey	616f4a773a	MDEV-7635: Reset sync_binlog back to 0	9 years ago
Nirbhay Choubey	8b2e642aa2	MDEV-7635: Update tests to adapt to the new default sql_mode	9 years ago
Nirbhay Choubey	f556aa9b5f	MDEV-7635: SET shouldn't fail for invalid values in strict trans mode	9 years ago
Nirbhay Choubey	04b52a0745	MDEV-7635: Part 2 New default sql_mode includes: * STRICT_TRANS_TABLES * ERROR_FOR_DIVISION_BY_ZERO * NO_ENGINE_SUBSTITUTION * NO_AUTO_CREATE_USER	9 years ago
Nirbhay Choubey	f8aa54f1bc	MDEV-11685: sql_mode can't be set with non-ascii connection charset The supplied sql_mode(s) should be converted to ASCII first, before comparing it with the sql_mode set.	9 years ago
Nirbhay Choubey	eaf9c4b54f	MDEV-7635: Disable rpl_row_index_choice (MDEV-11666)	9 years ago

1 2 3 4 5 ...

176360 Commits (1f372cf1de2a15057a09c6936f025f09500c0228) All Branches Search

176360 Commits (1f372cf1de2a15057a09c6936f025f09500c0228)

All Branches