mariadb

Tree: 1b8322c3c6

Author	SHA1	Message	Date
Alexey Kopytov	1b8322c3c6	Bug #44767 : invalid memory reads in password() and old_password() functions The PASSWORD() and OLD_PASSWORD() functions could lead to memory reads outside of an internal buffer when used with BLOB arguments. String::c_ptr() assumes there is at least one extra byte in the internally allocated buffer when adding the trailing '\0'. This, however, may not be the case when a String object was initialized with externally allocated buffer. The bug was fixed by adding an additional "length" argument to make_scrambled_password_323() and make_scrambled_password() in order to avoid String::c_ptr() calls for PASSWORD()/OLD_PASSWORD(). However, since the make_scrambled_password[_323] functions are a part of the client library ABI, the functions with the new interfaces were implemented with the 'my_' prefix in their names, with the old functions changed to be wrappers around the new ones to maintain interface compatibility. mysql-test/r/func_crypt.result: Added a test case for bug #44767. mysql-test/t/func_crypt.test: Added a test case for bug #44767. sql/item_strfunc.cc: Use the new my_make_scrambled_password() to avoid String::c_ptr(). sql/item_strfunc.h: Changed Item_func[_old]_password::alloc() interfaces so that we can use the new my_make_scrambled_password() functions. sql/mysql_priv.h: Added declarations for the new my_make_scrambled_password() functions. sql/password.c: Added new my_make_scrambled_password() functions with an additional "length" argument. Changed ones to be wrappers around the new ones to maintain interface compatibility. sql/sql_yacc.yy: Utilize the new password hashing functions with additional length argument.	17 years ago
Matthias Leich	1d03fb715e	Merge of fix into GCA tree, no conflicts	17 years ago
Georgi Kodinov	df41cc207e	backported a change from 5.1	17 years ago
Georgi Kodinov	ebdb0b91db	merged	17 years ago
Georgi Kodinov	793bf59536	fixed a win32 compile error	17 years ago
Philip Stoev	8e72b44969	Bug #32651 grant_cache.test fails It turns out that this test case no longer fails with the discrepancy in numbers that was the original cause for disabling this test (and showed potential genuine issues with the query cache). Therefore this test is being enabled after some minor adjustment of error codes and messages.	17 years ago
Matthias Leich	f4eb0953b1	Fix for Bug#44826 main.information_schema_db could harm succeeding tests Details: 1. Add missing "disconnect <session>" 2. Take care that the disconnects are finished when the test terminates 3. Replace error names by error numbers 4. Minor beautifying of script code	17 years ago
Georgi Kodinov	812d2559b5	merged 5.0-main -> 5.0-bugteam	17 years ago
Alexey Kopytov	d68ea7d519	Automerge.	17 years ago
Alexey Kopytov	22e840d707	Bug #44792 : valgrind warning when casting from time to time Field_time::get_time() did not initialize some members of MYSQL_TIME which led to valgrind warnings when those members were accessed in Protocol_simple::store_time(). It is unlikely that this bug could result in wrong data being returned, since Field_time::get_time() initializes the 'day' member of MYSQL_TIME to 0, so the value of 'day' in Protocol_simple::store_time() would be 0 regardless of the values for 'year' and 'month'. mysql-test/r/type_time.result: Added a test case for bug #44792. mysql-test/t/type_time.test: Added a test case for bug #44792. sql/field.cc: Field_time::get_time() did not initialize some members of MYSQL_TIME which led to valgrind warnings when those members were accessed in Protocol_simple::store_time().	17 years ago
Sergey Glukhov	fc57b4cfb5	Bug#43612 crash with explain extended, union, order by In UNION if we use last SELECT without braces and this SELECT have ORDER BY clause, such clause belongs to global UNION. It is parsed like last SELECT part and used further as 'unit->global_parameters->order_list' value. During DESCRIBE EXTENDED we call select_lex->print_order() for last SELECT where order fields refer to tmp table which already freed. It leads to crash. The fix is clean up global_parameters->order_list instead of fake_select_lex->order_list. mysql-test/r/union.result: test result mysql-test/t/union.test: test case sql/sql_union.cc: In UNION if we use last SELECT without braces and this SELECT have ORDER BY clause, such clause belongs to global UNION. It is parsed like last SELECT part and used further as 'unit->global_parameters->order_list' value. During DESCRIBE EXTENDED we call select_lex->print_order() for last SELECT where order fields refer to tmp table which already freed. It leads to crash. The fix is clean up global_parameters->order_list instead of fake_select_lex->order_list.	17 years ago
Philip Stoev	ccc0ffb419	Bugs #44871 and #43894 : UNIX sockets need to be on a path shorter than 70 characters on some older platofrms. MTRv1 tries to fix this by moving the socket to the $TMPDIR, however this causes issues with certain tests on Windows. Fixed by not applying any hacks on Windows - Windows does not need them.	17 years ago
Philip Stoev	e67233ff3f	Bugs #44871 and #43894 : UNIX sockets need to be on a path shorter than 70 characters on some older platofrms. MTRv1 tries to fix this by moving the socket to the $TMPDIR, however this causes issues with certain tests on Windows. Fixed by not applying any hacks on Windows - Windows does not need them.	17 years ago
Ramil Kalimullin	80fdebafa8	Fix for bug#44774 merged.	17 years ago
Jim Winstead	c65ebb5d13	Merge from 5.0-bugteam	17 years ago
Chad MILLER	dbf8997b40	Remove community-server only feature and place in its own test with appropriate condition.	17 years ago
Ramil Kalimullin	8b9084eff4	Fix for bug#44774: load_file function produces valgrind warnings Problem: using LOAD_FILE() in some cases we pass a file name string without a trailing '\0' to fn_format() which relies on that however. That may lead to valgrind warnings. Fix: add a trailing '\0' to the file name passed to fn_format(). mysql-test/r/func_str.result: Fix for bug#44774: load_file function produces valgrind warnings - test result. mysql-test/t/func_str.test: Fix for bug#44774: load_file function produces valgrind warnings - test case. sql/item_strfunc.cc: Fix for bug#44774: load_file function produces valgrind warnings - passing a file name to fn_format(), file_name->c_ptr() replaced with file_name->c_ptr_safe() to ensure we have a trailing '\0'.	17 years ago
Chad MILLER	a7794c7549	Merge with trunk.	17 years ago
Chad MILLER	3593b73eb1	Fix improperly-protected variable definition and use. Also, add CPP so Windows works properly for profiling. Community-server functionality is required.	17 years ago
Ramil Kalimullin	d615a11bd5	Fix for bug#42009: SELECT into variable gives different results to direct SELECT Problem: storing "SELECT ... INTO @var ..." results in variables we used val_xxx() methods which returned results of the current row. So, in some cases (e.g. SELECT DISTINCT, GROUP BY or HAVING) we got data from the first row of a new group (where we evaluate a clause) instead of data from the last row of the previous group. Fix: use val_xxx_result() counterparts to get proper results. mysql-test/r/distinct.result: Fix for bug#42009: SELECT into variable gives different results to direct SELECT - results adjusted. mysql-test/r/user_var.result: Fix for bug#42009: SELECT into variable gives different results to direct SELECT - test result. mysql-test/t/user_var.test: Fix for bug#42009: SELECT into variable gives different results to direct SELECT - test case. sql/item_func.cc: Fix for bug#42009: SELECT into variable gives different results to direct SELECT - Item_func_set_user_var::save_item_result() added to evaluate and store an item's result into a user variable. sql/item_func.h: Fix for bug#42009: SELECT into variable gives different results to direct SELECT - Item_func_set_user_var::save_item_result() added to evaluate and store an item's result into a user variable. sql/sql_class.cc: Fix for bug#42009: SELECT into variable gives different results to direct SELECT - use Item_func_set_user_var::save_item_result() to store results into user variables.	17 years ago
Joerg Bruehe	48706e948f	Merge from main 5.0 (again) into 5.0-build - just version number change.	17 years ago
Joerg Bruehe	d3dbf166b6	Merge main 5.0 into 5.0-build	17 years ago
Alexey Kopytov	f68ae2f514	Automerge.	17 years ago
Alexey Kopytov	4cbe047c0c	Automerge.	17 years ago
unknown	fca0a61a1a	Raise version number after cloning 5.0.82	17 years ago
Jim Winstead	df3887f913	The get_date() function in mysys interpreted the GETDATE_GMT option backwards, which resulted in the incorrect time being reported at the end of mysqldump. (Bug #44424, patch by Andrew Hutchings)	17 years ago
Daniel Fischer	4cf2001cfe	merge 5.0.81 into 5.0	17 years ago
Jim Winstead	3fe1d299ec	Fix support for -i (--ignore-spaces) in the mysql command line application, which didn't actually do anything. (Bug #39101)	17 years ago
Alexey Kopytov	c0cd2742af	Bug #41943 : mysqlbinlog.exe crashes if --hexdump option is used The --hexdump option crashed mysqlbinlog when used together with the --read-from-remote-server option due to use of uninitialized memory. Since Log_event::print_header() relies on temp_buf to be initialized when the --hexdump option is present, dump_remote_log_entries() was fixed to setup temp_buf to point to the start of a binlog event as done in dump_local_log_entries(). The root cause of this bug is identical to the one for bug #17654. The latter was fixed in 5.1 and up, so this patch is backport of the patches for bug #17654 to 5.0. Only 5.0 needs a changelog entry. client/mysqlbinlog.cc: Fixed dump_remote_log_entries() so that temp_buf is initialized as it may be used later by Log_event::print_header() if the --hexdump option is present. mysql-test/r/mysqlbinlog.result: Added a test case for bug #41943. mysql-test/t/mysqlbinlog.test: Added a test case for bug #41943.	17 years ago
Bernt M. Johnsen	a9f57db08c	Bug 23471 merged from GCA and prepared for push	17 years ago
Chad MILLER	767501a9b1	Merge community up to enterprise, thus ending the community-server adventure.	17 years ago
Anurag Shekhar	69fcfa67d3	merging with local fix.	17 years ago
Anurag Shekhar	609a794b15	Bug #39918 memory (heap) engine crashing with b-tree index and DELETE with seg fault Multiple-table DELETE from a table joined to itself may cause server crash. This was originally discovered with MEMORY engine, but may affect other engines with different symptoms. The problem was that the server violated SE API by performing parallel table scan in one handler and removing records in another (delete on the fly optimization). mysql-test/r/heap_btree.result: Updated test result after adding new test for this bug. mysql-test/t/heap_btree.test: Updated test result after adding new test for the bug report. sql/sql_delete.cc: Updated to check if the files in delete list appears in join list and disable delete while scanning, if it appears.	17 years ago
Chad MILLER	4822696ecb	Pull 5.1 treatment of community features into 5.0.	17 years ago
Davi Arnaut	6bee08c61d	Merge from 5.0-pe-stage into main.	17 years ago
Bernt M. Johnsen	ef65e32d70	Bug#23471 prepared for commit in 5.0 gca branch	17 years ago
unknown	e9f38910da	Merge from mysql-5.0.80-release	17 years ago
MySQL Build Team	12b0c92f23	merge in small portability tweaks from 5.0.80	17 years ago
MySQL Build Team	d64c0e1675	A few portability tweaks for Netware, SCO and QNX	17 years ago
Gleb Shchepa	f0791b8b6b	Bug #37362 : Crash in do_field_eq EXPLAIN EXTENDED of nested query containing a error: 1054 Unknown column '...' in 'field list' may cause a server crash. Parse error like described above forces a call to JOIN::destroy() on malformed subquery. That JOIN::destroy function closes and frees temporary tables. However, temporary fields of these tables may be listed in st_select_lex::group_list of outer query, and that st_select_lex may not cleanup them properly. So, after the JOIN::destroy call that st_select_lex::group_list may have Item_field objects with dangling pointers to freed temporary table Field objects. That caused a crash. mysql-test/r/subselect3.result: Added test case for bug #37362. mysql-test/t/subselect3.test: Added test case for bug #37362. sql/sql_select.cc: Bug #37362: Crash in do_field_eq The JOIN::destroy function has been modified to cleanup temporary table column items.	17 years ago
Andrei Elkin	75da023da6	merging from 5.0-bt rep to a local branch	17 years ago
Georgi Kodinov	abf3efe588	merged 5.0-main to 5.0-bugteam	17 years ago
Andrei Elkin	9cf91b4cd9	merging from 5.0-bt rep to a local branch	17 years ago
Matthias Leich	e5d859fab7	Merge of fix for Bug#44522 main.not_embedded_server fails with "--check-testcases" into actual tree	17 years ago
Alexey Botchkov	626a272ed4	mysql_client_test fixed. per-file comments: tests/mysql_client_test.c the test for bug 37956 isn't relevant anymore. The query there 'select point(?,?)' doesn't produce an error.	17 years ago
Alexey Botchkov	eed928808e	merging	17 years ago
Matthias Leich	ae154dca77	Merge latest changes into local GCA tree no conflicts	17 years ago
Matthias Leich	2328f9b13f	Fix for Bug#43546 Several 5.0 tests do not pass MTR's --check option (moved from Bug 42308) Details: - insert_update Add DROP TABLE which was missing, error numbers -> names - varbinary Add DROP TABLE which was missing - sp_trans_log Add missing DROP function, improved formatting	17 years ago
Staale Smedseng	9f04d27027	Bug#35769 typo in mysqlhotcopy documentation Fixed a number of typos, and made punctuation and capitalization more consistent in documentation and help.	17 years ago
Andrei Elkin	d38e62634f	Bug #38694 Race condition in replication thread shutdown The issue of the current bug is unguarded access to mi->slave_running by the shutdown thread calling end_slave() that is bug#29968 (alas happened not to be cross-linked with the current bug) Fixed: with removing the unguarded read of the running status and perform reading it in terminate_slave_thread() at time run_lock is taken (mostly bug#29968 backporting, still with some improvements over that patch - see the error reporting from terminate_slave_thread()). Issue of bug#38716 is fixed here for 5.0 branch as well. Note: There has been a separate artifact identified - a race condition between init_slave() and end_slave() - reported as Bug#44467. mysql-test/r/rpl_bug38694.result: a new results file is added. mysql-test/t/rpl_bug38694-slave.opt: simulating delay at slave threads shutdown. mysql-test/t/rpl_bug38694.test: A new test to check if a delay at the termination phase of slave threads could cause any issue. sql/slave.cc: The unguarded read of the running status is removed. Its reading is done in terminate_slave_thread() at time run_lock is taken; Calling terminate_slave_threads(skip_lock := !need_slave_mutex) in the failing branch of start_slave_threads() which is bug#38716 issue. sql/slave.h: removing terminate_slave_thread() out of the global interface scope.	17 years ago

1 2 3 4 5 ...

39919 Commits (1b8322c3c6f406bd119145c6f38ddeb802e1b9fc) All Branches Search

39919 Commits (1b8322c3c6f406bd119145c6f38ddeb802e1b9fc)

All Branches