mariadb

Tree: 1ae59d9e65

Author	SHA1	Message	Date
vasil	756a8b29a9	branches/zip: Add a hash_table_clear() function to drop all elements that have been added to it. Approved by: Marko	18 years ago
marko	e7d302e786	branches/zip: Remove trx->sync_cb. Call dict_rename_indexes() directly from ha_innobase::add_index(). dict_rename_indexes(): Remove the redundant parameter commit_flag.	18 years ago
marko	7274fd95af	branches/zip: Fix a memory leak in fast index creation. ha_innobase::add_index(): Add assertions about !trx->sync_cb and !trx->dict_redo_list. Remove a bogus comment. Replace row_lock_table_for_merge() with row_merge_lock_table(). row_merge_lock_table(): Renamed from row_lock_table_for_merge() and moved from row0mysql.c to row0merge.c. Always lock the table in the mode LOCK_X. Call que_graph_free() in order not to leak memory.	18 years ago
marko	dea769663d	branches/zip: mem_heap_free_heap_top(): Declare the memory freed with UNIV_MEM_FREE(). Before this change, the memory freed by mem_heap_empty() was not completely flagged free in UNIV_DEBUG_VALGRIND builds. After this change, Valgrind will hopefully catch all errors caught by UNIV_MEM_DEBUG.	18 years ago
marko	4dfa0cc981	branches/zip: ha_innobase::add_index(): Remove the mem_heap_empty() call. The index[] array that is allocated from the heap is still live.	18 years ago
marko	b59ce25d1e	branches/zip: dict_foreign_eval_sql(): Print foreign->id as a table name (in the database.id format). This should have been changed in r1570.	18 years ago
marko	71f47ed2e2	branches/zip: innodb-index.test: Add tests for creating or dropping FOREIGN KEY constraints. At the moment, MySQL will rebuild the entire table and indexes when such constraints are added or removed, even though the constraints do not affect the storage format of the data.	18 years ago
marko	8aa17b95e1	branches/zip: row_merge_read(): Call os_file_read_no_error_handling() instead of os_file_read(). Display some fault diagnostics.	18 years ago
marko	885212294d	branches/zip: Preserve FOREIGN KEY constraints when creating a PRIMARY KEY. innodb-index.test: Add some test cases for FOREIGN KEY constraints. row_merge_rename_tables(): New function, adapted from row_rename_table_for_mysql(). ha_innobase::add_index(): Use row_merge_rename_tables().	18 years ago
marko	fc02084a69	branches/zip: row_rename_table_for_mysql(): Rely on the diagnostic printout of dict_table_rename_in_cache(). Correct the comment about the SQL parser. This function does not drop any table.	18 years ago
marko	2be769710c	branches/zip: dict_table_rename_in_cache(): Improve the diagnostic printout for the error cases. Avoid copying the old table->name; the string will remain valid in table->heap.	18 years ago
marko	9ce78f52ea	branches/zip: Refuse fast index creation if newraw or innodb_force_recovery have been set. ha_innobase::add_index(), ha_innobase::prepare_drop_index(), ha_innobase::final_drop_index(): Return HA_ERR_WRONG_COMMAND if newraw or innodb_force_recovery have been set.	18 years ago
marko	c09dd214be	branches/zip: Add const qualifiers to the upd_t* parameters of some functions.	18 years ago
marko	1e7b92f844	branches/zip: Use mem_heap_zalloc() when initializing dict_table_t, dict_index_t, and dict_foreign_t.	18 years ago
marko	d4568988fd	branches/zip: ha_innobase::write_row(): Remove an unreachable break statement.	18 years ago
marko	8634d343f7	branches/zip: Rename mem_heap_calloc() and mem_calloc() to mem_heap_zalloc() and mem_zalloc(), because calloc() in the C runtime library takes two size parameters, not one. mem_heap_zalloc(): Add debug assertions. Document that the return value is never NULL.	18 years ago
marko	66f6a5acc8	branches/zip: Fix bugs in the creation or dropping of the clustered index (PRIMARY KEY or UNIQUE INDEX on NOT NULL columns). innodb-index.test: Remove the --replace_regex directives. Replace correct values to the "Duplicate entry" messages. This will cause the test to fail until we somehow return the duplicate key values to MySQL. Add test cases for creating or dropping UNIQUE INDEX or PRIMARY KEY. innobase_copy_index_def(): Allow the function to copy a clustered index definition to a secondary one (UNIQUE INDEX). innobase_create_key_def(): Check the NOT NULL flag from the correct place. Copy the clustered index if it is a UNIQUE INDEX. ha_innobase::prepare_drop_index(): Refuse to drop the clustered index.	18 years ago
marko	c541324b21	branches/zip: Minor cleanup. ha_innobase::add_index(), ha_innobase::prepare_drop_index(): Remove the redundant thd_test_options() calls. The options are tested in check_trx_exists(). ha_innobase::prepare_drop_index(): key cannot be NULL; remove the tests. Move the condition for checking foreign keys outside of the loop. Remove the redundant error log printout about foreign key dependency.	18 years ago
marko	2c7f6f6a26	branches/zip: Remove redundant type casts. Change the parameter type of ut_strcmp() from const void* to const char*.	18 years ago
marko	064e5aae3f	branches/zip: dict0mem.h: Minor cleanup. Remove the unused constant DICT_NOT_READY. Make dict_index_t::type a bit-field, and move it next to other bit-fields. Add a const qualifier to dict_index_t::name.	18 years ago
marko	91ee8176f6	branches/zip: Remove the error code DB_CANNOT_DROP_FOREIGN_INDEX. It was only set by ha_innobase::prepare_drop_index(), which can return the appropriate MySQL error code (HA_ERR_DROP_INDEX_FK) directly. ha_innobase::add_index(): Correct the function comment. ha_innobase::prepare_drop_index(): Correct the function comment. Return MySQL error codes directly. ha_innobase::final_drop_index(): Correct the function comment.	18 years ago
marko	dddb659202	branches/zip: row_mysql_handle_errors(): Replace the if-else with switch-case.	18 years ago
marko	f218619067	branches/zip: Performance improvement: row_merge_buf_add(): Add a prefetch instruction to row->fields. Eliminate a variable from the copying loop, and move the termination condition to the end of the loop. row_merge_build_indexes(): Remove the second call to trx_start_if_not_started().	18 years ago
marko	6b7c6cb398	branches/zip: Minor cleanup. trx_t: Change the type of error_info from void* to const dict_index_t. trx_get_error_info(): Add const qualifier to trx_t. Make this an inline function.	18 years ago
marko	b008bc09a7	branches/zip: Fix two mistakes made in r1414 (merging branches/fast-index-creation): row_truncate_table_for_mysql(), row_drop_table_for_mysql_no_commit(): Let ut_print_name() output to ef instead of stderr.	18 years ago
marko	04ae127d2d	branches/zip: ha_innobase::add_index(): Do not merely check for a key name "PRIMARY". If the table has a generated clustered index, also check for a UNIQUE INDEX containing no NULL columns. innobase_create_index_def(): Add the parameter key_primary. innobase_create_key_def(): Check if the first index is a UNIQUE index consisting of NOT NULL columns. Fixing this bug revealed another one: FOREIGN KEY constraints will be lost when a PRIMARY KEY is created. This is the reason why innodb.test will fail.	18 years ago
marko	2cf5070fda	branches/zip: ha_innobase::change_active_index(): Write to the error log when the index could not be found.	18 years ago
marko	e0009cd4db	branches/zip: Add some const qualifiers to dict_index_t* and dict_table_t*. innobase_create_key_def(), row_table_got_default_clust_index(), row_get_mysql_key_number_for_index(): Add a const qualifier. dict_table_get_first_index(), dict_table_get_next_index(): Define as a const-preserving macro. Preserve the old function for UNIV_DEBUG, but add a const qualifier to the parameter and cast away the constness.	18 years ago
marko	f68d3656dc	branches/zip: Use mem_calloc and mem_heap_calloc when possible. row_ext_create(): After a memset() inside UNIV_DEBUG, flag the memory uninitialized with UNIV_MEM_ALLOC().	18 years ago
marko	d9db67696e	branches/zip: row_rename_table_for_mysql(): Change the return type to ulint and simplify error handling.	18 years ago
marko	845bd0914c	branches/zip: ha_innobase::add_index(): Remove the unused variable new_unique.	18 years ago
marko	5f42eea7cc	branches/zip: ha_innobase::add_index(): Fix an ut_ad() assertion that was broken in r1685.	18 years ago
marko	4d793ff876	branches/zip: Add changes that accidentally omitted from r1698: innodb-index.test, innodb-index.result: Add a test for creating a PRIMARY KEY on a column that contains a NULL value.	18 years ago
marko	e2052eba27	branches/zip: When creating a PRIMARY KEY, flag all its columns NOT NULL. row_merge_create_temporary_table(): Add the parameter index_defs. DB_PRIMARY_KEY_IS_NULL: New error code, mapped to ER_PRIMARY_CANT_HAVE_NULL. row_merge_read_clustered_index(): Replace the parameter "table" with the two parameters "old_table" and "new_table". Detect NULL values of columns that are supposed to be NOT NULL. row_merge_col_prtype(): New auxiliary function, used by row_merge_create_temporary_table() to flag NOT NULL any columns contained in an added PRIMARY KEY.	18 years ago
marko	f304ce109c	branches/zip: Minor cleanup. innobase_copy_index_field_def(): Remove parameter heap. The field->name will not be deallocated before the copied index has been added to the data dictionary cache. innobase_copy_index_def(): Add const qualifier to dict_index_t*. Add an assertion !dict_index_is_clust(index). ha_innobase::add_index(): Add the missing user_thd parameter to the convert_error_code_to_mysql() call that was forgotten from r1686. merge_index_field_struct: Add const qualifier to field_name. merge_index_def_struct: Add const qualifier to name. row_merge_build_indexes(): Improve the function comment. row_merge_drop_table(): Remove bogus assertion ut_a(table->to_be_dropped).	18 years ago
marko	992f5be17f	branches/zip: ha_innobase::add_index(): Convert the error code before goto err_exit. The error handling should be rewritten. Many of the error messages contain parameters, but this code is only returning the error number to MySQL.	18 years ago
marko	77e01ec982	branches/zip: innobase_check_index_keys(): return 0 instead of DB_SUCCESS, as documented. Do not translate the error code. This function is still broken; we should probably use my_error() for reporting errors.	18 years ago
marko	b532e5059c	branches/zip: convert_error_code_to_mysql(): replace if-else with switch-case	18 years ago
marko	33bf9d5024	branches/zip: Resolve an error number collision in db0err.h. The code for DB_CANNOT_DROP_FOREIGN_INDEX should have been renumbered in r1494 (Merge revisions 1402:1493 from trunk).	18 years ago
marko	5de9dc5627	branches/zip: Add const qualifiers to some dict_table_t* accessor functions.	18 years ago
marko	92f615ae30	branches/zip: merge_index_field_struct: Remove the unused field col_type.	18 years ago
marko	f2538af41a	branches/zip: Fix memory management errors in row_merge_buf_t. row_merge_buf_create_low(): Swap the parameters max_tuples and buf_size, because the callers had them swapped. Add debug assertions about these parameters. row_merge_buf_empty(): Return the emptied buffer. In some cases, the buffer may be relocated.	19 years ago
marko	b67e98ad20	branches/zip: ha_innobase::add_index(): When creating a clustered index, do not release and relock the data dictionary during initial preparations.	19 years ago
marko	79eb6e9e09	branches/zip: row_undo_dictionary(): For TRX_UNDO_INDEX_CREATE_REC, the index may be NULL when unfinished transactions are rolled back after crash recovery.	19 years ago
marko	da0bcd6429	branches/zip: trx_sys_init_at_db_start(): Initialize trx_dummy_sess before calling trx_lists_init_at_db_start(). This was broken in r1594.	19 years ago
marko	dcd1b3cbef	branches/zip: Fix errors made in r1672.	19 years ago
marko	c99c5c240a	branches/zip: Add const qualifiers to the functions that read MySQL data. row_mysql_read_true_varchar(), row_mysql_read_blob_ref(), row_mysql_store_col_in_innobase_format(), row_sel_convert_mysql_key_to_innobase(): Add const qualifiers. row_sel_convert_mysql_key_to_innobase(): Document that the first parameter is in/out.	19 years ago
marko	60c44c3a5f	branches/zip: Ensure that the dictionary updates are atomic by keeping the data dictionary locked across the operations. dict_table_decrement_handle_count(), row_prebuilt_free(): Add the flag dict_locked, to prevent the acquisition of dict_sys->mutex. innobase_rename_table(): Rename commit_flag to lock_and_commit, and do not acquire dict_sys->mutex or flush the log unless the flag is set. Remove bogus comment about utility threads, because the threads will be waken up by the upper-level function ha_innobase::rename_table(). ha_innobase::add_index(): After creating a primary key, hold dict_sys->mutex across all dictionary operations.	19 years ago
marko	3fa7bde536	branches/zip: row_merge_create_temporary_table(): Correct a bogus ut_ad().	19 years ago
marko	9ae3820ffa	branches/zip: innodb-index.test: Replace numeric error codes with symbolic ones.	19 years ago

... 5 6 7 8 9 ...

976 Commits (1ae59d9e657cf36dfe27c142792354720aa20e09) All Branches Search

976 Commits (1ae59d9e657cf36dfe27c142792354720aa20e09)

All Branches