mariadb

Tree: 1ae59d9e65

Author	SHA1	Message	Date
vasil	1ae59d9e65	branches/zip: Change the output format of transaction ids from 2 32bit numbers separated by space to a single hex number. Suggested by: Heikki Approved by: Heikki	18 years ago
marko	15cc260838	branches/zip: trx0sys.h: Add a compile-time check that UNIV_PAGE_SIZE is at least 4 kilobytes.	18 years ago
marko	5c7fb88749	branches/zip: Allow the uncompressed page size to be settable by setting just one parameter: UNIV_PAGE_SIZE_SHIFT. UNIV_PAGE_SIZE, BUF_BUDDY_SIZES: Define in terms of UNIV_PAGE_SIZE_SHIFT. BUF_BUDDY_LOW_SHIFT: New macro, to simplify the definition of BUF_BUDDY_LOW and BUF_BUDDY_SIZES. PAGE_ZIP_DIR_SLOT_MASK: Relax the compile-time check. This bitmask must be one less than a power of two, and at least UNIV_PAGE_SIZE - 1.	18 years ago
marko	8c852371e5	branches/zip: Add some clarifying comments. btr_copy_blob_prefix(), btr_copy_externally_stored_field_prefix_low(): Document the return value as "number of bytes written", not "bytes written". trx_undo_page_fetch_ext(): Explain the assertion ut_a(ext_len). row_build_index_entry(): Explain the assertion ut_a(!ext).	18 years ago
marko	2c4aaa9ec6	branches/zip: Minor cleanup. row_create_index_graph_for_mysql(): Move from row0mysql.c to row0merge.c and rename to row_merge_create_index_graph(). Also change the function comment to say that the function will create and execute the query graph for creating the index. row_merge_create_index(): Remove redundant assignment to trx->error_state.	18 years ago
marko	acf84dfb75	branches/zip: Fast index creation: Lock the data dictionary only after acquiring the table lock. The data dictionary should not be locked for long periods. Before this change, in the worst case, the dictionary would be locked until the expiration of innodb_lock_wait_timeout. Virtually, transaction-level locks (locks on database objects, such as records and tables) have a latching order level of SYNC_USER_TRX_LOCK, which is above any InnoDB rw-locks or mutexes. However, the latching order of SYNC_USER_TRX_LOCK is never checked, not even by UNIV_SYNC_DEBUG. ha_innobase::add_index(), ha_innobase::final_drop_index(): Invoke row_mysql_lock_data_dictionary(trx) only after row_merge_lock_table().	18 years ago
marko	adbb92becd	branches/zip: Implement a limit for the size of undo log records. innodb-index.test: Add a test with a large number of externally stored columns. Check that there may not be prefix indexes on too many columns. dict_index_too_big_for_undo(): New function: Check if the undo log may overflow. dict_index_add_to_cache(): Return DB_SUCCESS or DB_TOO_BIG_RECORD. Postpone the creation and linking of some data structures, so that when dict_index_too_big_for_undo() holds, it will be easier to clean up. Check the return status in all callers.	18 years ago
marko	b99fbdf261	branches/zip: dict0dict.c: Minor cleanup. dict_index_copy(): Remove the prototype, because this static function will be defined before its first use. Add const qualifier to "table". dict_index_build_internal_clust(), dict_index_build_internal_non_clust(): Add const qualifier to "table". Correct the comment about setting indexed[].	18 years ago
vasil	97025c3acf	branches/zip: Non-functional change: Do not include the terminating '\0' in TRX_I_S_LOCK_ID_MAX_LEN.	18 years ago
marko	807c28079f	branches/zip: Fast index creation: Clarify why lock waits may occur in row_merge_lock_table(). ha_innobase::final_drop_index(): Set the dictionary operation mode to TRX_DICT_OP_INDEX_MAY_WAIT for the duration of the row_merge_lock_table() call.	18 years ago
marko	9120973f56	branches/zip: row_merge_lock_table(): Set a more informative trx->op_info.	18 years ago
marko	71a4f691b2	branches/zip: Fast index creation: Remove the ROW_PREBUILT_OBSOLETE nonsense. Active transactions must not switch table or index definitions on the fly, for several reasons, including the following: * copied indexes do not carry any history or locking information; that is, rollbacks, read views, and record locking would be broken * huge potential for race conditions, inconsistent reads and writes, loss of data, and corruption Instead of trying to track down if the table was changed during a transaction, acquire appropriate locks that protect the creation and dropping of indexes. innodb-index.test: Test the locking of CREATE INDEX and DROP INDEX. Test that consistent reads work across dropped indexes. lock_rec_insert_check_and_lock(): Relax the lock_table_has() assertion. When inserting a record into an index, the table must be at least IX-locked. However, when an index is being created, an IS-lock on the table is sufficient. row_merge_lock_table(): Add the parameter enum lock_mode mode, which must be LOCK_X or LOCK_S. row_merge_drop_table(): Assert that n_mysql_handles_opened == 0. Unconditionally drop the table. ha_innobase::add_index(): Acquire an X or S lock on the table, as appropriate. After acquiring an X lock, assert that n_mysql_handles_opened == 1. Remove the comments about dropping tables in the background. ha_innobase::final_drop_index(): Acquire an X lock on the table. dict_table_t: Remove version_number, to_be_dropped, and prebuilts. ins_node_t: Remove table_version_number. enum lock_mode: Move the definition from lock0lock.h to lock0types.h. ROW_PREBUILT_OBSOLETE, row_update_prebuilt(), row_prebuilt_table_obsolete(): Remove. row_prebuilt_t: Remove the declaration from row0types.h. row_drop_table_for_mysql_no_commit(): Always print a warning if a table was added to the background drop queue.	18 years ago
marko	8d54e9e6dd	branches/zip: lock_rec_insert_check_and_lock(): Use the cached value of thr_get_trx(thr).	18 years ago
marko	252b24e880	branches/zip: innobase_mysql_end_print_arbitrary_thd(): Note that kernel_mutex must be released before calling this function. innobase_mysql_end_print_arbitrary_thd(), innobase_mysql_prepare_print_arbitrary_thd(): Assert that the kernel_mutex is not being held by the current thread.	18 years ago
vasil	a6e940f586	branches/zip: Bugfix: Lock the MySQL mutex LOCK_thread_count before accessing trx->mysql_query_str to avoid race conditions where MySQL sets it to NULL after we have checked that it is not NULL and before we access it. Approved by: Marko	18 years ago
vasil	6367b36c50	branches/zip: Non-functional change: add "out:" comment for the return value.	18 years ago
vasil	dbc6cbe30a	branches/zip: Non-functional change: Move the prototypes of innobase_mysql_prepare_print_arbitrary_thd() and innobase_mysql_end_print_arbitrary_thd() from lock0lock.c to ha_prototypes.h Suggested by: Marko Approved by: Marko	18 years ago
marko	9e26020ceb	branches/zip: page_zip_decompress(): Implement a proper check if there is an overlap between BLOB pointers and the modification log or the zlib stream. page_zip_decompress_clust_ext(): Remove the improper check. The d_stream->avail_in cannot be decremented here, because we do not know at this point if the record is deleted. No space is reserved for the BLOB pointers in deleted records. page_zip_decompress_clust(): Check for the overlap here, right before copying the BLOB pointers. page_zip_decompress_clust(): Also check that the target column is long enough, and return FALSE instead of ut_ad() failure.	18 years ago
vasil	85f1c90d74	branches/zip: Add some clarification to a comment.	18 years ago
marko	c2505f9bb3	branches/zip: page_zip_decompress_node_ptrs(): Remove the local variable is_clust, to avoid a warning about unused variable when the definition of page_zip_fail() is empty.	18 years ago
marko	3802ff3f8c	branches/zip: page0zip.c: Add more page_zip_fail() diagnostics to some decompression functions. page_zip_apply_log_ext(), page_zip_apply_log(): Call page_zip_fail() with appropriate diagnostics before returning NULL. page_zip_decompress_node_ptrs(), page_zip_decompress_sec(), page_zip_decompress_clust(): When detecting that the zlib stream followed by the modification log overlaps the trailer, do not let an assertion fail, but invoke page_zip_fail() and return FALSE. Corrupt data should never lead into assertion failures in decompression functions.	18 years ago
marko	48eb4c4b67	branches/zip: page0zip.c: Define and use the auxiliary macros ASSERT_ZERO() and ASSERT_ZERO_BLOB() for asserting that certain blocks of memory are filled with zero.	18 years ago
marko	8b00501bea	branches/zip: Clarify that buf_buddy_alloc() should only be used for allocating compressed page frames or their control blocks. Also note that if buf_buddy_alloc() is used for allocating a control block, it must be initialized before releasing buf_pool->mutex. buf_page_init_for_read(): When the page hash check fails after buf_buddy_alloc(), free the uninitialized control block before freeing the compressed page frame. This fixes a potential error in buf_buddy_relocate_block().	18 years ago
marko	b7acbef614	branches/zip: Document how the data structures of the buddy allocator are interfaced with the buffer pool.	18 years ago
marko	6d604a10a0	branches/zip: buf_page_get_gen(): Check the return status of buf_zip_decompress() and return NULL on decompression failure.	18 years ago
marko	c94791e13a	branches/zip: Correct an off-by-one error in the debug assertion that was supposed to be fixed in r2163.	18 years ago
marko	33e082be24	branches/zip: buf_buddy_alloc(): Assign *lru = TRUE whenever the buffer pool mutex is temporarily released. buf_LRU_free_block(), buf_buddy_alloc_clean(): Add an output parameter that will be assigned TRUE when the buffer pool mutex is released. This bug was spotted by and fix provided by Sunny.	18 years ago
marko	15ef4c8f0b	branches/zip: rec_convert_dtuple_to_rec_comp(): Allow externally stored columns to be up to REC_MAX_INDEX_COL_LEN + BTR_EXTERN_FIELD_REF_SIZE bytes in a debug assertion. This assertion could fail since r2159 in trx_undo_prev_version_build(), because the undo log records for updates and deletes would contain longer prefixes of externally stored columns. The assertion failure was reported by Sunny.	18 years ago
marko	7c5511ef98	branches/zip: dict_table_copy_types(): Initialize all fields to the SQL NULL value. Document this change in behaviour, and make all callers invoke the function right after dtuple_create(). dict_create_sys_fields_tuple(): Add a missing "break" statement to the loop that checks if there are any column prefixes in the index. row_get_prebuilt_insert_row(): Do not set the fields to the SQL NULL value, now that dict_table_copy_types() takes care of it.	18 years ago
marko	a65020d27f	branches/zip: When logging updates or deletes in the undo log, store long enough prefixes of externally stored columns, so that purge will not have to dereference any BLOB pointers, which may be invalid. This will not be necessary for logging inserts, because inserts are no-ops in purge, and the record will remain locked during transaction rollback. TODO: in dict_build_table_def_step() or dict_build_index_def_step(), prevent the creation of tables with too many columns for which a prefix index is defined. This is because there is a size limit of undo log records, and for each prefix-indexed column, the log must store REC_MAX_INDEX_COL_LEN + BTR_EXTERN_FIELD_REF_SIZE bytes. trx_undo_page_report_insert(): Assert that the index is clustered. trx_undo_page_fetch_ext(): New function, for fetching the BLOB prefix in trx_undo_page_report_modify(). trx_undo_page_report_modify(): Write long enough prefixes of the externally stored columns to the undo log. trx_undo_rec_get_partial_row(): Remove the parameter "ext". Assert that the undo log contains long enough prefixes of the externally stored columns. purge_node_t: Remove the field "ext".	18 years ago
marko	3044ef3523	branches/zip: row_build_index_entry(): Add assertions that prevent improper prefix indexes from being built on externally stored columns.	18 years ago
marko	c440688147	branches/zip: btr_cur_pessimistic_update(), btr_cur_pessimistic_delete(): Use rec_offs_any_extern() as a condition for freeing externally stored columns. This is only a performance optimization.	18 years ago
marko	244c9eeda3	branches/zip: Merge r2154 from trunk: innodb.result, innodb.test: Revert the changes in r2145. The tests that were removed by MySQL ChangeSet@1.2598.2.6 2007-11-06 15:42:58-07:00 tsmith@hindu.god were moved to a new test, innodb_autoinc_lock_mode_zero, which is kept in the MySQL BitKeeper tree.	18 years ago
marko	3978843916	branches/zip: Fix a bug in fast index creation that was introduced in r2131 when row_build() was changed to prefetch all externally stored column prefixes that occur in ordering fields of an index. row_build(): Add the parameter col_table for determining which externally stored columns need to be fetched. row_merge_read_clustered_index(): Pass new_table as the said parameter, so that newly added indexes containing column prefix indexes of externally stored columns will work.	18 years ago
marko	71cf1edf8d	branches/zip: btr_store_big_rec_extern_fields(): Note that the page number of the record containing the field reference may change.	18 years ago
marko	771ed4070c	branches/zip: row_ext_cache_fill(): Add a missing "else" that should have been added in r2131.	18 years ago
marko	b385d9abd2	branches/zip: Merge 2116:2146 from trunk.	18 years ago
marko	44387227d7	branches/zip: row_ext_cache_fill(): Add an assertion that some BLOB data was actually fetched. ext->len[i] == 0 is reserved to mean an uninitialized BLOB pointer.	18 years ago
vasil	6a6d7a9b09	branches/zip: * Change terminology: wait lock -> requested lock waited lock -> blocking lock new: requesting transaction (the trx what owns the requested lock) new: blocking transaction (the trx that owns the blocking lock) * Add transaction ids to INFORMATION_SCHEMA.INNODB_LOCK_WAITS. This is somewhat redundant because transaction ids can be found in INNODB_LOCKS (which can be joined with INNODB_LOCK_WAITS) but would help users to write shorter joins (one table less) in some cases where they want to find which transaction is blocking which. Suggested by: Ken Approved by: Heikki	18 years ago
marko	5784e7debb	branches/zip: row_ext_create(): Remove unused variables that were added in r2131.	18 years ago
marko	603defd2de	branches/zip: row_ext_create(): Remove the UNIV_INLINE that should have been removed in r2131.	18 years ago
marko	8fb8584e75	branches/zip: row_ext: Fetch the BLOB prefixes already at row_ext_create(). Only add indexed BLOBs to row_ext. trx_undo_rec_get_partial_row(): Move the BLOB fetching to row_ext_create(). row_build(): Pass only those BLOBs to row_ext_create() that are referenced by ordering columns of some indexes, similar to trx_undo_rec_get_partial_row(). row_ext_create(): Add the parameter "tuple". Move the implementation from row0ext.ic to row0ext.c. row_ext_lookup_ith(), row_ext_lookup(): Return a const pointer. Remove the parameters "field" and "f_len". Make the row_ext_t* parameter const. row_ext_t: Remove the field zip_size. field_ref_zero[]: Declare in btr0types.h instead of btr0cur.h. row_ext_lookup_low(): Rename to row_ext_cache_fill() and change the signature.	18 years ago
marko	962ed52317	branches/zip: Clean up after r2129: univ.i: Do not define UNIV_DEBUG, UNIV_ZIP_DEBUG. btr_cur_del_unmark_for_ibuf(): Use the same comment in both btr0cur.c and btr0cur.h. Wrap long lines.	18 years ago
sunny	eca3cb2378	branches/zip: Fix a bug where the zipped page and the uncompressed page contents end up with conflicting versions of a record's state. The zipped page record was not being marked as "(un)deleted" because we were not passing the zipped page contents to the (un)delete function, which first (un)delete marks the uncompressed version and then based on whether page_zip is NULL or not (un)delete marks the record in the compressed page.	18 years ago
marko	1a4db95edf	branches/zip: ha_innobase::final_drop_index(): Allocate a separate transaction for dropping the index trees, and set the dictionary operation flag, similar to what ha_innobase::add_index() does. This should ensure correct crash recovery.	18 years ago
marko	cf7d5b774f	branches/zip: trx_undo_rec_get_partial_row(): Set up the row_ext cache only for those externally stored columns that occur in the ordering columns of indexes. Prefetch the prefixes of those columns, because the clustered index record and the BLOBs may have been deleted by the time when the purge thread needs to read the BLOB prefixes. row_ext_create(): Add the debug assertion ut_ad(ut_is_2pow(zip_size)).	18 years ago
marko	dae1fdd6b9	branches/zip: Remove the warnings about pointer targets differing in signedness that were introduced in r2114. row_upd_index_replace_new_col_vals_index_pos(), row_upd_index_replace_new_col_vals(): Declare "data" as const byte* instead of const char*, and add casts to the dtype_get_at_most_n_mbchars() calls.	18 years ago
marko	95d04ddb90	branches/zip: Fix a bug that was introduced in r2123. buf_block_is_uncompressed(): Check that the pointer is aligned. Use the C modulus operator % instead of ut_align_offset(), because sizeof(buf_block_t) is not guaranteed to be a power of 2.	18 years ago
marko	15d8cc6e64	branches/zip: row_vers_impl_x_locked_off_kernel(): In follow-up to r2119, assert ut_a(entry) instead of playing it safe.	18 years ago
marko	a3190b1f49	branches/zip: buf_page_get_gen(): Note that the guessed block may also point to a buffer pool chunk that has been released when resizing the buffer pool. buf_block_is_uncompressed(): Check that the pointer is aligned. Thanks to this check, it is safe to pass an arbitrary pointer as a guess to buf_page_get_gen().	18 years ago

1 2 3 4 5 ...

976 Commits (1ae59d9e657cf36dfe27c142792354720aa20e09) All Branches Search

976 Commits (1ae59d9e657cf36dfe27c142792354720aa20e09)

All Branches