mariadb

Tree: 182e2d4a6c

Author	SHA1	Message	Date
Thirunarayanan Balathandayuthapani	3a8943ae73	MDEV-17481 mariadb service won't shutdown when it's running and the OS datetime updated backwards __pthread_cond_timedwait() in page cleaner hangs if os time moved backwards.Workaround could be waking up the page cleaner thread in logs_empty_and_mark_files_at_shutdown(). But there is possibility that server could hang when server is running. So InnoDB should wake up page cleaner thread periodically in srv_master_do_idle_tasks().	5 years ago
Thirunarayanan Balathandayuthapani	2a3bc0b9cd	MDEV-13830 Assertion failed: recv_sys->mlog_checkpoint_lsn <= recv_sys->recovered_lsn There can be multiple MLOG_CHECKPOINT record for the same checkpoint. During recovery, InnoDB could encounter the previous MLOG_CHECKPOINT for the checkpoint lsn. So the assertion mlog_checkpoint_lsn <= recovered_lsn is wrong.	5 years ago
Varun Gupta	62d73df6b2	MDEV-19232: Floating point precision / value comparison problem The issue occurs when the subquery_cache is enabled. When there is a cache miss the division was leading to a value with scale 9. In the case of cache hit the value returned was of scale 9 and due to the different values for the scales the where condition evaluated to FALSE, hence the output was incomplete. To fix this problem we need to round up the decimal to the limit mentioned in Item::decimals. This would make sure the values are compared with the same scale.	5 years ago
Nikita Malyavin	6898eae7f8	fix assertion	5 years ago
Nikita Malyavin	ebca70ead3	fix c++98 build	5 years ago
Nikita Malyavin	5acd391e8b	MDEV-16039 Crash when selecting virtual columns generated using functions with DAYNAME() * Allocate items on thd->mem_root while refixing vcol exprs * Make vcol tree changes register and roll them back after the statement is executed. Explanation: Due to collation implementation specifics an Item tree could change while fixing. The tricky thing here is to make it on a proper arena. It's usually not a problem when a field is deterministic, however, makes a pain vice-versa, during allocation allocating. A non-deterministic field should be refixed on each statement, since it depends on the environment state. Changing the tree will be temporary and therefore it should be reverted after the statement execution.	6 years ago
Marko Mäkelä	ca9276e37e	Merge 10.1 into 10.2	5 years ago
Marko Mäkelä	57ec42bc32	MDEV-23190 InnoDB data file extension is not crash-safe When InnoDB is extending a data file, it is updating the FSP_SIZE field in the first page of the data file. In commit `8451e09073` (MDEV-11556) we removed a work-around for this bug and made recovery stricter, by making it track changes to FSP_SIZE via redo log records, and extend the data files before any changes are being applied to them. It turns out that the function fsp_fill_free_list() is not crash-safe with respect to this when it is initializing the change buffer bitmap page (page 1, or generally, N*innodb_page_size+1). It uses a separate mini-transaction that is committed (and will be written to the redo log file) before the mini-transaction that actually extended the data file. Hence, recovery can observe a reference to a page that is beyond the current end of the data file. fsp_fill_free_list(): Initialize the change buffer bitmap page in the same mini-transaction. The rest of the changes are fixing a bug that the use of the separate mini-transaction was attempting to work around. Namely, we must ensure that no other thread will access the change buffer bitmap page before our mini-transaction has been committed and all page latches have been released. That is, for read-ahead as well as neighbour flushing, we must avoid accessing pages that might not yet be durably part of the tablespace. fil_space_t::committed_size: The size of the tablespace as persisted by mtr_commit(). fil_space_t::max_page_number_for_io(): Limit the highest page number for I/O batches to committed_size. MTR_MEMO_SPACE_X_LOCK: Replaces MTR_MEMO_X_LOCK for fil_space_t::latch. mtr_x_space_lock(): Replaces mtr_x_lock() for fil_space_t::latch. mtr_memo_slot_release_func(): When releasing MTR_MEMO_SPACE_X_LOCK, copy space->size to space->committed_size. In this way, read-ahead or flushing will never be invoked on pages that do not yet exist according to FSP_SIZE.	5 years ago
Marko Mäkelä	98e2c17e9e	Cleanup: Remove fil_check_adress_in_tablespace()	5 years ago
Marko Mäkelä	14543afd59	Cleanup: Remove unused AbstractCallback::m_free_limit	5 years ago
Varun Gupta	c400ef2586	Making the stat_tables_innodb test deterministic	5 years ago
Julius Goryavsky	a1e52e7f32	MDEV-20401: revert unnecessary change	5 years ago
Julius Goryavsky	1ba8df4c60	MDEV-20401: revert unnecessary change	5 years ago
Julius Goryavsky	b3cae9db11	MDEV-20401: Server incorrectly auto-sets lower_case_file_system value Server auto-sets lower_case_file_system value based on default datadir's behavior instead of instead of using the directory specified by the user through the configuration file or command line options. This patch fixes this problem.	6 years ago
Julius Goryavsky	4412a461a1	MDEV-20401: Server incorrectly auto-sets lower_case_file_system value Server auto-sets lower_case_file_system value based on default datadir's behavior instead of instead of using the directory specified by the user through the configuration file or command line options. This patch fixes this problem.	6 years ago
Marko Mäkelä	147d4b1ec0	MDEV-21347 innodb_log_optimize_ddl=OFF is not crash safe In commit `0f90728bc0` (MDEV-16809) we introduced the configuration option innodb_log_optimize_ddl for controlling whether native index creation or table-rebuild in InnoDB should avoid writing full redo log. Fungo Wang reported that this option is causing occasional failures. The reason is that pages may be written to data files in an inconsistent state. Applying log records to such inconsistent pages may fail. The solution is to always invoke PageBulk::finish() before page latches may be released, to ensure that the page contents is in a consistent state. Something similar was implemented in MySQL 8.0.13: mysql/mysql-server@d1254b947354e0f5b7223b09c521bd85f22e1e31 buf_block_t::skip_flush_check: Remove. Suppressing consistency checks is a bad idea. PageBulk::needs_finish(): New predicate: Determine whether PageBulk::finish() must fix up the page. PageBulk::init(): Clear PAGE_DIRECTION to ensure that needs_finish() will hold. We change the field from PAGE_NO_DIRECTION to 0 and back without writing redo log. This trick avoids the need to introduce any new data member to PageBulk. PageBulk::insert(): Replace some high-level accessors to bypass debug assertions related to PAGE_HEAP_TOP that we will be violating until finish() has been executed. PageBulk::finish(): Tolerate m_rec_no==0. We must invoke this also on an empty page, to ensure that PAGE_HEAP_TOP is initialized. PageBulk::commit(): Always invoke finish(). PageBulk::release(), BtrBulk::pageSplit(), BtrBulk::storeExt(), BtrBulk::finish(): Invoke PageBulk::finish().	5 years ago
Marko Mäkelä	fee11c7727	Make page validation stricter page_simple_validate_old(), page_simple_validate_new(): Require PAGE_N_DIR_SLOTS to be at least 2.	5 years ago
Marko Mäkelä	38b4c07833	MDEV-23183 Infinite loop on page_validate() on corrupted page MDEV-22721 (commit `eba2d10ac5`) inadvertently introduced an infinite loop. page_validate(): Remove the infinite loop.	5 years ago
Vladislav Vaintroub	9c8420fe8c	Fix compile warning	5 years ago
Daniel Black	7473e1841c	check_linker_flag: use for linker flags -Wl,-z,relro,-z,now are linker flags and should be checked as such. TODO: perform module, exe shared checks separately rather than a pure linker check.	6 years ago
Varun Gupta	dfdfeecb03	MDEV-22851: Engine independent index statistics are incorrect for large tables on Windows An oveflow was happening on windows because on Windows sizeof(ulong) is 4 bytes while it is 8 bytes on Linux. Switched avg_frequency and avg length for column statistics to ulonglong. Switched avg_frequency for index statistics to ulonglong.	5 years ago
Marko Mäkelä	07e89bf7d1	MDEV-23163 Merge new release of InnoDB 5.7.31 to 10.2 The only InnoDB change between MySQL 5.7.30 and MySQL 5.7.31 that is applicable to MariaDB Server was applied in commit `8d061996e6` (MDEV-23161).	5 years ago
Marko Mäkelä	646a6005e7	Merge 10.1 into 10.2	5 years ago
Marko Mäkelä	67a03b7c94	XtraDB 5.6.48-88.0 The only InnoDB changes between Percona XtraDB Server 5.6.47-87.0 and 5.6.48-88.0 are related to InnoDB changes between MySQL 5.6.47 and MySQL 5.6.48, which we had already applied.	5 years ago
Marko Mäkelä	142f85142a	Update the InnoDB version number to 5.6.49 There were no InnoDB changes between MySQL 5.6.48 and MySQL 5.6.49.	5 years ago
Marko Mäkelä	8d061996e6	MDEV-23161 avg_count_reset may wrongly be NULL in I_S.INNODB_METRICS This issue was originally reported by Fungo Wang, along with a fix, as MySQL Bug #98990. His suggested fix was applied as part of mysql/mysql-server@a003fc373d1adb3ccea353b5d7d83f6c4c552383 and released in MySQL 5.7.31. i_s_metrics_fill(): Add the missing call to Field::set_notnull(), and simplify some code.	5 years ago
Thirunarayanan Balathandayuthapani	dc58987eb7	MDEV-22765 i_s_fts_index_cache_fill_one_index() is not protect by the lock - i_s_fts_index_cache_fill() should take shared lock of fts cache before accessing index cache to avoid reading stale data.	5 years ago
Julius Goryavsky	6b6c012f33	Merge branch '10.4-MDEV-18838' of https://github.com/codership/mariadb-server into 10.2-MDEV-18838	5 years ago
Thirunarayanan Balathandayuthapani	e80183dbd5	MDEV-15662 mariabackup.huge_lsn fails sporadically with "log sequence number is in the future" - Problem is that test case creates iblogfile* files. So existing ibdata pages could point to future LSN. Fix is that taking the backup of data before iblogfile* creation and apply it before exiting the test case.	5 years ago
Thirunarayanan Balathandayuthapani	194a720e28	MDEV-22890 DEADLOCK of threads detected: row0sel.cc S-LOCK / btr0cur.cc S-LOCK / row0quiesce.cc X-LOCK Problem: ======= - Read operations are always allowed to hold a secondary index leaf latch and then look up the corresponding clustered index record. Flush table operation acquires secondary index latch while holding a clustered index latch. It leads to deadlock violation. Fix: ==== - Flush table operation should acquire secondary index before taking clustered index to avoid deadlock violation with select operation.	5 years ago
Olivier Bertrand	ad0d2424dd	Fix compile error for KVM. Modified filamdbf.cpp	5 years ago
Vicențiu Ciorbaru	f73db93329	MDEV-23027 symlink_wsrep_sst_rsync target built when WITH_WSREP is off Only install wsrep scripts and links if WSREP_ON is actually set	5 years ago
Varun Gupta	b0df247db6	MDEV-22463: Element_type &Bounds_checked_array<Item >::operator[](size_t) [Element_type = Item ]: Assertion `n < m_size' failed. Allocate space for fields inside the window function (arguments, PARTITION BY and ORDER BY clause) in the ref pointer array. All fields inside the window function are part of the temporary table that is required for the window function computation.	5 years ago
Olivier Bertrand	1e07df99f3	- Fix MDEV-22561 Unable to access DBF inside a ZIP archive modified: storage/connect/filamdbf.cpp modified: storage/connect/filamdbf.h modified: storage/connect/filamzip.cpp modified: storage/connect/filamzip.h modified: storage/connect/ha_connect.cc modified: storage/connect/plgxml.cpp modified: storage/connect/tabdos.cpp modified: storage/connect/tabdos.h modified: storage/connect/tabfix.h - Add/Init Level class member modified: storage/connect/mongo.cpp modified: storage/connect/mongo.h modified: storage/connect/tabjson.cpp modified: storage/connect/tabjson.h - Typo modified: storage/connect/connect.cc	5 years ago
Rucha Deodhar	0994af43e5	MDEV-22058: Assertion `!is_set() \|\| (m_status == DA_OK_BULK && is_bulk_op())' failed in Diagnostics_area::set_ok_status Error state is not stored in check_and_do_in_subquery_rewrites() when there is illegal combination of optimizer switches. So all the functions eventually return false. Thus the assetion failure.	5 years ago
Rucha Deodhar	f81ff93287	MDEV-19119: main.ssl_crl fails in buildbot with wrong error code The client can only find out if the server has disconnected when it tries to read or send something. If the server gets disconnected before send_client_reply_packet(), the client will try sending authentication information but it will fail. But, if the client is fast enough to send autentication information before disconnecting, it will notice that when reading the ok packet. So the client can fail on read or on write. It is unpredictable because, the process are unsynchronized and this could happen in any order.	5 years ago
Varun Gupta	737c3025e9	MDEV-10120: Wrong result of UNION .. ORDER BY GROUP_CONCAT() Reject queries that have aggregate functions with UNION as these are not allowed by standard.	5 years ago
Oleksandr Byelkin	a759f9af51	Fix typo in the comment (and old info)	5 years ago
Vicențiu Ciorbaru	f18c5a7ed7	MDEV-23114 AUTH_PAM plugin can not be disabled when using mysql_release config When setting the PLUGIN_AUTH_PAM variable, mark it as a "CACHE" variable so it can be overridden by the user.	5 years ago
Varun Gupta	253aa7bbc4	MDEV-12059: Assertion `precision > 0' failed with a window function or window aggregate function Pass the unsigned flag from the Item_sum to the window function	5 years ago
Rucha Deodhar	a536625553	MDEV-22654: Assertion `!is_set() \|\| (m_status == DA_OK_BULK && is_bulk_op())' failed in Diagnostics_area::set_ok_status on FUNCTION replace When there is REPLACE in the statement, sp_drop_routine_internal() returns 0 (SP_OK) on success which is then assigned to ret. So ret becomes false and the error state is lost. The expression inside DBUG_ASSERT() evaluates to false and thus the assertion failure.	5 years ago
Vladislav Vaintroub	cad9a9b1f8	MDEV-23098 mariadb-upgrade-service.exe does not work on WAMPServer While trying to detect datadir, take into account that one can use Windows service name as section name in options file, for Windows service. The historical obscurity is being used by WAMP installations.	5 years ago
Varun Gupta	6163af9397	MDEV-22390: Assertion `m_next_rec_ptr >= m_rawmem' failed in Filesort_buffer::spaceleft \| SIGSEGV in __memmove_avx_unaligned_erms from my_b_write Make sure that the sort_buffer that is allocated has atleast space for MERGEBUFF2 keys. The issue here was that the record length is quite high and sort buffer size is very small, due to which we end up with zero number of keys in the sort buffer. The Sort_param::max_keys_per_buffer was zero in such a case, due to which we were flushing empty sort_buffer to the disk.	5 years ago
Daniel Black	3efdac2064	MDEV-22173: socket accept - test for failure accept might return an error, including SOCKET_EAGAIN/ SOCKET_EINTR. The caller, usually handle_connections_sockets can these however and invalid file descriptor isn't something to call fcntl on. Thanks to Etienne Guesnet (ATOS) for diagnosis, sample patch description and testing.	6 years ago
Marko Mäkelä	dba7e1e8e1	Merge 10.1 into 10.2	5 years ago
Marko Mäkelä	c43a666662	Revert "Fix result of merge." This reverts commit `e0793d3865`. In idiomatic C++, accessor functions should not discard qualifiers.	5 years ago
Marko Mäkelä	90d1e58ed0	MDEV-22941: Fix the DBUG_ENTER name	5 years ago
Marko Mäkelä	838a1046b2	MDEV-20377: Fix cmake -DPLUGIN_PERFSCHEMA=NO	5 years ago
Marko Mäkelä	69df4f834b	MDEV-20377: Fix -Wunused-but-set-variable	5 years ago
Vladislav Vaintroub	41b0d98e69	MDEV-23067 Windows : manually registered services rejected mysql_upgrade_service - service not using "--defaults-file" can have any name not just "MySQL" - service with "--defaults-file", without datadir in them use default datadir (install_root\data)	5 years ago

1 2 3 4 5 ...

183724 Commits (182e2d4a6ce502ca623ba0baf358cac271e9e425) All Branches Search

183724 Commits (182e2d4a6ce502ca623ba0baf358cac271e9e425)

All Branches