mariadb

Tree: 182e2d4a6c

Author	SHA1	Message	Date
Marko Mäkelä	879ba1979b	MDEV-11799 Doublewrite recovery can corrupt data pages The purpose of the InnoDB doublewrite buffer is to make InnoDB tolerant against cases where the server was killed in the middle of a page write. (In Linux, killing a process may interrupt a write system call, typically on a 4096-byte boundary.) There may exist multiple copies of a page number in the doublewrite buffer. Recovery should choose the latest valid copy of the page. By design, the FIL_PAGE_LSN must not precede the latest checkpoint LSN nor be later than the end of the recovered log. For page_compressed and encrypted pages, we were missing proper consistency checks. In the 10.4 data set generated for in MDEV-23231, the data file contained a valid page_compressed page, and an identical copy of that page was also present in the doublewrite buffer. But, recovery would incorrectly consider the page invalid and restore an uncompressed copy of the same page that had been written before the log checkpoint. (In fact, no redo log was to be applied to that page.) buf_dblwr_process(): Validate the FIL_PAGE_LSN in the doublewrite buffer pages, and always skip page 0, because those pages should have been recovered by Datafile::restore_from_doublewrite() if necessary. Datafile::restore_from_doublewrite(): Choose the latest applicable page from the doublewrite buffer. recv_dblwr_t::find_page(): Also validate encrypted or page_compressed pages. recv_dblwr_t::validate_page(): New function to validate a page, either a copy in a data file or in the doublewrite buffer. Also validate encrypted or page_compressed pages. This is joint work with Thirunarayanan Balathandayuthapani.	5 years ago
Marko Mäkelä	f35d172103	MDEV-23198 Crash in REPLACE row_vers_impl_x_locked_low(): clust_offsets may point to memory that is allocated by mem_heap_alloc() and may have been freed. For initializing clust_offsets, try to use the stack-allocated buffer instead of a pointer that may point to freed memory. This fixes a regression that was introduced in commit `f0aa073f2b` (MDEV-20950).	5 years ago
Nikita Malyavin	fd0abc890f	MDEV-18042 Server crashes upon adding a non-null date column under NO_ZERO_DATE with ALGORITHM=INPLACE accept table_name and db_name instead of table_share in make_truncated_value_warning	5 years ago
Nikita Malyavin	91ebf1844f	MDEV-19338 InnoDB: Failing assertion: !cursor->index->is_committed() Call mark_columns_per_binlog_row_image before find_row() to set up table->vcol_set early, so the virtual column value will be updated after record read (ha_rnd_pos/ha_index_next/etc) by table->update_virtual_fields() call	5 years ago
Sergei Golubchik	09ec8e2e22	improve the error message for a dropped current role	5 years ago
Sergei Golubchik	4635218cb0	MDEV-22521 Server crashes in traverse_role_graph_up or Assertion `user' fails in traverse_role_graph_impl	5 years ago
Thirunarayanan Balathandayuthapani	8a612314d0	MDEV-23332 Index online status assert failure in btr_search_drop_page_hash_index Problem: ======== In row_merge_drop_indexes(), InnoDB drops only the index from dictionary and frees the index pages but it maintains the index object if the table is being used by other DML threads. It sets the online status of the index to ONLINE_INDEX_ABORTED_DROPPED. Removing the index from dictionary doesn't remove the corressponding ahi entries of the index. When block is being reused, InnoDB tries to remove ahi entries for the block and it fails if index online status is ONLINE_INDEX_ABORTED_DROPPED. Fix: ==== MDEV-22456 allows the index ahi entries to be dropped lazily. so checking online status in btr_search_drop_page_hash_index() is meaningless and should be removed.	5 years ago
Marko Mäkelä	4860fe244b	XtraDB 5.6.49-89.0 The only change between Percona XtraDB Server 5.6.48-88.0 and 5.6.49-89.0 (apart from the version number change) was percona/percona-server@25ec24092064c2ab95752705e592e0c038ec1111 which we had already addressed in commit `7c03edf2fe` and commit `c0fca2863b`.	5 years ago
Marko Mäkelä	c5d4dd2533	MDEV-23339 innodb_force_recovery=2 may still abort the rollback of recovered transactions trx_rollback_active(), trx_rollback_resurrected(): Replace an incorrect condition that we failed to replace in commit `b68f1d847f` (MDEV-21217).	5 years ago
Sergei Petrunia	7e9ffc69ec	MDEV-21472: ALTER TABLE ... ANALYZE PARTITION ... with EITS reads and locks all rows Do not collect EITS statistics for this statement: ALTER TABLE t ANALYZE PARTITION p EITS stats are currently global, not per-partition. Collecting global stats when we are asked to process just one partition causes issues for DBAs.	5 years ago
Sergei Golubchik	e54a7ac1b3	MDEV-23010 UPDATE privilege at Database and Table level fail to update with SELECT command denied to user check both column- and table-level grants when looking for SELECT privilege on UPDATE statement.	5 years ago
Sergei Golubchik	2ba70f69fd	cleanup: reduce code duplication	5 years ago
Sergei Golubchik	0b5b2f8641	Bug #25207522 : INCORRECT ORDER-BY BEHAVIOR ON A PARTITIONED TABLE WITH A COMPOSITE PREFIX INDEX Fix prefix key comparison in partitioning. Comparions must take into account no more than prefix_len characters. It used to compare prefix_len*mbmaxlen bytes.	5 years ago
Sergei Golubchik	d5970779fa	bugfix: mysql_create_view() infinite loop if mysql_create_view() is aborted when view is linked into lex (when WSREP_TO_ISOLATION_BEGIN fails), it should not be linked there again on err:.	6 years ago
Sergei Golubchik	77b7f793f9	MDEV-18496 Crash when Aria encryption is enabled but plugin not available fix uninitialized struct member	6 years ago
Sergei Golubchik	88cbe2f081	MDEV-18496 Crash when Aria encryption is enabled but plugin not available wait_while_table_is_used() should return an error if handler::extra() fails	6 years ago
Oleksandr Byelkin	2107e3bb9c	MDEV-21258: Can't uninstall plugin if the library file doesn't exist Removing plugin from the mysql.plugin even if the plugin is not loaded	5 years ago
Eugene Kosov	8ec877f40a	speed up my_timer_init() I run perf top during ./mtr testing and constantly see times() function there. It's so slow, that it has no sense to run it in a loop too many times. This patch speeds up -suite=innodb for me from 218s to 208s. 9s of times() function!	5 years ago
Marko Mäkelä	3c3f172f17	MDEV-23308 CHECK TABLE attempts to access parent_right_page_no=FIL_NULL mysql/mysql-server@e00ad49edc8b07317b52c9efd0810f2cbc57877a which introduced WL#6326 to MySQL 5.7.2 added a buffer page acquisition to CHECK TABLE code (solely for the purpose of obeying the changed latching order), but failed to check that a parent page actually exists. It would not necessarily exist in a corrupted index where a parent page is missing pointer records to child pages.	5 years ago
Marko Mäkelä	6307b17aa1	MDEV-20142 encryption.innodb_encrypt_temporary_tables failed in buildbot with wrong result Let us read both encrypted temporary tables to increase the changes of page flushing and eviction.	5 years ago
Daniel Black	940668f5cb	MDEV-23137: aarch64, postfix - cmake include	5 years ago
Dan Solodko	459b87f6b4	MDEV-9911: NTILE must return an error when parameter is not stable	5 years ago
Karthik Kamath	e6cb263ef3	MDEV-15961: Fix stacktraces under FreeBSD (aarch64) Largely based on MySQL commit `75271e51d6` MySQL Ref: BUG#24566529: BACKPORT BUG#23575445 TO 5.6 (cut) Also, the PTR_SANE macro which tries to check if a pointer is invalid (used when printing pointer values in stack traces) gave false negatives on OSX/FreeBSD. On these platforms we now simply check if the pointer is non-null. This also removes a sbrk() deprecation warning when building on OS X. (It was before only disabled with building using XCode). Removed execinfo path of MySQL patch that was already included. sbrk doesn't exist on FreeBSD aarch64. Removed HAVE_BSS_START based detection and replaced with __linux__ as it doesn't exist on OSX, Solaris or Windows. __bss_start exists on mutiple Linux architectures. Tested on FreeBSD and Linux x86_64. Being in FreeBSD ports for 2 years implies a good testing there on all FreeBSD architectures there too. MySQL-8.0.21 code is functionally identical to original commit.	5 years ago
Daniel Black	cae4b3f811	rocksdb: FreeBSD disable jemalloc search FreeBSD's inbuilt default jemalloc means its pointless to do a package search on it. The paths are already set by the system defaults.	5 years ago
Daniel Black	715beee46a	MDEV-23051: riscv64 fails build (atomics) riscv64 fails to build because the use of #include <atomic> needs to link with -latomic. per https://github.com/riscv/riscv-gnu-toolchain/issues/183#issuecomment-253721765	5 years ago
Krunal Bauskar	d88ea26088	MDEV-23137: RocksDB: undefined reference to crc32c_arm64 RocksDB fails to build on arm64: undefined reference to `crc32c_arm64(unsigned int, unsigned char const*, unsigned int)' MariaDB uses storage/rocksdb/build_rocksdb.cmake to compile RocksDB. Said cmake missed adding crc32c_arm64 compilation target so if machine native architecture supported crc32 then complier would enable usage of function defined in crc32c_arm64 causing the listed error. Added crc32c_arm64 complition target. closes #1642	5 years ago
Daniel Black	beec8404fa	MDEV-17076: mtr int options aren't negative	5 years ago
Daniel Black	99af3cbc85	MDEV-17076: mtr max-{core,datadir} 0 means 0 There was no ability to set the mtr arguments of: * --max-save-core; and * --max-save-datadir to 0. This is desireable in an automatied scenario where space is limited hence targeting 10.1 branch. We take away the 0 means unlimited aspect for these, however, perl can handle some big numbers so they may as well be close enough to unlimited for all meaningful purposes.	5 years ago
Teodor Mircea Ionita	1ce97358bb	MDEV-17076: increment only if saving occurs	7 years ago
Daniel Black	186d9d0d72	MDEV-12474: rocksdb: mtr - rocksdb.concurrent_alter use sh FreeBSD doesn't have bash installed by default and sh has sufficient job control for this test. $ mysql-test/mtr --mem --max-test-fail=30 --force --parallel=1 rocksdb.concurrent_alter Logging: /home/dan/mariadb-server-10.5/mysql-test/mysql-test-run.pl --mem --max-test-fail=30 --force --parallel=1 rocksdb.concurrent_alter vardir: /usr/home/dan/build-mariadb-server-10.5/mysql-test/var Checking leftover processes... Removing old var directory... Creating var directory '/usr/home/dan/build-mariadb-server-10.5/mysql-test/var'... - symlinking 'var' to '/tmp/var_auto_P81m' Checking supported features... MariaDB Version 10.5.4-MariaDB - SSL connections supported - binaries built with wsrep patch Collecting tests... Installing system database... ============================================================================== TEST RESULT TIME (ms) or COMMENT -------------------------------------------------------------------------- worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 16000..16019 rocksdb.concurrent_alter 'write_committed' [ pass ] 16348 rocksdb.concurrent_alter 'write_prepared' [ pass ] 16771 -------------------------------------------------------------------------- The servers were restarted 1 times Spent 33.119 of 41 seconds executing testcases Completed: All 2 tests were successful. $ uname -a FreeBSD freebsd 12.1-RELEASE-p6 FreeBSD 12.1-RELEASE-p6 GENERIC amd64	5 years ago
Daniel Black	c81a2d2322	MDEV-23088: Change LimitNOFILE default from 16364 to 16384 Correct to a true 2^14 rather than some different number that was actually just a number typo. Bug report thanks to Hartmut Holzgraefe.	5 years ago
Thirunarayanan Balathandayuthapani	a1f899a8ab	MDEV-23233: Race condition for btr_search_drop_page_hash_index() in buf_page_create() commit `ad6171b91c` (MDEV-22456) introduced code to buf_page_create() that would lazily drop adaptive hash index entries for an index that has been evicted from the data dictionary cache. Unfortunately, that call was missing adequate protection. While the btr_search_drop_page_hash_index(block) was executing, the block could be reused for something else. buf_page_create(): If btr_search_drop_page_hash_index() must be invoked, pin the block before releasing the buf_pool->page_hash lock, so that the block cannot be grabbed by other threads.	5 years ago
Jan Lindström	b4c742108f	Enable fixed test case.	5 years ago
Varun Gupta	a6410deba9	MDEV-18916: crash in Window_spec::print_partition() with decimals Removed an unnecessary ifndef which was printing the window name for a named window only in the case of debug build. The print() for the window function should behave in the same way on both release and debug builds.	5 years ago
Alexander Barkov	29851b677e	MDEV-23282 FLOAT(53,0) badly handles out-of-range values truncate_double() did not take into account the max_value limit in case when dec<NOT_FIXED_DEC.	5 years ago
Sergei Petrunia	8460db12b5	Add testcases for MDEV-20557, MDEV-21649	5 years ago
Sergei Petrunia	b000d6952f	MDEV-23221: A subquery causes crash * Fix the crash: IN-to-EXISTS rewrite causes an error (and so JOIN::optimize() fails with an error, too), don't call update_used_tables(). Terminate the query execution instead. * Fix the cause of the error in the IN-to-EXISTS rewrite: don't do the rewrite if doing it will cause an error of this kind: This version of MariaDB doesn't yet support 'SUBQUERY in ROW in left expression of IN/ALL/ANY' * Fix another issue exposed by this testcase: JOIN::setup_subquery_caches() may be invoked before any select has saved its query plan, and will crash because none of the SELECTs has called create_explain_query_if_not_exists() to create the Explain Data Structure for this SELECT. TODO: When merging this to 10.2, remove the poorly-placed call to create_explain_query_if_not_exists made by fix for M_D_E_V-16153	5 years ago
Thirunarayanan Balathandayuthapani	5f1ec5cbb7	MDEV-14711 Assertion `mode == 16 \|\| mode == 12 \|\| !fix_block->page.file_page_was_freed' failed in buf_page_get_gen (rollback requesting a freed undo page) Problem: ======= In buf_cur_optimistic_latch_leaves(), requesting a left block with BTR_GET after releasing current block. But there is no guarantee that left block could be still available. Fix: ==== (1) In btr_cur_optimistic_latch_leaves(), replace the BUF_GET with BUF_GET_POSSIBLY_FREED for fetching left block. (2) Once InnoDB acquires left block, it should check FIL_PAGE_NEXT with current block page number. If not, release cursor->left_block and return false.	5 years ago
mkaruza	a3a249c72f	MDEV-15236: galera_ist_progress fails when trying to read transfer status Fixed by new recording test recording	5 years ago
sjaakola	c9928cc0fb	MDEV-20928 mtr test galera.galera_var_innodb_disallow_writes test failure The sporadic test hangs happen because of mutex dealock between innodb background threads and two test connection executions. The test sets variable innodb_disallow_writes, which blocks all writes to filesyste. The test logic is to execute an INSERT, which should hang because of filesytstem writes are blocked, and through another session verify by SELECT that this hanging happens. The SELECT session will then release innodb_disallow_writes blocking. However, filesystem write blocking affects also innodb background threads and they may hang while keeping some other resources locked. As an example, in one test hang situation, buffer pool access was blocked. And, if buffer pool is blocked, the test connections will be blocked as well, and the SELECT session will not be able to continue to release the innodb_disallow_writes. The fix in this commit is refactoring of the test logic. The test will now set first innodb_disallow_writes blocking, and then record a hash of data directory's filesystem contents. This works as checksum of the state of data on the datadirectory. Then some SQL load is tried on both nodes, these sessions will be blocking due to frozen file system state. The test will have a short sleep to allow innodb background threads to loop and possibly encounter innodb_disallow_writes blocking as well. After the sleep, the test will record file system checksun for the second time, and then release the innodb_disallow-writes blocking. Finally, the two checksums are compared, they should be identical to verify that nothing was written on datadirectory during the test execution. The checksum is implemented by md5sum hash over all files found in datadirectory by find command. all these file hashes are hashed together by one more md5sum. The test therefore depends on md5sum and find. find may work differently with some OS distributions, e.g. freebsd may be problematic.	5 years ago
Daniel Black	4b97f14a3d	mysql_install_db: help lists --defaults-file twice Removed duplicate. Also move the --no-defaults option close to the other "default*" options.	5 years ago
Teemu Ollakka	8ef41c6084	MDEV-23272 Galera stack-use-after-scope error with ASAN build THD proc info was assigned from stack allocated temporary buffer which went out of scope immediately after assignment. Fixed by removing the use of temp buffer and assign proc info from string literal.	5 years ago
Jan Lindström	ba23e6d76f	MDEV-18177 : Galera test failure on galera_autoinc_sst_mariabackup Add wait_condition	5 years ago
Ian Gilfillan	7d22d666d2	MDEV-15207: mysql_upgrade cannot create file mysql_upgrade_info	5 years ago
Thirunarayanan Balathandayuthapani	b3b1c51e4d	MDEV-23134 SEGV in dict_load_table_one during restart after server crash Problem: ======== dict_load_table_one() doesn't handle the scenario where clustered index page is FIL_NULL when DICT_ERR_IGNORE_INDEX_ROOT mode is set. Fix: ==== InnoDB should set the file_unreadable when it can't find the clustered index root page.	5 years ago
Thirunarayanan Balathandayuthapani	adeb736f9a	MDEV-22903 heap-use-after-free while accessing fts cache deleted doc ids Problem: ======= fts_cache_append_deleted_doc_ids() holds the deleted_lock and tries to access size of deleted_doc_ids. In the meantime, fts_cache_clear() clears the sync_heap before clearing deleted_doc_ids. It leads to invalid access of deleted_doc_ids. Fix: === fts_cache_clear() should free the sync_heap after clearing deleted_doc_ids.	5 years ago
Thirunarayanan Balathandayuthapani	fe39d02f51	MDEV-20638 Remove the deadcode from srv_master_thread() and srv_active_wake_master_thread_low() - Due to commit `fe95cb2e40` (MDEV-16125), InnoDB master thread does not need to call srv_resume_thread() and therefore there is no need to wake up the thread. Due to the above patch, InnoDB should remove the following dead code. srv_check_activity(): Makes the parameter as in,out and returns the recent activity value innobase_active_small(): Removed srv_active_wake_master_thread(): Removed srv_wake_master_thread(): Removed srv_active_wake_master_thread_low(): Removed Simplify srv_master_thread() and remove switch cases, added the assert. Replace srv_wake_master_thread() with srv_inc_activity_count() INNOBASE_WAKE_INTERVAL: Removed	5 years ago
Sujatha	b3dd95e035	MDEV-14203: rpl.rpl_extra_col_master_myisam, rpl.rpl_slave_load_tmpdir_not_exist failed in buildbot with a warning Problem: ======= rpl.rpl_slave_load_tmpdir_not_exist 'stmt' w3 [ fail ] Found warnings/errors in server log file! Test ended at 2017-09-27 20:34:55 [Warning] Master is configured to log replication events with checksum, but will not send such events to slaves that cannot process them ^ Found warnings in /mnt/buildbot/build/mariadb-10.2.10/mysql-test/var/3/log/mysqld.1.err ok Analysis: ======== When slave tries to connect to master 'get_master_version_and_clock' function is invoked to perform elaborated slave-master handshake. During this process slave server queries master server, to know if it is checksum aware and at the same time master is notified about its CRC-awareness. The master's side instant value of @@global.binlog_checksum is stored in the dump thread's uservar area as well as cached locally to become known in consensus by master and slave. Post hand-shake slave requests master for binlog dump. It sends 'COM_BINLOG_DUMP'. This command is sent to master by 'cli_advanced_command' call. If there is some temporary network failure during this request_dump call, 'end_server' is invoked to close the current connection between master and slave. Upon connection close the dump thread on the master gets terminated and it clears the 'uservar' data it got through master-slave handshake. The 'COM_BINLOG_DUMP' command is sent once again without master-slave handshake. Since the checksum data is not available with new dump thread a warning gets reported. Fix: === Upon network write error donot attempt reconnect, proceed to master-slave handshake. This ensures that master is aware of slave's capability to use checksums.	5 years ago
Marko Mäkelä	52ccedd6dd	MDEV-23268 SIGSEGV on srv_monitor_event if InnoDB is read-only The srv_monitor_event and the srv_monitor_thread would not be created when InnoDB is in read-only mode. Yet, some code would unconditionally invoke os_event_set(srv_monitor_event).	5 years ago
Ian Gilfillan	d2982331a6	Code comment spellfixes	5 years ago

1 2 3 4 5 ...

183724 Commits (182e2d4a6ce502ca623ba0baf358cac271e9e425) All Branches Search

183724 Commits (182e2d4a6ce502ca623ba0baf358cac271e9e425)

All Branches