mariadb

Tree: 13493078e9

Author	SHA1	Message	Date
Marko Mäkelä	13493078e9	MDEV-11802 innodb.innodb_bug14676111 fails The function trx_purge_stop() was calling os_event_reset(purge_sys->event) before calling rw_lock_x_lock(&purge_sys->latch). The os_event_set() call in srv_purge_coordinator_suspend() is protected by that X-latch. It would seem a good idea to consistently protect both os_event_set() and os_event_reset() calls with a common mutex or rw-lock in those cases where os_event_set() and os_event_reset() are used like condition variables, tied to changes of shared state. For each os_event_t, we try to document the mutex or rw-lock that is being used. For some events, frequent calls to os_event_set() seem to try to avoid hangs. Some events are never waited for infinitely, only timed waits, and os_event_set() is used for early termination of these waits. os_aio_simulated_put_read_threads_to_sleep(): Define as a null macro on other systems than Windows. TODO: remove this altogether and disable innodb_use_native_aio on Windows. os_aio_segment_wait_events[]: Initialize only if innodb_use_native_aio=0.	9 years ago
Marko Mäkelä	72994d6442	Revert the MDEV-4396 tweak to innodb.innodb_bug14676111. MDEV-11802 aims to fix the root cause instead.	9 years ago
Elena Stepanova	343ba58562	MDEV-10631 rpl.rpl_mdev6386 failed in buildbot The failure happens due to a race condition between processing a row event (INSERT) and an automatically generated event DROP TEMPORARY TABLE. Even though DROP has a higher GTID, it can become visible in @@gtid_slave_pos before the row event with a lower GTID has been committed. Since the test makes the slave to synchronize with the master using GTID, the waiting stops as soon as GTID of the DROP TEMPORARY TABLE becomes visible, and if changes from the previous event haven't been applied yet, the error occurs. According to Kristian (see the comment to MDEV-10631), the real problem is that DROP TEMPORARY TABLE is logged in the row mode at all. For this particular test, since DROP does not do anything, nothing prevents it from competing with the prior transaction. The workaround for the test is to add a meaningful event after DROP TEMPORARY TABLE, so that the slave would wait on its GTID instead of the one from DROP. Additionally (unrelated to this problem) removed FLUSH TABLES, which, as the comment stated, should have been removed after MDEV-6403 was fixed.	9 years ago
Elena Stepanova	72a822f2ec	MDEV-11766 Tests failed in buildbot with semaphore waiting warnings The standalone warning is not a sign of a problem, just of slowness, so it should be added to global suppressions. If a real problem happens, there will be other errors	9 years ago
Daniel Black	5e42c958a5	MDEV-11619: mtr --mem and $MTR_MEM support in sane and consistent manner (10.0) (#289 ) * Revert "Make --mem a pure flag. If there is need to specifically set the location" This reverts commit `716621db3f`. * MDEV-11619: mtr: when --mem is pure flag, conflicts with $MTR_MEM Conflicts occurs when MTR_MEM=/xxx/yy ./mtr --mem is invoked. Here the --mem option overrides opt_mem leaving the default path to be chosen. This change makes when MTR_MEM set, opt_mem, the flag, is also set. Both the environment and flag can no be set without conflicting. Signed-off-by: Daniel Black <daniel.black@au.ibm.com> * MDEV-11619: if opt_mem is a path include it first * MDEV-11619: MTR_MEM locations - don't follow symlinks From Bjorn Munch it seems symlinks can confuse some tests. Lets just avoid those. (ref: https://github.com/mysql/mysql-server/pull/116#issuecomment-268479774) Signed-off-by: Daniel Black <daniel.black@au.ibm.com>	9 years ago
Marko Mäkelä	01d5d6db4c	Fix GCC 6.3.0 warnings.	9 years ago
Marko Mäkelä	6011fb6daa	Post-push fix for MDEV-11947 InnoDB purge workers fail to shut down Use the ib_int64_t type alias instead of the standard type int64_t, so that the code will compile on Microsoft Visual Studio 2013.	9 years ago
Marko Mäkelä	d831e4c22a	MDEV-12024 InnoDB startup fails to wait for recv_writer_thread to finish recv_writer_thread(): Do not assign recv_writer_thread_active=true in order to avoid a race condition with recv_recovery_from_checkpoint_finish(). recv_init_crash_recovery(): Assign recv_writer_thread_active=true before creating recv_writer_thread.	9 years ago
Marko Mäkelä	f162704570	Rewrite the innodb.log_file_size test with DBUG_EXECUTE_IF. Remove the debug parameter innodb_force_recovery_crash that was introduced into MySQL 5.6 by me in WL#6494 which allowed InnoDB to resize the redo log on startup. Let innodb.log_file_size actually start up the server, but ensure that the InnoDB storage engine refuses to start up in each of the scenarios.	9 years ago
Marko Mäkelä	20e8347447	MDEV-11985 Make innodb_read_only shutdown more robust If InnoDB is started in innodb_read_only mode such that recovered incomplete transactions exist at startup (but the redo logs are clean), an assertion will fail at shutdown, because there would exist some non-prepared transactions. logs_empty_and_mark_files_at_shutdown(): Do not wait for incomplete transactions to finish if innodb_read_only or innodb_force_recovery>=3. Wait for purge to finish in only one place. trx_sys_close(): Relax the assertion that would fail first. trx_free_prepared(): Also free recovered TRX_STATE_ACTIVE transactions if innodb_read_only or innodb_force_recovery>=3.	9 years ago
Marko Mäkelä	9f0dbb3120	MDEV-11947 InnoDB purge workers fail to shut down srv_release_threads(): Actually wait for the threads to resume from suspension. On CentOS 5 and possibly other platforms, os_event_set() may be lost. srv_resume_thread(): A counterpart of srv_suspend_thread(). Optionally wait for the event to be set, optionally with a timeout, and then release the thread from suspension. srv_free_slot(): Unconditionally suspend the thread. It is always in resumed state when this function is entered. srv_active_wake_master_thread_low(): Only call os_event_set(). srv_purge_coordinator_suspend(): Use srv_resume_thread() instead of the complicated logic.	9 years ago
Marko Mäkelä	e174d923d9	innodb.innodb-get-fk: Actually test --innodb-read-only.	9 years ago
Elena Stepanova	1d725c8176	Flush suppressions table to prevent corruption when server is killed	9 years ago
Elena Stepanova	b3dac63f9b	Produce better diagnostics when backtrace attempt fails	9 years ago
Elena Stepanova	923d7d0ad2	Set sys_errno upon exec command	9 years ago
Elena Stepanova	c46d140961	MDEV-11764 perfschema.table_name fails in buildbot There is only one select that returns a result set in this test. It needs to be sorted	9 years ago
Nirbhay Choubey	f7e03d4419	MDEV-4774: Fix test case	9 years ago
Marko Mäkelä	4e82aaab2f	Clean up a few tests that kill the server. As noted in MDEV-8841, any test that kills the server must issue FLUSH TABLES, so that tables of crash-unsafe storage engines will not be corrupted. Consistently issue this statement after any call mtr.add_suppression() calls. Also, do not invoke shutdown_server directly, but use helpers instead.	9 years ago
Marko Mäkelä	ea9caea87e	MDEV-11814 test fix Do not kill the server after call mtr.add_suppression(), because the procedure modifies a crash-unsafe table, and we do not want to corrupt that table.	9 years ago
Marko Mäkelä	732672c304	MDEV-11233 CREATE FULLTEXT INDEX with a token longer than 127 bytes crashes server This bug is the result of merging the Oracle MySQL follow-up fix BUG#22963169 MYSQL CRASHES ON CREATE FULLTEXT INDEX without merging the base bug fix: Bug#79475 Insert a token of 84 4-bytes chars into fts index causes server crash. Unlike the above mentioned fixes in MySQL, our fix will not change the storage format of fulltext indexes in InnoDB or XtraDB when a character encoding with mbmaxlen=2 or mbmaxlen=3 and the length of a word is between 128 and 84mbmaxlen bytes. The Oracle fix would allocate 2 length bytes for these cases. Compatibility with other MySQL and MariaDB releases is ensured by persisting the used maximum length in the SYS_COLUMNS table in the InnoDB data dictionary. This fix also removes some unnecessary strcmp() calls when checking for the legacy default collation my_charset_latin1 (my_charset_latin1.name=="latin1_swedish_ci"). fts_create_one_index_table(): Store the actual length in bytes. This metadata will be written to the SYS_COLUMNS table. fts_zip_initialize(): Initialize only the first byte of the buffer. Actually the code should not even care about this first byte, because the length is set as 0. FTX_MAX_WORD_LEN: Define as HA_FT_MAXCHARLEN 4 aka 336 bytes, not as 254 bytes. row_merge_create_fts_sort_index(): Set the actual maximum length of the column in bytes, similar to fts_create_one_index_table(). row_merge_fts_doc_tokenize(): Remove the redundant parameter word_dtype. Use the actual maximum length of the column. Calculate the extra_size in the same way as row_merge_buf_encode() does.	9 years ago
Marko Mäkelä	afb461587c	MDEV-11915 Detect InnoDB system tablespace size mismatch early InnoDB would refuse to start up if there is a mismatch on the size of the system tablespace files. However, before this check is conducted, the system tablespace may already have been heavily modified. InnoDB should perform the size check as early as possible. recv_recovery_from_checkpoint_finish(): Move the recv_apply_hashed_log_recs() call to innobase_start_or_create_for_mysql(). innobase_start_or_create_for_mysql(): Test the mutex functionality before doing anything else. Use a compile_time_assert() for a sizeof() constraint. Check the size of the system tablespace as early as possible.	9 years ago
Marko Mäkelä	49fe9bad01	MDEV-11814 Refuse innodb_read_only startup if crash recovery is needed recv_scan_log_recs(): Remember if redo log apply is needed, even if starting up in innodb_read_only mode. recv_recovery_from_checkpoint_start_func(): Refuse innodb_read_only startup if redo log apply is needed.	9 years ago
Varun Gupta	8725b35d89	MDEV-11108: Assertion `uniq_tuple_length_arg <= table->file->max_key_length()' failed in SJ_TMP_TABLE::create_sj_weedout_tmp_table Removed the assert from the if clause to the else clause.	9 years ago
Sachin Setiya	18ef02b04d	MDEV-4774 Strangeness with max_binlog_stmt_cache_size Settings Problem:- When setting max_binlog_stmt_cache_size=18446744073709547520 from either command line or .cnf file, server fails to start. Solution:- Added one more function eval_num_suffix_ull , which uses strtoull to get unsigned ulonglong from string. And getopt_ull calls this function instead of eval_num_suffix. Also changed previous eval_num_suffix to eval_num_suffix_ll to remain consistent.	9 years ago
Sergei Golubchik	fbcdc3437c	connect zip bug fix	9 years ago
Sergei Golubchik	6728aae3b3	Merge branch '5.5' into 10.0	9 years ago
Sergei Golubchik	e4e801d478	connect: compilation errors and few obvious bugs	9 years ago
Kristian Nielsen	3e589d4b8e	MDEV-11811: dual master with parallel replication memory leak in write master Gtid_list_log_event::do_apply_event() did not free_root(thd->mem_root). It can allocate on this in record_gtid(), and in some scenarios there is nothing else that does free_root(), leading to temporary memory leak until stop of SQL thread. One scenario is in circular replication with only one master active. The active master receives only its own events on the slave, all of which are ignored. But whenever the SQL thread catches up with the IO thread, a Gtid_list_log_event is applied, leading to the leak.	9 years ago
Sergei Golubchik	b948b5f7c6	bugfix: Item_func_min_max stored thd internally It was used for get_datetime_value() and for thd->is_error(). But in fact, get_datetime_value() never used thd argument, because the cache ptr argument was NULL. And thd->is_error() check was not needed at that place at all.	9 years ago
Sergei Golubchik	798fcb5416	bugfix: cmp_item_row::alloc_comparators() allocated on the wrong arena it used current_thd->alloc() and allocated on the thd's execution arena, not on table->expr_arena. Remove THD::arena_for_cached_items that is temporarily set in update_virtual_fields(), and replaces THD arena in get_datetime_value(). Instead set THD arena to table->expr_arena for the whole duration of update_virtual_fields()	9 years ago
Sergei Golubchik	67e2028161	MDEV-9690 concurrent queries with virtual columns crash in temporal code Item_func_le included Arg_comparator. Arg_comparator remembered the current_thd during fix_fields and used that value during execution to allocate Item_cache in get_datetime_value(). But for vcols fix_fields and val_int can happen in different threads. Same bug for Item_func_in using in_datetime or cmp_item_datetime, both also remembered current_thd at fix_fields() to use it later for get_datetime_value(). As a fix, these objects no longer remember the current_thd, and get_datetime_value() uses current_thd at run time. This should not increase the number of current_thd calls much, as Item_cache is created only once anyway.	9 years ago
Vicențiu Ciorbaru	66744f4540	Merge branch '5.5' into 10.0	9 years ago
Daniel Bartholomew	939d1255a7	bump the VERSION	9 years ago
Sergei Golubchik	20ca1bcf4b	MDEV-11527 Virtual columns do not get along well with NO_ZERO_DATE don't check defaults for vcols	9 years ago
Vicențiu Ciorbaru	4f53384678	Merge branch 'bb-10.0-vicentiu' into 10.0 Extra merge commit due to intermediate commits pushed to 10.0 while merge was done.	9 years ago
Vicențiu Ciorbaru	1c5ca7c183	Merge branch '5.5' into 10.0	9 years ago
Sergei Golubchik	0d1d0d77f2	MDEV-11706 Assertion `is_stat_field \|\| !table \|\| (!table->write_set \|\| bitmap_is_set(table->write_set, field_index) \|\| (table->vcol_set && bitmap_is_set(table->vcol_set, field_index)))' failed in Field_time::store_TIME_with_warning vcols and triggers. Revert `094f4cf778`, backport the correct fix (Table_triggers_list::mark_fields_used() not marking vcols) from 10.2.	9 years ago
Nirbhay Choubey	ab93a4d4df	MDEV-11685: sql_mode can't be set with non-ascii connection charset The supplied sql_mode(s) should be converted to ASCII first, before comparing it with the sql_mode set.	9 years ago
Marko Mäkelä	833fda8f1a	InnoDB: Enable UNIV_DEBUG_VALGRIND for cmake -DWITH_VALGRIND The symbol HAVE_VALGRIND_MEMCHECK_H was never defined. Instead, the symbol HAVE_VALGRIND should have been used.	9 years ago
Sergei Golubchik	c1a23cd4e5	MDEV-11676 Starting service with mysqld_safe_helper fails in SELINUX "enforcing" mode compile, and install selinux policy for mysqld_safe_helper on centos6. the policy was created as described in https://mariadb.com/kb/en/mariadb/what-to-do-if-mariadb-doesnt-start/#other-selinux-changes	9 years ago
Elena Stepanova	f516db3500	Updated list of unstable tests for 10.0.29 release	9 years ago
iangilfillan	9a4bc0d098	Update mysql_secure_installation man page	9 years ago
Sergei Golubchik	6ad3dd6054	mysqld_safe: don't close stdout if set -x	9 years ago
Marko Mäkelä	78e6fafcaa	Fix an innodb_plugin leak noted in MDEV-11686 buf_flush_init_flush_rbt() was called too early in MariaDB server 10.0, 10.1, MySQL 5.5 and MySQL 5.6. The memory leak has been fixed in the XtraDB storage engine and in MySQL 5.7. As a result, when the server is started to initialize new data files, the buf_pool->flush_rbt will be created unnecessarily and then leaked. This memory leak was noticed in MariaDB server 10.1 when running the test encryption.innodb_first_page.	9 years ago
Vicențiu Ciorbaru	4799af0925	Fix unit test after merge from mysql 5.5.35 perfschema The problem in MariaDB is introduced by this merge commit: `c33db2cdc0` The merge comes from mysql and the original author comes from this commit from MySQL: ------------------------------------------------ commit `160b823d14` Author: Marc Alff <marc.alff@oracle.com> Date: Tue Aug 30 12:14:07 2016 +0200 Bug#22551677 SIGNAL 11 IN LF_PINBOX_PUT_PINS Backport to 5.6 ------------------------------------------------ The breaking change is in start_socket_wait_v1 where instead of using m_thread_owner, we make use of my_pthread_getspecific_ptr to fetch a thread local storage value. Unfortunately this invalidates the "m_thread_owner" member when a socket is created. The internals of the socket structure have m_thread_owner set to NULL, but when checking for ownership we actually look at the current thread's key store. This seems incorrect however it is not immediately apparent why. To not diverge from MySQL's reasoning as it is not described what the actual problem was that this commit is trying to fix, I have adjusted the unittest to account for this new behaviour. We destroy the current thread in the unit test, such that the newly created socket actually has no thread owner. The m_thread_owner is untouched in all this.	9 years ago
Vicențiu Ciorbaru	d00d46f4ce	Merge remote-tracking branch 'origin/5.5' into 10.0	9 years ago
Vicențiu Ciorbaru	ecdb39a9f5	Fix problems from 5.5 merge * Update mysqld_safe script to remove duplicated parameter --crash-script * Make --core-file-size accept underscores as well as dashes correctly. * Add mysqld_safe_helper to Debian and Ubuntu files. * Update innodb minor version to 35	9 years ago
Vicențiu Ciorbaru	94e18e2987	Merge remote-tracking branch 'merge/merge-perfschema-5.6' into 10.0	9 years ago
vicentiu	682d4849ff	Merge remote-tracking branch 'merge/merge-innodb-5.6' into 10.0	9 years ago
Alexey Botchkov	171e59ed47	MDEV-11548 Reproducible server crash after the 2nd ALTER TABLE ADD FOREIGN KEY IF NOT EXISTS. Have to use 'keyname' to check the name uniqueness.	9 years ago

1 2 3 4 5 ...

171862 Commits (13493078e9aea37f6714b3921921aa10864c8b30) All Branches Search

171862 Commits (13493078e9aea37f6714b3921921aa10864c8b30)

All Branches