mariadb

Tree: 1084fa77ab

Author	SHA1	Message	Date
Marko Mäkelä	1084fa77ab	MDEV-21539 Assertion ...prtype... failed in row_log_table_apply_convert_mrec This bug is a cousin of MDEV-18719 and MDEV-20190, which failed to relax a debug assertion in one more code path. row_log_table_apply_convert_mrec(): Use dict_col_t::same_format() and ignore all format-agnostic flags in the assertions.	6 years ago
Andrei Elkin	5cd21ac202	MDEV-20821 parallel slave server shutdown hang Parallel slave server shutdown found to be hanging in close_connections() triggered by shutdown due to a slave worker thread would not be notified to exit in case the worker was sitting idle. Fixed with destroying the worker pool earlier that is in slave_prepare_for_shutdown() when all their driver threads have already left. A test file is added to simulate the bug condition as well as check multi-sourced and not-idle worker cases.	6 years ago
Vladislav Vaintroub	7c0e4748ac	silence a warning in WolfSSL. There is a warning about inconsistency between function definition and prototype. See https://github.com/wolfSSL/wolfssl/issues/2752 Disable specific MSVC warning for now.	6 years ago
Sergei Golubchik	1ecd0e0732	compilation fixes for new wolfssl	6 years ago
Oleksandr Byelkin	3155a643df	new wolfssl v4.3.0-stable	6 years ago
Marko Mäkelä	259185764b	MDEV-17062: Fix a typo in an error message	6 years ago
Jan Lindström	57ec527841	MDEV-17062 : Test failure on galera.MW-336 Add mutex protection while we calculate required slave thread change and create them. Add error handling.	6 years ago
Marko Mäkelä	87a61355e8	Merge 10.3 into 10.4 The MDEV-17062 fix in commit `c4195305b2` was omitted.	6 years ago
Marko Mäkelä	bc43bf3e43	Merge 10.2 into 10.3	6 years ago
Marko Mäkelä	ceffabc421	Enable tests for --embedded	6 years ago
Marko Mäkelä	e47b780286	MDEV-13626: Work around DEBUG_SYNC timeouts	6 years ago
Igor Babaev	7ea413ac2d	MDEV-21446 Assertion `!prebuilt->index->is_primary()' failed in row_search_idx_cond_check with rowid_filter upon concurrent access to table This bug has nothing to do with the concurrent access to table. Rather it concerns queries for which the optimizer decides to employ a rowid filter when accessing an InnoDB table by a secondary index, but later when calling test_if_skip_sort_order() changes its mind to access the table by the primary key. Currently usage of rowid filters is not supported in InnoDB if the table is accessed by the primary key. So in this case usage of a rowid filter to access the table must be prohibited.	6 years ago
Sergei Petrunia	9be5c19c34	Fix another trivial merge error	6 years ago
Sergei Golubchik	74a0cde1c6	mysql_install_db always has to pass --user=$user to the mysqld followup for `9d18b62467` strangely enough it only failed upgrade test on eoan	6 years ago
Igor Babaev	4de32015be	MDEV-21356 ERROR 1032 Can't find record when running simple, single-table query This bug could happen when both optimizer switches 'mrr' and 'mrr_sort_keys' are enabled and the optimizer decided to use a rowid filter when accessing an InnoDB table by a secondary key. With the above setting any access by a secondary is converted to the rndpos access. In InnoDB the rndpos access uses the primary key. Currently usage of a rowid filter within InnoDB engine is not supported if the table is accessed by the primary key. Do not use pushed rowid filter if the table is accessed actually by the primary key. Use the rowid filter outside the egine code instead.	6 years ago
Marko Mäkelä	6373ec3ec7	Merge 10.2 into 10.3	6 years ago
Jan Lindström	057fbfa356	Disable Galera tests failing on bb and Azure until they are fixed.	6 years ago
Sergei Golubchik	51a9571256	MDEV-20205 mysql_install_db shouldn't execute chown Make chown error non-fatal. Just print a warning.	6 years ago
Sergei Golubchik	9d18b62467	rpm/deb and auth_pam_tool_dir/auth_pam_tool don't let mysql_install_db set SUID bit for auth_pam_tool in rpm/deb packages - instead package files with correct permissions and only fix the ownership of auth_pam_tool_dir (which can only be done after mysql user is created, so in post-install). keep old mysql_install_db behavior for bintars	6 years ago
Sergei Petrunia	d595a91bc6	Fix a merge typo	6 years ago
Marko Mäkelä	7b70cbd838	MDEV-21499 Merge new release of InnoDB 5.7.29 to 10.2	6 years ago
Nikša Skeledžija	c25a0662b3	Bug #30499288 - GCC 9.2.1 REPORTS A NEW WARNING FOR OS_FILE_GET_PARENT_DIR - Fixed a warning visible in optimized build related to calling memcpy with length parameters larger than ptrdiff_t max. rb#23333 approved by Annamalai Gurusami <annamalai.gurusami@oracle.com>	6 years ago
Marko Mäkelä	08b0b2b6fb	MDEV-21513: Avoid some crashes in ALTER TABLE...IMPORT TABLESPACE IndexPurge::next(): Replace btr_pcur_move_to_next_user_rec() with some equivalent code that performs sanity checks without killing the server. Perform some additional sanity checks as well. This change is motivated by mysql/mysql-server@48de4d74f4d2f10cd01b129753c7dfa908cf36b5 which unnecessarily introduces storage overhead to btr_pcur_t and uses a test case that injects a fault somewhere else, not in the code path that was modified.	6 years ago
Marko Mäkelä	457ce97ef2	MDEV-21512 InnoDB may hang due to SPATIAL INDEX MySQL 5.7.29 includes the following fix: Bug #30287668 INNODB: A LONG SEMAPHORE WAIT mysql/mysql-server@5cdbb22b51cf2b35dbdf5666a251ffbec2f84dec There is no test case. It seems that the problem could occur when a spatial index is large and peculiar enough so that multiple R-tree leaf pages will have the exactly same maximum bounding rectangle (MBR). The commit message suggests that the hang can occur when R-tree non-leaf pages are being merged, which should only be possible during transaction rollback or the purge of transaction history, when the R-tree index is at least 2 levels high and very many records are being deleted. The message says that a comparison result that two spatial index node pointer records are equal will cause an infinite loop in rtr_page_copy_rec_list_end_no_locks(). Hence, we must include the child page number in the comparison to be consistent with mysql/mysql-server@2e11fe0e152e34d73579e1a9ec19aedc3f6010f6. We fix this bug in a simpler way, involving fewer code changes. cmp_rec_rec(): Renamed from cmp_rec_rec_with_match(). Assert that rec2 always resides in an index page. Treat non-leaf spatial index pages specially.	6 years ago
Marko Mäkelä	c3695b4058	MDEV-21511: Remove unnecessary code Now that we will be invoking dtuple_get_n_ext() instead of letting btr_push_update_extern_fields() update an already calculated value, it is unnecessary to calculate the n_ext upfront. row_rec_to_index_entry(), row_rec_to_index_entry_low(): Remove the output parameter n_ext.	6 years ago
Marko Mäkelä	5838b52743	MDEV-21511 Wrong estimate of affected BLOB columns in update During update, rollback, or MVCC read, we may miscalculate the number of off-page columns, and thus the size of the clustered index record. The function btr_push_update_extern_fields() is mostly redundant, because the off-page columns would also be moved by row_upd_index_replace_new_col_val(), which is invoked via row_upd_index_replace_new_col_vals(). btr_push_update_extern_fields(): Remove. This is based on mysql/mysql-server@1fa475b85d24de4b9ce2958c0eed738c221fc82c which refines a fix for a recovery bug fix mysql/mysql-server@ce0a1e85e24e48b8171f767b44330da635a6ea0a in MySQL 5.7.5. No test case was provided by Oracle. Some of the changed code is being covered by the existing test innodb.blob-crash.	6 years ago
Marko Mäkelä	3e38d15585	MDEV-21509 Possible hang during purge of history, or rollback WL#6326 in MariaDB 10.2.2 introduced a potential hang on purge or rollback when an index tree is being shrunk by multiple levels. This fix is based on mysql/mysql-server@f2c58526300c0d84837effa26d37cbd5d2694967 with the main difference that our version of the test case uses DEBUG_SYNC instrumentation on ROLLBACK, not on purge. btr_cur_will_modify_tree(): Simplify the check further. This is the actual bug fix. row_undo_mod_remove_clust_low(), row_undo_mod_clust(): Add DEBUG_SYNC instrumentation for the test case.	6 years ago
Marko Mäkelä	9cae7bdcc0	MDEV-13626: Add the WL#6326 tests	6 years ago
Jan Lindström	c4195305b2	MDEV-17062 : Test failure on galera.MW-336 Add mutex protection while we calculate required slave thread change and create them. Add error handling.	6 years ago
Jan Lindström	7e378a8d31	Test requires debug build from galera library.	6 years ago
Sergei Petrunia	e709eb9bf7	Merge branch '10.2' into 10.3 # Conflicts: # mysql-test/suite/galera/r/MW-388.result # mysql-test/suite/galera/t/MW-388.test # mysql-test/suite/innodb/r/truncate_inject.result # mysql-test/suite/innodb/t/truncate_inject.test # mysql-test/suite/rpl/r/rpl_stop_slave.result # mysql-test/suite/rpl/t/rpl_stop_slave.test # sql/sp_head.cc # sql/sp_head.h # sql/sql_lex.cc # sql/sql_yacc.yy # storage/xtradb/buf/buf0dblwr.cc	6 years ago
Sergei Petrunia	b04429434a	Merge branch '10.1' into 10.2 # Conflicts: # sql/sp_head.cc # sql/sql_select.cc # sql/sql_trigger.cc	6 years ago
Jan Lindström	bb8226deab	MDEV-21492 : Galera test sporadic failure on galera.galera_events2 Add wait condition for event creation.	6 years ago
Marko Mäkelä	bde7e0ba6e	MDEV-21500 Server hang when using simulated AIO The write-heavy test innodb_zip.wl6501_scale_1 timed out on 10.2 `60d7011c5f` for me. Out of os_aio_n_segments=6, 5 are waiting for an event in os_aio_simulated_handler(). One thread is waiting for a write to complete in buf_dblwr_add_to_batch(), but that would never happen, because nothing is waking up the simulated AIO handler threads. This hang appears to have been introduced in MySQL 5.6.12 in mysql/mysql-server@26cfde776cdf5ce61bd5cc494dfc1df28c76977f.	6 years ago
Alice Sherepa	0f0c284ec0	fix for rpl_slave_load_remove_tmpfile.test	6 years ago
Gagan Goel	f0ca9bc669	MDEV-20732 Correctly set the length of the FORMAT() result for float data type as argument.	6 years ago
Jan Lindström	a382f69e24	MDEV-21498 : wsrep.binlog_format test failed on Azure Waiting wsrep_ready is possible only if wsrep_on=ON.	6 years ago
Igor Babaev	1c97cd339e	MDEV-21184 Assertion `used_tables_cache == 0' failed in Item_func::fix_fields with condition_pushdown_from_having This bug could manifest itself for queries with GROUP BY and HAVING clauses when the HAVING clause was a conjunctive condition that depended exclusively on grouping fields and at least one conjunct contained an equality of the form fld=sq where fld is a grouping field and sq is a constant subquery. In this case the optimizer tries to perform a pushdown of the HAVING condition into WHERE. To construct the pushable condition the optimizer first transforms all multiple equalities in HAVING into simple equalities. This has to be done for a proper processing of the pushed conditions in WHERE. The multiple equalities at all AND/OR levels must be converted to simple equalities because any multiple equality may refer to a multiple equality at the upper level. Before this patch the conversion was performed like this: multiple_equality(x,f1,...,fn) => x=f1 and ... and x=fn. When an equality item for x=fi was constructed both the items for x and fi were cloned. If x happened to be a constant subquery that could not be cloned the conversion failed. If the conversions of multiple equalities previously performed had succeeded then the whole condition became in an inconsistent state that could cause different failures. The solution provided by the patch is: 1. to use a different conversion rule if x is a constant multiple_equality(x,f1,...,fn) => f1=x and f2=f1 and ... and fn=f1 2. not to clone x if it's a constant. Such conversions cannot fail and besides the result of the conversion preserves the equivalence of f1,...,fn that can be used for other optimizations. This patch also made sure that expensive predicates are not pushed from HAVING to WHERE.	6 years ago
Alice Sherepa	60d7011c5f	MDEV-21360 global debug_dbug pre-test value restoration issues	6 years ago
Alice Sherepa	b7fb30e930	MDEV-21360 global debug_dbug pre-test value restoration issues	6 years ago
Alice Sherepa	451573fab1	MDEV-21360 debug_dbug pre-test value restoration issues	6 years ago
Marko Mäkelä	6a8a4c19e2	MDEV-21485 ASAN use-after-poison in dfield_get_len or Assertion `pos < index->n_def' failed The server would crash when instantly reordering the columns of a table whose all columns belong to the PRIMARY KEY.	6 years ago
Sergei Petrunia	23041af720	MDEV-21341: Fix UBSAN failures, part 8: fix error in compare_fields_by_table_order Dont assign Item_field variables to point to Item_string objects (even if we don't make any dangerous calls for them).	6 years ago
Sergei Petrunia	4635047ca1	MDEV-21341: Fix UBSAN failures, part #5 Item_cond inherits from Item_args but doesn't store its arguments as function arguments, which means it has zero arguments. Don't call memcpy in this case.	6 years ago
Jan Lindström	800d1f3010	Disable usually failing Galera tests until a real fix is found.	6 years ago
Sergei Petrunia	5e5ae51b73	MDEV-21341: Fix UBSAN failures: Issue Six (Variant #2 of the patch, which keeps the sp_head object inside the MEM_ROOT that sp_head object owns) (10.3 requires extra work due to sp_package, will commit a separate patch for it) sp_head::operator new() and operator delete() were dereferencing sp_head* pointers to memory that didn't hold a valid sp_head object (it was not created/already destroyed). This caused UBSan to crash when looking up type information. Fixed by providing static sp_head::create() and sp_head::destroy() methods.	6 years ago
Daniele Sciascia	7d31321464	MDEV-19803 Long semaphore wait error on galera.MW-388 The long semaphore wait appeared to be the caused by the following pattern in the MTR test: ``` SET DEBUG_SYNC = "now SIGNAL wsrep_after_certification_continue"; SET DEBUG_SYNC = "now SIGNAL signal.wsrep_apply_cb; ``` Raising two signals, one right after another, caused one signal to overwrite the other, before the signal was consumed by the thread. This caused one thread to be stuck until the debug sync point would timeout.	6 years ago
Daniele Sciascia	2d4b6571ec	Wsrep position not updated in InnoDB after certification failures (#1432 ) A certification failure followed by a clean shutdown would cause an inconsistency between the sequence number stored in innodb and the sequence number stored in provider. This happened both in the case of local certification failure, and in the case where dummy writeset is applied. The fix consists of: - updating wsrep position after dummy writeset is delivered in `Wsrep_high_priority_service::log_dummy_write_set()` - updating wsrep position while releasing commit order in wsrep-lib side Added two tests which stress the situation where a server is shutdown after a certification failure.	6 years ago
Sergei Petrunia	d531b4ee3a	MDEV-21341: Fix UBSAN failures: Issue Six (Variant #2 of the patch, which keeps the sp_head object inside the MEM_ROOT that sp_head object owns) (10.3 version of the fix, with handling for class sp_package) sp_head::operator new() and operator delete() were dereferencing sp_head* pointers to memory that didn't hold a valid sp_head object (it was not created/already destroyed). This caused UBSan to crash when looking up type information. Fixed by providing static sp_head::create() and sp_head::destroy() methods.	6 years ago
Sergei Petrunia	9c3eca8514	MDEV-21243: Join buffer: condition is checked in wrong place for range access In this scenario: - There is a possible range access for table T - And there is a ref access on the same index which uses fewer key parts - The join optimizer picks the ref access (because it is cheaper) - make_join_select applies this heuristic to switch to range: /* Range uses longer key; Use this instead of ref on key */ Join buffer will be used without having called JOIN_TAB::make_scan_filter(). This means, conditions that should be checked when reading table T will be checked after T is joined with the contents of the join buffer, instead. Fixed this by adding a make_scan_filter() check. (updated patch after backport to 10.3) (Fix testcase on Windows)	6 years ago

1 2 3 4 5 ...

187742 Commits (1084fa77abad9a24caa1eddb5dfbda89c0bc0576) All Branches Search

187742 Commits (1084fa77abad9a24caa1eddb5dfbda89c0bc0576)

All Branches