mariadb

Tree: 0f4a35a327

Author	SHA1	Message	Date
Dave Gosselin	923094b4cd	MDEV-36094 Row ID filtering for reverse-ordered scans The fix for MDEV-34413 added support for Index Condition Pushdown with reverse ordered scans. This makes Rowid filtering work with reverse-ordered scans, too, so enable it. For example, InnoDB can now check the pushed index condition and then check the rowid filter on success, in the ORDER BY ... DESC case.	9 months ago
Dave Gosselin	24b5c3021d	MDEV-36094 Row ID filtering for reverse-ordered scans Add tests showing that RowID filtering is not enabled for reverse-ordered scans.	9 months ago
Christian Hesse	02893e875b	MDEV-35969 wsrep: set new status for service manager On WSREP state transfer the status in service manager changes to: WSREP state transfer (role ...) ongoing... This status was not changed after state transfer was complete. Let's change it again to reflect now situation: WSREP state transfer (role ...) comleted. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	9 months ago
Christian Hesse	0b8762822e	MDEV-35969 wsrep: add more details in service manager status Let's show the difference between donor and joiner. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	9 months ago
Yuchen Pei	b50df7bbd4	MDEV-36220 Correct length in memcpy saving and restoring found NULL record in loose index scan of min Use reclength because rec_buff_length is the actual reclength with padding, whose use could cause ASAN unknown-crash, presumably caused by memory violation.	8 months ago
Dave Gosselin	7e4233746e	MDEV-34413 Index Condition Pushdown for reverse ordered scans Allows index condition pushdown for reverse ordered scans, a previously disabled feature due to poor performance. This patch adds a new API to the handler class called set_end_range which allows callers to tell the handler what the end of the index range will be when scanning. Combined with a pushed index condition, the handler can scan the index efficiently and not read beyond the end of the given range. When checking if the pushed index condition matches, the handler will also check if scanning has reached the end of the provided range and stop if so. If we instead only enabled ICP for reverse ordered scans without also calling this new API, then the handler would perform unnecessary index condition checks. In fact this would continue until the end of the index is reached. These changes are agnostic of storage engine. That is, any storage engine that supports index condition pushdown will inhereit this new behavior as it is implemented in the SQL and storage engine API layers. The partitioned tables storage meta-engine (ha_partition) adds an override of set_end_range which recursively calls set_end_range on its child storage engine (handler) implementations. This commit updates the test made in an earlier commit to show that ICP matches happen for the reverse ordered case. This patch is based on changes written by Olav Sandstaa in MySQL commit `da1d92fd46`	9 months ago
Dave Gosselin	261d5520a2	MDEV-34413 Index Condition Pushdown for reverse-ordered scans Adds tests which show that ICP was not enabled for reverse-ordered scans prior to this mdev. A later commit for this same mdev records again these same tests, showing that ICP for reverse-ordered scans is enabled and working.	9 months ago
Alexander Barkov	2ae721f2ad	MDEV-36179 Assertion `0' failed in virtual bool Type_handler_row::Item_save_in_value(THD, Item, st_value*) const sp_head::execute_procedure() and sp_head::execute_function() did not check that Item_param could be passed as an actual parameter to a ROW type formal parameter of a stored routine. Example: CREATE PROCEDURE p0(OUT a ROW(a INT,b INT)) ...; PREPARE s0 'CALL p0(?)'; EXECUTE p0 USING @a; In case of passing a user variable as an OUT parameter it led to a crash after executing routine instructions, when copying formal OUT parameters to the bound actual parameters. Fix: Check cases when Item_param is being bound to a ROW type formal parameter. Raise an error if so. The new check is done for all parameter modes: IN, OUT, INOUT, for a consistent error message. The new check is done before executing the routine instructions.	8 months ago
ParadoxV5	15848a75a7	MDEV-36238 Functional Tests for --master-info-file and --show-slave-auth-info Add MTR tests in the `multi_source` suite to validate future changes that they does not affect the function of these two `mariadbd` options ``` master_info_file rpl_show_slave_auth_info ``` Reviewed-by: Susil Kumar Behera <susil.behera@mariadb.com>	8 months ago
Sergey Vojtovich	c3f21762e9	Corrections to parent "speedup collation" commit Rather than populating collation_name_hash in a separate loop, call my_hash_insert() from appropriate methods.	8 months ago
Jitesh Chawla	543ebbcf8e	MDEV-35876 - speedup collation/charset lookup Replaces O(n) linear scans for collation lookups with O(1) hash lookups to eliminate performance bottlenecks as collation counts grow.	8 months ago
Marko Mäkelä	1756b0f37d	MDEV-35813: more robust test case Let us integrate the test case with innodb.page_cleaner so that there will be less interference from log writes due to checkpoints. Also, make the test compatible with ./mtr --cursor-protocol.	8 months ago
Marko Mäkelä	0e8e0065d6	MDEV-35813 test case	8 months ago
Dmitry Shulga	408a637b87	MDEV-29344: engines/iuds.insert_time cannot run with PS protocol (syntax error) The syntax error produced on running the test engines/iuds.insert_time in PS-mode was caused by presence of the C-Style comment containing the single quote at the end of SQL statement, something like the following one: /* doesn't throw error /; Presence of the single quote was interpreted by mysqltest utility as indication of real string literal, that resulted in consuming every characters following that mark as a literal, including the delimiter character ';'. It led to concatenation of lines into a single multi-statement that was sent from mysqltest to MariaDB server for processing. In case mysqltest is run in regular mode (that is, not PS-mode), multi-statement is handled successfully on server side, but in case PS-mode is on, multi-statement is supplied in COM_STMT_PREPARE that caused the parsing error since multi-statements is not supported by statement prepare command. To fix the issue, in case mysqltest encounters the C-Style comment is should switch to reading next following characters without any processing until it hit the closing C-style comment marks '/', with one exception if the sequence of characters '/*' followed by the exclamation mark, that means the hint introducer has been read.	8 months ago
mariadb-DebarunBanerjee	a8e35a1cc6	MDEV-36149 UBSAN in X is outside the range of representable values of type 'unsigned long' \| page_cleaner_flush_pages_recommendation Currently it is allowed to set innodb_io_capacity to very large value up to unsigned 8 byte maximum value 18446744073709551615. While calculating the number of pages to flush, we could sometime go beyond innodb_io_capacity. Specifically, MDEV-24369 has introduced a logic for aggressive flushing when dirty page percentage in buffer pool exceeds innodb_max_dirty_pages_pct. So, when innodb_io_capacity is set to very large value and dirty page percentage exceeds the threshold, there is a multiplication overflow in Innodb page cleaner. Fix: We should prevent setting io_capacity to unrealistic values and define a practical limit to it. The patch introduces limits for innodb_io_capacity_max and innodb_io_capacity to the maximum of 4 byte unsigned integer i.e. 4294967295 (2^32-1). For 16k page size this limit translates to 64 TiB/sec write IO speed which looks sufficient. Reviewed by: Marko Mäkelä	8 months ago
Sam Bull	839828e57f	MDEV-36009: Systemd: Restart on OOM Per https://github.com/systemd/systemd/issues/36529 OOM counts as a on-abnormal condition. To ensure that MariaDB testart on OOM the Restart is changes to on-abnormal which an extension on the current on-abort condition.	1 year ago
Kristian Nielsen	d931bb8174	MDEV-36287: Server crash in SHOW SLAVE STATUS concurrent with STOP SLAVE In SHOW SLAVE STATUS, do not access members of the SQL thread's THD without holding mi->run_lock. Otherwise the THD can go away in case of concurrent STOP SLAVE, leading to invalid memory references and server crash. Reviewed-by: Monty <monty@mariadb.org> Reviewed-by: Brandon Nesterenko <brandon.nesterenko@mariadb.com> Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	8 months ago
Kristian Nielsen	acaf07daed	Add --source include/long_test.inc to some tests This will make mysql-test-run.pl try to schedule these long-running (> 60 seconds) tests early in --parallel runs, which helps avoid that the testsuite gets stuck with a few long-running tests at the end while most other test workers are idle. This speed up mtr --parallel=96 with 25 seconds for me. Reviewed-by: Brandon Nesterenko <brandon.nesterenko@mariadb.com> Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	8 months ago
Kristian Nielsen	b6b6bb8d36	Fix sporadic failures of rpl.rpl_gtid_crash - Suppress a couple errors the slave can get as the master crashes. - The mysql-test-run occasionally takes 120 seconds between crashing the master and starting it back up for some (unknown) reason. For now, work-around that by letting the slave try for 500 seconds to connect to master before giving up instead of only 100 seconds. Reviewed-by: Brandon Nesterenko <brandon.nesterenko@mariadb.com> Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	8 months ago
Marko Mäkelä	c3c5cd9377	MDEV-35813 Unnecessary InnoDB log writes in INSERT…SELECT ha_innobase::extra(): Conditionally avoid a log write that had been added in commit `e5b9dc1536` (MDEV-25910) because it may be invoked as part of select_insert::prepare_eof() and not only during DDL operations. Reviewed by: Sergei Golubchik	8 months ago
Sergey Vojtovich	feb1cf9086	Corrections to parent "fix typos" commmit	8 months ago
Vasilii Lakhin	717c12de0e	Fix typos in C comments inside sql/	8 months ago
Brandon Nesterenko	01cf1cb84b	MDEV-7850: Optimize Query_log_event::begin_event() * Use bfill() to pad a Query_log_event (from GTID event) instead of a loop. * Add error conditions Co-author: Monty <monty@mariadb.org>	11 months ago
Kristian Nielsen	04e114aec0	Fix sporadic failure of rpl.parallel_backup_xa_debug The test case set debug_sync=RESET without waiting for the server thread to receive the prior signal. This can cause the signal to be lost, the thread to not wake up, and thus the test to time out. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	8 months ago
Kristian Nielsen	6810cdae1b	Add --source include/long_test.inc to a few long-running tests Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	8 months ago
Marko Mäkelä	38e420ba6e	Merge 10.11 into 11.4	8 months ago
Kristian Nielsen	2641409731	Fix redundant ER_PRIOR_COMMIT_FAILED in parallel replication wait_for_prior_commit() can be called multiple times per event group, only do my_error() the first time the call fails. Remove redundant set_overwrite_status() calls. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org> Reviewed-by: Monty <monty@mariadb.org>	8 months ago
Yuchen Pei	55efe47d3c	MDEV-36118 Fix wrong result with MAX in loose index scan Loose index scan currently only supports ASC key. When searching for the next MAX value, the search starts from the rightmost range and moves towards the left. If the key has "moved" as the result of a successful ha_index_read_map() call when handling a previous range, we check if the key is to the left of the current range, and if so, we can skip to the next range. The existing check on whether the loop has iterated at least once is not sufficient, as an unsuccessful ha_index_read_map() often (always?) does not "move" the key.	8 months ago
Marko Mäkelä	652f33e0a4	MDEV-30000: Force an InnoDB checkpoint in mariadb-backup At the start of mariadb-backup --backup, trigger a flush of the InnoDB buffer pool, so that as little log as possible will have to be copied. The previously debug-build-only interface SET GLOBAL innodb_log_checkpoint_now=ON; will be made available on all builds, and mariadb-backup --backup will invoke it, unless the option --skip-innodb-log-checkpoint-now is specified. Reviewed by: Vladislav Vaintroub	8 months ago
Thirunarayanan Balathandayuthapani	5b686cc8f9	MDEV-36253 Redundant check in wf_incremental_process() - Remove the redundant check of TRX_SYS page change in wf_incremental_process() - Remove the double casting of srv_undo_tablespaces in write_backup_config_file() - Remove the unused variables like checkpoint_lsn_start and checkpoint_no_start. This is a regression which caused by commit `1c55b845e0`.	8 months ago
Monty	eef94c9d46	MDEV-36248 Connect crashes server because of duplicate 'free()' in GetUser If connect engineis not able to allocate connect_work_space memory for GetUser() it will call free() twice with the same value (g). g was freed first in user_connect::user_init() which calls PlugExit() on errors and then again in ~user_connect() which also calls PlugExit(). Fixed by setting g to 0 in user_init() after calling PlugExit() This code was tested 'by hand' by setting connect.work_space=600G Other things: - Removed some very old not relevant comments in touched code - Added comments to clarify how some memory was freed - Fixed indentation in changed functions.	8 months ago
Monty	64a1458847	Ensure that ER_CONNECTION_KILLED error message is not lost my_real_read() detects if the connection was killed and sets error to ER_CONNECTION_KILLED. However net_real_write() overrides the error with ER_NET_READ_INTERRUPTED or ER_NET_READ_ERROR when it tries to send the 'Connection was killed' to the user on a closed connection. Fixed by not overwriting the original error code if the connection was shutdown. Rewiewed-by: Kristian Nielsen <knielsen@knielsen-hq.org>	8 months ago
Monty	b12e8d9095	MENT-2235 Aria engine: log initialization failed Some thing causes the aria_log_control file to be larger than the expected 52 bytes. The control file has the correct information but somehow it is filled up with ox00 bytes up to 512 bytes. This could have happened in case of a file system crash that enlarged the file to the sector boundary. Fixed that aria will ignore bytes outside of it's expected Other things: - Fixed wrong DBUG_ASSERT() in my_malloc_size_cb_func() that could cause crashes in debug binaries during Aria recovery.	8 months ago
Monty	1331c73243	Moved server_threads.erase(thd) to end of handle_slave_sql() The effect is that 'show processlist' will show the Slave SQL thread until the thread ends. This may help finding cases where the Slave SQL thread could hang for some time during the cleanup part. The Slave SQL thread will have the state "Slave SQL thread ending' during this stage. Reviewed-by: Kristian Nielsen <knielsen@knielsen-hq.org>	8 months ago
KhaledR57	e1277845a4	MDEV-36206: Fix mysqld deprecation warning When running mariabackup with --prepare --export options, a deprecation warning appears because the program name is set to "mysqld" instead of "mariadbd" The fix ensures that when running in mysqld mode, we properly set the program name to "mariadbd" to avoid the deprecation warning while maintaining the original functionality	8 months ago
Marko Mäkelä	0331f1fff7	MDEV-36227 Race condition between ALTER TABLE…EXCHANGE PARTITION and SELECT In commit `6e6a1b316c` (MDEV-35000) a race condition was exposed. ha_innobase::check_if_incompatible_data(): If the statistics have already been initialized for the table, skip the invocation of innobase_copy_frm_flags_from_create_info() in order to avoid unexpectedly ruining things for other threads that are concurrently accessing the table. dict_stats_save(): Add debug instrumentation that is necessary for reproducing the interlocking of the failure scenario.	8 months ago
Oleksandr Byelkin	5217d8609b	MDEV-9101 forgotten symbolic error representation	8 months ago
Monty	cc4d9200c4	MDEV-33813 ERROR 1021 (HY000): Disk full (./org/test1.MAI); waiting for someone to free some space... (errno: 28 "No space left on device") The problem with MariaDB waiting was fixed earlier. However the server still gives the old error,in case of disk full, that includes "waiting for someone to free some space" even if there is now wait. This commit changes the error message for the non waiting case to: Disk got full writing 'db.table' (Errcode: 28 "No space left on device") Disk got full writing 'test.t1' (Errcode: 28 "No space left on device")Disk got full writing 'test.t1' (Errcode: 28 "No space left on device")Disk got full writing 'test.t1' (Errcode: 28 "No space left on device")	8 months ago
Marko Mäkelä	153778437d	Merge 11.8 into main	8 months ago
Marko Mäkelä	bb9f010432	Merge 11.4 into 11.8	8 months ago
Hossam Hassan	689bed1940	MDEV-23818 mysql option --script-dir This commit introduces an additional command line option to the mariadb client. --script-dir=<directory> will cause the `source` command to look for files initially in CWD, then in <script-dir> if not found in CWD.	9 months ago
Akshat Nehra	868bc463c0	MDEV-4151 Mixed MySQL/MariaDB references in RPM upgrade error message Update pre-install script to fix package detection and standardize MariaDB/MySQL terminology in messages for improved upgrade reliability and reduced user confusion. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.	10 months ago
Marko Mäkelä	2183f302c8	MDEV-33489 atomic.alter_table is too slow with SSL The test is killing and restarting the server very many times. This may lead to timeouts on architectures or builds that lack an SIMD based encryption implementation, such as IBM System Z (s390x) or cmake -DWITH_MSAN=ON builds.	8 months ago
Julius Goryavsky	15139c88a8	Merge branch '10.5' into '10.6'	8 months ago
Julius Goryavsky	3a4c0295ae	galera: synchronization between branches and editions	8 months ago
Oleksandr Byelkin	7544fd4cae	fix problem of reallocated string	9 months ago
Vladislav Vaintroub	3a81664cb8	Review fixes - explain why "long" is deprecated, point out to Wikipedia 64bit data models article. - fix typo	8 months ago
Vladislav Vaintroub	1fecf581ac	Rewrite the 'Types' chapter in coding standards. Problem - current coding standards explicitly discourages use of int, char, short etc, and recommends fixed types instead. This is overly pedantic. The real problem, and the only problem we have with types concerning portability, the inappropriate use of `long` is too easy to overlook. Thus,un-deprecate the types that are portable, for all practical purpose i.e int, short, long long. Warning that char might be unsigned, though, all compilers have appropriate flags. Yet, use strongly wording to deprecate long and ulong, those are the types that create real portability problems.	8 months ago
Marko Mäkelä	49a6baec56	Merge 10.11 into 11.4	8 months ago
Julius Goryavsky	3deac2ea77	galera_inject_bf_log_wait mtr test: more stable test Added explicit checkpoint wait instead of implicit assumption that statement sent via --send will already be executed when lock-contesting statement is started in another session.	8 months ago

... 3 4 5 6 7 ...

203083 Commits (0f4a35a3270d11c834a36e9def62e9a4f0128e76) All Branches Search

203083 Commits (0f4a35a3270d11c834a36e9def62e9a4f0128e76)

All Branches