mariadb

Commit Graph

Author	SHA1	Message	Date
Julius Goryavsky	c61345169a	galera tests: synchronization after merge	7 months ago
Vladislav Vaintroub	da20e4d8a5	Fix PCRE2 10.45 build on Windows as an external project PCRE2 10.45 sets cmake_minimum_required to version 3.15. With that, on MSVC, compile flags for choosing C runtime (/MT, /MD, etc.) are ignored. Instead, CMAKE_MSVC_RUNTIME_LIBRARY must be passed when building an external project for consistent linkage, if it creates a static library.	7 months ago
Sergei Golubchik	bc13c8e4ae	MDEV-36078 PCRE2 10.45 breaks main.func_regexp_pcre due to change in PCRE 10.45 is correct, update test results to match. allow builds with <10.45 too (for old distros) but remove the buggy test	7 months ago
Sergei Golubchik	04771ff6b1	MDEV-28209 New mysql_upgrade message on minor-only upgrades is confusing	7 months ago
Sergei Golubchik	bca07a6f88	cleanup: mysql_upgrade.test make it strict, don't just ignore all the pesky numbers it shows, replace the current mariadb version with X.Y.Z, replace first two components of the current version with X.Y replace the first component (or first-1, if the second is 0) with X fix perl to write mysql_upgrade_info files in binary mode, otherwise mariadb-upgrade reads them incorrectly on Windows.	7 months ago
Sergei Golubchik	1cc138958e	MDEV-35727 main.mysql-interactive fails in buildbot on debian fix failing main.mysql-interactive * increase socat EOF timeout from 0.5s to 10s * add an explicit exit to not wait 10s (or even 0.5s - the test now finishes in 0.15s) * enable it for libedit	8 months ago
Sergei Golubchik	6aa860be27	MDEV-36268 mariadb-dump used wrong quoting character use ' not " and use quote_for_equal()	8 months ago
Sergei Golubchik	992d85025c	cmake CMP0177 policy, no dot in the install destination path	8 months ago
Marko Mäkelä	027d815546	MDEV-29445 fixup: Make Valgrind fair again recv_sys_t::wait_for_pool(): Also wait for pending writes, so that previously written blocks can be evicted and reused. buf_flush_sync_for_checkpoint(): Wait for pending writes, in order to guarantee progress even if the scheduler is unfair.	7 months ago
Dmitry Shulga	6e4fa7e5a1	MDEV-36390: Minor refactoring of the method get_expr_query at the classes sp_instr_cpush/sp_instr_cursor_copy_struct Duplicated code from methods sp_instr_cpush::get_expr_query sp_instr_cursor_copy_struct::get_expr_query were extracted to the standalone function get_cursor_query Additionally, added correct parsing of a cursor definition with a new line or TAB instead of the space immediately after FOR/IS.	7 months ago
Marko Mäkelä	9a6540cb84	MDEV-29445 fixup: galera_sst_mariabackup_use_memory The mariadb-backup --use-memory parameter will be trimmed to a multiple of 8 MiB, or 2 MiB on 32-bit systems. Also, let us remove a bogus message in mariadb-backup: Warning: option 'use-memory': signed value -1 adjusted to 8388608	7 months ago
Marko Mäkelä	d68f5ea9f0	MDEV-35000 fixup: galera.MDEV-33136 TRUNCATE TABLE will no longer cause a reload of InnoDB statistics. RENAME TABLE will.	7 months ago
Marko Mäkelä	ab0f2a00b6	Merge 10.6 into 10.11	7 months ago
Marko Mäkelä	191209d8ab	Merge 10.5 into 10.6	7 months ago
Marko Mäkelä	ba81009f63	MDEV-34863 RAM Usage Changed Significantly Between 10.11 Releases innodb_buffer_pool_size_auto_min: A minimum innodb_buffer_pool_size that a Linux memory pressure event can lead to shrinking the buffer pool to. On a memory pressure event, we will attempt to shrink innodb_buffer_pool_size halfway between its current value and innodb_buffer_pool_size_auto_min. If innodb_buffer_pool_size_auto_min is specified as 0 or not specified on startup, its default value will be adjusted to innodb_buffer_pool_size_max, that is, memory pressure events will be disregarded by default. buf_pool_t::garbage_collect(): For up to 15 seconds, attempt to shrink the buffer pool in response to a memory pressure event. Reviewed by: Debarun Banerjee	7 months ago
Marko Mäkelä	b6923420f3	MDEV-29445: Reimplement SET GLOBAL innodb_buffer_pool_size We deprecate and ignore the parameter innodb_buffer_pool_chunk_size and let the buffer pool size to be changed in arbitrary 1-megabyte increments. innodb_buffer_pool_size_max: A new read-only startup parameter that specifies the maximum innodb_buffer_pool_size. If 0 or unspecified, it will default to the specified innodb_buffer_pool_size rounded up to the allocation unit (2 MiB or 8 MiB). The maximum value is 4GiB-2MiB on 32-bit systems and 16EiB-8MiB on 64-bit systems. This maximum is very likely to be limited further by the operating system. The status variable Innodb_buffer_pool_resize_status will reflect the status of shrinking the buffer pool. When no shrinking is in progress, the string will be empty. Unlike before, the execution of SET GLOBAL innodb_buffer_pool_size will block until the requested buffer pool size change has been implemented, or the execution is interrupted by a KILL statement a client disconnect, or server shutdown. If the buf_flush_page_cleaner() thread notices that we are running out of memory, the operation may fail with ER_WRONG_USAGE. SET GLOBAL innodb_buffer_pool_size will be refused if the server was started with --large-pages (even if no HugeTLB pages were successfully allocated). This functionality is somewhat exercised by the test main.large_pages, which now runs also on Microsoft Windows. On Linux, explicit HugeTLB mappings are apparently excluded from the reported Redident Set Size (RSS), and apparently unshrinkable between mmap(2) and munmap(2). The buffer pool will be mapped to a contiguous virtual memory area that will be aligned and partitioned into extents of 8 MiB on 64-bit systems and 2 MiB on 32-bit systems. Within an extent, the first few innodb_page_size blocks contain buf_block_t objects that will cover the page frames in the rest of the extent. The number of such frames is precomputed in the array first_page_in_extent[] for each innodb_page_size. In this way, there is a trivial mapping between page frames and block descriptors and we do not need any lookup tables like buf_pool.zip_hash or buf_pool_t::chunk_t::map. We will always allocate the same number of block descriptors for an extent, even if we do not need all the buf_block_t in the last extent in case the innodb_buffer_pool_size is not an integer multiple of the of extents size. The minimum innodb_buffer_pool_size is 256*5/4 pages. At the default innodb_page_size=16k this corresponds to 5 MiB. However, now that the innodb_buffer_pool_size includes the memory allocated for the block descriptors, the minimum would be innodb_buffer_pool_size=6m. my_large_virtual_alloc(): A new function, similar to my_large_malloc(). my_virtual_mem_reserve(), my_virtual_mem_commit(), my_virtual_mem_decommit(), my_virtual_mem_release(): New interface mostly by Vladislav Vaintroub, to separately reserve and release virtual address space, as well as to commit and decommit memory within it. After my_virtual_mem_decommit(), the virtual memory range will be read-only or unaccessible, depending on whether the build option cmake -DHAVE_UNACCESSIBLE_AFTER_MEM_DECOMMIT=1 has been specified. This option is hard-coded on Microsoft Windows, where VirtualMemory(MEM_DECOMMIT) will make the memory unaccessible. On IBM AIX, Linux, Illumos and possibly Apple macOS, the virtual memory will be zeroed out immediately. On other POSIX-like systems, madvise(MADV_FREE) will be used if available, to give the operating system kernel a permission to zero out the virtual memory range. We prefer immediate freeing so that the reported resident set size (RSS) of the process will reflect the current innodb_buffer_pool_size. Shrinking the buffer pool is a rarely executed resource intensive operation, and the immediate configuration of the MMU mappings should not incur significant additional penalty. opt_super_large_pages: Declare only on Solaris. Actually, this is specific to the SPARC implementation of Solaris, but because we lack access to a Solaris development environment, we will not revise this for other MMU and ISA. buf_pool_t::chunk_t::create(): Remove. buf_pool_t::create(): Initialize all n_blocks of the buf_pool.free list. buf_pool_t::allocate(): Renamed from buf_LRU_get_free_only(). buf_pool_t::LRU_warned: Changed to Atomic_relaxed<bool>, only to be modified by the buf_flush_page_cleaner() thread. buf_pool_t::shrink(): Attempt to shrink the buffer pool. There are 3 possible outcomes: SHRINK_DONE (success), SHRINK_IN_PROGRESS (the caller may keep trying), and SHRINK_ABORT (we seem to be running out of buffer pool). While traversing buf_pool.LRU, release the contended buf_pool.mutex once in every 32 iterations in order to reduce starvation. Use lru_scan_itr for efficient traversal, similar to buf_LRU_free_from_common_LRU_list(). buf_pool_t::shrunk(): Update the reduced size of the buffer pool in a way that is compatible with buf_pool_t::page_guess(), and invoke my_virtual_mem_decommit(). buf_pool_t::resize(): Before invoking shrink(), run one batch of buf_flush_page_cleaner() in order to prevent LRU_warn(). Abort if shrink() recommends it, or no blocks were withdrawn in the past 15 seconds, or the execution of the statement SET GLOBAL innodb_buffer_pool_size was interrupted. buf_pool_t::first_to_withdraw: The first block descriptor that is out of the bounds of the shrunk buffer pool. buf_pool_t::withdrawn: The list of withdrawn blocks. If buf_pool_t::resize() is aborted before shrink() completes, we must be able to resurrect the withdrawn blocks in the free list. buf_pool_t::contains_zip(): Added a parameter for the number of least significant pointer bits to disregard, so that we can find any pointers to within a block that is supposed to be free. buf_pool_t::is_shrinking(): Return the total number or blocks that were withdrawn or are to be withdrawn. buf_pool_t::to_withdraw(): Return the number of blocks that will need to be withdrawn. buf_pool_t::usable_size(): Number of usable pages, considering possible in-progress attempt at shrinking the buffer pool. buf_pool_t::page_guess(): Try to buffer-fix a guessed block pointer. If HAVE_UNACCESSIBLE_AFTER_MEM_DECOMMIT is set, the pointer will be validated before being dereferenced. buf_pool_t::get_info(): Replaces buf_stats_get_pool_info(). innodb_init_param(): Refactored. We must first compute srv_page_size_shift and then determine the valid bounds of innodb_buffer_pool_size. buf_buddy_shrink(): Replaces buf_buddy_realloc(). Part of the work is deferred to buf_buddy_condense_free(), which is being executed when we are not holding any buf_pool.page_hash latch. buf_buddy_condense_free(): Do not relocate blocks. buf_buddy_free_low(): Do not care about buffer pool shrinking. This will be handled by buf_buddy_shrink() and buf_buddy_condense_free(). buf_buddy_alloc_zip(): Assert !buf_pool.contains_zip() when we are allocating from the binary buddy system. Previously we were asserting this on multiple recursion levels. buf_buddy_block_free(), buf_buddy_free_low(): Assert !buf_pool.contains_zip(). buf_buddy_alloc_from(): Remove the redundant parameter j. buf_flush_LRU_list_batch(): Add the parameter to_withdraw to keep track of buf_pool.n_blocks_to_withdraw. buf_do_LRU_batch(): Skip buf_free_from_unzip_LRU_list_batch() if we are shrinking the buffer pool. In that case, we want to minimize the page relocations and just finish as quickly as possible. trx_purge_attach_undo_recs(): Limit purge_sys.n_pages_handled() in every iteration, in case the buffer pool is being shrunk in the middle of a purge batch. Reviewed by: Debarun Banerjee	7 months ago
Sergei Petrunia	3b4de4c281	MDEV-32084: Assertion in best_extension_by_limited_search() ... When subquery with LEFT JOIN is converted into semi-join, it is possible to construct cases where the LEFT JOIN's ON expression refers to a table in the current select but not in the current join nest. For example: t1 SEMI JOIN ( t2 LEFT JOIN (t3 LEFT JOIN t4 ON t4.col=t1.col) ON expr ) here, ON t4.col=t1.col" has this property. Let's denote it as ON-EXPR-HAS-REF-OUTSIDE-NEST. The optimizer handles LEFT JOINs like so: - Outer join runtime requires that "inner tables follow outer" in any join order. - Join optimizer enforces this by constructing join orders that follow table dependencies as they are specified in TABLE_LIST::dep_tables. - The dep_tables are set in simplify_joins() according to the contents of ON expressions and LEFT JOIN structure. However, the logic in simplify_joins() failed to account for possible ON-EXPR-HAS-REF-OUTSIDE-NEST. It assumed that references outside of the current join nest could only be OUTER_REF_TABLE_BIT or RAND_TABLE_BIT. The fix was to add the missing logic.	7 months ago
Vasilii Lakhin	22efc2c784	Fix typos in C comments inside storage/	7 months ago
Marko Mäkelä	d1a6792324	MDEV-36122: Protect table references with a lock dict_table_open_on_id(): Simplify the logic. dict_stats: A helper for acquiring MDL and opening the tables mysql.innodb_table_stats and mysql.innodb_index_stats. innodb_ft_aux_table_validate(): Contiguously hold dict_sys.latch while accessing the table that we open with dict_table_open_on_name(). lock_table_children(): Do not hold a table reference while invoking dict_acquire_mdl_shared<false>(), which may temporarily release and reacquire the shared dict_sys.latch that we are holding. prepare_inplace_alter_table_dict(): If an unexpected reference to the table exists, wait for the purge subsystem to release its table handle, similar to how we would do in case FULLTEXT INDEX existed. This function is supposed to be protected by MDL_EXCLUSIVE on the table name. If purge is going to access the table again later during is ALTER TABLE operation, it will have access to an MDL compatible name for it and therefore should conflict with any MDL_EXCLUSIVE that would cover ha_innobase::commit_inplace_alter_table(commit=true). ha_innobase::rename_table(): Before locking the data dictionary, ensure that the purge subsystem is not holding a reference to the table due to the lack of metadata locking, related to FULLTEXT INDEX or the row-level undo logging of ALTER IGNORE TABLE. ha_innobase::truncate(): Before locking the data dictionary, ensure that the purge subsystem is not holding a reference to the table due to insufficient metadata locking related to an earlier ALTER IGNORE TABLE operation. trx_purge_attach_undo_recs(), purge_sys_t::batch_cleanup(): Clear purge_sys.m_active only after all table handles have been released. With these changes, no caller of dict_acquire_mdl_shared<false> should be holding a table reference. All remaining calls to dict_table_open_on_name(dict_locked=false) except the one in fts_lock_table() and possibly in the DDL recovery predicate innodb_check_version() should be protected by MDL, but there currently is no assertion that would enforce this. Reviewed by: Debarun Banerjee	7 months ago
Marko Mäkelä	4a21cba7fc	MDEV-36122 Assertion ctx0->old_table->get_ref_count() == 1 trx_purge_close_tables(): Before releasing any metadata locks (MDL), release all table references, in case an ALTER TABLE…ALGORITHM=COPY operation has confused our logic. trx_purge_table_acquire(), trx_purge_table_open(): Do not acquire any table reference before successfully acquiring a necessary metadata lock. In this way, if purge is waiting for MDL, a concurrent ha_innobase::commit_inplace_alter_table(commit=true) that is holding a conflicting MDL_EXCLUSIVE will only observe its own reference on the table that it may need to replace. dict_acquire_mdl_shared<false>(): Unless we hold an MDL or one is not needed, do not hold a table reference when releasing dict_sys.latch. After loading a table into the dictionary cache, we will look up the table again, because the table could be evicted or dropped while we were not holding any dict_sys.latch. Reviewed by: Debarun Banerjee	7 months ago
Marko Mäkelä	6066e5d13c	MDEV-36122: Work around missing MDL in purge prepare_inplace_alter_table_dict(): If an unexpected reference to the table exists, wait for the purge subsystem to release its table handle, similar to how we would do in case FULLTEXT INDEX existed. This function is supposed to be protected by MDL_EXCLUSIVE on the table name. If purge is going to access the table again later during is ALTER TABLE operation, it will have access to an MDL compatible name for it and therefore should conflict with any MDL_EXCLUSIVE that would cover ha_innobase::commit_inplace_alter_table(commit=true). This change should prevent race conditions where purge had initially looked up a table for which row-level undo log records had been written by ALTER IGNORE TABLE, and purge did not finish before a subsequent ALTER TABLE is trying to rebuild the table. trx_purge_attach_undo_recs(), purge_sys_t::batch_cleanup(): Clear purge_sys.m_active only after all table handles have been released. ha_innobase::truncate(): Before locking the data dictionary, ensure that the purge subsystem is not holding a reference to the table due to insufficient metadata locking related to an earlier ALTER IGNORE TABLE operation. Reviewed by: Debarun Banerjee	7 months ago
Marko Mäkelä	67caeca284	MDEV-36122: Protect table references with a lock dict_table_open_on_id(): Simplify the logic. dict_stats: A helper for acquiring MDL and opening the tables mysql.innodb_table_stats and mysql.innodb_index_stats. innodb_ft_aux_table_validate(): Contiguously hold dict_sys.latch while accessing the table that we open with dict_table_open_on_name(). lock_table_children(): Do not hold a table reference while invoking dict_acquire_mdl_shared<false>(), which may temporarily release and reacquire the shared dict_sys.latch that we are holding. With these changes, no caller of dict_acquire_mdl_shared<false> should be holding a table reference. All remaining calls to dict_table_open_on_name(dict_locked=false) except the one in fts_lock_table() and possibly in the DDL recovery predicate innodb_check_version() should be protected by MDL, but there currently is no assertion that would enforce this. Reviewed by: Debarun Banerjee	7 months ago
Marko Mäkelä	337bf8ac4b	MDEV-36122 Assertion ctx0->old_table->get_ref_count() == 1 trx_purge_close_tables(): Before releasing any metadata locks (MDL), release all table references, in case an ALTER TABLE…ALGORITHM=COPY operation has confused our logic. trx_purge_table_acquire(), trx_purge_table_open(): Do not acquire any table reference before successfully acquiring a necessary metadata lock. In this way, if purge is waiting for MDL, a concurrent ha_innobase::commit_inplace_alter_table(commit=true) that is holding a conflicting MDL_EXCLUSIVE will only observe its own reference on the table that it may need to replace. dict_acquire_mdl_shared<false>(): Unless we hold an MDL or one is not needed, do not hold a table reference when releasing dict_sys.latch. After loading a table into the dictionary cache, we will look up the table again, because the table could be evicted or dropped while we were not holding any dict_sys.latch. Reviewed by: Debarun Banerjee	7 months ago
Thirunarayanan Balathandayuthapani	1f4a901576	MDEV-36281 DML aborts during online virtual index Reason: ======= - InnoDB DML commit aborts the server when InnoDB does online virtual index. During online DDL, concurrent DML commit operation does read the undo log record and their related current version of the clustered index record. Based on the operation, InnoDB do build the old tuple and new tuple for the table. If the concurrent online index can be affected by the operation, InnoDB does build the entry for the index and log the operation. Problematic case is update operation, InnoDB does build the update vector. But while building the old row, InnoDB fails to fill the non-affected virtual column. This lead to server abort while build the entry for index. Fix: === - First, fill the virtual column entries for the new row. Duplicate the old row based on new row and change only the affected fields in old row based on the update vector.	7 months ago
Thirunarayanan Balathandayuthapani	a390aaaf23	MDEV-36180 Doublewrite recovery of innodb_checksum_algorithm=full_crc32 page_compressed pages does not work - InnoDB fails to recover the full crc32 page_compressed page from doublewrite buffer. The reason is that buf_dblwr_t::recover() fails to identify the space id from the page because the page has compressed from FIL_PAGE_FILE_FLUSH_LSN_OR_KEY_VERSION bytes. Fix: === recv_dblwr_t::find_deferred_page(): Find the page which has the same page number and try to decompress/decrypt the page based on the tablespace metadata. After the decompression/decryption, compare the space id and write the recovered page back to the file. buf_page_t::read_complete(): Page read from disk is corrupted then try to read the page from deferred pages in doublewrite buffer.	7 months ago
Marko Mäkelä	19c4e1abe4	MDEV-24035 fixup: GCC 4.8.5 CMAKE_BUILD_TYPE=Debug	7 months ago
Daniel Black	85ecb80fa3	MDEV-36229: Remove CAP_DAC_OVERRIDE CAP_AUDIT_WRITE from AmbientCapabilities In resolving MDEV-33301 (`76a27155b4`) we moved all the capabilities from CapabilityBoundingSet to AmbientCapabilities where only add/moving CAP_IPC_LOCK was intended. The effect of this is the defaulting running MariaDB HAS the capabiltiy CAP_DAC_OVERRIDE CAP_AUDIT_WRITE allowing it to access any file, even while running as a non-root user. Resolve this by making CAP_IPC_LOCK apply to AmbientCapabilities and leave the remaining CAP_DAC_OVERRIDE CAP_AUDIT_WRITE to CapabilityBoundingSet for the use by auth_pam_tool.	8 months ago
Kristian Nielsen	3b3c512feb	MDEV-36265: Unique error for changing Domain ID with open temporary tables Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	8 months ago
Sergei Petrunia	47d11328c9	MDEV-36381: Comment "Procedure of keys generation ..." is in the wrong place Move it from the middle of table.cc to sql_select.cc:generate_derived_keys()	7 months ago
Thirunarayanan Balathandayuthapani	2469963f05	MDEV-36270 mariabackup.incremental_compressed fails in 10.11+ - During prepare of incremental backup, mariabackup does create new file in target directory with default file size of 4 * innodb_page_size. While applying .delta file to corresponding data file, it encounters the FSP_SIZE modification on page0 and tries to extend the file to the size which is 4 in our case. Since the table is in compressed row format, page_size for the table is 8k. This lead to shrinking of tablespace file from 65536 to 32768. This issue happens only in windows because os_file_set_size() doesn't check for the current size and shrinks the file. Solution: ======== xtrabackup_apply_delta(): Check for the current size before doing setting size for the file.	8 months ago
Marko Mäkelä	d84ceb586a	MDEV-36378 Recognize innodb_purge_rseg_truncate_frequency In commit `bda40ccb85` (MDEV-34803) there was a spelling mistake that somehow causes the deprecated parameter innodb_purge_rseg_truncate_frequency to be rejected at server startup.	7 months ago
Daniel Black	3d54cd6cf5	update C/C	7 months ago
Marko Mäkelä	33a462e0b1	MDEV-36373 Bogus Warning: ... storage is corrupted ha_innobase::statistics_init(), ha_innobase::info_low(): Correctly handle a DB_READ_ONLY return value from dict_stats_save(). Fixes up commit `6e6a1b316c` (MDEV-35000)	7 months ago
Jan Lindström	1277f9b451	MDEV-36372: Compilation is broken with the PLUGIN_PARTITION=NO Fixed a compilation error caused by MDEV-27861 that occurs when building with cmake -DPLUGIN_PARTITION=NO, because the default_part_plugin variable is only visible when WITH_PARTITION_STORAGE_ENGINE is defined. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	7 months ago
Faustin Lammler	ab468e33af	Add a sanity check for backups The check makes sure that the backup contains the latest PR information (based on title and PR number).	7 months ago
Alexander Barkov	3bbe11acd9	MDEV-20912 Add support for utf8mb4_0900_* collations in MariaDB Server Fixing a wrong alias utf8mb4_0900_bin: - was utf8mb4_bin - changed to utf8mb4_nopad_bin MySQL 0900 collations are NOPAD, including utf8mb4_0900_bin.	7 months ago
Amar Jilani	b0ec99398f	MDEV-21375: Get option group suffix from $MARIADB_GROUP_SUFFIX in addition to $MYSQL_GROUP_SUFFIX Add check for MARIADB_GROUP_SUFFIX environment variable when --default-group-suffix argument is not passed. This environment variable will take precedence over the MYSQL_GROUP_SUFFIX environment variable if both are set. All new code of the whole pull request, including one or several files that are either new files or modified ones, are contributed under the BSD-new license. I am contributing on behalf of my employer Amazon Web Services, Inc.	9 months ago
Aleksey Midenkov	4c695c85bd	MDEV-34775 Wrong reopen of already open routine due to auto-create in SP MDEV-34171 denied removing indirect routines/tables after recover_from_failed_open() for auto-create partition case. Now we are going further and keep them for any failed table reopen. MDEV-34171 did not handle correctly open_and_process_routine() after that skip of sp_remove_not_own_routines(). Now it is fixed by sroutine_to_open correct usage.	7 months ago
Dmitry Shulga	cc831f16c8	MDEV-36079: Stored routine with a cursor crashes on the second execution if a DDL statement happened Attempt to run a cursor after change in metadata of tables it depends on resulted in firing assertion on allocating a memory from a memory root marked as read only. On every execution of a cursor its Query_arena is set up as a statement arena (see sp_lex_keeper::cursor_reset_lex_and_exec_core()). As a consequence, any memory allocations happened on execution of the cursor's query should be taken from the cursor's memory root. The reason of allocating a memory from the memory root marked as read only is that the cursor's memory root points to a memory root of sp_head that could be already marked as read only after first successful execution and this relation isn't changed on re-parsing of the cursor's query. To fix the issue, memory root of cursor is adjusted in the method sp_lex_instr::parse_expr() to point to the new memory root just created for re-parsing of failed query.	7 months ago
Vasilii Lakhin	5f7c2a617f	Fix typos in C comments in miscellaneous files	7 months ago
Alexander Barkov	98a75d111c	MDEV-36322 Comparison ROW(stored_func(),1)=ROW(1,1) calls the function twice per row Item_func_sp::execute() was called two times per row in this scenario: SELECT ROW(f1(),1) = ROW(1,1), @counter FROM seq_1_to_5; - the first time from Item_func_sp::bring_value() - the second time from Item_func_sp::val_int() Fix: Changing Item_func_sp::bring_value() to call execute() only when the result type is ROW_RESULT.	7 months ago
Alexander Barkov	5f7e883336	MDEV-36322 Comparison ROW(stored_func(),1)=ROW(1,1) calls the function twice per row Item_func_sp::execute() was called two times per row in this scenario: SELECT ROW(f1(),1) = ROW(1,1), @counter FROM seq_1_to_5; - the first time from Item_func_sp::bring_value() - the second time from Item_func_sp::val_int() Fix: Changing Item_func_sp::bring_value() to call execute() only when the result type is ROW_RESULT.	7 months ago
Brad Smith	05be1865a9	Fix building with Clang and GCC on RISC-V Clang does not have the builtin __builtin_riscv_pause().	8 months ago
Faustin Lammler	c34bb80b3d	MDBF-1000: wrong urls	7 months ago
Thirunarayanan Balathandayuthapani	f1deebbb0b	MDEV-35420 Server aborts while deleting the record in spatial index - This issue caused by commit a032f14b342c782b82dfcd9235805bee446e6fe8(MDEV-33559). In MDEV-33559, matched_rec::block was changed to pointer and assinged with the help of buf_block_alloc(). But patch fails to check for the block can be nullptr in rtr_check_discard_page(). rtr_cur_search_with_match(): Acquire rtr_match_mutex before creating shadow block for the matched records rtr_pcur_move_to_next(): Copy the shadow block to page cursor block under rtr_match_mutex	8 months ago
KhaledR57	f813c8541a	MDEV-34621 Fix division by zero in mariadb-slap when iterations=0 mariadb-slap crashes with a floating point exception when run with -iterations=0 due to division by zero in generate_stats(). This occurs when calculating average timing by dividing by the number of iterations. To fix this, the solution checks if iterations == 0 before performing the division, and returns early from the function in such cases.	8 months ago
Dmitry Shulga	56bc6901d6	MDEV-34501: SIGSEGV in pfs_start_mutex_wait_v1, __strlen_avx2, or __strlen_evex from safe_mutex_lock on CREATE DEFINER when using skip-grant-tables Attempt to create a procedure with the DEFINER clause resulted in abnormal server termination in case the server run with the option --skip-grant-tables=1. The reason of abnormal termination is that on handling of the DEFINER clause, not initialized data members of acl_cache is accessed, that led to server crash. Behaviour of the server for considered use case must be the same as for embedded server. Than means, if a security subsytem wasn't initialized (server is started with the option --skip-grant-tables=1) return success from get_current_user() without further access to the acl_cache that obviously not initialized. Additionlly, AUTHID::is_role was modified to handle the case when a host part of the user name isn't provided. Treat this case as if the empty host name is provided.	7 months ago
Faustin Lammler	31adb3030c	MDBF-1000: implement an export for the server repository No MariaDB server code is touched here, this is only about GitHub actions CI.	7 months ago
Aleksey Midenkov	64ea539f76	MDEV-36208 dbug_print_table_row is broken: prints empty rows in debugger	8 months ago
Marko Mäkelä	2a92cf8b0c	MDEV-35000 fixup: GCC 4.8.5 -Wconversion Old GCC versions would issue bogus -Wconversion. Let us silence this one with a redundant cast.	7 months ago

... 2 3 4 5 6 ...

203083 Commits (0f4a35a3270d11c834a36e9def62e9a4f0128e76) All Branches Search

203083 Commits (0f4a35a3270d11c834a36e9def62e9a4f0128e76)

All Branches