mariadb

Tree: 09b7a0d115

Author	SHA1	Message	Date
Konstantin Osipov	09b7a0d115	A post-review fix for type-aware metadata locks. DDL no longer aborts mysql_lock_tables(), and hence we no longer need to support need_reopen flag of this call. Remove the flag, and all the code in the server that was responsible for handling the case when it was set. This allowed to simplify: open_and_lock_tables_derived(), the delayed thread, multi-update. Rename MYSQL_LOCK_IGNORE_FLUSH to MYSQL_OPEN_IGNORE_FLUSH, since we now only support this flag in open_table(). Rename MYSQL_LOCK_PERF_SCHEMA to MYSQL_LOCK_LOG_TABLE, to avoid confusion. Move the wait for the global read lock for cases when we do updates in SELECT f1() or DO (UPDATE) to open_table() from mysql_lock_tables(). When waiting for the read lock, we could raise need_reopen flag, which is no longer present in mysql_lock_tables(). Since the block responsible for waiting for GRL was moved, MYSQL_LOCK_IGNORE_GLOBAL_READ_LOCK was renamed to MYSQL_OPEN_IGNORE_GLOBAL_READ_LOCK. mysql-test/r/mdl_sync.result: Update test results (see comments for mdl_sync.test). mysql-test/t/mdl_sync.test: Update tests: an abort mysql_lock_tables() called for an INSERT no longer auto-closes SQL HANDLERS, since it no longer leads to back-off and retry. sql/ha_ndbcluster_binlog.cc: Remove unused variables. sql/lock.cc: Remove support for need_reopen parameter of mysql_lock_tables(). Update comments. sql/log_event_old.cc: Remove the loop responsible for handling need_reopen out parameter of mysql_lock_tables(). sql/mysql_priv.h: Update open and lock tables flag names. sql/share/errmsg-utf8.txt: Add a new error message to report when thr_multi_lock() is aborted. sql/sql_base.cc: Update comments. Rename MYSQL_LOCK_IGNORE_FLUSH to MYSQL_OPEN_IGNORE_FLUSH. sql/sql_class.h: Remove unused code. sql/sql_db.cc: Remove an unused bit of code. sql/sql_handler.cc: For backward compatibility, we still want to back off and retry when a call to mysql_lock_tables() is aborted from within an SQL HANDLER. Write an internal error handler to support the case. sql/sql_insert.cc: Call mysql_lock_tables() no longer has need_reopen out parameter. Simplify the code by removing the crud that took care of it. MYSQL_LOCK_IGNORE_FLUSH is now only supported by open_tables(). sql/sql_show.cc: Rename MYSQL_LOCK_IGNORE_FLUSH to MYSQL_OPEN_IGNORE_FLUSH sql/sql_table.cc: Remove an unused parameter. sql/sql_update.cc: Remove the need_reopen loop from multi-update. We no also longer need to cleanup the parse tree in case when mysql_lock_tables() is aborted and thus an infinite source of multi-update bugs is gone. sql/tztime.cc: Rename MYSQL_LOCK_IGNORE_FLUSH to MYSQL_OPEN_IGNORE_FLUSH, since from now on this flag is only supported by open_table().	16 years ago
Vladislav Vaintroub	a45162d4e3	merge	16 years ago
Alexander Nozdrin	8825ea3f2a	Auto-merge from mysql-trunk.	16 years ago
Alexander Nozdrin	c161a4876b	A patch for Bug#52071 (rpl_ndb.rpl_ndb_ctype_ucs2_def fails). Use new command line options instead of deprecated and removed ones.	16 years ago
Alexander Nozdrin	6be830e14b	Enable ndb and rpl_ndb test suites in daily builds.	16 years ago
Magnus Blåudd	cdb480d6dd	Merge	16 years ago
Magnus Blåudd	df1ed40b30	Merge in fix for bug#42589	16 years ago
Jon Olav Hauglid	c7c1f2198f	Bug #51160 Deadlock around SET GLOBAL EVENT_SCHEDULER = ON\|OFF This deadlock could occour betweeen one connection executing SET GLOBAL EVENT_SCHEDULER= ON and another executing SET GLOBAL EVENT_SCHEDULER= OFF. The bug was introduced by WL#4738. The first connection would hold LOCK_event_metadata (protecting the global variable) while trying to lock LOCK_global_system_variables starting the event scheduler thread (in THD:init()). The second connection would hold LOCK_global_system_variables while trying to get LOCK_event_scheduler after stopping the event scheduler inside event_scheduler_update(). This patch fixes the problem by not using LOCK_event_metadata to protect the event_scheduler variable. It is still protected using LOCK_global_system_variables. This fixes the deadlock as it removes one of the two mutexes used to produce it. However, this patch opens up the possibility that the event_scheduler variable and the real event_scheduler state can become out of sync (e.g. variable = OFF, but scheduler running). But this can only happen under very unlikely conditions - two concurrent SET GLOBAL statments, with one thread interrupted at the exact wrong moment. This is preferable to having the possibility of a deadlock. This patch also fixes a bug where it was possible to exit create_event() without releasing LOCK_event_metadata if running out of memory during its exection. No test case added since a repeatable test case would have required excessive use of new sync points. Instead we rely on the fact that this bug was easily reproduceable using RGQ tests.	16 years ago
Alexander Nozdrin	f007796bf4	Auto-merge from mysql-trunk.	16 years ago
Konstantin Osipov	7116431a8a	A review comment for the fix for Bug#46672. Remove unnecessary need_reopen loops.	16 years ago
unknown	a3bc225ecf	Raise version number after cloning 5.5.3-m3	16 years ago
Alexander Nozdrin	f6d13ea3e3	Auto-merge from mysql-trunk.	16 years ago
Alexander Nozdrin	233cdaedd2	Auto-merge from mysql-next-mr.	16 years ago
Alexander Nozdrin	cc27bf7c01	Auto-merge (empty) from mysql-trunk.	16 years ago
Alexander Nozdrin	7582f3ddff	Auto-merge from mysql-next-mr-bugfixing.	16 years ago
Alexander Nozdrin	b03480e9ad	Auto-merge from mysql-trunk-bugfixing.	16 years ago
Luis Soares	b7b9b45366	BUG#51716 post push fix. There are two issues fixed here: 1. We needed to update the result file, for some of mysqlbinlog_* tests, because now the some padding chars are not output anymore. 2. We needed to change the Field_string::pack so that for BINARY types the padding chars are not packed (lengthsp will return full length for these types).	16 years ago
Joerg Bruehe	1d7f8578d3	Automerge the bug#49022 fix correction into next-mr-bugfixing.	16 years ago
Joerg Bruehe	f59c7267f2	Fix for the bug#49022 patch, detected by further testing.	16 years ago
Vladislav Vaintroub	c8141ce4c0	Bug#51949 - make_binary_distribution fails on Mac. Unquoted ${CMAKE_CPACK_COMMAND} is used in this script. This variable resolves to cpack's real path with spaces, e.g /Applications/CMake 2.6.4-app/Contents/bin/cpack. Script fails due to lack of quotes. Fix is to use quotes around ${CMAKE_CPACK_COMMAND}.	16 years ago
Konstantin Osipov	ea70b6a20a	A fix for Bug#49972 "Crash in prepared statements": The problem is introduced by WL#4435 "Support OUT-parameters in prepared statements". When a statement that has out parameters was reprepared, the reprepare request error was ignored, and an attempt to send out parameters to the client was made. Since the out parameter list was not initialized in case of an error, this attempt led to a crash. Don't try to send out parameters to the client if an error occurred in statement execution. sql/sql_prepare.cc: Don't try to send out parameters if error. tests/mysql_client_test.c: Re-enable the test case for Bug#49972.	16 years ago
Luis Soares	baab8dd83c	Automerge: mysql-next-mr-bugfixing bug branch --> mysql-next-mr-bugfixing latest.	16 years ago
Alexander Barkov	b0ed7a5499	An additional fix for WL#1213 4-byte UTF8 - Fixing crash on attempt to create a fulltext index with an utf8mb4 column - fixing wrong border width for supplementary characters in mysql client: mysql --default-character-set=utf8mb4 -e "select concat(_utf32 0x20000,'a')"	16 years ago
He Zhenxing	9c2961ab63	Auto merge	16 years ago
He Zhenxing	7f76b4d36c	Enable rpl_semi_sync test on Windows	16 years ago
He Zhenxing	71e8549eb1	Auto merge from 5.1-rep-semisync	16 years ago
Luis Soares	092d50389e	Fix for BUG#51716 and BUG#51787: test case improvements. Split rpl_row_charset into: - rpl_row_utf16. - rpl_row_utf32. This way these tests can run independently if server supports either one of the charsets but not both. Cleaned up rpl_row_utf32 which had a spurious instruction: -- let $reset_slave_type_conversions= 0	16 years ago
Davi Arnaut	f147aa35a6	Automatic merge.	16 years ago
Luis Soares	ade4977c1e	Fix for BUG#51716 and BUG#51787. In BUG#51787 we were using the wrong charset to print out the data. We were using the field charset for the string that would hold the information. This caused the assertion, because the string length was not aligned with UTF32 bytes requirements for storage. We fix this by using &my_charset_latin1 in the string object instead of the field->charset(). As a side-effect, we needed to extend the show_sql_type interface so that it took the field charset is now passed as a parameter, so that one is able to calculate the correct field size. In BUG#51716 we had issues with Field_string::pack and Field_string::unpack. When packing, the length was incorrectly calculated. When unpacking, the padding the string would be padded with the wrong bytes (a few bytes less than it should). We fix this by resorting to charset abstractions (functions) that calculate the correct length when packing and pad correctly the string when unpacking.	16 years ago
Joerg Bruehe	3396ca2211	Automerge into next-mr-bugfixing.	16 years ago
Alexander Nozdrin	929293b9be	Auto-merge from mysql-next-mr-bugfixing.	16 years ago
Konstantin Osipov	7fe455a6bc	A fix and a test case for Bug#51710 FLUSH TABLES <view> WITH READ LOCK kills the server. Prohibit FLUSH TABLES WITH READ LOCK application to views or temporary tables. Fix a subtle bug in the implementation when we actually did not remove table share objects from the table cache after acquiring exclusive locks. mysql-test/r/flush.result: Update results (Bug#51710) mysql-test/t/flush.test: Add a test case for Bug#51710. sql/sql_parse.cc: Fix Bug#51710 "FLUSH TABLES <view> WITH READ LOCK killes the server. Ensure we don't open views and temporary tables. Fix a yet another bug in the implementation which did not actually remove the tables from cache after acquiring exclusive locks.	16 years ago
Davi Arnaut	b11740894e	Bug#33669: Transactional temporary tables do not work under --read-only The problem was that in read only mode (read_only enabled), the server would mistakenly deny data modification attempts for temporary tables which belong to a transactional storage engine (eg. InnoDB). The solution is to allow transactional temporary tables to be modified under read only mode. As a whole, the read only mode does not apply to any kind of temporary table. mysql-test/r/read_only_innodb.result: Add test case result for Bug#33669 mysql-test/t/read_only_innodb.test: Add test case for Bug#33669 sql/lock.cc: Rename mysql_lock_tables_check to lock_tables_check and make it static. Move locking related checks from get_lock_data to lock_tables_check. Allow write locks to temporary tables even under read-only.	16 years ago
Joerg Bruehe	3139b90494	Part of the fixes for bug#49022 Plugins included into bin release cannot be installed on debug version of server Ensure that the plugin files of the debug build get into the optimized tree, so that they find their way into the final RPMs. support-files/mysql.spec.sh: Use "make install" in the debug build tree to get the debug plugin files to a temporary location, then move them to "plugin/debug/" in the optimized build tree so that the install hook in "plugin/Makefile.am" forwards them into the final installation. This fixes bug#49022 for the generic RPMs. Unrelated: The plugin objects were listed twice in the file list, do a cleanup.	16 years ago
Alexander Nozdrin	8f79df0435	Auto-merge (empty) from mysql-trunk-bugfixing.	16 years ago
Alexander Nozdrin	d4e0cff35b	Auto-merge (empty) from mysql-next-mr.	16 years ago
Alexander Nozdrin	e58f200a3d	Auto-merge from mysql-trunk.	16 years ago
Alexander Nozdrin	494781fa8d	Auto-merge (empty) from mysql-trunk.	16 years ago
Alexander Nozdrin	cfeee8580d	Auto-merge from mysql-next-mr.	16 years ago
Alexander Nozdrin	c9db455c87	Auto-merge from mysql-next-mr-bugfixing.	16 years ago
Joerg Bruehe	1b0d2eefb7	Automerge part of the fixes for bug#49022 into "next-mr-bugfixing".	16 years ago
He Zhenxing	bd6cce8a7c	Post fix for Bug#49557	16 years ago
Joerg Bruehe	fcd119066c	Part of the fixes for bug#49022 Plugins included into bin release cannot be installed on debug version of server IF the build process was split into separate "debug" and "optimized" builds AND the plugin files of the debug build got copied into "plugin/debug/" (both is done for MySQL release builds starting from 5.5.3), THEN these debug plugin files are to be included in the final binary package. This change deals with the inclusion only, the other parts are done in different changesets. plugin/Makefile.am: The "install" rule must not assume that "debug" files are present, this depends on the preceding steps in the build. If they are present, we cannot copy them by simply using "libtool install" (as we could do during an ordinary build) because they are already kept in "plugin/debug/". When doing the copy to the destination hierarchy, we must ensure that symlinks are not expanded but rather copied as symlinks. "cp -d" is specific to GNU, the portable way would use "cp -P", but that is not fully specified with recursion. So we fall back on "tar c \| tar x", which is known to keep symlinks unchanged (and un-expanded). Using "$(TAR)" is just a precaution in case of weird path settings or other portability issues.	16 years ago
Mats Kindahl	ec82cbb293	Merging with mysql-next-mr-bugfixing	16 years ago
Marc Alff	f6660539c2	Bug#51878 Build break in HPUX involving mysql_prlock on a client This is a fix specific for HPUX, for which the compiler does not resolve properly dependencies involving unused inline functions. (See existing comments in mysql_thread.h) In include/mysql/psi/mysql_thread.h, the instrumentation helpers for mysql_prlock_* uses the pr lock apis. These apis are implemented in mysys/thr_rwlock.c, which is not linked to client code. As a result, the code does not link in libmysql_r, on HPUX. The fix is to cut dependencies explicitely, by introducing -DDISABLE_MYSQL_RWLOCK_H, when building client code.	16 years ago
Tor Didriksen	58559ac827	Bug#50888 valgrind warnings in Field_timestamp::val_str Ensure that we store the correct cached_field_type whenever we cache Field items (in this case it allows us to compare dates as dates, rather than strings) mysql-test/r/type_timestamp.result: Add test case. mysql-test/t/type_timestamp.test: Add test case. sql/item.h: Initialize cached_field_type from the Field item.	16 years ago
Alexander Nozdrin	4315b101f5	pfs_upgrade.test is a case-sensitive test.	16 years ago
Alexander Nozdrin	85f04306f9	Auto-merge from mysql-next-mr-bugfixing.	16 years ago
Alexander Nozdrin	786a83e2d4	Auto-merge from mysql-trunk-bugfixing.	16 years ago
Alexander Nozdrin	9670dba990	Auto-merge from mysql-next-mr.	16 years ago

1 2 3 4 5 ...

61434 Commits (09b7a0d11540495dd6fc9cf7ec0d2c81fd630f83) All Branches Search

61434 Commits (09b7a0d11540495dd6fc9cf7ec0d2c81fd630f83)

All Branches