mariadb

Tree: 065ba53ccb

Author	SHA1	Message	Date
Marko Mäkelä	065ba53ccb	MDEV-12711 mariabackup --backup is refused for multi-file system tablespace Before MDEV-12113 (MariaDB Server 10.1.25), on shutdown InnoDB would write the current LSN to the first page of each file of the system tablespace. This is incompatible with MariaDB's InnoDB table encryption, because encryption repurposed the field for an encryption key ID and checksum. buf_page_is_corrupted(): For the InnoDB system tablespace, skip FIL_PAGE_FILE_FLUSH_LSN when checking if a page is all zero, because the first page of each file in the system tablespace can contain nonzero bytes in the field.	7 years ago
Alexander Barkov	6fbbb0853e	MDEV-18968 Both (WHERE 0.1) and (WHERE NOT 0.1) return empty set	7 years ago
FaramosCZ	ed643f4bb3	Fix resource leak The 'bitmap_dir' has to be closed when no longer needed	7 years ago
Alexander Barkov	f704361cd6	Backporting slow log simulation logic details from 10.2 to 10.1 Simulate slow statements only for COM_QUERY and COM_STMT_EXECUTE commands, to exclude mysqld_stmt_prepare() and mysqld_stmt_close() entries from the log, as they are not relevant for log_slow_debug.test. This simplifies the test.	7 years ago
FaramosCZ	9c9bf9642e	Fix resource leak	7 years ago
FaramosCZ	89e390b7ce	Fix resource leak	7 years ago
FaramosCZ	9ff713d33a	Fix resource leak	7 years ago
FaramosCZ	8be02be08b	Fix USE_AFTER_FREE (CWE-672) The file will be closed on line 540	7 years ago
Marko Mäkelä	8c493a910f	Merge 10.0 into 10.1	7 years ago
Marko Mäkelä	925b503058	Merge 5.5 into 10.0	7 years ago
Marko Mäkelä	5d454181a8	MDEV-6262 follow-up: Ensure NUL termination on strncpy()	7 years ago
Alexander Barkov	e9c494c843	Fixing a failure in tests for "MDEV-18892 Regression in slow log and admin statements" Tests for MDEV-18892 failed, because of extra 'Prepare' and 'Close stmt' entries in the output. Filtering out PS related entries (where it is necessary).	7 years ago
Alexander Barkov	ef81d2ea64	Fixing "mtr func_math" failure in the test for MDEV-17643 Adding an intermediate volatile variable to avoid using co-processor registers on some platforms (e.g. 32-bit x86). This change makes test results stable accross all platforms.	7 years ago
Alexander Barkov	3b98c65c4e	MDEV-18881 Assertion `0' failed in make_sortkey upon SELECT with GROUP BY after LOAD DATA	7 years ago
Jan Lindström	6c08174e36	MDEV-18908: Remove galera and wsrep suites from default run suites in mtr Idea is that many users do not install galera library and do not want to unnecessary run galera and wsrep suites. Furthermore, failures on these suites disturb development as buildbot shows red failing column and causes unnecessary work for those who do not care galera tests. There will be other way to run these suites on buildbot.	7 years ago
Vladislav Vaintroub	cd805a5f1c	Cleanup - remove unused variables and functions after MDEV-18917	7 years ago
Alexander Barkov	b6dc47a0f7	MDEV-17643 Assertion `nr >= 0.0' failed in Item_sum_std::val_real()	7 years ago
Marko Mäkelä	34db9958e2	MDEV-18936 Purge thread fails to exit on shutdown When there is a huge transaction in the undo log, the purge threads may get stuck in trx_purge_attach_undo_recs() for a long time, causing the server to hang on a normal shutdown (innodb_fast_shutdown>0). Apparently the innodb_purge_batch_size does not work correctly, or the n_pages_handled is not being incremented correctly. We do not fix that for now, but we will instead check if shutdown has been initiated, allowing the purge threads to shut down without delays.	7 years ago
Vladislav Vaintroub	396cf60ac0	MDEV-18917 Don't create xtrabackup_binlog_pos_innodb with Mariabackup	7 years ago
Ian Gilfillan	7ad355dde7	MDEV-18934: Document missing mysqldumpslow sort options	7 years ago
Alexander Barkov	78c2499282	MDEV-16958 Assertion `field_length < 5' failed in Field_year::val_str or data corruption upon SELECT with UNION and aggregate functions	7 years ago
Igor Babaev	0dd12b4f2a	MDEV-18896 Crash in convert_join_subqueries_to_semijoins If an IN-subquery is used in a table-less select the current code should never consider it as candidate for semi-join optimizations. Yet the function check_and_do_in_subquery_rewrites() improperly checked the property "to be a table-less select". As a result such select in IN subquery was used in INSERT .. SELECT then the IN subquery by mistake was registered as a semi-join subquery and convert_subq_to_sj() was called for it. However the code of this function does not assume that the parent select of the subquery could be a table-less select.	7 years ago
Sergei Golubchik	3d2d060b62	fix gcc 8 compiler warnings There were two newly enabled warnings: 1. cast for a function pointers. Affected sql_analyse.h, mi_write.c and ma_write.cc, mf_iocache-t.cc, mysqlbinlog.cc, encryption.cc, etc 2. memcpy/memset of nontrivial structures. Fixed as: * the warning disabled for InnoDB * TABLE, TABLE_SHARE, and TABLE_LIST got a new method reset() which does the bzero(), which is safe for these classes, but any other bzero() will still cause a warning * Table_scope_and_contents_source_st uses `TABLE_LIST ` (trivial) instead of `SQL_I_List<TABLE_LIST>` (not trivial) so it's safe to bzero now. added casts in debug_sync.cc and sql_select.cc (for JOIN) * move assignment method for MDL_request instead of memcpy() * PARTIAL_INDEX_INTERSECT_INFO::init() instead of bzero() * remove constructor from READ_RECORD() to make it trivial * replace some memcpy() with c++ copy assignments	7 years ago
Alexander Barkov	ddfa722a03	MDEV-18626 ASAN stack-buffer-overflow in int10_to_str / make_date_time upon DATE_FORMAT	7 years ago
Alexander Barkov	49c49e630b	Tests for MDEV-18667 ASAN heap-use-after-free in make_date_time / Arg_comparator::compare_string / Item_func_nullif::compare The patch for MDEV-14926 fixed MDEV-18667 as well. Adding tests only.	7 years ago
Alexander Barkov	cb66cdc6f8	MDEV-14926 AddressSanitizer: heap-use-after-free in make_date_time on weird combination of functions	7 years ago
Alexander Barkov	d7a38eaf1a	MDEV-18907 Slow log: RENAME TABLE is not "admin", while ALTER TABLE..RENAME is	7 years ago
Jan Lindström	691c306953	MDEV-14033: wsrep_on=off + binlog = mixed on MariaDB 10.2.9 If wsrep provider (i.e. galera library) is defined but wsrep_on=OFF we should not force row binlog row format.	7 years ago
Alexander Barkov	90ce95de4b	Tests for MDEV-18892 Regression in slow log and admin statements The patch for MDEV-15945 fixed MDEV-18892. Adding tests only.	7 years ago
Jan Lindström	3b2a568589	Test cleanups.	7 years ago
Sergei Golubchik	a62e9a83c0	MDEV-15945 --ps-protocol does not test some queries Make mysqltest to use --ps-protocol more use prepared statements for everything that server supports with the exception of CALL (for now). Fix discovered test failures and bugs. tests: * PROCESSLIST shows Execute state, not Query * SHOW STATUS increments status variables more than in text protocol * multi-statements should be avoided (see tests with a wrong delimiter) * performance_schema events have different names in --ps-protocol * --enable_prepare_warnings mysqltest.cc: * make sure run_query_stmt() doesn't crash if there's no active connection (in wait_until_connected_again.inc) * prepare all statements that server supports protocol.h * Protocol_discard::send_result_set_metadata() should not send anything to the client. sql_acl.cc: * extract the functionality of getting the user for SHOW GRANTS from check_show_access(), so that mysql_test_show_grants() could generate the correct column names in the prepare step sql_class.cc: * result->prepare() can fail, don't ignore its return value * use correct number of decimals for EXPLAIN columns sql_parse.cc: * discard profiling for SHOW PROFILE. In text protocol it's done in prepare_schema_table(), but in --ps it is called on prepare only, so nothing was discarding profiling during execute. * move the permission checking code for SHOW CREATE VIEW to mysqld_show_create_get_fields(), so that it would be called during prepare step too. * only set sel_result when it was created here and needs to be destroyed in the same block. Avoid destroying lex->result. * use the correct number of tables in check_show_access(). Saying "as many as possible" doesn't work when first_not_own_table isn't set yet. sql_prepare.cc: * use correct user name for SHOW GRANTS columns * don't ignore verbose flag for SHOW SLAVE STATUS * support preparing REVOKE ALL and ROLLBACK TO SAVEPOINT * don't ignore errors from thd->prepare_explain_fields() * use select_send result for sending ANALYZE and EXPLAIN, but don't overwrite lex->result, because it might be needed to issue execute-time errors (select_dumpvar - too many rows) sql_show.cc: * check grants for SHOW CREATE VIEW here, not in mysql_execute_command sql_view.cc: * use the correct function to check privileges. Old code was doing check_access() for thd->security_ctx, which is invoker's sctx, not definer's sctx. Hide various view related errors from the invoker. sql_yacc.yy: * initialize lex->select_lex for LOAD, otherwise it'll contain garbage data that happen to fail tests with views in --ps (but not otherwise).	7 years ago
Sergei Golubchik	22f1cf9292	cleanup: misc	7 years ago
Sergei Golubchik	dda2e940fb	pass the slow logging information in thd->query_plan_flags This solves the following issues: * unlike lex->m_sql_cmd and lex->sql_command, thd->query_plan_flags is not reset in Prepared_statement::execute, it survives till the log_slow_statement(), so slow logging behaves correctly in --ps * using thd->query_plan_flags for both slow_log_filter and log_slow_admin_statements means the definition of "admin" statements for the slow log is the same no matter how it is filtered out.	7 years ago
Oleksandr Byelkin	bc8ae50e7c	Fix of prepared CREATE VIEW with global ORDER/GROUP	7 years ago
Oleksandr Byelkin	83123412f0	MDEV-11975: SQLCOM_PREPARE of EXPLAIN & ANALYZE statement do not return correct metadata info Added metadate info after prepare EXPLAIN/ANALYZE.	8 years ago
Oleksandr Byelkin	01c49e66b5	MDEV-11966: Impossible to execute prepared ANALYZE SELECT Prepare os ANALYZE now respond as EXPLAIN.	9 years ago
Marko Mäkelä	32de60bb2e	MDEV-18749: Fix GCC -flifetime-dse row_merge_create_fts_sort_index(): Initialize dict_col_t in an unambiguous way. GCC 6 and later appear to be able to optimize away the memset() that is part of mem_heap_zalloc() in the placement new call. Let us avoid using placement new in order to ensure that the objects will actually be initialized. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71388 https://gcc.gnu.org/ml/gcc/2016-02/msg00207.html While the latter reference hints that the optimization is only applicable to non-POD types (and dict_col_t does not define any member functions before 10.2), it is most consistent to use the same initialization across all versions.	7 years ago
Sergey Vojtovich	ea52ecbc10	Merge remote-tracking branch 'origin/10.0' into 10.1	7 years ago
Sergey Vojtovich	149b754768	MDEV-17595 - ALTER TABLE ADD FOREIGN KEY crash ALTER TABLE ... ADD FOREIGN KEY may trigger assertion failure when it has LOCK=EXCLUSIVE clause or concurrent FLUSH TABLES is being executed. In both cases being altered table is marked as flushed, which forces subsequent attempt to open parent table to re-open. Which in turn is not allowed while transaction is running. Rather than opening parent table, just take appropriate MDL lock. Also removed table_already_fk_prelocked() check: MDL itself has much better methods to handle duplicate locks. E.g. the former won't acquire MDL_SHARED_NO_WRITE if it already has MDL_SHARED_READ.	7 years ago
Eugene Kosov	2a2ab121b0	MDEV-17703 Add WITH_UBSAN switch to CMake similar to WITH_ASAN This can be useful: UBSAN_OPTIONS=log_path=/some/path clang users may want to increase stack size in include/my_pthread.h or enable some optimizations	7 years ago
Marko Mäkelä	0415021840	Clean up mysql-test/suite/galera/disabled.def again Clean up after commit `0957d25781` which introduced some disorder (unsorted or duplicated test names).	7 years ago
Jan Lindström	b31d025c97	Decrease the time required to run test by removing unnecessary sleeps. modified: suite/galera/t/galera_autoinc_sst_mariabackup.test	7 years ago
Jan Lindström	9fb84a166a	remove WSREP_SST_OPT_SUFFIX_VALUE, checking [mysqld] is covered in the parse_cnf --mysqld case also in wsrep_sst_xtrabackup-v2	7 years ago
Jan Lindström	a05ca1a99a	Galera 3 versions of the result files recorded.	7 years ago
Daniel Black	e8541c7565	galera: test cases for non [mysqld] section for configuration	7 years ago
Daniel Black	85a18526bc	wsrep_sst: remove WSREP_SST_OPT_SUFFIX_VALUE, checking [mysqld] is covered in the parse_cnf --mysqld case	7 years ago
Jan Lindström	0957d25781	MDEV-18830: Port SST fixes from 10.4 to 10.1 modified: mysql-test/suite/galera/disabled.def modified: mysql-test/suite/galera/r/galera_many_rows.result modified: mysql-test/suite/galera/t/galera_kill_nochanges.test new file: mysql-test/suite/galera/t/galera_many_rows.cnf modified: mysql-test/suite/galera/t/galera_many_rows.test modified: mysql-test/suite/galera/t/galera_var_dirty_reads.test modified: scripts/wsrep_sst_mariabackup.sh	7 years ago
Marko Mäkelä	6567636b09	Disable regularly failing Galera tests galera.partition and galera.galera_binlog_stmt_autoinc regularly display mismatching values for AUTO_INCREMENT columns. galera.MW-336 often times out while waiting for something in PROCESSLIST. Also, sort the test names, remove the redundant "galera." prefix and fix typos in 2 test names.	7 years ago
Thirunarayanan Balathandayuthapani	d038806dfe	MDEV-18855 Mariabackup should fetch innodb_compression_level from running server - Fetch innodb_compression_level from the running server.Add the value of innodb_compression_level in backup-my.cnf file during backup phase. So that prepare can use the innodb_compression_level variable from backup-my.cnf	7 years ago
Marko Mäkelä	e3adf96aeb	MDEV-13818 CREATE INDEX leaks memory if running out of undo log space row_merge_create_index_graph(): Relay the internal state from dict_create_index_step(). Our caller should free the index only if it was not copied, added to the cache, and freed. row_merge_create_index(): Free the index template if it was not added to the cache. This is a safer variant of the logic that was introduced in `65070beffd` in 10.2. prepare_inplace_alter_table_dict(): Add additional fault injection to exercise a code path where we have already added an index to the cache.	7 years ago

1 2 3 4 5 ...

177712 Commits (065ba53ccbf3ab468408dc5a5dbcb3741750a02d) All Branches Search

177712 Commits (065ba53ccbf3ab468408dc5a5dbcb3741750a02d)

All Branches