mariadb

Tree: 06299dddd4

Author	SHA1	Message	Date
marko	06299dddd4	branches/zip: In purge, avoid dereferencing unset BLOB pointers of freshly inserted, uncommitted clustered index records when determining if a secondary index record that contains a column prefix of an externally stored column is referencing the clustered index record. field_ref_zero[]: A BLOB pointer full of zero, for use in comparisons. btr_copy_externally_stored_field_prefix(): Assert that the BLOB pointer is set. row_ext_lookup_ith(), row_ext_lookup(), row_ext_lookup_low(): Document that field_ref_zero is returned when the BLOB cannot be fetched. row_ext_lookup_low(): Return field_ref_zero and *len = 0 when the BLOB pointer is unset. row_build_index_entry(): Return NULL when a needed BLOB pointer cannot be dereferenced (row_ext_lookup returns field_ref_zero). Check the return value for NULL in callers. row_vers_impl_x_locked_off_kernel(): Avoid comparisons when row_build_index_entry() returns NULL. row_vers_old_has_index_entry(): Ignore records for which row_build_index_entry() returns NULL. The entry should never be NULL in rollback, but it may be NULL in purge. row_merge_buf_add(): Assert that row_ext_lookup() does not return field_ref_zero. The table will be locked during index creation.	18 years ago
marko	110781a39e	branches/zip: btr_cur_pessimistic_insert(): When calling btr_cur_optimistic_insert(), pass big_rec to it, so that the field references of externally stored columns (BLOB pointers) will not be left uninitialized after a successful optimistic insert. This bug was spotted by Sunny.	18 years ago
vasil	5243af9c87	branches/zip: Merge 2093:2116 from trunk.	18 years ago
marko	30358fe698	branches/zip: Correct mistakes made in r2114. row_upd_index_replace_new_col_vals(): Declare fetch_ext. row_upd_index_replace_new_col_vals_index_pos(): Add a type conversion to the initialization expression of fetch_ext, to avoid a warning about comparison between signed and unsigned.	18 years ago
marko	36874d65f0	branches/zip: Fix a bug in the updates of index records that contain a column prefix of an externally stored column. row_upd_ext_fetch(): New function. row_upd_index_replace_new_col_vals(), row_upd_index_replace_new_col_vals_index_pos(): Fetch prefixes of externally stored columns when they are needed for column prefix indexes. For memory allocation, add the parameter ext_heap. Avoid repeating the inner loop after finding a matching upd_field->field_no.	18 years ago
marko	138ca85a9d	branches/zip: row_ext_create(), row_ext_lookup(): Clarify that the column numbers are relative to the InnoDB table object, or numbers returned by dict_col_get_no(). This will have to be ensured in all calling code.	18 years ago
marko	05e8d405de	branches/zip: dict_col_get_clust_pos(): Split a debug assertion, and make use of dict_index_is_clust().	18 years ago
marko	57b3081135	branches/zip: row_ext_create(), row_ext_lookup(): Clarify that the column numbers are relative to the clustered index record.	18 years ago
marko	404d94b38c	branches/zip: btr_store_big_rec_extern_fields(), btr_free_externally_stored_field(): Add some page type assertions that were suggested by Sunny.	18 years ago
vasil	759af55181	branches/zip: Fix the size of the static buffer for lock_table and lock_index. I was not realizing that NAME_LEN contains the mbmaxlen multiplier and thus a quote, when converted to 2 quotes, will take 2 bytes while there are 3 bytes reserved. Spotted by: Marko Pointyhat to: Vasil	18 years ago
vasil	5c8a9ce25a	branches/zip: Add C test for innobase_convert_name() in addition to the mysql-test one.	18 years ago
marko	71b3c265b8	branches/zip: When writing an externally stored column to the undo log, set the "external storage" flag. When parsing the undo log, do not misinterpret a SQL NULL column for externally stored. These bugs were spotted by Heikki and Sunny. trx_undo_page_report_modify(): Set the UNIV_EXTERN_STORAGE_FIELD flag when needed. trx_undo_rec_get_partial_row(): Check for len == UNIV_SQL_NULL.	18 years ago
vasil	5cd14d70bc	branches/zip: Fix a bug where the static buffer for innodb_locks.lock_table may not have enough space. Pointyhat to: Marko	18 years ago
vasil	6edf3ef181	branches/zip: Bugfix1: Set innodb_locks.lock_index to NOT NULL. If a column in INFORMATION_SCHEMA table has the flag MY_I_S_MAYBE_NULL and it is not explicitly marked as NOT NULL with the method ::set_notnull() then it is always rendered as NULL by MySQL. Bugfix2: Avoid crashes if lock_index is NULL. It is NULL for table level locks. Pointyhat to: Marko	18 years ago
vasil	30d19bf45f	branches/zip: Non-functional change: Fix consistency of the sizeof() operator with the rest of i_s.cc Pointyhat to: Marko	18 years ago
vasil	857c6501f4	branches/zip: Move test that depends on ucs2 to a separate file that is disabled if ucs2 is not compiled in.	18 years ago
vasil	9d76b5263d	branches/zip: Move common SQL commands to an .inc file.	18 years ago
vasil	62a46de281	branches/zip: Synchronize the utf8 and ucs2 tests.	18 years ago
marko	e1eb788f73	branches/zip: INFORMATION_SCHEMA.INNODB_LOCKS: Quote lock_table, lock_index. innodb_information_schema.test. Add tests that display most columns from INFORMATION_SCHEMA.INNODB_LOCKS. Test that quoting of table names works and respects SQL_MODE='ANSI_QUOTES'. innobase_print_identifier(): Remove. innobase_convert_identifier(): New function, based on innobase_print_identifier(). innobase_convert_name(): New function, similar to ut_print_namel(), but using a memory buffer. ut_print_namel(): Use innobase_convert_name(). fill_innodb_locks_from_cache(): Convert lock_table and lock_index by calling innobase_convert_name().	18 years ago
marko	f6c6980f36	branches/zip: ut_fold_binary(): Adjust a bogus debug assertion.	18 years ago
vasil	3dfa05681a	branches/zip: Convert INFORMATION_SCHEMA tables' names to upper case so that they are consistent with other INFORMATION_SCHEMA tables. mysql> show tables; +---------------------------------------+ \| Tables_in_information_schema \| +---------------------------------------+ \| CHARACTER_SETS \| \| COLLATIONS \| \| COLLATION_CHARACTER_SET_APPLICABILITY \| \| COLUMNS \| \| COLUMN_PRIVILEGES \| \| ENGINES \| \| EVENTS \| \| FILES \| \| GLOBAL_STATUS \| \| GLOBAL_VARIABLES \| \| KEY_COLUMN_USAGE \| \| PARTITIONS \| \| PLUGINS \| \| PROCESSLIST \| \| REFERENTIAL_CONSTRAINTS \| \| ROUTINES \| \| SCHEMATA \| \| SCHEMA_PRIVILEGES \| \| SESSION_STATUS \| \| SESSION_VARIABLES \| \| STATISTICS \| \| TABLES \| \| TABLE_CONSTRAINTS \| \| TABLE_PRIVILEGES \| \| TRIGGERS \| \| USER_PRIVILEGES \| \| VIEWS \| \| innodb_zip_reset \| \| innodb_trx \| \| innodb_locks \| \| innodb_lock_waits \| \| innodb_zip \| +---------------------------------------+	18 years ago
marko	f1c8ace241	branches/zip: trx_undo_rec_get_partial_row(): When reading an externally stored column, subtract UNIV_EXTERN_STORAGE_FIELD from the length of the field.	18 years ago
marko	e95893151b	branches/zip: Merge 2015:2093 from trunk.	18 years ago
vasil	5cbf4e3840	branches/zip: Implement a limit on the memory used by the INNODB_TRX, INNODB_LOCKS and INNODB_LOCK_WAITS tables. The maximum allowed memory is defined with the macro TRX_I_S_MEM_LIMIT. Approved by: Marko (via IM)	18 years ago
marko	7be8ffc2c6	branches/zip: Introduce the function page_zip_fail_func() and the wrapper macro page_zip_fail() for displaying error messages. When the error output is enabled (at compile-time), a breakpoint may be set in page_zip_fail_func to easily debug all decompression errors in the context where they occur.	18 years ago
vasil	6162deb677	branches/zip: Remove unnecessary code. Environment variables are passed to children anyway, no need to export them. Approved by: Sunny (via IM)	18 years ago
vasil	13c99e8bc1	branches/zip: Fix typos in comment.	18 years ago
sunny	cbe16b8704	branches/zip: Minor fix, remove the constant, calculate the length of string dynamically.	18 years ago
sunny	85ba4bd6b2	branches/zip: Change directory to one level up if export.sh script run from within the scripts/ directory, so that the relative paths work. This change was required because the script was moved from the top-level directory to its sub-directory scripts/.	18 years ago
sunny	ce4099878b	branches/zip: Add plugin build scripts, move export.sh to the scripts/ directory	18 years ago
marko	8822b4f94f	branches/zip: btr_cur_pessimistic_insert(): For clarity, use return(DB_...) instead of assigning err = DB_... when possible.	18 years ago
marko	58bea7acaf	branches/zip: Undo r2079 and fix the cause of uninitialized data bytes in page_zip_decompress(). page_zip_decompress_clust(), page_zip_decompress_clust_ext(): Zero-fill the columns DB_TRX_ID and DB_ROLL_PTR on the uncompressed page.	18 years ago
marko	97a03baf41	branches/zip: page_zip_decompress(): Note that the uncompressed page may contain uninitialized bytes when the space of a deleted record is reused by a shorter record.	18 years ago
marko	51d5187137	branches/zip: Remove __attribute__((warn_unused_result)), because it does not work in GCC 3.3. It was useful during the development of zip compression, when some placeholder code ignored the return values of some functions.	18 years ago
vasil	e7c63e2c15	branches/zip: Add the query in information_schema.innodb_trx.trx_query. Add it even though it is available in information_schema.processlist.info to make inconsistencies between those two tables obvious. It is rather confusting to see a transaction shown in innodb_trx and innodb_locks that holds a lock on one table and the corresponding query in processlist executing INSERT on another table. We do not want users to contact us asking to explain that. It is caused by the fact that the data for innodb_* tables and processlist is fetched at different time. Approved by: Marko	18 years ago
vasil	e3c2d27143	branches/zip: Fix comment: sync variable name in comment with the actual variable name.	18 years ago
vasil	8424daa64b	branches/zip: Add mysql_addons.(cc\|h) to Makefile.am, forgotten in r2072. Pointyhat to: Vasil	18 years ago
marko	96c6fe18b1	branches/zip: Improve Valgrind instrumentation. page_zip_get_trailer_len(), page_zip_write_header(): Correct the UNIV_MEM_ASSERT_RW() assertions. page_zip_validate(): Read the validity bits of page, page_zip, and page_zip->data.	18 years ago
marko	cf7d407119	branches/zip: Improve Valgrind instrumentation. page_zip_decompress(): Assert that the uncompressed page is completely defined. page_zip_validate(): Assert that the compressed and uncompressed pages are completely defined. Fetch the "valid" bits, so that they can be examined when run under valgrind --db-attach=yes.	18 years ago
vasil	193e2376b1	branches/zip: Introduce a generic soultion to the common problem that MySQL do not add functions needed by us in a reasonable time. Start with a function that retrieves THD::thread_id, this is needed for the information_schema.innodb_trx.mysql_thread_id column. Approved by: Marko	18 years ago
marko	23d99475e0	branches/zip: row_insert_for_mysql(), row_update_for_mysql(), row_prebuilt_free(): Add UNIV_UNLIKELY hints around tests for ROW_PREBUILT_OBSOLETE and some other tests.	18 years ago
marko	98546caa6f	branches/zip: page_zip_apply_log(): Write the status bits of the record before invoking rec_get_offsets().	18 years ago
marko	9a9a952c37	branches/zip: Return a meaningful error message when refusing to create a compressed table in the system tablespace. db0err.h: Introduce the error code DB_TABLE_ZIP_NO_IBD. Replace the #define directives with an enum, to ease future code merges. These error codes are never written out to files or displayed to the user. Thus they need not remain constant. dict_build_table_def_step(): Return DB_TABLE_ZIP_NO_IBD instead of DB_ERROR. create_table_def(): Report ER_ILLEGAL_HA_CREATE_OPTION "KEY_BLOCK_SIZE" when the table creation fails with DB_TABLE_ZIP_NO_IBD.	18 years ago
marko	2a106e0f3a	branches/zip: Deny non-superuser access to the INFORMATION_SCHEMA tables INNODB_ZIP and INNODB_ZIP_RESET.	18 years ago
vasil	f0e3f1f3fe	branches/zip: Bugfix: In row_raw_format() - fix the return value when printing in hex; do not forget to count the 2 extra characters "0x" that we wrote at the beginning of the output.	18 years ago
vasil	1482a2d223	branches/zip: Deny access to TRX INFORMATION_SCHEMA tables to non-superusers. Approved by: Marko	18 years ago
marko	680586464e	branches/zip: btr_cur_pessimistic_update(): After btr_cur_pessimistic_insert(), update page_zip, because rec may be on a different page.	18 years ago
marko	d03bdd38bc	branches/zip: btr_free_externally_stored_field(): Clear rec_zip_size when rec == NULL.	18 years ago
marko	4b23d55164	branches/zip: page_zip_compress(): Do not call deflate(&c_stream, Z_FULL_FLUSH) unless more than 6 bytes are available for the output. This should remove the possibility that deflate() returns Z_OK without consuming all input.	18 years ago
marko	a8635f7e29	branches/zip: buf_page_get_gen(): Ignore "guess" if it does not point to buf_pool->chunks[]->blocks[]. buf_block_is_uncompressed(): New function, to detect if a block points to buf_pool->chunks[]->blocks[].	18 years ago

1 2 3 4 5 ...

923 Commits (06299dddd480649c5c6d3f6f21873b17713451db) All Branches Search

923 Commits (06299dddd480649c5c6d3f6f21873b17713451db)

All Branches