mariadb

Tree: 00b70bbb51

Author	SHA1	Message	Date
Marko Mäkelä	00b70bbb51	Merge 10.2 into 10.3	4 years ago
Marko Mäkelä	7ab3db142b	MDEV-27913 fixup: sys_vars.sysvars_innodb result	4 years ago
Thirunarayanan Balathandayuthapani	a76731e1a1	MDEV-27913 innodb_ft_cache_size max possible value (80000000) is too small for practical purposes - Make innodb_ft_cache_size & innodb_ft_total_cache_size are dynamic variable and increase the maximum value of innodb_ft_cache_size to 512MB for 32-bit system and 1 TB for 64-bit system and set innodb_ft_total_cache_size maximum value to 1 TB for 64-bit system. - Print warning if the fts cache exceeds the innodb_ft_cache_size and also unlock the cache if fts cache memory reduces less than innodb_ft_cache_size.	4 years ago
Julius Goryavsky	a3da3c8a0b	MDEV-26377: Stricter validation of ssl-mode values This commit adds validation of the values of the ssl-mode parameter in SSL scripts, since now only a basic check for the presence of the "VERIFY_" prefix is performed there to detect "VERIFY_IDENTITY" and "VERIFY_CA", but all other values are not checked at all. In addition, this commit removes leading and trailing spaces from parameter values that SST scripts read from configuration files or from the command line so that they do not interfere with parameter checks and substitutions. Parameter substitution has been made more robust against characters in strings that the shell might erroneously interpret as regexp.	4 years ago
Marko Mäkelä	8b7abe21e0	MDEV-23888 fixup: GCC 12 -Wunused-value	4 years ago
Julius Goryavsky	fac9224d85	MDEV-27777: Some Galera tests fail on FreeBSD This commit fixes problems due to bugs and quirks in bsdtar (the FreeBSD version of tar). Separate tests are not required, because without these fixes, many other tests fail when tested in the FreeBSD environment. Also, the grep patterns for reading utility version numbers has been made more robust. The notation of some options of the "cut" utility has been changed.	4 years ago
Julius Goryavsky	17e0f5224c	MDEV-27524: Incorrect binlogs after Galera SST using rsync and mariabackup This commit adds correct handling of binlogs for SST using rsync or mariabackup. Before this fix, binlogs were handled incorrectly - - only one (last) binary log file was transferred during SST, which then led to various failures (for example, when trying to list all events from the binary log). These bugs were long masked by flaws in the primitive binlogs handling code in the SST scripts, which causing binary logs files to be erased after transfer or not added to the binlog index on the joiner node. Now the correct transfer of all binary logs (not just the last of the binary log files) has been implemented both for the rsync (at the script level) and for the mariabackup (at the level of the main utility code). This commit also adds a new sst_max_binlogs=<n> parameter, which can be located in the [sst] section or in the [xtrabackup] section (historically, supported for mariabackup only, not for rsync), or in one of the server sections. This parameter specifies the number of binary log files to be sent to the joiner node during SST. This option is added for compatibility with old SST scripting behavior, which can be emulated by setting the sst_max_binlogs=1 (although in general this can cause problems for the reasons described above). In addition, setting the sst_max_binlogs=0 can be used to suppress the transmission of binary logs to the joiner nodes during SST (although sometimes a single file with the current binary log can still be transmitted to the joiner, even with sst_max_binlogs=0, because this sometimes necessary in modes that involve the use of GTIDs with Galera). Also, this commit ensures correct handling of paths to various innodb files and directories in the SST scripts, and fixes some problems with this that existed in mariabackup utility (which were associated with incorrect handling of the innodb_data_dir parameter in some scenarios). In addition, this commit contains the following enhancements: 1) Added tests for mtr, which check the correct work with binlogs after SST (using rsync and mariabackup); 2) Added correct handling of slashes at the end of all paths that the SST script receives as parameters; 3) Improved parsing code for --mysqld-args parameters. Now it correctly processes the sequence "--" after the name of the one-letter option; 4) Checking the secret signature during joiner authentication is made independent of presence of bash (as a unix shell) in the system and diff utility no longer needed to check certificates compliance; 5) All directories that are necessary for the correct placement of various logs are automatically created by SST scripts in advance (before running mariabackup on the joiner node); 6) Removal of old binary logs on joiner is done using the binlog index (if it exists) (not only by fixed pattern that based on the current binlog name, as before); 7) Paths for placing binary logs are correctly processed if they are set as relative paths (to the datadir); 8) SST scripts are made even more resistant to spaces in filenames (now for binlogs); 9) In case of failure, SST scripts now always end with an exit code other than zero; 10) SST script for rsync now correctly create a tar file with the binlogs, even if the paths to them (in the binlog index file) are specified as a mix of absolute and relative paths, and even if they do not match with the datadir path specified in the current configuration settings.	4 years ago
Julius Goryavsky	571eb9d775	mariabackup: cosmetic changes (whitespaces and indentation)	4 years ago
Julius Goryavsky	c753b3f6f8	MDEV-27534: mariabackup: missing line in the compress_qpress.result This commit adds the missing line to the .result file for compress_qpress (in the mariabackup test suite).	4 years ago
Varun Gupta	647e952315	MDEV-15208: server crashed, when using ORDER BY with window function and UNION (Edits by SergeiP: fix encryption.tempfiles_encrypted, re-word comment) Global ORDER BY clause of a UNION may not refer to 1) aggregate functions or 2) window functions. setup_order() checked for #1 but not for #2.	5 years ago
Varun Gupta	942a9791b2	MDEV-15208: server crashed, when using ORDER BY with window function and UNION SELECTs inside a UNION can have window function but not the global ORDER BY clause of the UNION.	5 years ago
Sergei Petrunia	d140d27624	MDEV-22377: Subquery in an UPDATE query uses full scan instead of range [Patch idea by Igor Babaev] Symptom: for IN (SELECT ...) subqueries using IN-to-EXISTS transformation, the optimizer was unable to make inferences using multiple equalities. The cause is code Item_in_subselect::inject_in_to_exists_cond() which may break invariants that Multiple-Equality code relies on. In particular, it may produce a WHERE condition with an empty Item_cond::m_cond_equal. Fixed this by making Item_cond::m_cond_equal.	4 years ago
Vlad Lesin	a6f258e47f	MDEV-20605 Awaken transaction can miss inserted by other transaction records due to wrong persistent cursor restoration Backported from 10.5 `20e9e804c1` and `5948d7602e`. sel_restore_position_for_mysql() moves forward persistent cursor position after btr_pcur_restore_position() call if cursor relative position is BTR_PCUR_ON and the cursor points to the record with NOT the same field values as in a stored record(and some other not important for this case conditions). It was done because btr_pcur_restore_position() sets page_cur_mode_t mode to PAGE_CUR_LE for cursor->rel_pos == BTR_PCUR_ON before opening cursor. So we are searching for the record less or equal to stored one. And if the found record is not equal to stored one, then it is less and we need to move cursor forward. But there can be a situation when the stored record was purged, but the new one with the same key but different value was inserted while row_search_mvcc() was suspended. In this case, when the thread is awaken, it will invoke sel_restore_position_for_mysql(), which, in turns, invoke btr_pcur_restore_position(), which will return false because found record don't match stored record, and sel_restore_position_for_mysql() will move forward cursor position. The above can lead to the case when awaken row_search_mvcc() do not see records inserted by other transactions while it slept. The mtr test case shows the example how it can be. The fix is to return special value from persistent cursor restoring function which would notify its caller that uniq fields of restored record and stored record are the same, and in this case sel_restore_position_for_mysql() don't move cursor forward. Delete-marked records are correctly processed in row_search_mvcc(). Non-unique secondary indexes are "uniquified" by adding the PK, the index->n_uniq should then be index->n_fields. So there is no need in additional checks in the fix. If transaction's readview can't see the changes made in secondary index record, it requests clustered index record in row_search_mvcc() to check its transaction id and get the correspondent record version. After this row_search_mvcc() commits mtr to preserve clustered index latching order, and starts mtr. Between those mtr commit and start secondary index pages are unlatched, and purge has the ability to remove stored in the cursor record, what causes rows duplication in result set for non-locking reads, as cursor position is restored to the previously visited record. To solve this the changes are just switched off for non-locking reads, it's quite simple solution, besides the changes don't make sense for non-locking reads. The more complex and effective from performance perspective solution is to create mtr savepoint before clustered record requesting and rolling back to that savepoint after that. See MDEV-27557. One more solution is to have per-record transaction id for secondary indexes. See MDEV-17598. If any of those is implemented, just remove select_lock_type argument in sel_restore_position_for_mysql().	4 years ago
Marko Mäkelä	b9ee26e9f4	MDEV-27550: Disable galera.MW-328D (cherry picked from commit `66465914c1`)	4 years ago
Vlad Lesin	5f001bd7b8	MDEV-27025 insert-intention lock conflicts with waiting ORDINARY lock The code was backported from 10.5 `be8113861c` commit. See that commit message for details.	4 years ago
Vladislav Vaintroub	24ec144c63	MDEV-27901 Windows : expensive system calls used to calculate file system block size The result is not used anywhere but in the output of Innodb information schema, but this can take as much as 7%CPU (only) on a benchmark. Fix to move fs blocksize calculate to where it is used.	4 years ago
Nayuta Yanagisawa	66f55a018b	MDEV-27730 Add PLUGIN_VAR_DEPRECATED flag to plugin variables The sys_var class has the deprecation_substitute member to mark the deprecated variables. As it's set, the server produces warnings when these variables are used. However, the plugin has no means to utilize that functionality. So, the PLUGIN_VAR_DEPRECATED flag is introduced to set the deprecation_substitute with the empty string. A non-empty string can make the warning more informative, but there's no nice way seen to specify it, and not that needed at the moment.	4 years ago
Vladislav Vaintroub	4e667b9638	MDEV-27877 considerably speed up innodb_force_recovery test decrease innodb_lock_wait_timeout for the current session.	4 years ago
Marko Mäkelä	5b237e5965	Merge 10.2 into 10.3	4 years ago
Marko Mäkelä	73c391afc5	MDEV-27583 InnoDB uses different constants for FK cascade error message in SQL vs error log convert_error_code_to_mysql(): Use the correct limit FK_MAX_CASCADE_DEL in the error message. The DICT_FK_MAX_RECURSIVE_LOAD applies to the number of foreign key constraints in table definitions, not to the number of rows that are visited while processing a foreign key constraint.	4 years ago
Marko Mäkelä	da64e503fb	MDEV-27722 innodb_fts.innodb-fts-ddl fails with a wrong message on FreeBSD On FreeBSD, the error message would say "Resource deadlock avoided". Let us simply replace the error message string in the test.	4 years ago
Jonathan Sabbe	9f429a2dd1	fix: Fix 'unknown type usermodehelper_t' issue after upgrading to MariaDB 10.4.24	4 years ago
forkfun	e195685ce6	MDEV-27548 session_tracker_last_gtid.test fails with --repeat, added cleanup after the test	4 years ago
Monty	0a92ef458b	MDEV-17223 Assertion `thd->killed != 0' failed in ha_maria::enable_indexes MDEV-22500 Assertion `thd->killed != 0' failed in ha_maria::enable_indexes For MDEV-17223 the issue was an assert that didn't take into account that we could get duplicate key errors when enablling unique indexes. Fixed by not retrying repair in case of duplicate key error for this case, which avoids the assert. For MDEV-22500 I removed the assert, as it's not critical (just a way to find potential wrong code) and we will anyway get things logged in the error log if this happens. This case cannot triggered an assert in 10.3 but I verified that it would trigger in 10.5 and that this patch fixes it.	4 years ago
Marko Mäkelä	cf574cf53b	MDEV-27634 innodb_zip tests failing on s390x Some GNU/Linux distributions ship a zlib that is modified to use the s390x DFLTCC instruction. That modification would essentially redefine compressBound(sourceLen) as (sourceLen * 16 + 2308) / 8 + 6. Let us relax the tests for InnoDB ROW_FORMAT=COMPRESSED to cope with such a weaker compression guarantee. create_table_info_t::row_size_is_acceptable(): Remove a bogus debug-only assertion that would fail to hold for the test innodb_zip.bug36169. The function page_zip_empty_size() may indeed return 0.	4 years ago
Lena Startseva	6c3f1f661c	MDEV-27691: make working view-protocol Added ability to disable/enable (--disable_view_protocol/--enable_view_protocol) view-protocol in tests. When the option "--disable_view_protocol" is used util connections are closed. Added new test for checking view-protocol	4 years ago
Brandon Nesterenko	cdf19cd618	MDEV-16091: Seconds_Behind_Master spikes to millions of seconds The rpl.rpl_seconds_behind_master_spike test would sometimes timeout or take a very long time to complete. This happened because an MTR DEBUG_SYNC signal would be lost due to a subsequent call to RESET. I.e., the slave SQL thread would be paused due to the WAIT_FOR signal being lost, resulting in either a failed test if the `select master_pos_wait` timeout occurs first, or a very long run-time if the DBUG_SYNC timeout occurs first. The fix ensures that the MTR signal is processed by the slave SQL thread before issuing the call to RESET Reviewed By: ============ Andrei Elkin <andrei.elkin@mariadb.com>	4 years ago
Ustun Ozgur	b557f26309	Fix typo in mysqadmin manpage	4 years ago
Marko Mäkelä	e928fdbff1	Merge 10.2 into 10.3	4 years ago
Marko Mäkelä	a6ef239b9e	MariaDB 10.3.34 release -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF39AEP5WyjM2MAMF8WVvJMdM0dgFAmIIFeIACgkQ8WVvJMdM 0divQxAAzNA4EsoHo4nYyUqGiz+5VWzyVaiNpAD4GRIzv1UxaGTZpLEu5jz6tmnr CIeltG0/QW3870oTtWs38TUgc6Yzcn1wWAYHzdErBdoP8QEBR4b4jnEIuB2DF94M mGExiZDnIvmdGelfOolCz9/WKzFNJm8hCK1T+wZ6YKPGsw0YDypcYcEgCLAqvV35 pAn6AzbBJny0a6qTbjUp0XzOcBbxssHX/PBYMwdM6xq+26ndJNLZm16VUKvKFYU4 tsFFVNSFboxSPzUyc4c/SrGtW2LFi3TZfuqy51c0PXEiQ007tYE726m9w5oiykXz BPRVsvO2dax6AsXdX/jVPXafUVAzqn2Xu6bl4URkcT78rR3xJOsxalim7FnQFEoV KjaGZ3WCSPqcTw5vaTIy5CVF4CfSdAmOBFHUSXebsOkGhP8AFsiO65U9/FRxxwGP Xm3BRyUcCJvNMVKQVlvJ0Siy8Ir4swgC5ZgVwPkvaAEnq3jK0p1D1YRAXumKPtSV Ame7T8Gt3iNdqSCDTR5BQbTfAaNfqJvWuBAl7J28u89mJnTC+9YgO/Oks/l9WLdy Aoh20dLc5ycT//vWVrJhZp1l0tS5qGUojcxx6WW4dktboXn+UKXmwqBOsrL3Urj9 X77L0Z4y23259IV5kUWJm7uQ2ReHy6tX03+ILM6Lww/W7GH+L3o= =AmK6 -----END PGP SIGNATURE----- Merge mariadb-10.3.34 into 10.3	4 years ago
Daniel Bartholomew	e777645d48	bump the VERSION	4 years ago
Daniel Bartholomew	e50421be21	bump the VERSION	4 years ago
Marko Mäkelä	1a7573d5a5	Disable innodb_gis.rtree_compress2	4 years ago
Vlad Lesin	3b10e8f80c	MDEV-27746 Wrong comparision of BLOB's empty preffix with non-preffixed BLOB causes rows count mismatch for clustered and secondary indexes during non-locking read row_sel_sec_rec_is_for_clust_rec() treats empty BLOB prefix field in secondary index as a field equal to any external BLOB field in clustered index. Row_sel_get_clust_rec_for_mysql::operator() doesn't zerro out clustered record pointer in row_search_mvcc(), and row_search_mvcc() thinks that delete-marked secondary index record has visible for "CHECK TABLE"'s read view old-versioned clustered index record, and row_scan_index_for_mysql() counts it as a row. The fix is to execute row_sel_sec_rec_is_for_blob() in row_sel_sec_rec_is_for_clust_rec() if clustered field contains BLOB's reference.	4 years ago
Sergei Golubchik	a36fc80aeb	Merge branch '10.2' into 10.3	4 years ago
Sergei Petrunia	3a52569499	MDEV-25636: Bug report: abortion in sql/sql_parse.cc:6294 The asserion failure was caused by this query select /id=1/ from t1 where col= ( select /id=2/ from ... where corr_cond1 union select /id=4/ from ... where corr_cond2) Here, - select with id=2 was correlated due to corr_cond1. - select with id=4 was initially correlated due to corr_cond2, but then the optimizer optimized away the correlation, making the select with id=4 uncorrelated. However, since select with id=2 remained correlated, the execution had to re-compute the whole UNION. When it tried to execute select with id=4, it hit an assertion (join buffer already free'd). This is because select with id=4 has freed its execution structures after it has been executed once. The select is uncorrelated, so it did not expect it would need to be executed for the second time. Fixed this by adding this logic in st_select_lex::optimize_unflattened_subqueries(): If a member of a UNION is correlated, mark all its members as correlated, so that they are prepared to be executed multiple times.	4 years ago
Sergei Golubchik	9e2c26b0f6	MDEV-26351 segfault - (MARIA_HA *) 0x0 in ha_maria::extra don't let Aria create a table that it cannot open	4 years ago
Sergei Golubchik	1b8bb44106	MDEV-26351 segfault - (MARIA_HA *) 0x0 in ha_maria::extra use the correct check. before invoking handler methods we need to know that the table was opened, not only created.	4 years ago
Oleksandr Byelkin	0168d1eda3	MDEV-25766 Unused CTE lead to a crash in find_field_in_tables/find_order_in_list Do not assume that subquery Item always present.	4 years ago
Monty	ad1fb06982	MDEV-27789 mysql_upgrade / mariadb-upgrade in 10.6.6 is putting password in host argument Removed all dependencies of command line arguments based on positions in an array (this kind of code should never have been written). Instead use option names, which are stable. Reviewer: Sergei Golubchik	4 years ago
Oleksandr Byelkin	e352444558	Merge branch '10.3' into bb-10.3-release	4 years ago
Oleksandr Byelkin	941bc70536	Merge branch '10.2' into bb-10.2-release	4 years ago
Daniel Bartholomew	30cc63fa1a	bump the VERSION	4 years ago
Daniel Bartholomew	c0a44ff7f1	bump the VERSION	4 years ago
Vladislav Vaintroub	ae33a006f7	MDEV-27738 Windows : mysql-test-run --extern does not work Use portable quoting in mtr_add_arg.	4 years ago
Teemu Ollakka	21413aee0a	MDEV-27737 Wsrep SST scripts not working on FreeBSD - Changed SST scripts to use /usr/bin/env bash instead of /bin/bash for better portability. - Fixed use of mktemp on non-Linux platforms to produce temporary file instead of directory. Reviewed-by: Jan Lindström <jan.lindstrom@mariadb.com>	4 years ago
Sergei Petrunia	5c89386fdb	MDEV-17785: Window functions not working in ONLY_FULL_GROUP_BY mode (Backport Varun Gupta's patch + edit the commit comment) Name resolution code produced errors for valid queries with window functions (but not for queries which used aggregate functions as window functions). Name resolution code worked incorrectly, because window function objects had is_window_func_sum_expr()=false. This was so, because mark_as_window_func_sum_expr() was only called for aggregate functions used as window functions. The fix is to call it for any window function.	4 years ago
Andrei	e53199e76b	MDEV-27721 rpl.rpl_relay_max_extension test is not FreeBSD-compatible Fixed the test to execute only on linux as it depends on unportable sed.	4 years ago
Oleksandr Byelkin	41a163ac5c	Merge branch '10.2' into 10.3	4 years ago
Sergei Golubchik	e2b50213cf	main.events_embedded test failures in buildbot revert `68b3fa8865`	4 years ago

1 2 3 4 5 ...

188883 Commits (00b70bbb51b9f2a3646c1ceedc6a27eeb1bdd6ac) All Branches Search

188883 Commits (00b70bbb51b9f2a3646c1ceedc6a27eeb1bdd6ac)

All Branches