mariadb

Branch: 10.6

Author	SHA1	Message	Date
Daniel Black	a1bba0e31c	MDEV-36482: Make liburing work WITH_MSAN=ON (fix) The uring_ member of the aio_uring class needed to be defined to make MSAN happy. To make aio_uring consistent with aio_libaio in the 10.11 branch, added the "using namespace tpool" and removed tpool scoped quantifiers. 10.6 aio_uring is defined in the tpool namespace however changing that would just cause merge conflicts.	2 months ago
Daniel Black	2c30f92dd3	MDEV-36482: Make liburing work WITH_MSAN=ON A read from liburing has its output buffer as defined by the nature of the system call. Instrumenting the library proved difficult as the completion events don't include the opcode or pointers that where there on submission. It was just easier to do this in the application code.	3 months ago
Marko Mäkelä	3c67d73aad	MDEV-36482: Make libaio work WITH_MSAN=ON As noted in commit `c36834c832` the MemorySanitizer instrumented builds so far only work with the synchronous I/O interface (innodb_use_native_aio=OFF). It is not that hard to make WITH_MSAN=ON work with the Linux libaio, without even instrumenting that library itself. aio_linux::getevent_thread_routine(): Declare the buffer that is returned by my_getevents() as initialized. Declare the data returned by a successful aio_opcode::AIO_PREAD as initialized. Reviewed by: Daniel Black	4 months ago
Daniel Black	839e8bfe9f	MDEV-36182: liburing - incorrect error handing. As noted by Jens Axobe, errno isn't set, it is returned by the io_uring_queue_init function. As such users where getting the following as the common case when EPERM was actually intended to be returned. "mariadbd: io_uring_queue_init() failed with errno 0". Add to error message the correct relevant information around EPERM.	6 months ago
Daniel Black	73cdeda347	tpool: remove m_group_enqueued (unused) Noted in MDEV-36542 that it wasn't used and the compile warning -Wunused-private-field is legitimate. Review: Vladislav Vaintroub	6 months ago
Vladislav Vaintroub	a2f510fccf	MDEV-33978 P_S.THREADS is not showing all server threads This patch only makes sure Linux getevents thread is shown in PS	10 months ago
Vladislav Vaintroub	d64034770e	MDEV-35273 tpool::worker_data - replace MY_ALIGNED with pad member	12 months ago
Daniel Black	d472391471	tpool: correct LIBAIO_REQIRED typo Noticed thanks to Razvan Liviu Varzaru	1 year ago
Dave Gosselin	db0c28eff8	MDEV-33746 Supply missing override markings Find and fix missing virtual override markings. Updates cmake maintainer flags to include -Wsuggest-override and -Winconsistent-missing-override.	1 year ago
Marko Mäkelä	c849952b71	MDEV-33840: Fix GCC -Wreorder This fixes up the merge commit `829cb1a49c`	1 year ago
mariadb-DebarunBanerjee	52f6df99ed	MDEV-33669 mariabackup --backup hangs This is a server hang and not an issue with backup. While concurrent DDLs in server gets in hanged state, mariabackup waits for DDLs to finish trying to acquire MDL_BACKUP_BLOCK_DDL. The server hang is serious in nature and caused by thread pool state being incorrectly set to thread creation pending state while no creation is actually pending. Once a thread pool reaches such state no new thread gets created in the pool. While it could possibly affect all thread pools in server, the innodb thread pool is the victim in current bug where IO job gets blocked when the pool is stuck with much less number of threads than intended. Available workers are blocked in purge waiting for page lock to be released by IO write (SX lock) causing a complete deadlock. The issue is caused by the state variable m_thread_creation_pending introduced by MDEV-31095: `9e62ab7aaf`. We check and set the variable early while attempting to create a new thread in pool but fail to reset it if we exit the flow for other reasons like maximum threads reached or get into thread creation throttling path. Fix: The simple fix is to make sure that the state is reset back in case we don't actually attempt to create the thread.	2 years ago
Vladislav Vaintroub	f6e9600f42	MDEV-33840 tpool- switch to longer maintainence timer interval, if pool is idle Previous solution, that would entirely switch timer off, turned out to be deadlock prone. This patch fixed previous attempt to switch between long/short interval periods in MDEV-24295. Now, initial state of the timer is fixed (it is ON). Also, avoid switching timer to longer periods if there is any activity in the pool.	2 years ago
Vladislav Vaintroub	2ba79aba2b	Revert "MDEV-33840 tpool : switch off maintenance timer when not needed." This reverts commit `09bae92c16`.	2 years ago
Vladislav Vaintroub	09bae92c16	MDEV-33840 tpool : switch off maintenance timer when not needed. Before patch, maintenance timer will tick every 0.4 seconds. After this patch, timer will tick every 0.4 seconds when necessary( there are delayed thread creation), switching off completely after 20 seconds of being idle.	2 years ago
Marko Mäkelä	78c9a12c8f	MDEV-32861 InnoDB hangs when running out of I/O slots When the constant OS_AIO_N_PENDING_IOS_PER_THREAD is changed from 256 to 1 and the server is run with the minimum parameters innodb_read_io_threads=1 and innodb_write_io_threads=2, two hangs were observed. tpool::cache<T>::put(T*): Ensure that get() in io_slots::acquire() will be woken up when the cache previously was empty. buf_pool_t::io_buf_t::reserve(): Schedule a possibly partial doublewrite batch so that os_aio_wait_until_no_pending_writes() has a chance of returning. Add a Boolean parameter and pass wait_for_reads=false inside buf_page_decrypt_after_read(), because those calls will be executed inside a read completion callback, and therefore os_aio_wait_until_no_pending_reads() would block indefinitely.	2 years ago
Vladislav Vaintroub	9e62ab7aaf	MDEV-31095 tpool - do not create new worker, if thread creation is pending. Use an std::atomic_flag to track thread creation in progress. This is mainly a cleanup, the effect of this change was not measureable in my tests.	3 years ago
Vladislav Vaintroub	e33e2fa949	MDEV-31095 tpool - restrict threadpool concurrency during bufferpool load Add threadpool functionality to restrict concurrency during "batch" periods (where tasks are added in rapid succession). This will throttle thread creation more agressively than usual, while keeping performance at least on-par. One of these cases is bufferpool load, where async read IOs are executed without any throttling. There can be as much as 650K read IOs for loading 10GB buffer pool. Another one is recovery, where "fake read" IOs are executed. Why there are more threads than we expect? Worker threads are not be recognized as idle, until they return to the standby list, and to return to that list, they need to acquire mutex currently held in the submit_task(). In those cases, submit_task() has no worker to wake, and would create threads until default concurrency level (2*ncpus) is satisfied. Only after that throttling would happen.	3 years ago
Marko Mäkelä	f50abab195	MDEV-31048 PERFORMANCE_SCHEMA lakcs InnoDB read_slots and write_slots tpool::cache::m_mtx: Add PERFORMANCE_SCHEMA instrumentation (wait/synch/mutex/innodb/tpool_cache_mutex). This covers the InnoDB read_slots and write_slots for asynchronous data page I/O.	3 years ago
Marko Mäkelä	a091d6ac4e	MDEV-26827 fixup: Do not duplicate io_slots::pending_io_count() os_aio_pending_reads_approx(), os_aio_pending_reads(): Replaces buf_pool.n_pend_reads. os_aio_pending_writes(): Replaces buf_dblwr.pending_writes(). buf_dblwr_t::write_cond, buf_dblwr_t::writes_pending: Remove.	3 years ago
Khem Raj	75bbf645a6	Add missing include <cstdio> This is needed with GCC 13 and newer [1] [1] https://www.gnu.org/software/gcc/gcc-13/porting_to.html Signed-off-by: Khem Raj <raj.khem@gmail.com>	3 years ago
Heiko Becker	15226a2822	Add missing include for std::runtime_error Fixes the following error when building with gcc 13: "tpool/aio_liburing.cc:64:18: error: 'runtime_error' is not a member of 'std' 64 \| throw std::runtime_error("aio_uring()");"	3 years ago
Daniel Black	fd8dbe0d2c	MDEV-29443: prevent uring access to galera sst /notify scripts The resources like uring in MariaDB aren't intended for spawned processes so we restrict access using the io_uring_ring_dontfork liburing library call.	3 years ago
Vladislav Vaintroub	a3fd9e6b06	MDEV-29367 Refactor tpool::cache Removed use std::vector's ba push_back(), pop_back() to make it more obvious that memory in the vectors won't be reallocated. Also, "borrowed" elements can be debugged a little better now, they are put into the start of the m_cache vector.	3 years ago
Vladislav Vaintroub	35f2cdcb99	MDEV-28920 Rescheduling of innodb_stats_func() missing Fixed tpool timer implementation on POSIX. Prior to this patch, under some specific rare circumstances (concurrency related), timer callback execution might be skipped.	3 years ago
Marko Mäkelä	3794673111	MDEV-28836: Memory alignment cleanup Table_cache_instance: Define the structure aligned at the CPU cache line, and remove a pad[] data member. Krunal Bauskar reported this to improve performance on ARMv8. aligned_malloc(): Wrapper for the Microsoft _aligned_malloc() and the ISO/IEC 9899:2011 <stdlib.h> aligned_alloc(). Note: The parameters are in the Microsoft order (size, alignment), opposite of aligned_alloc(alignment, size). Note: The standard defines that size must be an integer multiple of alignment. It is enforced by AddressSanitizer but not by GNU libc on Linux. aligned_free(): Wrapper for the Microsoft _aligned_free() and the standard free(). HAVE_ALIGNED_ALLOC: A new test. Unfortunately, support for aligned_alloc() may still be missing on some platforms. We will fall back to posix_memalign() for those cases. HAVE_MEMALIGN: Remove, along with any use of the nonstandard memalign(). PFS_ALIGNEMENT (sic): Removed; we will use CPU_LEVEL1_DCACHE_LINESIZE. PFS_ALIGNED: Defined using the C++11 keyword alignas. buf_pool_t::page_hash_table::create(), lock_sys_t::hash_table::create(): lock_sys_t::hash_table::resize(): Pad the allocation size to an integer multiple of the alignment. Reviewed by: Vladislav Vaintroub	3 years ago
Marko Mäkelä	db0fde3f24	MDEV-28665 aio_uring::thread_routine terminates prematurely, causing hang aio_uring::thread_routine(): Handle -EINTR from io_uring_wait_cqe() in the same way as aio_linux::getevent_thread_routine() does it: simply ignore it and invoke the system call again. Reviewed by: Vladislav Vaintroub	3 years ago
Daniel Black	6350a52445	tpool: liburing typo in error Also the ENOSYS is more likely explained by seccomp filters in containers than a pre-5.1 kernel, so include both.	4 years ago
Marko Mäkelä	2aed566d22	Cleanup: alignas(CPU_LEVEL1_DCACHE_LINESIZE) Let us replace all use of MY_ALIGNED in InnoDB with C++11 alignas. CACHE_LINE_SIZE: Replaced with CPU_LEVEL1_DCACHE_LINESIZE.	4 years ago
Sergei Golubchik	f92388fa14	MDEV-27900 fixes * prevent infinite recursion in beyond-EOF reads (when pread returns 0) * reduce code duplication followup for `d78173828e` and `f4fb6cb3fe`	4 years ago
Daniel Black	f4fb6cb3fe	MDEV-27900: aio handle partial reads/writes (uring) MDEV-27900 continued for uring. Also spell synchronously correctly in sql_parse.cc. Reviewed by Wlad.	4 years ago
Daniel Black	d78173828e	MDEV-27900: aio handle partial reads/writes As btrfs showed, a partial read of data in AIO /O_DIRECT circumstances can really confuse MariaDB. Filipe Manana (SuSE)[1] showed how database programmers can assume O_DIRECT is all or nothing. While a fix was done in the kernel side, we can do better in our code by requesting that the rest of the block be read/written synchronously if we do only get a partial read/write. Per the APIs, a partial read/write can occur before an error, so reattempting the request will leave the caller with a concrete error to handle. [1] https://lore.kernel.org/linux-btrfs/CABVffENfbsC6HjGbskRZGR2NvxbnQi17gAuW65eOM+QRzsr8Bg@mail.gmail.com/T/#mb2738e675e48e0e0778a2e8d1537dec5ec0d3d3a Also spell synchronously correctly in other files.	4 years ago
Vladislav Vaintroub	012e724deb	MDEV-27796 Windows - starting server with huge innodb-log-buffer-size may fail Fixed tpool::pread() and tpool::pwrite() to return SSIZE_T on Windows, so that huge numbers are not converted to negatives. Also, make sure to never attempt reading/writing more bytes than DWORD can accomodate (4G)	4 years ago
Marko Mäkelä	db915f7387	MDEV-27058: Move buf_page_t::slot to IORequest::slot MDEV-23855 and MDEV-23399 already moved some transient data fields from buffer pool page descriptors to IORequest, but the write buffer of PAGE_COMPRESSED or ENCRYPTED tables was missed. Since is only needed during asynchronous page write requests, it belongs to IORequest.	4 years ago
Marko Mäkelä	03e4cb2484	MDEV-24512 fixup: Remove after_task_callback In commit `ff5d306e29` we removed dbug_after_task_callback but forgot to revert the rest of commit `bada05a883`.	4 years ago
Vladislav Vaintroub	78bd7d86a4	MDEV-25953 Tpool - prevent potential deadlock in simulated AIO Do not execute user callback just after pwrite. Instead, submit user function as task into thread pool. This way, the IO thread would not hog aiocb, which is a limited (in Innodb) resource	4 years ago
Marko Mäkelä	6ba938af62	MDEV-25905: Assertion table2==NULL in dict_sys_t::add() In commit `49e2c8f0a6` (MDEV-25743) we made dict_sys_t::find() incompatible with the rest of the table name hash table operations in case the table name contains non-ASCII octets (using a compatibility mode that facilitates the upgrade into the MySQL 5.0 filename-safe encoding) and the target platform implements signed char. ut_fold_string(): Remove; replace with my_crc32c(). This also makes table name hash value calculations independent on whether char is unsigned or signed.	4 years ago
Marko Mäkelä	28e362eaca	MDEV-25760: Resubmit IO job on -EAGAIN from io_uring The server still may abort if there is no enough free space in the ring buffer to resubmit the IO job, but the behavior is equal to the failure of os_aio() -> submit_io().	4 years ago
Daniel Black	f82e69735e	io_liburing: ENOMEM handling - use io_uring_mlock_size This gives the user the size required and how to set memlock limits for the process. Thanks Jens Axboe for providing this requested interface ref: https://github.com/axboe/liburing/issues/246 Also don't put \n on my_printf_error, its implicit.	5 years ago
Vladislav Vaintroub	cb545f1116	CMake cleanup - use FIND_PACKAGE(LIBAIO) to find libaio - Use standard CMake conventions in Find{PMEM,URING}.cmake - Drop the LIB from LIB{PMEM,URING}_{INCLUDE_DIR,LIBRARIES} It is cleaner, and consistent with how other packages are handled in CMake. e.g successful FIND_PACKAGE(PMEM) now sets PMEM_FOUND, PMEM_LIBRARIES, PMEM_INCLUDE_DIR, not LIBPMEM_{FOUND,LIBRARIES,INCLUDE_DIR}. - Decrease the output. use FIND_PACKAGE with QUIET argument. - for Linux packages, either liburing, or libaio is required If liburing is installed, libaio does not need to be present . Use FIND_PACKAGE([LIBAIO\|URING] REQUIRED) if either library is required.	5 years ago
Marko Mäkelä	e8113f7572	CMake cleanup: Make WITH_URING, WITH_PMEM Boolean The new default values WITH_URING:BOOL=OFF, WITH_PMEM:BOOL=OFF imply that the dependencies are optional. An explicit request WITH_URING=ON or WITH_PMEM=ON will cause the build to fail if the requested dependencies are not available. Last, to prevent a feature to be built in even though the built-time dependencies are available, the following can be used: cmake -DCMAKE_DISABLE_FIND_PACKAGE_URING=1 cmake -DCMAKE_DISABLE_FIND_PACKAGE_PMEM=1 This cleanup was suggested by Vladislav Vaintroub.	5 years ago
Marko Mäkelä	a0558b8c96	MDEV-24883 fixup: Add a dependency In commit `783625d78f` we forgot to declare a dependency on the generated file mysqld_error.h.	5 years ago
Marko Mäkelä	783625d78f	MDEV-24883 add io_uring support for tpool liburing is a new optional dependency (WITH_URING=auto\|yes\|no) that replaces libaio when it is available. aio_uring: class which wraps io_uring stuff aio_uring::bind()/unbind(): optional optimization aio_uring::submit_io(): mutex prevents data race. liburing calls are thread-unsafe. But if you look into it's implementation you'll see atomic operations. They're used for synchronization between kernel and user-space only. That's why our own synchronization is still needed. For systemd, we add LimitMEMLOCK=524288 (ulimit -l 524288) because the io_uring_setup system call that is invoked by io_uring_queue_init() requests locked memory. The value was found empirically; with 262144, we would occasionally fail to enable io_uring when using the maximum values of innodb_read_io_threads=64 and innodb_write_io_threads=64. aio_uring::thread_routine(): Tolerate -EINTR return from io_uring_wait_cqe(), because it may occur on shutdown on Ubuntu 20.10 (Groovy Gorilla). This was mostly implemented by Eugene Kosov. Systemd integration and improved startup/shutdown error handling by Marko Mäkelä.	5 years ago
Marko Mäkelä	f24b738318	MDEV-24313 (2 of 2): Silently ignored innodb_use_native_aio=1 In commit `5e62b6a5e0` (MDEV-16264) the logic of os_aio_init() was changed so that it will never fail, but instead automatically disable innodb_use_native_aio (which is enabled by default) if the io_setup() system call would fail due to resource limits being exceeded. This is questionable, especially because falling back to simulated AIO may lead to significantly reduced performance. srv_n_file_io_threads, srv_n_read_io_threads, srv_n_write_io_threads: Change the data type from ulong to uint. os_aio_init(): Remove the parameters, and actually return an error code. thread_pool::configure_aio(): Do not silently fall back to simulated AIO. Reviewed by: Vladislav Vaintroub	5 years ago
Vladislav Vaintroub	3ee24b2306	Simplify clang workarounds.	5 years ago
Marko Mäkelä	f3a58ed801	MDEV-24295: Fix the non-clang build Sorry, only tested commit `4174fc1a1b` on clang. Other compilers do not define __has_feature().	5 years ago
Marko Mäkelä	4174fc1a1b	MDEV-24295: Fix the WITH_MSAN build For some reason, commit `5bb5d4ad3a` made clang++-11 unhappy about a constexpr declaration.	5 years ago
Vladislav Vaintroub	1435f35bda	Clarify some comments. - the intention for my_getevents syscall is now better explained, why are we using it (to be able to interrupt io_getevents syscall via io_destroy()). - Fix comment for MAX_EVENTS in getevent_thread_routine. MAX_EVENTS is more of less arbitrary constant, chosen such that events array is big enough to get multiple simultaneous io completions, but small enough so it does not blow the thread's stack.	5 years ago
Vladislav Vaintroub	5bb5d4ad3a	MDEV-24295 Reduce wakeups by tpool maintenance timer, when server is idle If maintenance timer does not do much for prolonged time, it will wake up less frequently, once every 4 seconds instead of once every 0.4 second. It will wakeup more often if thread creation is throttled, to avoid stalls.	5 years ago
Monty	279b5f87de	Avoid some DBUG prints from idle server in thread pool	5 years ago
Marko Mäkelä	f693b72547	MDEV-24270: Clarify some comments	5 years ago

1 2

85 Commits (10.6)