mariadb

Branch: 10.6

Author	SHA1	Message	Date
Daniel Black	d891d23ec3	MDEV-37724: Debug Memory leak with InnoDB ALTER TABLE ALGORITHM=INSTANT Instrumented debug mode triggering of instant_insert_fail failed to free partition memory like the que_eval_sql function who's failure it intended to emulate. Corrected by freeing the partition information when this internal debug mode instrumented condition occured.	6 days ago
Marko Mäkelä	e1f12f149c	MDEV-37626 clang -fsanitize=undefined errors in row0log.cc row_log_apply_ops(), row_log_table_apply_ops(): Instead of adding an offset to a potentially null pointer, subtract the offset from a never-null pointer and then compare to the potentially null pointer. Also, instead of adding a negative (wrapped-around) pointer offset, subtract a positive pointer offset. Reviewed by: Daniel Black	2 weeks ago
Thirunarayanan Balathandayuthapani	687b18648c	MDEV-35163 InnoDB persistent statistics fail to update after ALTER TABLE...ALGORITHM=COPY Problem: ======= - InnoDB statistics calculation for the table is done after every 10 seconds by default in background thread dict_stats_thread() - Doing multiple ALTER TABLE..ALGORITHM=COPY causes the dict_stats_thread() to lag behind, therefore calculation of stats for newly created intermediate table gets delayed Fix: ==== - Stats calculation for newly created intermediate table is made independent of background thread. After copying gets completed, stats for new table is calculated as part of ALTER TABLE ... ALGORITHM=COPY. dict_stats_rename_table(): Rename the table statistics from intermediate table to new table alter_stats_rebuild(): Removes the table name from the warning. Because this warning can print for intermediate table as well. Alter table using copy algorithm now calls alter_stats_rebuild() under a shared MDL lock on a temporary #sql-alter- table, differing from its previous use only during ALGORITHM=INPLACE operations on user-visible tables. dict_stats_schema_check(): Added a separate check for table readability before checking for tablespace existence. This could lead to detect of existence of persistent statistics storage eariler and fallback to transient statistics. This is a cherry-pick fix of mysql commit@cfe5f287ae99d004e8532a30003a7e8e77d379e3	2 weeks ago
Sergei Golubchik	764b893cb7	suppress 'InnoDB: native AIO failed' under rr	4 weeks ago
Alexey Botchkov	32c1725b1b	MDEV-35713 UBSAN: runtime error: load of value 1341112147, which is not a valid value for type 'enum enum_schema_tables' in optimize_for_get_all_tables and get_all_tables and on SELECT from I_S geometry_columns. get_schema_table_idx() returns garbage if the SCHEMA table comes from a plugin. Added specific value to reflect this.	4 weeks ago
Alexey Yurchenko	e238246872	MDEV-37494 Diagnostics_area does not always contain apply error info It appears that some error conditions don't store error information in the Diagnostics_area. For example when table_def::compatible_with() check fails error message is stored in Relay_log_info instead. This results in optimistically identical votes and zero error buffer size breaks wsrep-lib logic as it relies on error buffer size to decide whether voting took place. To account for this, first try to obtain error info from Diagnostics_area, then fallback to Relay_log_info. If that fails use some "random" data to distinguish this condition from success in production.	2 months ago
Monty	6058e02732	MDEV-37172 Server crashes in Item_func_nextval::update_table after INSERT to the table, that uses expression with nextval() as default The issue was that unpack_vcol_info_from_frm() wrongly linked the used sequence tables into tables->internal_tables when more than one sequence table was used. Other things: - Fixed internal_table_exists() to take db into account. (This is making the code easier to read. As we where comparing pointers the old code also worked).	3 weeks ago
Michael Widenius	e3e4013330	Added memory allocated by my_once_malloc() to global_memory_used	3 weeks ago
Vladislav Vaintroub	2ccf6a245f	MDEV-37483 - fix output differences Linux vs Windows in the test - Do not mix latin1 and utf8 in the test and result file. Not only it looks strange, and it does not work on Windows either. - Fix --default-character-set usage in mariadb-import. Prior to patch it was just using platform default when communicating with server. Now, it uses the charset provided by the option. - Use --default-character-set=utf8mb4 in test, to have uniform output across different OSes.	3 weeks ago
Oleksandr Byelkin	1b5fb40b6d	MDEV-32308 Server crash on cleanup of non-fully-constructed-due-to-an-error CTE Cleanup sequence comes after error state when not all units were prepared. The With_element without rec_result was created for following unit: "select 1 AS `1` union select 'x' AS x from x" the error happened in select "select x AS x" so above unit was not prepared. The case seems to be legal and the presence of rec_result must be checked during the cleanup.	2 years ago
Marko Mäkelä	16d91f87ff	MDEV-29930 Lock order inversion in ibuf_remove_free_page() The function ibuf_remove_free_page() was waiting for ibuf_mutex while holding ibuf.index->lock. This constitutes a lock order inversion and may cause InnoDB to hang when innodb_change_buffering is enabled and ibuf_merge_or_delete_for_page() is being executed concurrently. In fact, there is no need for ibuf_remove_free_page() to reacquire ibuf_mutex if we make ibuf.seg_size and ibuf.free_list_len protected by the ibuf.index->lock as well as the root page latch rather than by ibuf_mutex. ibuf.seg_size, ibuf.free_list_len: Instead of ibuf_mutex, let the ibuf.index->lock and the root page latch protect these, like ibuf.empty. ibuf_init_at_db_start(): Acquire the root page latch before updating ibuf.seg_size. (The ibuf.index would be created later.) ibuf_data_enough_free_for_insert(), ibuf_data_too_much_free(): Assert also ibuf.index->lock.have_u_or_x(). ibuf_remove_free_page(): Acquire the ibuf.index->lock and the root page latch before accessing ibuf.free_list_len. Simplify the way how the root page latch is released and reacquired. Acquire and release ibuf_mutex only once. ibuf_free_excess_pages(), ibuf_insert_low(): Acquire also ibuf.index->lock before reading ibuf.free_list_len. ibuf_print(): Acquire ibuf.index->lock before reading ibuf.free_list_len and ibuf.seg_size. Reviewed by: Vladislav Lesin Tested by: Matthias Leich	3 weeks ago
Thirunarayanan Balathandayuthapani	4dcd2d8513	MDEV-37412 Corrupted page during recovery aborts the server Problem: ======= When InnoDB encounters a corrupted page during crash recovery, server would abort due to improper handling of page locks and space references. The recovery process was not properly cleaning up resources when corruption was detected, leading to inconsistent state and server termination. Solution: ========= recover_low(): Move page lock recursive acquisition after deferred/non-deferred page creation logic to ensure consistent locking behavior for both code paths. Ensure proper block recursive unlock for non-deferred tablespaces recv_recover_page(): Simplify corrupted page cleanup by removing redundant space reference handling.	4 weeks ago
Elena Stepanova	c40402e4a9	MDEV-37618 galera.MDEV-26266 fails with ER_OPTION_PREVENTS_STATEMENT with PS protocol	4 weeks ago
Yuchen Pei	0a4315509b	MDEV-36723 Fix an MSAN caused by memcmp going over a string boundary When spider tries to find a partition matching a name passed from the sql layer, it construct the partition name with NORMAL_PART_NAME. However, the name passed from the sql layer could be constructed with other types of name, such as TEMP_PART_NAME, which is a longer string. Spider does handle TEMP_PART_NAME in other places of spider_get_partition_info, but overall it is not able to handle partition changes involving redistributing data to partitions which can result in TEMP_PART_NAME. That is a more involved issue. In this patch, we simply follow the existing intended logic and fix the MSAN complaint.	1 month ago
Sergei Golubchik	5743435954	MDEV-37397 Assertion `bitmap_is_set(&read_partitions, next->id)' failed in int partition_info::vers_set_hist_part(THD *) after `633417308f` (MDEV-37312) lookup_handler is locked with F_WRLCK, because it may be used for deleting rows. And lookup_handler is locked with F_WRLCK after prune_partitions(), but the main handler is locked before, and might expects all partitions to be in the read least, non-pruned. Let's prepare the lookup handler before prune_partitions().	1 month ago
Sergei Golubchik	ff12ec86a5	MDEV-37483 mariadb-dump -T doesn't convert table names use my_charset_filename to build file names from table names. this guarantees that file name will be always valid for any table name, no matter what characters it contains and what file name rules local filesystem has. mariadb-import now converts back, if possible.	1 month ago
Sergei Golubchik	75b000372b	cleanup: reusable build_path_for_table() function	1 month ago
Sergei Golubchik	b6445714ca	MDEV-37505 myisamchk -V crashes fix double-free in myisamchk followup for `c3578720e6`	2 months ago
Monty	8f771b28a1	MDEV-34914 maria.bulk_insert_crash fails on s390x (10.6+, Debug) This was caused by a wrong handling of bitmaps in copy_not_changed_fields() that did not work on big endian machines. This bug caused recovery of Aria files to fail on big endian machines like s390x or Sparc. This issue was noticed by the bulk_insert_crash.test on the s390x builder.	1 month ago
Marko Mäkelä	d00e0f71a4	MDEV-33817/MDEV-37170 fixup: Remove evex512 It turns out that there is no need to use the evex512 target attribute that had been introduced in GCC 14 and clang 18, and will be removed in GCC 16. At the time when the evex512 attribute was introduced, Intel had plans to release products with AVX10.1-256, supporting the AVX512 instruction set but limited to 256-bit registers. The evex512 attribute would have been needed to "opt in" to the 512-bit instruction variants (using the EVEX instruction prefix). Later on, Intel revised its plans to make AVX10.1 always 512-bit. Reviewed by: Kristian Nielsen	1 month ago
Kristian Nielsen	5487c059c6	Fix undefined behaviour in crc32_avx512() The code was mistakenly using _mm512_castsi128_si512() to convert __m128i to __m512i, which leaves the upper bits undefined. Use instead _mm512_zextsi128_si512() which zero-extends as needed. Signed-off-by: Kristian Nielsen <knielsen@knielsen-hq.org>	1 month ago
Daniel Black	a1bba0e31c	MDEV-36482: Make liburing work WITH_MSAN=ON (fix) The uring_ member of the aio_uring class needed to be defined to make MSAN happy. To make aio_uring consistent with aio_libaio in the 10.11 branch, added the "using namespace tpool" and removed tpool scoped quantifiers. 10.6 aio_uring is defined in the tpool namespace however changing that would just cause merge conflicts.	1 month ago
Marko Mäkelä	8761047e11	Work around MDEV-37478 THD::get_net_wait_timeout(): Silence GCC -Wconversion by an explicit conversion from ulong (64 or 32 bits) to uint (32 bits).	1 month ago
Marko Mäkelä	6bf1ed55e6	MDEV-37477: decimal_digits_t trips GCC -Wconversion In commit `fa7d4abf16` when the 16-bit type alias decimal_digits_t was introduced, some incompatible use of the 32-bit uint data type was overlooked. Only for converting Item_result_field::max_length (uint), we will use explicit conversion.	1 month ago
Daniel Black	2c30f92dd3	MDEV-36482: Make liburing work WITH_MSAN=ON A read from liburing has its output buffer as defined by the nature of the system call. Instrumenting the library proved difficult as the completion events don't include the opcode or pointers that where there on submission. It was just easier to do this in the application code.	3 months ago
Marko Mäkelä	1d84cb272f	Fix clang-21 -Wunnecessary-virtual-specifier Member functions of a final class cannot be virtual.	1 month ago
Marko Mäkelä	4ba12910fc	Fix clang-21 -Wignored-attributes void __attribute__((unused)) never made any sense.	1 month ago
Marko Mäkelä	4f7a5f7477	Fix clang-21 -Wuninitialized-const-pointer pfs_get_thread_file_name_locker_v1(): Note that the last parameter is unused. Let us pass it as NULL to avoid the warning.	1 month ago
Alexey Yurchenko	8dae7150b2	MTR test to verify that Galera gcs.stateless flag works Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	7 months ago
Julius Goryavsky	03ae1f5ab3	Continuation of previous FreeBSD-related fix for Galera SST scripts Paths are set to "canonical" form and historical practice where /lib comes before /usr/lib and /bin comes before /usr/bin. This eliminates the need to skip setting LD_LIBRARY_PATH for FreeBSD, which may help those users whose LD_LIBRARY_PATH is not configured properly.	2 months ago
Florian Smeets	b5d79b86b2	Fix bootstrapping Galera nodes on FreeBSD 15.0 Bootstrapping nodes on FreeBSD 15.0 with mariadb-backup currently broken. We should not need LD_LIBRARY_PATH trickery on FreeBSD, so skip setting it same as on Darwin. Alternatively putting /lib before /usr/lib also fixes it. WSREP_SST: [INFO] Preparing the backup at /var/db/mysql/.sst (20250608 14:44:04.000) WSREP_SST: [INFO] Evaluating /usr/local/bin/mariadb-backup --prepare ...... WSREP_SST: [ERROR] Cleanup after exit with status: 1 (20250608 14:44:04.000) With the following error in /var/db/mysql/mariabackup.prepare.log: ld-elf.so.1: /usr/local/bin/mariadb-backup: Undefined symbol "_ZNSt3__117bad_function_callD1Ev" I did not look for the root cause in FreeBSD 15.0 that changed this behaviour. Calling mariadb-backup directly from the shell works fine on FreeBSD 14.x and 15.x when LD_LIBRARY_PATH is not set (when using FreeBSD packages or installing from FreeBSD ports). Setting LD_LIBRARY_PATH manually like the script does, breaks mariadb-backup with the "Undefined symbol" error on FreeBSD 15.0 but not on 14.x. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	4 months ago
Julius Goryavsky	525ae97b12	galera tests: synchronization between versions and editions	2 months ago
Jan Lindström	3d11313b6f	MDEV-36134 : Mariadb server crashed during insert Replication filtering is not safe for cluster consistency. There is problem when two or more filtering rules are provided by user. Here, we disable replication filtering inside a Galera cluster for now. To support safe replication filereing in the Galera cluster it should also effect SST/IST. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	5 months ago
Denis Protivensky	6dfc9bc75b	MDEV-36710: Revert "MDEV-33136: backport corrections from 10.11+" This reverts commit `0403f0147f` for 10.6 branch. It caused MDEV-33136 test to fail in 10.6 branch. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	5 months ago
Julius Goryavsky	fc2990fd90	MDEV-37366 test correction: added missing --disable_ps_protocol	2 months ago
Hemant Dangi	88d43afd33	MDEV-37366: Inconsistency detected - create sequence Issue: When applying 'SELECT NEXT VALUE..' on applier node with binlog_row_image=MINIMAL and log-binlog enabled, applier node fails with below error: Slave SQL: Could not execute Write_rows_v1 event on table monitor.seq_moni_num; Unknown error, Error_code: 1105; handler error No Error!; the event's master log FIRST, end_log_pos 0, Internal MariaDB error code: 1105 To reproduce run below command on the first/active node: > CREATE SEQUENCE `seq_test` start with 1 minvalue 1 maxvalue 9223372036854775806 increment by 0 cache 1000 nocycle ENGINE=InnoDB; > SELECT NEXT VALUE FOR seq_test; > SELECT NEXT VALUE FOR seq_test; The applier node will leave the cluster after executing the 'SELECT NEXT VALUE' with below error: ERROR] Slave SQL: Could not execute Write_rows_v1 event on table test.seq_test; Unknown error, Error_code: 1105; handler error No Error!; the event's master log FIRST, end_log_pos 0, Internal MariaDB error code: 1105 [Warning] WSREP: Event 3 Write_rows_v1 apply failed: 195, seqno 14511334511 Solution: When binary loggging is enabled and binlog_row_image is set to 'MINIMAL', then 'SELECT NEXT VALUE' fails to apply on applier node. It fails with error HA_ERR_SEQUENCE_INVALID_DATA 195 in sequence_definition::check_and_adjust() because sequence variables like min_value, max_value, start are 0. The marking of all columns in 'TABLE::mark_columns_per_binlog_row_image()' will prevent update/set column values for the sequence table. For the sequence table column bitmap sent from master is only used. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	2 months ago
Julius Goryavsky	858dc5bd5c	galera: fixed duplicated debug checkpoint name	2 months ago
Julius Goryavsky	abc5661c12	galera mtr tests: fix some tests after rebase to reflect recent changes	2 months ago
Jan Lindström	c24b4b92aa	MDEV-36949 : unstable autoincrement value in galera_toi_ddl_nonconflicting test Remove show create table because, Test has two concurrent statements: (1) ALTER TABLE t1 ADD COLUMN f3 INTEGER; INSERT INTO t1 VALUES (NULL, 10000, 10000); (2) CREATE UNIQUE INDEX i1 ON t1(f2); If INSERT starts execution and reaches certifying state and execution is switched to CREATE, there will be MDL-conflict. This MDL-conflict is resolved by BF-abort (brute force abort) i.e. INSERT is aborted. But it has already acquired value for auto_increment column from InnoDB. INSERT is then retryed and that will cause new auto_increment value generation. Therefore, later SHOW CREATE TABLE could show unstable values i.e. either value that is generated on schedule where there was no retry and value where there was a retry. Signed-off-by: Julius Goryavsky <julius.goryavsky@mariadb.com>	4 months ago
Julius Goryavsky	23b4431cb4	galera: wsrep-lib submodule update	2 months ago
Marko Mäkelä	9ffec4c1f3	MDEV-37360: SIGSEGV in srv_printf_innodb_monitor srv_printf_innodb_monitor(): After acquiring a latch, abort the iteration if innodb_adaptive_hash_index=OFF. If the adaptive hash index was disabled in a concurrently executing thread, btr_search_sys_t::partition::clear() would have freed part->heap, leading to us dereferencing a null pointer. Reviewed by: Thirunarayanan Balathandayuthapani Tested by: Saahil Alam	2 months ago
Michal Schorm	c5169a3510	Make sure the 'lex_hash.h' and 'lex_token.h' header files are packed In some cases the '.' path used to pack the header files may not equal the '${CMAKE_CURRENT_BINARY_DIR}' path where these two header files are. This is the case of Fedora 33 and later: https://fedoraproject.org/wiki/Changes/CMake_to_do_out-of-source_builds	4 months ago
Oleksandr Byelkin	f2736c3b4d	Fix small stack problem on some ARM.	2 months ago
Daniel Bartholomew	13f337ce1f	bump the VERSION	2 months ago
Monty	df1eb3fbb2	Fixed mi_test1 and mi_test_all.sh The mi_rsame() test in mi_test has been broken since MDEV-15458 in 2019. Fixed same was as ma_test1 was fixed.	2 months ago
Monty	6435aeb241	Fixed "frame size..larger thane 16384" error in MyISAM Fixed by using my_alloc() and by using 'needed allocation size' instead of maxium possible.	2 months ago
Sergei Golubchik	317f099ca5	mtr: override local gnutls config that might disable individual ciphers or protocols and fail tests. Just like we do with OpenSSL.	2 months ago
Sergei Golubchik	59f9ef24ea	Merge remote-tracking branch 'github/10.6' into 10.6	2 months ago
Sergei Golubchik	fe8047caf2	MDEV-37320 ASAN errors in Field::is_null / Item_param::assign_default don't construct a "default value field" by moving field's ptr/null_ptr. Field can have its null_ptr moved to extra_null_bitmap for BEFORE triggers. Perhaps there can be other reasons for null_ptr and ptr not to be at the right offset to each other. Instead, use pointers from TABLE_SHARE::field, which always point to default values. Except when there's no TABLE_SHARE::field, which can happen for TEMPTABLE views, for example, but these views are not updatable anyway. Add an assert to Field::move_field_offset() to ensure it's only used for appropriately set ptr/null_ptr pairs.	2 months ago
Michael Widenius	49febfad21	Fixed compiler error with framesize=16384 in InnoDB log0sync.cc When compiling with debug and valgrind on Ubuntu 22.04 with gcc 11.4.0, the used framsize was 16400 bytes because of the code: completion_callback callbacks[1000]; Reducing the array to 950 fixes the issue	2 months ago

1 2 3 4 5 ...

199616 Commits (10.6) All Branches Search

199616 Commits (10.6)

All Branches