4db4a0a46f
Pcbnew, PCB_PAINTER: very minor enhancement for commit 2751c677
5 years ago
e0c2531f53
Catch exception inside JSON_SETTINGS constructor
This exception will probably never be thrown in real life,
but the constructors are normally noexcept, so throwing
any exception from the json library causes Coverity to
have a fit.
5 years ago
2becd368d9
Thirdparty: Properly handle error condition in nanosvg
ftell() returns -1 on an error, so it must be a long return
type, and we should test for its failure.
(found by Coverity)
5 years ago
68985490c6
Update lemon and its template to most recent upstream version
This should fix some Coverity warnings about memory management
in the lemon tool (less critical), but also fix improper
memory accesses in the generated parsers (labeled critical
by Coverity).
Ref: https://sqlite.org/forum/forumpost/edecf32da3
5 years ago
650cff5b39
Shorten solder mask alert and provide a link for fixing.
Fixes https://gitlab.com/kicad/code/kicad/issues/4798
5 years ago
b3a369bd7c
Remove zone areas outside board edges.
The first attempt to address this which added back in the zones
with a 0 netcode didn't pick up those with a netcode which weren't
isolated (ie: because there were unplaced footprints outside the
board edges).
The new system gives up on trying to adjust the insulated island
list and just makes a second pass.
Fixes https://gitlab.com/kicad/code/kicad/issues/5658
5 years ago
fdbb28aea2
Treat Reference and Unit as separate words when searching.
Fixes https://gitlab.com/kicad/code/kicad/issues/4630
5 years ago
884bed7e12
Fix that all file types are shown in file dialog
5 years ago
d9a94dc538
Don't allow selection of PCB_NETINFO_T.
Fixes https://gitlab.com/kicad/code/kicad/issues/5729
5 years ago
e64806cd20
Menus/Submenus: fix incorrect bitmap for checkable menuitems in submenus.
Windows specific, because other OS do not accept user bitmaps in ckeckable menuitems
the bug was due to the same bitmap was set for each state for these menuitems.
Fixes #5622
https://gitlab.com/kicad/code/kicad/issues/5622
5 years ago
0b03d8a5ff
Fix a few Coverity warnings.
5 years ago
2751c67746
Pcbnew, PCB_PAINTER: provides an option to show footprints bounding box.
This is only for bounding box debug purposes, and is not activated.
5 years ago
1039fb1bc5
Minor refinement to Import Settings from Board dialog.
Also some defensive code to protect against an ASAN stack buffer
underflow.
Fixes https://gitlab.com/kicad/code/kicad/issues/5660
5 years ago
0b108d61e7
Cairo canvas not on Mac; no need to show antialiasing settings.
5 years ago
ad2407867a
Disable Save Report while DRC is running.
Fixes https://gitlab.com/kicad/code/kicad/issues/5723
5 years ago
e27ff1dd3c
Add Select All to multi-line text properties.
5 years ago
89dcc46898
Coverity cleanup and remove unused variables
5 years ago
65bd1ee9a4
Add a new BITMAP_BUTTON widget and use it in the appearances panel
This button behaves like an AUI button, so it is more suited
to being on panels without a border.
5 years ago
c5feccca53
Add stub functions in KIPLATFORM to detect dark mode
These haven't been written yet, but current code can
be adapted to use these now.
5 years ago
f82ad61c90
More warning cleanup
5 years ago
4558aff24b
Add textVar cross-reference support to Dimensions.
Also adjusts spacing in the dialog.
Fixes https://gitlab.com/kicad/code/kicad/issues/5664
5 years ago
13f1de8e73
Forgot a bunch of files from last commit.
5 years ago
64fa400b19
Ease translation a bit.
Also improves the SNR and consistency of the menu item text. For
instance, a position is rarely useful, while relative sizes can be.
Also removes some unnecessary repitition, such as "Graphic Rectangle"
when "Rectangle" communicates the necessary information.
5 years ago
db5de738ae
Apply rules commutatively.
5 years ago
121ccc3a10
Fix broken MODULE::HitTest()
HitTest was using a rotated bounding box, but the bounding box
is already right.
5 years ago
55089f4732
Better strings for translation (minor fix)
5 years ago
d227b53e1a
Fix broken translation string
5 years ago
39bdc547af
Smarten up the guess selection routine to pick closest item.
Fixes https://gitlab.com/kicad/code/kicad/issues/5697
5 years ago
d402d93487
Implement shape routines for DIMENSION_Ts.
This allows them to participate in DRC and PNS.
Fixes https://gitlab.com/kicad/code/kicad/issues/5712
5 years ago
ece2ae9805
Don't capture commands in the router eventloop that it doesn't process.
Fixes https://gitlab.com/kicad/code/kicad/issues/5692
5 years ago
0763a8962c
Implement boolean not processing in expression language.
Also adds some more error catching to be more robust in the face
of malformed customer rules.
Fixes https://gitlab.com/kicad/code/kicad/issues/5694
5 years ago
23f7ba6ee4
Ensure that we had a pad remaining before painting
Null polygons should not be send to the painter, so we need to check to
see if our mask has removed the complete pad before painting
Fixes https://gitlab.com/kicad/code/kicad/issues/5702
5 years ago
375f1b8129
Avoid throwing exception when starting from scratch
Fixes https://gitlab.com/kicad/code/kicad/-/issues/5661
for some reason
5 years ago
4fa3de2211
Ensure we clear forced position
Fixes https://gitlab.com/kicad/code/kicad/issues/5699
5 years ago
5e0d79449e
Fix pcbnew api for DIMENSIONs
DIMENSION is now an abstract class and we should cast to
concrete implementations instead.
Also change broken 'return none' to throwing an exception
which will give feedback about what is not supported by
the API instead of silently returning a non-object.
5 years ago
ef48dba7ff
Correctly set value and footprint fields from Symbol Fields editor.
Fixes https://gitlab.com/kicad/code/kicad/issues/5689
5 years ago
7062a3b29b
Fix bug in net <-> netclass matching.
Also adds a "Default" setting for Edit Text and Graphics Properties
so the linestyle can be batch-edited back to default.
Fixes https://gitlab.com/kicad/code/kicad/issues/5674
5 years ago
2799faf52b
Add syntax example using "not".
Fixes https://gitlab.com/kicad/code/kicad/issues/5694
5 years ago
80acf944a0
Don't assert when compiling rules; generate a user-visible error.
Fixes https://gitlab.com/kicad/code/kicad/issues/5694
5 years ago
67b5d24995
Support ESC & Cancel for DRC.
Fixes https://gitlab.com/kicad/code/kicad/issues/5698
5 years ago
73fc00ee69
Collapse VIA_TOO_SMALL and MICROVIA_TOO_SMALL into VIA_DIAMETER.
We'll also check too large in future....
5 years ago
f340636f70
When knocking out higher-priority zone use fill, not outline.
Also fixes a bunch of naming issues, primarily with lowercase for
protected variables, but also some for consistency with other parts
of the code.
Also changes the zone fill radio buttons in Board Setup to be more
generic referring to legacy vs. current, and to have tooltips.
Fixes https://gitlab.com/kicad/code/kicad/issues/5583
5 years ago
d468618411
Don't eat commands that aren't ours in SCH_MOVE_TOOL.
Fixes https://gitlab.com/kicad/code/kicad/issues/5692
5 years ago
90b147a914
Add DRC_ITEM definition for DRC_VIA_DIAMETER.
Fixes https://gitlab.com/kicad/code/kicad/issues/5695
5 years ago
079bc52f6d
Minor cleanup.
5 years ago
53297c78a6
Don't eat commands we don't need in move tool.
This also fixes the dynamic ratsnest issue.
Fixes https://gitlab.com/kicad/code/kicad/issues/5692
5 years ago
1a988e8d85
Fix event processing bug which kept ModEdit's context menu from working.
5 years ago
34527630d0
Small cleanup
5 years ago
a53f3899d4
Initialize variables properly
5 years ago
aa0b0ca7e7
Fix some warnings in the cadstar importer
5 years ago
jean-pierre charras
Ian McInerney
Jeff Young
Dominik Wernberger
Seth Hillbrand
Jon Evans
qu1ck