Apparently, GetImage() on MacOS does not always convert the image
properly. So do a two-step here to get the Bitmap first, forcing the
conversion and then going back to an image
(cherry picked from commit 9f06d1f66b)
Don't wait for mouse to move before refreshing after a command.
Also fixes a crash bug deleting an item after an
Unstage() (the Unstage() has already deleted the item).
Also fixes a crash when changing label type during
creation of a label produces a mess.
Also Keep cursor aligned to grid when not warping
back to original point.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/16828
(cherry picked from commit 9d7db3d135)
- Do not throw an error in CTor: this is not the place. It is much easy to
fix the value of incorrect radius.
Moreover, the Ctor is called without catching a throw-ed error in code.
- fix the test about radius validity, broken.
From master branch.
When converting poly shapes with arcs in STEP_PCB_MODEL::MakeShapes,
when an error happens, a second try is made using a full polygonal shape.
However a fatal error was emitted at the first attempt, before the second try.
Now at first try, only a debug message is emitted on error. The fatal error
is emitted only if the second try fails.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/21589
(cherry picked from commit aeafbe48fe)
If we are not asking for fields to be removed when updating, then don't
say we're doing anything if all we have to do is remove fields
(cherry picked from commit ea8206eca5)
Teardrop generator used pad::HitTest not testing the hit of a specific layer.
It created false test for some complex pads. Now use a test specific to a layer.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/21560
(cherry picked from commit 963aa47778)
Another case where large grids are overly "grabby" for snaps.
In this case, because the via was moved to the grid-snap first,
and then THAT position was used to look for things like pad-snaps,
the pad snaps would not be found if a coarse grid meant the cursor
was outside the pad.
Instead, use the mouse position when looking for the non-grid snaps
in VIA_PLACER::SnapItem.
Fixes: https://gitlab.com/kicad/code/kicad/-/issues/18626
(cherry picked from commit 0f0527bd03)
When (happens after converting old schematics to the new format) trying to
update symbols having a bad lib id can hang Eeschema (infinite loop)
It can easily happens when the user has badly converted the schematic.
Also display a error message when happens.
Fixes https://gitlab.com/kicad/code/kicad/-/issues/21536
(cherry picked from commit 61aeea9237)
Pferd O
Mark Roszko
jean-pierre charras
Seth Hillbrand
Jeff Young
Jon Evans
Emmanuel Vera
John Beard
Alex Shvartzkop