Fix incompatibility between basic_gal (which used angles in degrees in rotation) and other gal layers (which used radians in rotation). Rotation angles are now in radians.

Fix erroneous optimization in VECTOR2<T>::Rotate (which was made for angles in degrees): Angles are in radians, and only 0 rd rotation is skipped ( case very frequent, especially in eeschema)

common/common.cpp

@@ -180,7 +180,7 @@ wxString GetUnitsLabel( EDA_UNITS_T aUnit )
         break;
 
     case DEGREES:
-        wxASSERT( false );
+        label = _( "degrees" );
         break;
     }
 

common/drawtxt.cpp

@@ -168,7 +168,8 @@ void DrawGraphicText( EDA_RECT* aClipBox,
     basic_gal.m_DC = aDC;
     basic_gal.m_Color = aColor;
     basic_gal.SetClipBox( aClipBox );
-    basic_gal.StrokeText( aText, VECTOR2D( aPos ), aOrient );
+
+    basic_gal.StrokeText( aText, VECTOR2D( aPos ), aOrient * M_PI/1800 );
 }
 
 void DrawGraphicHaloText( EDA_RECT* aClipBox, wxDC * aDC,

include/basic_gal.h

@@ -135,7 +135,7 @@ public:
      */
     virtual void Rotate( double aAngle )
     {
-        m_transform.m_rotAngle = aAngle * M_PI/1800;
+        m_transform.m_rotAngle = aAngle;
         m_transform.m_rotCenter = m_transform.m_moveOffset;
     }
 

include/math/vector2d.h

@@ -355,22 +355,17 @@ VECTOR2<T>& VECTOR2<T>::operator-=( const T& aScalar )
 }
 
 
+/**
+ * Rotate a VECTOR2 by aAngle.
+ * @param aAngle = rotation angle in radians
+ */
 template <class T>
 VECTOR2<T> VECTOR2<T>::Rotate( double aAngle ) const
 {
-    // fast calculation of some rotations, very frequently found
+    // Avoid 0 radian rotation, case very frequently found
     if( aAngle == 0.0 )
         return VECTOR2<T> ( T( x ), T( y ) );
 
-    if( aAngle == 90.0 )
-        return VECTOR2<T> ( T( -y ), T( x ) );
-
-    if( aAngle == -90.0 )
-        return VECTOR2<T> ( T( y ), T( -x ) );
-
-    if( aAngle == 180.0 || aAngle == -180.0 )
-        return VECTOR2<T> ( T( -x ), T( -y ) );
-
     double  sa  = sin( aAngle );
     double  ca  = cos( aAngle );