Multithreaded safety. (KICAD-T5A)

common/lset.cpp

@@ -581,20 +581,18 @@ LSET allCuMask( int aCuLayerCount )
 
 LSET LSET::AllCuMask( int aCuLayerCount )
 {
-    static LSET savedMax = allCuMask( MAX_CU_LAYERS );
-    static LSET cache;
-    static int  cacheCuLayerCount = -1;
-
     if( aCuLayerCount == MAX_CU_LAYERS )
-        return savedMax;
+        return AllCuMask();
 
-    if( aCuLayerCount != cacheCuLayerCount )
-    {
-        cache = allCuMask( aCuLayerCount );
-        cacheCuLayerCount = aCuLayerCount;
-    }
+    return allCuMask( aCuLayerCount );
+}
+
+
+LSET LSET::AllCuMask()
+{
+    static LSET s_savedMax = allCuMask( MAX_CU_LAYERS );
 
-    return cache;
+    return s_savedMax;
 }
 
 

include/lset.h

@@ -117,7 +117,12 @@ public:
     /**
      * Return a mask holding the requested number of Cu PCB_LAYER_IDs.
      */
-    static LSET AllCuMask( int aCuLayerCount = MAX_CU_LAYERS );
+    static LSET AllCuMask( int aCuLayerCount );
+
+    /**
+     * return AllCuMask( MAX_CU_LAYERS );
+     */
+    static LSET AllCuMask();
 
     /**
      * Return a mask holding the Front and Bottom layers.