Mirrors
/
kicad
mirror of https://github.com/KiCad/kicad-source-mirror
3
0
Fork 0
Code Releases Activity
Browse Source

Prevent pads for forcing each other to flash 

Conditional flashing should be reserved for elements that will be on the
board regardless of their flash state.  Footprints likewise should not
cause internal elements to flash since the footprint elements are fixed
as a unit and if you want the layer flashed, you just design it that way

Fixes https://gitlab.com/kicad/code/kicad/-/issues/21737
master
Seth Hillbrand 4 weeks ago
parent
48c9145177
commit
e46bcd3d5a
3 changed files with 155 additions and 0 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 33
      pcbnew/connectivity/connectivity_data.cpp
  2. 1
      qa/tests/pcbnew/CMakeLists.txt
  3. 121
      qa/tests/pcbnew/test_pad_flashing.cpp

33
pcbnew/connectivity/connectivity_data.cpp
View File

@ -34,6 +34,7 @@
#include <connectivity/connectivity_data.h>
#include <connectivity/connectivity_algo.h>
#include <connectivity/from_to_cache.h>
#include <board_item.h>
#include <project/net_settings.h>
#include <board_design_settings.h>
#include <geometry/shape_segment.h>
@ -424,6 +425,8 @@ bool CONNECTIVITY_DATA::IsConnectedOnLayer( const BOARD_CONNECTED_ITEM *aItem, i
{
CN_CONNECTIVITY_ALGO::ITEM_MAP_ENTRY &entry = m_connAlgo->ItemEntry( aItem );
FOOTPRINT* parentFootprint = aItem->GetParentFootprint();
auto matchType =
[&]( KICAD_T aItemType )
{
@ -451,6 +454,36 @@ bool CONNECTIVITY_DATA::IsConnectedOnLayer( const BOARD_CONNECTED_ITEM *aItem, i
&& matchType( connected->Parent()->Type() )
&& connected->Net() == aItem->GetNetCode() )
{
BOARD_ITEM* connectedItem = connected->Parent();
if( connectedItem == aItem )
continue;
if( parentFootprint && connectedItem
&& connectedItem->GetParentFootprint() == parentFootprint )
{
continue;
}
if( aItem->Type() == PCB_PAD_T && connectedItem
&& connectedItem->Type() == PCB_PAD_T )
{
const PAD* thisPad = static_cast<const PAD*>( aItem );
const PAD* otherPad = static_cast<const PAD*>( connectedItem );
auto flashesConditionally = []( PADSTACK::UNCONNECTED_LAYER_MODE aMode )
{
return aMode == PADSTACK::UNCONNECTED_LAYER_MODE::REMOVE_EXCEPT_START_AND_END
|| aMode == PADSTACK::UNCONNECTED_LAYER_MODE::REMOVE_ALL;
};
if( flashesConditionally( thisPad->Padstack().UnconnectedLayerMode() )
&& flashesConditionally( otherPad->Padstack().UnconnectedLayerMode() ) )
{
continue;
}
}
if( aItem->Type() == PCB_PAD_T && zoneLayer )
{
const PAD* pad = static_cast<const PAD*>( aItem );

1
qa/tests/pcbnew/CMakeLists.txt
View File

@ -44,6 +44,7 @@ set( QA_PCBNEW_SRCS
test_io_mgr.cpp
test_lset.cpp
test_pns_basics.cpp
test_pad_flashing.cpp
test_pad_numbering.cpp
test_prettifier.cpp
test_libeval_compiler.cpp

121
qa/tests/pcbnew/test_pad_flashing.cpp
View File

@ -0,0 +1,121 @@
/*
* This program source code file is part of KiCad, a free EDA CAD application.
*
* Copyright The KiCad Developers, see AUTHORS.txt for contributors.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, you may find one here:
* http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
* or you may search the http://www.gnu.org website for the version 2 license,
* or you may write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
*/
#include <qa_utils/wx_utils/unit_test_utils.h>
#include <board.h>
#include <footprint.h>
#include <pad.h>
#include <memory>
BOOST_AUTO_TEST_SUITE( PadFlashing )
BOOST_AUTO_TEST_CASE( PadsInSameFootprintDoNotForceInnerLayerFlashing )
{
BOARD board;
board.SetBoardUse( BOARD_USE::FPHOLDER );
auto footprint = std::make_unique<FOOTPRINT>( &board );
auto net = new NETINFO_ITEM( &board, "P1", 1 );
board.Add( net );
auto pad1 = new PAD( footprint.get() );
auto pad2 = new PAD( footprint.get() );
const int diameter = pcbIUScale.mmToIU( 1.0 );
const int drill = pcbIUScale.mmToIU( 0.5 );
pad1->SetAttribute( PAD_ATTRIB::PTH );
pad2->SetAttribute( PAD_ATTRIB::PTH );
pad1->SetLayerSet( LSET::AllCuMask() );
pad2->SetLayerSet( LSET::AllCuMask() );
pad1->SetSize( PADSTACK::ALL_LAYERS, VECTOR2I( diameter, diameter ) );
pad2->SetSize( PADSTACK::ALL_LAYERS, VECTOR2I( diameter, diameter ) );
pad1->SetDrillSize( VECTOR2I( drill, drill ) );
pad2->SetDrillSize( VECTOR2I( drill, drill ) );
pad1->SetPosition( VECTOR2I( 0, 0 ) );
pad2->SetPosition( VECTOR2I( 0, 0 ) );
pad1->SetUnconnectedLayerMode( PADSTACK::UNCONNECTED_LAYER_MODE::REMOVE_EXCEPT_START_AND_END );
pad2->SetUnconnectedLayerMode( PADSTACK::UNCONNECTED_LAYER_MODE::REMOVE_EXCEPT_START_AND_END );
pad1->SetNet( net );
pad2->SetNet( net );
footprint->Add( pad1 );
footprint->Add( pad2 );
board.Add( footprint.release() );
board.BuildConnectivity();
BOOST_CHECK( pad1->FlashLayer( F_Cu ) );
BOOST_CHECK( pad2->FlashLayer( B_Cu ) );
BOOST_CHECK( !pad1->FlashLayer( In1_Cu ) );
BOOST_CHECK( !pad2->FlashLayer( In1_Cu ) );
}
BOOST_AUTO_TEST_CASE( PadsInDifferentFootprintsDoNotForceInnerLayerFlashing )
{
BOARD board;
board.SetBoardUse( BOARD_USE::FPHOLDER );
auto footprint1 = std::make_unique<FOOTPRINT>( &board );
auto footprint2 = std::make_unique<FOOTPRINT>( &board );
auto net = new NETINFO_ITEM( &board, "P1", 1 );
board.Add( net );
auto pad1 = new PAD( footprint1.get() );
auto pad2 = new PAD( footprint2.get() );
const int diameter = pcbIUScale.mmToIU( 1.0 );
const int drill = pcbIUScale.mmToIU( 0.5 );
pad1->SetAttribute( PAD_ATTRIB::PTH );
pad2->SetAttribute( PAD_ATTRIB::PTH );
pad1->SetLayerSet( LSET::AllCuMask() );
pad2->SetLayerSet( LSET::AllCuMask() );
pad1->SetSize( PADSTACK::ALL_LAYERS, VECTOR2I( diameter, diameter ) );
pad2->SetSize( PADSTACK::ALL_LAYERS, VECTOR2I( diameter, diameter ) );
pad1->SetDrillSize( VECTOR2I( drill, drill ) );
pad2->SetDrillSize( VECTOR2I( drill, drill ) );
pad1->SetPosition( VECTOR2I( 0, 0 ) );
pad2->SetPosition( VECTOR2I( 0, 0 ) );
pad1->SetUnconnectedLayerMode( PADSTACK::UNCONNECTED_LAYER_MODE::REMOVE_EXCEPT_START_AND_END );
pad2->SetUnconnectedLayerMode( PADSTACK::UNCONNECTED_LAYER_MODE::REMOVE_EXCEPT_START_AND_END );
pad1->SetNet( net );
pad2->SetNet( net );
footprint1->Add( pad1 );
footprint2->Add( pad2 );
board.Add( footprint1.release() );
board.Add( footprint2.release() );
board.BuildConnectivity();
BOOST_CHECK( pad1->FlashLayer( F_Cu ) );
BOOST_CHECK( pad2->FlashLayer( B_Cu ) );
BOOST_CHECK( !pad1->FlashLayer( In1_Cu ) );
BOOST_CHECK( !pad2->FlashLayer( In1_Cu ) );
}
BOOST_AUTO_TEST_SUITE_END()
Write Preview
Loading…
Cancel
Save