Browse Source
ADDED: via_dangling constraint
ADDED: via_dangling constraint
Allows programmatic suppression of this error if you don't care about it Fixes https://gitlab.com/kicad/code/kicad/-/issues/18058master
9 changed files with 551 additions and 5 deletions
-
1common/drc_rules.keywords
-
3pcbnew/drc/drc_rule.h
-
8pcbnew/drc/drc_rule_parser.cpp
-
19pcbnew/drc/drc_test_provider_connectivity.cpp
-
5qa/data/pcbnew/via_dangling.kicad_dru
-
137qa/data/pcbnew/via_dangling.kicad_pcb
-
296qa/data/pcbnew/via_dangling.kicad_pro
-
1qa/tests/pcbnew/CMakeLists.txt
-
86qa/tests/pcbnew/drc/test_drc_via_dangling.cpp
@ -0,0 +1,5 @@ |
|||||
|
(version 1) |
||||
|
(rule ignore_left |
||||
|
(constraint via_dangling) |
||||
|
(condition "A.Position_X < 20mm") |
||||
|
(severity ignore)) |
@ -0,0 +1,137 @@ |
|||||
|
(kicad_pcb |
||||
|
(version 20250901) |
||||
|
(generator "pcbnew") |
||||
|
(generator_version "9.99") |
||||
|
(general |
||||
|
(thickness 1.6) |
||||
|
(legacy_teardrops no) |
||||
|
) |
||||
|
(paper "A4") |
||||
|
(layers |
||||
|
(0 "F.Cu" signal) |
||||
|
(2 "B.Cu" signal) |
||||
|
(25 "Edge.Cuts" user) |
||||
|
(27 "Margin" user) |
||||
|
(31 "F.CrtYd" user "F.Courtyard") |
||||
|
(29 "B.CrtYd" user "B.Courtyard") |
||||
|
) |
||||
|
(setup |
||||
|
(pad_to_mask_clearance 0) |
||||
|
(allow_soldermask_bridges_in_footprints no) |
||||
|
(tenting |
||||
|
(front yes) |
||||
|
(back yes) |
||||
|
) |
||||
|
(covering |
||||
|
(front no) |
||||
|
(back no) |
||||
|
) |
||||
|
(plugging |
||||
|
(front no) |
||||
|
(back no) |
||||
|
) |
||||
|
(capping no) |
||||
|
(filling no) |
||||
|
(pcbplotparams |
||||
|
(layerselection 0x00000000_00000000_55555555_5755f5ff) |
||||
|
(plot_on_all_layers_selection 0x00000000_00000000_00000000_00000000) |
||||
|
(disableapertmacros no) |
||||
|
(usegerberextensions no) |
||||
|
(usegerberattributes yes) |
||||
|
(usegerberadvancedattributes yes) |
||||
|
(creategerberjobfile yes) |
||||
|
(dashed_line_dash_ratio 12) |
||||
|
(dashed_line_gap_ratio 3) |
||||
|
(svgprecision 4) |
||||
|
(plotframeref no) |
||||
|
(mode 1) |
||||
|
(useauxorigin no) |
||||
|
(pdf_front_fp_property_popups yes) |
||||
|
(pdf_back_fp_property_popups yes) |
||||
|
(pdf_metadata yes) |
||||
|
(pdf_single_document no) |
||||
|
(dxfpolygonmode yes) |
||||
|
(dxfimperialunits yes) |
||||
|
(dxfusepcbnewfont yes) |
||||
|
(psnegative no) |
||||
|
(psa4output no) |
||||
|
(plot_black_and_white yes) |
||||
|
(sketchpadsonfab no) |
||||
|
(plotpadnumbers no) |
||||
|
(hidednponfab no) |
||||
|
(sketchdnponfab yes) |
||||
|
(crossoutdnponfab yes) |
||||
|
(subtractmaskfromsilk no) |
||||
|
(outputformat 1) |
||||
|
(mirror no) |
||||
|
(drillshape 1) |
||||
|
(scaleselection 1) |
||||
|
(outputdirectory "") |
||||
|
) |
||||
|
) |
||||
|
(net 0 "") |
||||
|
(gr_rect |
||||
|
(start 0 0) |
||||
|
(end 40 20) |
||||
|
(stroke |
||||
|
(width 0.1) |
||||
|
(type solid) |
||||
|
) |
||||
|
(fill no) |
||||
|
(layer "Edge.Cuts") |
||||
|
(uuid "6286fcef-0d96-4ddb-ae43-be4b4ffe718e") |
||||
|
) |
||||
|
(segment |
||||
|
(start 10 10) |
||||
|
(end 30 10) |
||||
|
(width 0.2) |
||||
|
(layer "F.Cu") |
||||
|
(net 0) |
||||
|
(uuid "d4a4f87d-990f-4a53-9b82-9a6fc90a1179") |
||||
|
) |
||||
|
(via |
||||
|
(at 30 10) |
||||
|
(size 0.8) |
||||
|
(drill 0.4) |
||||
|
(layers "F.Cu" "B.Cu") |
||||
|
(tenting |
||||
|
(front none) |
||||
|
(back none) |
||||
|
) |
||||
|
(capping none) |
||||
|
(covering |
||||
|
(front none) |
||||
|
(back none) |
||||
|
) |
||||
|
(plugging |
||||
|
(front none) |
||||
|
(back none) |
||||
|
) |
||||
|
(filling none) |
||||
|
(net 0) |
||||
|
(uuid "0d899acd-71ef-4c82-9710-1acddf041557") |
||||
|
) |
||||
|
(via |
||||
|
(at 10 10) |
||||
|
(size 0.8) |
||||
|
(drill 0.4) |
||||
|
(layers "F.Cu" "B.Cu") |
||||
|
(tenting |
||||
|
(front none) |
||||
|
(back none) |
||||
|
) |
||||
|
(capping none) |
||||
|
(covering |
||||
|
(front none) |
||||
|
(back none) |
||||
|
) |
||||
|
(plugging |
||||
|
(front none) |
||||
|
(back none) |
||||
|
) |
||||
|
(filling none) |
||||
|
(net 0) |
||||
|
(uuid "d750ed33-4724-448f-b5ca-17da4065fd7e") |
||||
|
) |
||||
|
(embedded_fonts no) |
||||
|
) |
@ -0,0 +1,296 @@ |
|||||
|
{ |
||||
|
"board": { |
||||
|
"3dviewports": [], |
||||
|
"design_settings": { |
||||
|
"defaults": { |
||||
|
"apply_defaults_to_fp_fields": false, |
||||
|
"apply_defaults_to_fp_shapes": false, |
||||
|
"apply_defaults_to_fp_text": false, |
||||
|
"board_outline_line_width": 0.05, |
||||
|
"copper_line_width": 0.2, |
||||
|
"copper_text_italic": false, |
||||
|
"copper_text_size_h": 1.5, |
||||
|
"copper_text_size_v": 1.5, |
||||
|
"copper_text_thickness": 0.3, |
||||
|
"copper_text_upright": false, |
||||
|
"courtyard_line_width": 0.05, |
||||
|
"dimension_precision": 4, |
||||
|
"dimension_units": 3, |
||||
|
"dimensions": { |
||||
|
"arrow_length": 1270000, |
||||
|
"extension_offset": 500000, |
||||
|
"keep_text_aligned": true, |
||||
|
"suppress_zeroes": true, |
||||
|
"text_position": 0, |
||||
|
"units_format": 0 |
||||
|
}, |
||||
|
"fab_line_width": 0.1, |
||||
|
"fab_text_italic": false, |
||||
|
"fab_text_size_h": 1.0, |
||||
|
"fab_text_size_v": 1.0, |
||||
|
"fab_text_thickness": 0.15, |
||||
|
"fab_text_upright": false, |
||||
|
"other_line_width": 0.1, |
||||
|
"other_text_italic": false, |
||||
|
"other_text_size_h": 1.0, |
||||
|
"other_text_size_v": 1.0, |
||||
|
"other_text_thickness": 0.15, |
||||
|
"other_text_upright": false, |
||||
|
"pads": { |
||||
|
"drill": 0.8, |
||||
|
"height": 1.27, |
||||
|
"width": 2.54 |
||||
|
}, |
||||
|
"silk_line_width": 0.1, |
||||
|
"silk_text_italic": false, |
||||
|
"silk_text_size_h": 1.0, |
||||
|
"silk_text_size_v": 1.0, |
||||
|
"silk_text_thickness": 0.1, |
||||
|
"silk_text_upright": false, |
||||
|
"zones": { |
||||
|
"min_clearance": 0.5 |
||||
|
} |
||||
|
}, |
||||
|
"diff_pair_dimensions": [], |
||||
|
"drc_exclusions": [], |
||||
|
"meta": { |
||||
|
"version": 2 |
||||
|
}, |
||||
|
"rule_severities": { |
||||
|
"annular_width": "error", |
||||
|
"clearance": "error", |
||||
|
"connection_width": "warning", |
||||
|
"copper_edge_clearance": "error", |
||||
|
"copper_sliver": "warning", |
||||
|
"courtyards_overlap": "error", |
||||
|
"creepage": "error", |
||||
|
"diff_pair_gap_out_of_range": "error", |
||||
|
"diff_pair_uncoupled_length_too_long": "error", |
||||
|
"drill_out_of_range": "error", |
||||
|
"duplicate_footprints": "warning", |
||||
|
"extra_footprint": "warning", |
||||
|
"footprint": "error", |
||||
|
"footprint_filters_mismatch": "ignore", |
||||
|
"footprint_symbol_mismatch": "warning", |
||||
|
"footprint_type_mismatch": "ignore", |
||||
|
"hole_clearance": "error", |
||||
|
"hole_to_hole": "warning", |
||||
|
"holes_co_located": "warning", |
||||
|
"invalid_outline": "error", |
||||
|
"isolated_copper": "warning", |
||||
|
"item_on_disabled_layer": "error", |
||||
|
"items_not_allowed": "error", |
||||
|
"length_out_of_range": "error", |
||||
|
"lib_footprint_issues": "warning", |
||||
|
"lib_footprint_mismatch": "warning", |
||||
|
"malformed_courtyard": "error", |
||||
|
"microvia_drill_out_of_range": "error", |
||||
|
"mirrored_text_on_front_layer": "warning", |
||||
|
"missing_courtyard": "ignore", |
||||
|
"missing_footprint": "warning", |
||||
|
"net_conflict": "warning", |
||||
|
"nonmirrored_text_on_back_layer": "warning", |
||||
|
"npth_inside_courtyard": "ignore", |
||||
|
"padstack": "warning", |
||||
|
"pth_inside_courtyard": "ignore", |
||||
|
"shorting_items": "error", |
||||
|
"silk_edge_clearance": "warning", |
||||
|
"silk_over_copper": "warning", |
||||
|
"silk_overlap": "warning", |
||||
|
"skew_out_of_range": "error", |
||||
|
"solder_mask_bridge": "error", |
||||
|
"starved_thermal": "error", |
||||
|
"text_height": "warning", |
||||
|
"text_on_edge_cuts": "error", |
||||
|
"text_thickness": "warning", |
||||
|
"through_hole_pad_without_hole": "error", |
||||
|
"too_many_vias": "error", |
||||
|
"track_angle": "error", |
||||
|
"track_dangling": "warning", |
||||
|
"track_segment_length": "error", |
||||
|
"track_width": "error", |
||||
|
"tracks_crossing": "error", |
||||
|
"unconnected_items": "error", |
||||
|
"unresolved_variable": "error", |
||||
|
"via_dangling": "warning", |
||||
|
"zones_intersect": "error" |
||||
|
}, |
||||
|
"rules": { |
||||
|
"max_error": 0.005, |
||||
|
"min_clearance": 0.0, |
||||
|
"min_connection": 0.0, |
||||
|
"min_copper_edge_clearance": 0.5, |
||||
|
"min_groove_width": 0.0, |
||||
|
"min_hole_clearance": 0.25, |
||||
|
"min_hole_to_hole": 0.25, |
||||
|
"min_microvia_diameter": 0.2, |
||||
|
"min_microvia_drill": 0.1, |
||||
|
"min_resolved_spokes": 2, |
||||
|
"min_silk_clearance": 0.0, |
||||
|
"min_text_height": 0.8, |
||||
|
"min_text_thickness": 0.08, |
||||
|
"min_through_hole_diameter": 0.3, |
||||
|
"min_track_width": 0.0, |
||||
|
"min_via_annular_width": 0.1, |
||||
|
"min_via_diameter": 0.5, |
||||
|
"solder_mask_to_copper_clearance": 0.0, |
||||
|
"use_height_for_length_calcs": true |
||||
|
}, |
||||
|
"teardrop_options": [ |
||||
|
{ |
||||
|
"td_onpthpad": true, |
||||
|
"td_onroundshapesonly": false, |
||||
|
"td_onsmdpad": true, |
||||
|
"td_ontrackend": false, |
||||
|
"td_onvia": true |
||||
|
} |
||||
|
], |
||||
|
"teardrop_parameters": [ |
||||
|
{ |
||||
|
"td_allow_use_two_tracks": true, |
||||
|
"td_curve_segcount": 0, |
||||
|
"td_height_ratio": 1.0, |
||||
|
"td_length_ratio": 0.5, |
||||
|
"td_maxheight": 2.0, |
||||
|
"td_maxlen": 1.0, |
||||
|
"td_on_pad_in_zone": false, |
||||
|
"td_target_name": "td_round_shape", |
||||
|
"td_width_to_size_filter_ratio": 0.9 |
||||
|
}, |
||||
|
{ |
||||
|
"td_allow_use_two_tracks": true, |
||||
|
"td_curve_segcount": 0, |
||||
|
"td_height_ratio": 1.0, |
||||
|
"td_length_ratio": 0.5, |
||||
|
"td_maxheight": 2.0, |
||||
|
"td_maxlen": 1.0, |
||||
|
"td_on_pad_in_zone": false, |
||||
|
"td_target_name": "td_rect_shape", |
||||
|
"td_width_to_size_filter_ratio": 0.9 |
||||
|
}, |
||||
|
{ |
||||
|
"td_allow_use_two_tracks": true, |
||||
|
"td_curve_segcount": 0, |
||||
|
"td_height_ratio": 1.0, |
||||
|
"td_length_ratio": 0.5, |
||||
|
"td_maxheight": 2.0, |
||||
|
"td_maxlen": 1.0, |
||||
|
"td_on_pad_in_zone": false, |
||||
|
"td_target_name": "td_track_end", |
||||
|
"td_width_to_size_filter_ratio": 0.9 |
||||
|
} |
||||
|
], |
||||
|
"track_widths": [], |
||||
|
"tuning_pattern_settings": { |
||||
|
"diff_pair_defaults": { |
||||
|
"corner_radius_percentage": 80, |
||||
|
"corner_style": 1, |
||||
|
"max_amplitude": 1.0, |
||||
|
"min_amplitude": 0.2, |
||||
|
"single_sided": false, |
||||
|
"spacing": 1.0 |
||||
|
}, |
||||
|
"diff_pair_skew_defaults": { |
||||
|
"corner_radius_percentage": 80, |
||||
|
"corner_style": 1, |
||||
|
"max_amplitude": 1.0, |
||||
|
"min_amplitude": 0.2, |
||||
|
"single_sided": false, |
||||
|
"spacing": 0.6 |
||||
|
}, |
||||
|
"single_track_defaults": { |
||||
|
"corner_radius_percentage": 80, |
||||
|
"corner_style": 1, |
||||
|
"max_amplitude": 1.0, |
||||
|
"min_amplitude": 0.2, |
||||
|
"single_sided": false, |
||||
|
"spacing": 0.6 |
||||
|
} |
||||
|
}, |
||||
|
"via_dimensions": [], |
||||
|
"zones_allow_external_fillets": false |
||||
|
}, |
||||
|
"ipc2581": { |
||||
|
"dist": "", |
||||
|
"distpn": "", |
||||
|
"internal_id": "", |
||||
|
"mfg": "", |
||||
|
"mpn": "" |
||||
|
}, |
||||
|
"layer_pairs": [], |
||||
|
"layer_presets": [], |
||||
|
"viewports": [] |
||||
|
}, |
||||
|
"boards": [], |
||||
|
"component_class_settings": { |
||||
|
"assignments": [], |
||||
|
"meta": { |
||||
|
"version": 0 |
||||
|
}, |
||||
|
"sheet_component_classes": { |
||||
|
"enabled": false |
||||
|
} |
||||
|
}, |
||||
|
"cvpcb": { |
||||
|
"equivalence_files": [] |
||||
|
}, |
||||
|
"libraries": { |
||||
|
"pinned_footprint_libs": [], |
||||
|
"pinned_symbol_libs": [] |
||||
|
}, |
||||
|
"meta": { |
||||
|
"filename": "via_dangling.kicad_pro", |
||||
|
"version": 3 |
||||
|
}, |
||||
|
"net_settings": { |
||||
|
"classes": [ |
||||
|
{ |
||||
|
"bus_width": 12, |
||||
|
"clearance": 0.2, |
||||
|
"diff_pair_gap": 0.25, |
||||
|
"diff_pair_via_gap": 0.25, |
||||
|
"diff_pair_width": 0.2, |
||||
|
"line_style": 0, |
||||
|
"microvia_diameter": 0.3, |
||||
|
"microvia_drill": 0.1, |
||||
|
"name": "Default", |
||||
|
"pcb_color": "rgba(0, 0, 0, 0.000)", |
||||
|
"priority": 2147483647, |
||||
|
"schematic_color": "rgba(0, 0, 0, 0.000)", |
||||
|
"track_width": 0.2, |
||||
|
"tuning_profile": "", |
||||
|
"via_diameter": 0.6, |
||||
|
"via_drill": 0.3, |
||||
|
"wire_width": 6 |
||||
|
} |
||||
|
], |
||||
|
"meta": { |
||||
|
"version": 5 |
||||
|
}, |
||||
|
"net_colors": null, |
||||
|
"netclass_assignments": null, |
||||
|
"netclass_patterns": [] |
||||
|
}, |
||||
|
"pcbnew": { |
||||
|
"last_paths": { |
||||
|
"idf": "", |
||||
|
"netlist": "", |
||||
|
"plot": "", |
||||
|
"specctra_dsn": "", |
||||
|
"vrml": "" |
||||
|
}, |
||||
|
"page_layout_descr_file": "" |
||||
|
}, |
||||
|
"schematic": { |
||||
|
"legacy_lib_dir": "", |
||||
|
"legacy_lib_list": [] |
||||
|
}, |
||||
|
"sheets": [], |
||||
|
"text_variables": {}, |
||||
|
"time_domain_parameters": { |
||||
|
"delay_profiles_user_defined": [], |
||||
|
"meta": { |
||||
|
"version": 0 |
||||
|
} |
||||
|
} |
||||
|
} |
@ -0,0 +1,86 @@ |
|||||
|
/*
|
||||
|
* This program source code file is part of KiCad, a free EDA CAD application. |
||||
|
* |
||||
|
* Copyright The KiCad Developers. |
||||
|
* |
||||
|
* This program is free software; you can redistribute it and/or |
||||
|
* modify it under the terms of the GNU General Public License |
||||
|
* as published by the Free Software Foundation; either version 2 |
||||
|
* of the License, or (at your option) any later version. |
||||
|
* |
||||
|
* This program is distributed in the hope that it will be useful, |
||||
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of |
||||
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
||||
|
* GNU General Public License for more details. |
||||
|
* |
||||
|
* You should have received a copy of the GNU General Public License |
||||
|
* along with this program; if not, you may find one here: |
||||
|
* http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
|
||||
|
* or you may search the http://www.gnu.org website for the version 2 license,
|
||||
|
* or you may write to the Free Software Foundation, Inc., |
||||
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA |
||||
|
*/ |
||||
|
|
||||
|
#include <qa_utils/wx_utils/unit_test_utils.h>
|
||||
|
#include <pcbnew_utils/board_test_utils.h>
|
||||
|
#include <board.h>
|
||||
|
#include <board_design_settings.h>
|
||||
|
#include <pcb_marker.h>
|
||||
|
#include <drc/drc_item.h>
|
||||
|
#include <settings/settings_manager.h>
|
||||
|
|
||||
|
struct DRC_REGRESSION_TEST_FIXTURE |
||||
|
{ |
||||
|
DRC_REGRESSION_TEST_FIXTURE() : |
||||
|
m_settingsManager( true /* headless */ ) |
||||
|
{ } |
||||
|
|
||||
|
SETTINGS_MANAGER m_settingsManager; |
||||
|
std::unique_ptr<BOARD> m_board; |
||||
|
}; |
||||
|
|
||||
|
BOOST_FIXTURE_TEST_CASE( DRCViaDanglingRuleTest, DRC_REGRESSION_TEST_FIXTURE ) |
||||
|
{ |
||||
|
KI_TEST::LoadBoard( m_settingsManager, "via_dangling", m_board ); |
||||
|
|
||||
|
std::vector<DRC_ITEM> violations; |
||||
|
BOARD_DESIGN_SETTINGS& bds = m_board->GetDesignSettings(); |
||||
|
|
||||
|
bds.m_DRCEngine->SetViolationHandler( |
||||
|
[&]( const std::shared_ptr<DRC_ITEM>& aItem, VECTOR2I aPos, int aLayer, |
||||
|
DRC_CUSTOM_MARKER_HANDLER* aCustomHandler ) |
||||
|
{ |
||||
|
PCB_MARKER temp( aItem, aPos ); |
||||
|
|
||||
|
if( bds.m_DrcExclusions.find( temp.SerializeToString() ) == bds.m_DrcExclusions.end() ) |
||||
|
violations.push_back( *aItem ); |
||||
|
} ); |
||||
|
|
||||
|
bds.m_DRCEngine->RunTests( EDA_UNITS::MM, true, false ); |
||||
|
|
||||
|
int danglingVias = 0; |
||||
|
|
||||
|
for( const DRC_ITEM& item : violations ) |
||||
|
{ |
||||
|
if( item.GetErrorCode() == DRCE_DANGLING_VIA ) |
||||
|
danglingVias++; |
||||
|
} |
||||
|
|
||||
|
if( danglingVias == 1 && violations.size() == 1 ) |
||||
|
{ |
||||
|
BOOST_CHECK_EQUAL( 1, 1 ); |
||||
|
BOOST_TEST_MESSAGE( "Via dangling rule test passed" ); |
||||
|
} |
||||
|
else |
||||
|
{ |
||||
|
UNITS_PROVIDER unitsProvider( pcbIUScale, EDA_UNITS::INCH ); |
||||
|
|
||||
|
std::map<KIID, EDA_ITEM*> itemMap; |
||||
|
m_board->FillItemMap( itemMap ); |
||||
|
|
||||
|
for( const DRC_ITEM& item : violations ) |
||||
|
BOOST_TEST_MESSAGE( item.ShowReport( &unitsProvider, RPT_SEVERITY_ERROR, itemMap ) ); |
||||
|
|
||||
|
BOOST_ERROR( "Via dangling rule test failed" ); |
||||
|
} |
||||
|
} |
Write
Preview
Loading…
Cancel
Save
Reference in new issue