Mirrors
/
kicad
mirror of https://github.com/KiCad/kicad-source-mirror
3
0
Fork 0
Code Releases Activity
Browse Source

Remove some nag tests which keep you from doing a DRC. 

Fixes https://gitlab.com/kicad/code/kicad/issues/4845
pull/16/head
Jeff Young 5 years ago
parent
9806d846b2
commit
998c216487
4 changed files with 0 additions and 168 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Unified View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 1
      pcbnew/CMakeLists.txt
  2. 30
      pcbnew/drc/drc.cpp
  3. 83
      pcbnew/drc/drc_netclass_tester.cpp
  4. 54
      pcbnew/drc/drc_netclass_tester.h

1
pcbnew/CMakeLists.txt
View File

@ -227,7 +227,6 @@ set( PCBNEW_DRC_SRCS
drc/drc_courtyard_tester.cpp drc/drc_courtyard_tester.cpp
drc/drc_drilled_hole_tester.cpp drc/drc_drilled_hole_tester.cpp
drc/drc_keepout_tester.cpp drc/drc_keepout_tester.cpp
drc/drc_netclass_tester.cpp
drc/drc_textvar_tester.cpp drc/drc_textvar_tester.cpp
drc/drc.cpp drc/drc.cpp
drc/drc_clearance_test_functions.cpp drc/drc_clearance_test_functions.cpp

30
pcbnew/drc/drc.cpp
View File

@ -57,7 +57,6 @@
#include <drc/drc_courtyard_tester.h> #include <drc/drc_courtyard_tester.h>
#include <drc/drc_drilled_hole_tester.h> #include <drc/drc_drilled_hole_tester.h>
#include <drc/drc_keepout_tester.h> #include <drc/drc_keepout_tester.h>
#include <drc/drc_netclass_tester.h>
#include <drc/drc_textvar_tester.h> #include <drc/drc_textvar_tester.h>
#include <drc/footprint_tester.h> #include <drc/footprint_tester.h>
#include <dialogs/panel_setup_rules.h> #include <dialogs/panel_setup_rules.h>
@ -250,35 +249,6 @@ void DRC::RunTests( wxTextCtrl* aMessages )
testOutline( commit ); testOutline( commit );
} }
if( aMessages )
{
aMessages->AppendText( _( "Netclasses...\n" ) );
wxSafeYield();
}
DRC_NETCLASS_TESTER netclassTester( [&]( MARKER_PCB* aMarker )
{
addMarkerToPcb( commit, aMarker );
} );
if( !netclassTester.RunDRC( userUnits(), *m_pcb ) )
{
// testing the netclasses is a special case because if the netclasses
// do not pass the BOARD_DESIGN_SETTINGS checks, then every member of a net
// class (a NET) will cause its items such as tracks, vias, and pads
// to also fail. So quit after *all* netclass errors have been reported.
if( aMessages )
aMessages->AppendText( _( "Netclasses are not valid: Cannot run DRC\n"
"Please open Board Setup and\ncheck netclass definitions" ) );
commit.Push( wxEmptyString, false, false );
// update the m_drcDialog listboxes
updatePointers();
return;
}
// test pad to pad clearances, nothing to do with tracks, vias or zones. // test pad to pad clearances, nothing to do with tracks, vias or zones.
if( !bds.Ignore( DRCE_COPPER_EDGE_CLEARANCE ) ) if( !bds.Ignore( DRCE_COPPER_EDGE_CLEARANCE ) )
{ {

83
pcbnew/drc/drc_netclass_tester.cpp
View File

@ -1,83 +0,0 @@
/*
* This program source code file is part of KiCad, a free EDA CAD application.
*
* Copyright (C) 2020 KiCad Developers, see AUTHORS.txt for contributors.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, you may find one here:
* http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
* or you may search the http://www.gnu.org website for the version 2 license,
* or you may write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
*/
#include <drc/drc_netclass_tester.h>
DRC_NETCLASS_TESTER::DRC_NETCLASS_TESTER( MARKER_HANDLER aMarkerHandler ) :
DRC_TEST_PROVIDER( std::move( aMarkerHandler ) ),
m_units( EDA_UNITS::MILLIMETRES ),
m_board( nullptr )
{
}
bool DRC_NETCLASS_TESTER::RunDRC( EDA_UNITS aUnits, BOARD& aBoard )
{
m_units = aUnits;
m_board = &aBoard;
bool success = true;
NETCLASSES& netclasses = m_board->GetDesignSettings().GetNetClasses();
success &= checkNetClass( netclasses.GetDefault() );
for( NETCLASSES::const_iterator i = netclasses.begin(); i != netclasses.end(); ++i )
success &= checkNetClass( i->second );
return success;
}
bool DRC_NETCLASS_TESTER::checkNetClass( const NETCLASSPTR& nc )
{
const BOARD_DESIGN_SETTINGS& bds = m_board->GetDesignSettings();
if( nc->GetClearance() < bds.m_MinClearance )
return false;
if( nc->GetTrackWidth() < bds.m_TrackMinWidth )
return false;
if( nc->GetViaDiameter() < bds.m_ViasMinSize )
return false;
if( nc->GetViaDrill() < bds.m_MinThroughDrill )
return false;
int ncViaAnnulus = ( nc->GetViaDiameter() - nc->GetViaDrill() ) / 2;
if( ncViaAnnulus < bds.m_ViasMinAnnulus )
return false;
if( nc->GetuViaDiameter() < bds.m_MicroViasMinSize )
return false;
if( nc->GetuViaDrill() < bds.m_MicroViasMinDrill )
return false;
return true;
}

54
pcbnew/drc/drc_netclass_tester.h
View File

@ -1,54 +0,0 @@
/*
* This program source code file is part of KiCad, a free EDA CAD application.
*
* Copyright (C) 2020 KiCad Developers, see change_log.txt for contributors.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
* as published by the Free Software Foundation; either version 2
* of the License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, you may find one here:
* http://www.gnu.org/licenses/old-licenses/gpl-2.0.html
* or you may search the http://www.gnu.org website for the version 2 license,
* or you may write to the Free Software Foundation, Inc.,
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
*/
#ifndef DRC_NETCLASS_TESTER__H
#define DRC_NETCLASS_TESTER__H
#include <drc/drc_provider.h>
class BOARD;
class BOARD_ITEM;
class DRC_NETCLASS_TESTER : public DRC_TEST_PROVIDER
{
public:
DRC_NETCLASS_TESTER( MARKER_HANDLER aMarkerHandler );
virtual ~DRC_NETCLASS_TESTER() {};
bool RunDRC( EDA_UNITS aUnits, BOARD& aBoard ) override;
private:
bool checkNetClass( const NETCLASSPTR& nc );
private:
EDA_UNITS m_units;
BOARD* m_board;
wxString m_msg; // Construct only once for performance
};
#endif // DRC_NETCLASS_TESTER__H
Write Preview
Loading…
Cancel
Save