Mirrors/php - php - Gitea: Git with a cup of tea

Commit Graph

Author	SHA1	Message	Date
Anatol Belski	9719621e07	fix error handling	9 years ago
Sammy Kaye Powers	dac6c639bb	Update copyright headers to 2017	9 years ago
Sammy Kaye Powers	478f119ab9	Update copyright headers to 2017	9 years ago
Bob Weinand	36527eccbb	Fixed build failure introduced by PR #2158 Note: AC_TRY_LINK interprets the source as part of a main function, ending up with int main() { /* ... / int main() { / ... */ } ; return 0; } here - Using AC_LINK_IFELSE with AC_LANG_SOURCE directly instead.	9 years ago
Joe Watkins	8d6cc00cbd	Merge branch 'pull-request/2158'	9 years ago
Joe Watkins	ae6fc21f14	Merge branch 'pull-request/2158'	9 years ago
Anatol Belski	c7b4cd1a51	fix HANDLE leak	9 years ago
Anatol Belski	a1ff39ffe5	backport relevant part from bug #72858 patch in 7.0	10 years ago
Anatol Belski	98d8794eae	avoid other efforts if memory mapping fails	10 years ago
Anatol Belski	20aae1caa3	map ell the err code	10 years ago
Anatol Belski	67f8c14c29	Fixed bug #72858 shm_attach null dereference	10 years ago
Kalle Sommer Nielsen	447e57a1e1	Fixed 7.1 build, decls first please!	10 years ago
Stanislav Malyshev	0218acb7e7	Fix for bug #72513	10 years ago
Anatol Belski	3d3f11ede4	Fixed the UTF-8 and long path support in the streams on Windows. Since long the default PHP charset is UTF-8, however the Windows part is out of step with this important point. The current implementation in PHP doesn't technically permit to handle UTF-8 filepath and several other things. Till now, only the ANSI compatible APIs are being used. Here is more about it https://msdn.microsoft.com/en-us/library/windows/desktop/dd317752%28v=vs.85%29.aspx The patch fixes not only issues with multibyte filenames under incompatible codepages, but indirectly also issues with some other multibyte encodings like BIG5, Shift-JIS, etc. by providing a clean way to access filenames in UTF-8. Below is a small list of issues from the bug tracker, that are getting fixed: https://bugs.php.net/63401 https://bugs.php.net/41199 https://bugs.php.net/50203 https://bugs.php.net/71509 https://bugs.php.net/64699 https://bugs.php.net/64506 https://bugs.php.net/30195 https://bugs.php.net/65358 https://bugs.php.net/61315 https://bugs.php.net/70943 https://bugs.php.net/70903 https://bugs.php.net/63593 https://bugs.php.net/54977 https://bugs.php.net/54028 https://bugs.php.net/43148 https://bugs.php.net/30730 https://bugs.php.net/33350 https://bugs.php.net/35300 https://bugs.php.net/46990 https://bugs.php.net/61309 https://bugs.php.net/69333 https://bugs.php.net/45517 https://bugs.php.net/70551 https://bugs.php.net/50197 https://bugs.php.net/72200 https://bugs.php.net/37672 Yet more related tickets can for sure be found - on bugs.php.net, Stackoverflow and Github. Some of the bugs are pretty recent, some descend to early 2000th, but the user comments in there last even till today. Just for example, bug #30195 was opened in 2004, the latest comment in there was made in 2014. It is certain, that these bugs descend not only to pure PHP use cases, but get also redirected from the popular PHP based projects. Given the modern systems (and those supported by PHP) are always based on NTFS, there is no excuse to keep these issues unresolved. The internalization approach on Windows is in many ways different from UNIX and Linux, while it supports and is based on Unicode. It depends on the current system code page, APIs used and exact kind how the binary was compiled The locale doesn't affect the way Unicode or ANSI API work. PHP in particular is being compiled without _UNICODE defined and this is conditioned by the way we handle strings. Here is more about it https://msdn.microsoft.com/en-us/library/tsbaswba.aspx However, with any system code page ANSI functions automatically convert paths to UTF-16. Paths in some encodings incompatible with the current system code page, won't work correctly with ANSI APIs. PHP till now only uses the ANSI Windows APIs. For example, on a system with the current code page 1252, the paths in cp1252 are supported and transparently converted to UTF-16 by the ANSI functions. Once one wants to handle a filepath encoded with cp932 on that particular system, an ANSI or a POSIX compatible function used in PHP will produce an erroneous result. When trying to convert that cp932 path to UTF-8 and passing to the ANSI functions, an ANSI function would likely interpret the UTF-8 string as some string in the current code page and create a filepath that represents every single byte of the UTF-8 string. These behaviors are not only broken but also disregard the documented INI settings. This patch solves the issies with the multibyte paths on Windows by intelligently enforcing the usage of the Unicode aware APIs. For functions expect Unicode (fe CreateFileW, FindFirstFileW, etc.), arguments will be converted to UTF-16 wide chars. For functions returning Unicode aware data (fe GetCurrentDirectoryW, etc.), resulting wide string is converted back to char's depending on the current PHP charset settings, either to the current ANSI codepage (this is the behavior prior to this patch) or to UTF-8 (the default behavior). In a particular case, users might have to explicitly set internal_encoding or default_charset, if filenames in ANSI codepage are necessary. Current tests show no regressions and witness that this will be an exotic case, the current default UTF-8 encoding is compatible with any supported system. The dependency libraries are long switching to Unicode APIs, so some tests were also added for extensions not directly related to streams. At large, the patch brings over 150 related tests into the core. Those target and was run on various environments with European, Asian, etc. codepages. General PHP frameworks was tested and showed no regressions. The impact on the current C code base is low, the most places affected are the Windows only places in the three files tsrm_win32.c, zend_virtual_cwd.c and plain_wrapper.c. The actual implementation of the most of the wide char supporting functionality is in win32/ioutil.* and win32/codepage.*, several low level functionsare extended in place to avoid reimplementation for now. No performance impact was sighted. As previously mentioned, the ANSI APIs used prior the patch perform Unicode conversions internally. Using the Unicode APIs directly while doing custom conversions just retains the status quo. The ways to optimize it are open (fe. by implementing caching for the strings converted to wide variants). The long path implementation is user transparent. If a path exceeds the length of _MAX_PATH, it'll be automatically prefixed with \\?\. The MAXPATHLEN is set to 2048 bytes. Appreciation to Pierre Joye, Matt Ficken, @algo13 and others for tips, ideas and testing. Thanks.	10 years ago
Joe Watkins	233115ea23	fix #71609 : Segmentation fault on ZTS with gethostbyname	10 years ago
Nikita Popov	1ac152938c	Move semicolon into TSRMLS_CACHE_EXTERN/DEFINE Also re bug #71575.	10 years ago
Xinchen Hui	97a9470d97	bump year which is missed in rev `49493a2`	10 years ago
Lior Kaplan	c51e73c803	Happy new year (Update copyright to 2016)	10 years ago
Anatol Belski	0e50a4c008	correct snprintf usage	10 years ago
Anatol Belski	4224907864	fix stack overflow	10 years ago
Anatol Belski	5b58d85186	fix stack overflow	10 years ago
Anatol Belski	d5bd999a8f	don't leak handles	10 years ago
Anatol Belski	3331d870aa	use correct function to close handles	10 years ago
Anatol Belski	afe04911a7	unmap correct handle	10 years ago
Anatol Belski	faa50318a3	nullify the memory chunk to avoid crashes when freeing resource	10 years ago
Anatol Belski	0e843a4582	check for NULL return	10 years ago
Anatol Belski	59d3529f29	cleanup an atavism no DOS support here )	11 years ago
Anatol Belski	94e272f1b3	TSRM_TLS should be usable in NTS build	11 years ago
Anatol Belski	ffa341de59	add macro to access globals as whole	11 years ago
Anatol Belski	3cd3881574	backported patch for bug #69472	11 years ago
Anatol Belski	fca341699e	don't pass zero to malloc()	11 years ago
Anatol Belski	d428bf2d4e	improve debugability in TS debug builds gdb seems to be not always able to fetch the correct context for thread locals. Thus, the "if (TSRMLS_CACHE)" clause causes gdb to show crashes which aren't recognized neither with helgrind nor in release builds. This is reproducable by setting breakpoints on the exact line where PHP has a tsrm_get_ls_cache() call.	11 years ago
Anatol Belski	af3ca74501	made ZEND_TSRMLS_CACHE_* macros look like function calls which also comply with the current semantics for such macros	11 years ago
Xinchen Hui	fc33f52d8c	bump year	11 years ago
Xinchen Hui	0579e8278d	bump year	11 years ago
Xinchen Hui	73c1be2653	Bump year	11 years ago
Stanislav Malyshev	b7a7b1a624	trailing whitespace removal	11 years ago
Anatol Belski	2bc63e7b6d	missed include for intptr_t/uintptr_t	11 years ago
Anatol Belski	d59fc5951e	use cleaner tsrm_intptr_t/tsrm_uintptr_t typedef	11 years ago
Ferenc Kovacs	a9e86957c7	fix zts build on mac/clang	11 years ago
Anatol Belski	24f0d2ed54	make the TSRM macros depend no the macroed cache name	11 years ago
Anatol Belski	64b423d6ed	removed the extra tsrm pointer passed to ctor/dtor	11 years ago
Anatol Belski	bdeb220f48	first shot remove TSRMLS_* things	11 years ago
Anatol Belski	de99a94c38	explicit passing of *tsrm_ls isn't needed anymore	11 years ago
Anatol Belski	22be00cb3c	TSRMLS_D should be void, thanks Dmitry	11 years ago
Anatol Belski	0180912823	default tsrmls cache to NULL	11 years ago
Anatol Belski	e6ea376a91	avoid repeated strlen usage, remove unused vars	11 years ago
Anatol Belski	999d387bf8	move these functions to the appropriate place and include the necessary header	11 years ago
Anatol Belski	20f8f533e1	fix datatype mismatch warns	11 years ago
Anatol Belski	8aeffdd74c	moved most of the core to use static tsrm ls cache pointer plus apache2handler, cli and cgi	11 years ago

1 2 3 4 5 ...

542 Commits (b71023e2977e44fd3bd94516eaebf77fd9907dd9)