Browse Source

fix for bug 26737 : private & protected member variables not serialized

when user defined __sleep() is declared. Additionally E_NOTICE is
being thrown if __sleep() returns a non-existing member variable name
PHP-5.1
Andrey Hristov 22 years ago
parent
commit
dd5538566e
  1. 36
      ext/standard/var.c
  2. 7
      tests/classes/bug26737.phpt

36
ext/standard/var.c

@ -578,14 +578,40 @@ static void php_var_serialize_class(smart_str *buf, zval **struc, zval *retval_p
smart_str_appendl(buf,"N;", 2);
continue;
}
php_var_serialize_string(buf, Z_STRVAL_PP(name), Z_STRLEN_PP(name));
if (zend_hash_find(Z_OBJPROP_PP(struc), Z_STRVAL_PP(name),
Z_STRLEN_PP(name) + 1, (void *) &d) == SUCCESS) {
php_var_serialize_intern(buf, d, var_hash TSRMLS_CC);
php_var_serialize_string(buf, Z_STRVAL_PP(name), Z_STRLEN_PP(name));
php_var_serialize_intern(buf, d, var_hash TSRMLS_CC);
} else {
php_var_serialize_intern(buf, &nvalp, var_hash TSRMLS_CC);
zend_class_entry *ce;
ce = zend_get_class_entry(*struc TSRMLS_CC);
if (ce) {
char *prot_name, *priv_name;
int prop_name_length;
do {
zend_mangle_property_name(&priv_name, &prop_name_length, ce->name, ce->name_length,
Z_STRVAL_PP(name), Z_STRLEN_PP(name) + 1, ce->type & ZEND_INTERNAL_CLASS);
if (zend_hash_find(Z_OBJPROP_PP(struc), priv_name, prop_name_length, (void *) &d) == SUCCESS) {
php_var_serialize_string(buf, priv_name, prop_name_length-1);
php_var_serialize_intern(buf, d, var_hash TSRMLS_CC);
break;
}
zend_mangle_property_name(&prot_name, &prop_name_length, "*", 1,
Z_STRVAL_PP(name), Z_STRLEN_PP(name) + 1, ce->type & ZEND_INTERNAL_CLASS);
if (zend_hash_find(Z_OBJPROP_PP(struc), prot_name, prop_name_length, (void *) &d) == SUCCESS) {
php_var_serialize_string(buf, prot_name, prop_name_length - 1);
php_var_serialize_intern(buf, d, var_hash TSRMLS_CC);
break;
}
php_error_docref(NULL TSRMLS_CC, E_NOTICE, "\"%s\" returned as member variable from __sleep() but does not exist", Z_STRVAL_PP(name));
php_var_serialize_string(buf, Z_STRVAL_PP(name), Z_STRLEN_PP(name));
php_var_serialize_intern(buf, &nvalp, var_hash TSRMLS_CC);
} while (0);
} else {
php_var_serialize_string(buf, Z_STRVAL_PP(name), Z_STRLEN_PP(name));
php_var_serialize_intern(buf, &nvalp, var_hash TSRMLS_CC);
}
}
}
}

7
tests/classes/bug26737.phpt

@ -10,12 +10,13 @@ class foo
public function __sleep()
{
return array('private', 'protected', 'public');
return array('private', 'protected', 'public', 'no_such');
}
}
$foo = new foo();
$data = serialize($foo);
var_dump(str_replace("\0", '\0', $data));
?>
--EXPECT--
string(76) "O:3:"foo":3:{s:7:"private";N;s:9:"protected";R:2;s:6:"public";s:6:"public";}"
--EXPECTF--
Notice: serialize(): "no_such" returned as member variable from __sleep() but does not exist in %s on line %d
string(130) "O:3:"foo":4:{s:12:"\0foo\0private";s:7:"private";s:12:"\0*\0protected";s:9:"protected";s:6:"public";s:6:"public";s:7:"no_such";N;}"
Loading…
Cancel
Save