From daaf706df07f045bfe85a3d48905857ca93dc27f Mon Sep 17 00:00:00 2001 From: Peter Kokot Date: Sat, 28 Jul 2018 23:09:06 +0200 Subject: [PATCH] Upgrade deprecated AC_OUTPUT macro calls Autoconf 2.50 made several changes to macro calls. These include also arguments passed to AC_OUTPUT macro. The upgrading chapter in Autoconf documentation include an example of using AC_OUTPUT with AC_CONFIG_FILES and AC_CONFIG_COMMANDS: - https://www.gnu.org/software/autoconf/manual/autoconf-2.69/html_node/Obsolete-Macros.html PHP 5.4 to 7.1 require Autoconf 2.59+, PHP 7.2+ require Autoconf 2.64+, and PHP 7.2 phpize script requires Autoconf 2.59+ which are all greater than above mentioned 2.50 version. Systems out there should well support this by now. This patch was created with the help of autoupdate script: autoupdate More info on where exactly this got deprecated: - ftp://ftp.gnu.org/old-gnu/Manuals/autoconf-2.13/html_mono/autoconf.html - ftp://ftp.auckland.ac.nz/pub/gnu/Manuals/autoconf-2.52/html_chapter/autoconf_15.html - http://git.savannah.gnu.org/cgit/autoconf.git/tree/NEWS --- TSRM/configure.ac | 3 ++- Zend/configure.ac | 3 ++- acinclude.m4 | 2 +- configure.ac | 4 +++- scripts/phpize.m4 | 2 +- 5 files changed, 9 insertions(+), 5 deletions(-) diff --git a/TSRM/configure.ac b/TSRM/configure.ac index 6f036727c88..c3ed326bce5 100644 --- a/TSRM/configure.ac +++ b/TSRM/configure.ac @@ -31,4 +31,5 @@ unistd.h \ limits.h ) -AC_OUTPUT(Makefile) +AC_CONFIG_FILES([Makefile]) +AC_OUTPUT diff --git a/Zend/configure.ac b/Zend/configure.ac index 4d0cf4c018d..73a001a7df5 100644 --- a/Zend/configure.ac +++ b/Zend/configure.ac @@ -125,7 +125,8 @@ LIBZEND_OTHER_CHECKS ZEND_EXTRA_LIBS="$LIBS" LIBS="" AC_SUBST(ZEND_EXTRA_LIBS) -AC_OUTPUT(Makefile) +AC_CONFIG_FILES([Makefile]) +AC_OUTPUT # Local Variables: # tab-width: 4 diff --git a/acinclude.m4 b/acinclude.m4 index 7556a347345..e04545ad05e 100644 --- a/acinclude.m4 +++ b/acinclude.m4 @@ -94,7 +94,7 @@ dnl dnl PHP_SUBST_OLD(varname) dnl dnl Same as PHP_SUBST() but also substitutes all @VARNAME@ -dnl instances in every file passed to AC_OUTPUT() +dnl instances in every file passed to AC_OUTPUT dnl AC_DEFUN([PHP_SUBST_OLD],[ PHP_SUBST($1) diff --git a/configure.ac b/configure.ac index 98d567a5872..e7530f70a32 100644 --- a/configure.ac +++ b/configure.ac @@ -1567,7 +1567,8 @@ PHP_CHECK_CONFIGURE_OPTIONS dnl dnl Generate build files dnl -AC_OUTPUT($ALL_OUTPUT_FILES, [], [ +AC_CONFIG_FILES([$ALL_OUTPUT_FILES]) +AC_CONFIG_COMMANDS([default],[],[ if test "\$CONFIG_FILES" = "$ALL_OUTPUT_FILES" || test "\$CONFIG_FILES" = " $ALL_OUTPUT_FILES" || test -z "\$CONFIG_FILES"; then REDO_ALL=yes @@ -1698,6 +1699,7 @@ Check '[$]0 --help' for available options fi ]) +AC_OUTPUT dnl ## Local Variables: dnl ## tab-width: 4 diff --git a/scripts/phpize.m4 b/scripts/phpize.m4 index e4b2029eb1c..f234e68ea8a 100644 --- a/scripts/phpize.m4 +++ b/scripts/phpize.m4 @@ -199,4 +199,4 @@ touch .deps AC_CONFIG_HEADERS([config.h]) -AC_OUTPUT() +AC_OUTPUT