Browse Source

MFH: Fix bug #43364 (recursive xincludes don't remove internal nodes properly)

add test
PHP-5.2.1RC1
Rob Richards 19 years ago
parent
commit
d5afff5286
  1. 4
      ext/dom/document.c
  2. 40
      ext/dom/tests/bug43364.phpt

4
ext/dom/document.c

@ -1737,6 +1737,10 @@ static void php_dom_remove_xinclude_nodes(xmlNodePtr cur TSRMLS_DC) {
/* XML_XINCLUDE_END node will be a sibling of XML_XINCLUDE_START */
while(cur && cur->type != XML_XINCLUDE_END) {
/* remove xinclude processing nodes from recursive xincludes */
if (cur->type == XML_ELEMENT_NODE) {
php_dom_remove_xinclude_nodes(cur->children TSRMLS_CC);
}
cur = cur->next;
}

40
ext/dom/tests/bug43364.phpt

@ -0,0 +1,40 @@
--TEST--
Bug #43364 (recursive xincludes don't remove internal xml nodes properly)
--FILE--
<?php
function loopElements($nodes)
{
$count = 0;
foreach($nodes as $node) {
if($node instanceof DOMElement) {
$count++;
if($node->childNodes->length > 0) {
$count += loopElements($node->childNodes);
}
}
}
return $count;
}
$xml = <<<DOC
<?xml version="1.0" encoding="UTF-8"?>
<root xmlns:xi="http://www.w3.org/2001/XInclude">
<a>
<a_child1>ac1</a_child1>
<a_child2>ac2</a_child2>
</a>
<b><xi:include xpointer="xpointer(/root/a)" /></b>
<c><xi:include xpointer="xpointer(/root/b)" /></c>
</root>
DOC;
$doc = new DomDocument();
$doc->loadXml($xml);
$doc->xinclude();
$count = loopElements(array($doc->documentElement));
var_dump($count);
?>
--EXPECT--
int(13)
Loading…
Cancel
Save