From 94040a28ce4a90d00da051dbb1968d5e029ac396 Mon Sep 17 00:00:00 2001 From: Andrey Hristov Date: Sat, 22 Feb 2003 10:54:26 +0000 Subject: [PATCH] rehash only in case something is changed. #lowers the execution time in half on my machine on array with 1000 elements #with nonscalar keys. Maybe it can be optimized further. --- ext/standard/array.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ext/standard/array.c b/ext/standard/array.c index 32edd74c1f9..cf4f1889cf8 100644 --- a/ext/standard/array.c +++ b/ext/standard/array.c @@ -1866,7 +1866,9 @@ static void _phpi_pop(INTERNAL_FUNCTION_PARAMETERS, int off_the_end) p = p->pListNext; } Z_ARRVAL_PP(stack)->nNextFreeElement = k; - zend_hash_rehash(Z_ARRVAL_PP(stack)); + if (k) { + zend_hash_rehash(Z_ARRVAL_PP(stack)); + } } else if (!key_len) { Z_ARRVAL_PP(stack)->nNextFreeElement = Z_ARRVAL_PP(stack)->nNextFreeElement - 1; }