Browse Source

do not search for empty strings with strpos() and strrpos()

PECL_OPENSSL
Antony Dovgal 20 years ago
parent
commit
7d7f84562c
  1. 8
      ext/iconv/iconv.c
  2. 6
      ext/iconv/tests/iconv_strpos.phpt
  3. 6
      ext/iconv/tests/iconv_strrpos.phpt

8
ext/iconv/iconv.c

@ -1946,6 +1946,10 @@ PHP_FUNCTION(iconv_strpos)
RETURN_FALSE;
}
if (ndl_len < 1) {
RETURN_FALSE;
}
err = _php_iconv_strpos(&retval, haystk, haystk_len, ndl, ndl_len,
offset, charset);
_php_iconv_show_error(err, GENERIC_SUPERSET_NAME, charset TSRMLS_CC);
@ -1981,6 +1985,10 @@ PHP_FUNCTION(iconv_strrpos)
RETURN_FALSE;
}
if (ndl_len < 1) {
RETURN_FALSE;
}
err = _php_iconv_strpos(&retval, haystk, haystk_len, ndl, ndl_len,
-1, charset);
_php_iconv_show_error(err, GENERIC_SUPERSET_NAME, charset TSRMLS_CC);

6
ext/iconv/tests/iconv_strpos.phpt

@ -31,6 +31,10 @@ foo(str_repeat("abcab", 60)."abcdb".str_repeat("adabc", 60), "abcd", 0);
foo(str_repeat("あいうえお", 30)."いうおえあ".str_repeat("あいえおう", 30), "うお", 0, "EUC-JP");
$str = str_repeat("あいうえお", 60).'$'.str_repeat("あいえおう", 60);
foo($str, '$', 0, "ISO-2022-JP", "EUC-JP");
var_dump(iconv_strpos("string", ""));
var_dump(iconv_strpos("", "string"));
?>
--EXPECTF--
2: %s
@ -50,3 +54,5 @@ int(302)
int(151)
int(1)
int(300)
bool(false)
bool(false)

6
ext/iconv/tests/iconv_strrpos.phpt

@ -32,6 +32,10 @@ for ($i = 0; $i <=6; ++$i) {
$str = str_repeat("あいうえお", 60).str_repeat('$', $i).str_repeat("あいえおう", 60);
foo($str, '$', "ISO-2022-JP", "EUC-JP");
}
var_dump(iconv_strrpos("string", ""));
var_dump(iconv_strrpos("", "string"));
?>
--EXPECT--
int(14)
@ -54,3 +58,5 @@ int(605)
int(304)
int(606)
int(305)
bool(false)
bool(false)
Loading…
Cancel
Save