From 17a57ad980f9585fd614101af590c8086a2b7c17 Mon Sep 17 00:00:00 2001 From: Anatol Belski Date: Mon, 24 Mar 2014 10:24:37 +0100 Subject: [PATCH 1/2] Fixed bug #65715 php5embed.lib isn't provided anymore --- sapi/embed/config.w32 | 2 ++ win32/build/confutils.js | 19 +++++++++++++++++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/sapi/embed/config.w32 b/sapi/embed/config.w32 index f3cc60d6007..64e44bdd94c 100644 --- a/sapi/embed/config.w32 +++ b/sapi/embed/config.w32 @@ -3,6 +3,8 @@ ARG_ENABLE('embed', 'Embedded SAPI library', 'no'); +var PHP_EMBED_PGO = false; + if (PHP_EMBED != "no") { SAPI('embed', 'php_embed.c', 'php' + PHP_VERSION + 'embed.lib'); PHP_INSTALL_HEADERS("sapi/embed", "php_embed.h"); diff --git a/win32/build/confutils.js b/win32/build/confutils.js index e0df4f621b5..489aa09bd55 100644 --- a/win32/build/confutils.js +++ b/win32/build/confutils.js @@ -1015,6 +1015,21 @@ function generate_version_info_resource(makefiletarget, basename, creditspath, s return resname; } +/* Check if PGO is enabled for given module. To disable PGO for a particular module, +define a global variable by the following name scheme before SAPI() or EXTENSION() call + var PHP_MYMODULE_PGO = false; */ +function is_pgo_desired(mod) +{ + var varname = "PHP_" + mod.toUpperCase() + "_PGO"; + + /* don't disable if there's no mention of the varname */ + if (eval("typeof " + varname + " == 'undefined'")) { + return true; + } + + return eval("!!" + varname); +} + function SAPI(sapiname, file_list, makefiletarget, cflags, obj_dir) { var SAPI = sapiname.toUpperCase(); @@ -1066,7 +1081,7 @@ function SAPI(sapiname, file_list, makefiletarget, cflags, obj_dir) manifest = "-@$(_VC_MANIFEST_EMBED_EXE)"; } - if(PHP_PGI == "yes" || PHP_PGO != "no") { + if(is_pgo_desired(sapiname) && (PHP_PGI == "yes" || PHP_PGO != "no")) { ldflags += " /PGD:$(PGOPGD_DIR)\\" + makefiletarget.substring(0, makefiletarget.indexOf(".")) + ".pgd"; } @@ -1252,7 +1267,7 @@ function EXTENSION(extname, file_list, shared, cflags, dllname, obj_dir) var ld = "@$(CC)"; ldflags = ""; - if (PHP_PGI == "yes" || PHP_PGO != "no") { + if (is_pgo_desired(extname) && (PHP_PGI == "yes" || PHP_PGO != "no")) { ldflags = " /PGD:$(PGOPGD_DIR)\\" + dllname.substring(0, dllname.indexOf(".")) + ".pgd"; } From 5efda763be97e36fd5c033a42c643357ed83782f Mon Sep 17 00:00:00 2001 From: Anatol Belski Date: Mon, 24 Mar 2014 10:28:21 +0100 Subject: [PATCH 2/2] updated NEWS --- NEWS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/NEWS b/NEWS index 302ea6c0d16..a82989ba4e8 100644 --- a/NEWS +++ b/NEWS @@ -1,6 +1,8 @@ PHP NEWS ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||| ?? ??? 2014, PHP 5.4.28 +- Embed: + . Fixed bug #65715 (php5embed.lib isn't provided anymore). (Anatol) ?? ??? 2014, PHP 5.4.27