Browse Source

MFB: Added missing format validator to unpack() function

PHAR_1_2
Ilia Alshanetsky 19 years ago
parent
commit
60a7d31254
  1. 6
      ext/standard/pack.c
  2. 11
      ext/standard/tests/strings/unpack.phpt

6
ext/standard/pack.c

@ -613,6 +613,12 @@ PHP_FUNCTION(unpack)
case 'd':
size = sizeof(double);
break;
default:
php_error_docref(NULL TSRMLS_CC, E_WARNING, "Invalid format type %c", type);
zval_dtor(return_value);
RETURN_FALSE;
break;
}
/* Do actual unpacking */

11
ext/standard/tests/strings/unpack.phpt

@ -0,0 +1,11 @@
--TEST--
Invalid format type validation
--FILE--
<?php
var_dump(unpack("-2222", 1));
echo "Done\n";
?>
--EXPECTF--
Warning: unpack(): Invalid format type - in %s/unpack.php on line %d
bool(false)
Done
Loading…
Cancel
Save