Mirrors
/
php
mirror of https://github.com/php/php-src
3
0
Fork 0
Code Releases Activity
Browse Source

Really use 62 as the upper boundary as requested and not 32.

experimental/5.3-FPM
David Soria Parra 17 years ago
parent
23f4da9113
commit
579a6e39de
2 changed files with 16 additions and 12 deletions
Whitespace
Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL
Split View
Diff Options
Show Stats Download Patch File Download Diff File
  1. 2
      ext/gmp/gmp.c
  2. 26
      ext/gmp/tests/bug50283.phpt

2
ext/gmp/gmp.c
View File

@ -796,7 +796,7 @@ ZEND_FUNCTION(gmp_strval)
return;
}
if ((base < 2 && base > -2) || base > 36 || base < -36) {
if ((base < 2 && base > -2) || base > 62 || base < -36) {
php_error_docref(NULL TSRMLS_CC, E_WARNING, "Bad base for conversion: %ld", base);
RETURN_FALSE;
}

26
ext/gmp/tests/bug50283.phpt
View File

@ -5,25 +5,29 @@ Feature Request #50283 (allow base in gmp_strval to use full range: 2 to 62, and
--FILE--
<?php
$a = gmp_init("0x41682179fbf5");
printf("Decimal: %s, 36-based: %s\n", gmp_strval($a), gmp_strval($a,-36));
printf("Decimal: %s, -36-based: %s\n", gmp_strval($a), gmp_strval($a,-36));
printf("Decimal: %s, 36-based: %s\n", gmp_strval($a), gmp_strval($a,36));
printf("Decimal: %s, 36-based: %s\n", gmp_strval($a), gmp_strval($a,-1));
printf("Decimal: %s, 36-based: %s\n", gmp_strval($a), gmp_strval($a,1));
printf("Decimal: %s, 36-based: %s\n", gmp_strval($a), gmp_strval($a,-37));
printf("Decimal: %s, 36-based: %s\n", gmp_strval($a), gmp_strval($a,37));
printf("Decimal: %s, -1-based: %s\n", gmp_strval($a), gmp_strval($a,-1));
printf("Decimal: %s, 1-based: %s\n", gmp_strval($a), gmp_strval($a,1));
printf("Decimal: %s, -37-based: %s\n", gmp_strval($a), gmp_strval($a,-37));
printf("Decimal: %s, 37-based: %s\n", gmp_strval($a), gmp_strval($a,37));
printf("Decimal: %s, 62-based: %s\n", gmp_strval($a), gmp_strval($a,62));
printf("Decimal: %s, 63-based: %s\n", gmp_strval($a), gmp_strval($a,63));
?>
--EXPECTF--
Decimal: 71915494046709, 36-based: PHPISCOOL
Decimal: 71915494046709, -36-based: PHPISCOOL
Decimal: 71915494046709, 36-based: phpiscool
Warning: gmp_strval(): Bad base for conversion: -1 in %s on line 5
Decimal: 71915494046709, 36-based:
Decimal: 71915494046709, -1-based:
Warning: gmp_strval(): Bad base for conversion: 1 in %s on line 6
Decimal: 71915494046709, 36-based:
Decimal: 71915494046709, 1-based:
Warning: gmp_strval(): Bad base for conversion: -37 in %s on line 7
Decimal: 71915494046709, 36-based:
Decimal: 71915494046709, -37-based:
Decimal: 71915494046709, 37-based: KHKATELJF
Decimal: 71915494046709, 62-based: KQ6yq741
Warning: gmp_strval(): Bad base for conversion: 37 in %s on line 8
Decimal: 71915494046709, 36-based:
Warning: gmp_strval(): Bad base for conversion: 63 in %s on line 10
Decimal: 71915494046709, 63-based:
Write Preview
Loading…
Cancel
Save