From 4b6328e05250bd4627bc290ad160b837af83bc34 Mon Sep 17 00:00:00 2001 From: Uwe Steinmann Date: Tue, 14 Sep 1999 14:47:14 +0000 Subject: [PATCH] - fixed memory leaks in pdf_open_memory_image() and pdf_add_bookmark() --- ext/pdf/pdf.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ext/pdf/pdf.c b/ext/pdf/pdf.c index b32a25d9d70..3d6d65afad0 100644 --- a/ext/pdf/pdf.c +++ b/ext/pdf/pdf.c @@ -177,6 +177,7 @@ static void _free_pdf_doc(PDF *pdf) static void _free_outline(int *outline) { + if(outline) efree(outline); } PHP_MINIT_FUNCTION(pdf) @@ -1829,7 +1830,7 @@ PHP_FUNCTION(pdf_add_outline) { } outline=emalloc(sizeof(int)); - *outline = PDF_add_bookmark(pdf, estrdup(arg2->value.str.val), parentid, open); + *outline = PDF_add_bookmark(pdf, arg2->value.str.val, parentid, open); id = php3_list_insert(outline,PDF_GLOBAL(le_outline)); RETURN_LONG(id); } @@ -2038,9 +2039,11 @@ PHP_FUNCTION(pdf_open_memory_image) { #else pdf_image = PDF_open_image(pdf, "raw", "memory", buffer, im->sx*im->sy*3, im->sx, im->sy, 3, 8, NULL); #endif + efree(buffer); if(-1 == pdf_image) { php3_error(E_WARNING, "Could not open image"); + efree(buffer); RETURN_FALSE; }