Browse Source

clean up - remove checked questions

pull/700/merge
Xinchen Hui 12 years ago
parent
commit
35dd200430
  1. 5
      ext/mysql/php_mysql.c
  2. 4
      ext/session/session.c
  3. 1
      ext/sqlite3/sqlite3.c

5
ext/mysql/php_mysql.c

@ -641,10 +641,9 @@ PHP_RINIT_FUNCTION(mysql)
/* }}} */
#if defined(A0) && defined(MYSQL_USE_MYSQLND)
static int php_mysql_persistent_helper(zval *el;zend_rsrc_list_entry *le TSRMLS_DC)
static int php_mysql_persistent_helper(zval *el TSRMLS_DC)
{
//???
//zend_rsrc_list_entry *le = (zend_rsrc_list_entry*)Z_PTR_P(el);
zend_resource *le = (zend_resource *)Z_PTR_P(el);
if (le->type == le_plink) {
mysqlnd_end_psession(((php_mysql_conn *) le->ptr)->conn);
}

4
ext/session/session.c

@ -1935,8 +1935,8 @@ static PHP_FUNCTION(session_id)
}
if (PS(id)) {
//??? keep compatibility for "\0" characters
//??? see: ext/session/tests/session_id_error3.phpt
/* keep compatibility for "\0" characters
/ see: ext/session/tests/session_id_error3.phpt */
int len = strlen(PS(id)->val);
if (UNEXPECTED(len != PS(id)->len)) {
RETVAL_STR(STR_INIT(PS(id)->val, len, 0));

1
ext/sqlite3/sqlite3.c

@ -2002,7 +2002,6 @@ static void php_sqlite3_free_list_dtor(void **item)
static int php_sqlite3_compare_stmt_zval_free(php_sqlite3_free_list **free_list, zval *statement ) /* {{{ */
{
//????? return ((*free_list)->stmt_obj->initialised && statement == (*free_list)->stmt_obj_zval);
return ((*free_list)->stmt_obj->initialised && Z_PTR_P(statement) == Z_PTR((*free_list)->stmt_obj_zval));
}
/* }}} */

Loading…
Cancel
Save