Browse Source

Fixed Bug #66412 readline_clear_history() with libedit causes segfault after #65714

Checking all libedit functions, this check is done in each functions (add_history,
read_history, write_history, ...) but is missing in clear_history.

Test coverage: readline_clear_history_001.phpt
PHP-5.5.9
Remi Collet 12 years ago
parent
commit
31d67bd353
  1. 4
      NEWS
  2. 5
      ext/readline/readline.c

4
NEWS

@ -17,6 +17,10 @@ PHP NEWS
. Fixed bug #66298 (ext/opcache/Optimizer/zend_optimizer.c has dos-style
^M as lineend). (Laruence)
- Readline
. Fixed Bug #66412 (readline_clear_history() with libedit causes segfault after
#65714). (Remi)
- Session
. Fixed bug #66469 (Session module is sending multiple set-cookie headers when
session.use_strict_mode=1) (Yasuo)

5
ext/readline/readline.c

@ -354,6 +354,11 @@ PHP_FUNCTION(readline_clear_history)
return;
}
#if HAVE_LIBEDIT
/* clear_history is the only function where rl_initialize
is not call to ensure correct allocation */
using_history();
#endif
clear_history();
RETURN_TRUE;

Loading…
Cancel
Save