Browse Source

removed ->is_ref check, doesn't make sense and causes bugs

experimental/namespaces
Harald Radi 25 years ago
parent
commit
21b9a2ca2a
  1. 16
      ext/com/TODO
  2. 2
      ext/com/conversion.c
  3. 16
      ext/rpc/com/TODO
  4. 2
      ext/rpc/com/conversion.c

16
ext/com/TODO

@ -1,5 +1,5 @@
1) Multi-dimenstional array support
2) IErrorInfo
-- done 2) IErrorInfo
3) WithEvents
4) Documentation (internal and user) and howtos
5) IEnumVariant::All() which would be like IEnumVariant::Next(IDispatch::Count)
@ -8,9 +8,17 @@
8) Test suite (Needs test component)
9) reduce the need for VARIANT()
10) lets try if we are able to call non IDispatch - only Typelib components
11) IEnumVariant::Next() without parameter should only return an object, not an array with one element
-- done 11) IEnumVariant::Next() without parameter should only return an object, not an array with one element
12) VARIANT->value as lvalue
these seem to be done:
ad 6.) check vbsample.php (new VARIANT(*, *|VT_BYREF)) GPs
ad 4.) faq (i've collected a few questions from various lists)
2) 6) 11)
to be discussed:
- dcom inporc issue
- mts support (getcontext)
- adsi support (ads* functions)
- winapi interface
- try serialisation support (if component implements IPersist)

2
ext/com/conversion.c

@ -86,7 +86,7 @@ PHPAPI void php_pval_to_variant(pval *pval_arg, VARIANT *var_arg, int codepage T
}
if (pval_arg->is_ref) { /* deprecated, implemented for downwards compatiblity */
type |= VT_BYREF;
// type |= VT_BYREF;
}
pval_to_variant_ex(pval_arg, var_arg, type, codepage TSRMLS_CC);

16
ext/rpc/com/TODO

@ -1,5 +1,5 @@
1) Multi-dimenstional array support
2) IErrorInfo
-- done 2) IErrorInfo
3) WithEvents
4) Documentation (internal and user) and howtos
5) IEnumVariant::All() which would be like IEnumVariant::Next(IDispatch::Count)
@ -8,9 +8,17 @@
8) Test suite (Needs test component)
9) reduce the need for VARIANT()
10) lets try if we are able to call non IDispatch - only Typelib components
11) IEnumVariant::Next() without parameter should only return an object, not an array with one element
-- done 11) IEnumVariant::Next() without parameter should only return an object, not an array with one element
12) VARIANT->value as lvalue
these seem to be done:
ad 6.) check vbsample.php (new VARIANT(*, *|VT_BYREF)) GPs
ad 4.) faq (i've collected a few questions from various lists)
2) 6) 11)
to be discussed:
- dcom inporc issue
- mts support (getcontext)
- adsi support (ads* functions)
- winapi interface
- try serialisation support (if component implements IPersist)

2
ext/rpc/com/conversion.c

@ -86,7 +86,7 @@ PHPAPI void php_pval_to_variant(pval *pval_arg, VARIANT *var_arg, int codepage T
}
if (pval_arg->is_ref) { /* deprecated, implemented for downwards compatiblity */
type |= VT_BYREF;
// type |= VT_BYREF;
}
pval_to_variant_ex(pval_arg, var_arg, type, codepage TSRMLS_CC);

Loading…
Cancel
Save