From 1ab7ea33cb756dd84e28d155703bf02af56412df Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20Calvi=C3=B1o=20S=C3=A1nchez?= <danxuliu@gmail.com>
Date: Thu, 14 May 2020 21:58:30 +0200
Subject: [PATCH] Ignore drag and drop events if files are not involved
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

If a drag and drop events does not involve files the drop hint should
not be shown, and the drop event does not need to be handled either. The
drag event may not contain yet the files in its "dataTransfer.files"
property, but at least one of the types included in its
"dataTransfer.types" property will be "Files".

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
---
 src/components/ChatView.vue | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/src/components/ChatView.vue b/src/components/ChatView.vue
index 230b1e101c..e60dcbff52 100644
--- a/src/components/ChatView.vue
+++ b/src/components/ChatView.vue
@@ -21,7 +21,7 @@
 <template>
 	<div
 		class="chatView"
-		@dragover.prevent="isDraggingOver = true"
+		@dragover.prevent="handleDragOver"
 		@dragleave.prevent="isDraggingOver = false"
 		@drop.prevent="handleDropFiles">
 		<transition name="slide" mode="out-in">
@@ -100,7 +100,17 @@ export default {
 
 	methods: {
 
+		handleDragOver(event) {
+			if (event.dataTransfer.types.includes('Files')) {
+				this.isDraggingOver = true
+			}
+		},
+
 		handleDropFiles(event) {
+			if (!this.isDraggingOver) {
+				return
+			}
+
 			// Restore non dragover state
 			this.isDraggingOver = false
 			// Stop the executin if the user is a guest