From c999fb9e26f944985ad63b9ec6d650ae3ac71e06 Mon Sep 17 00:00:00 2001 From: Vitor Mattos Date: Wed, 21 Dec 2022 12:44:38 -0300 Subject: [PATCH] Changes after code review * Text improvements https://github.com/nextcloud/spreed/pull/8471#discussion_r1052558815 * Use constant instead of hardcoded value https://github.com/nextcloud/spreed/pull/8471#discussion_r1052559391 Signed-off-by: Vitor Mattos --- docs/conversation.md | 4 ++-- lib/Controller/RoomController.php | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/docs/conversation.md b/docs/conversation.md index fbb928c69c..5348c84401 100644 --- a/docs/conversation.md +++ b/docs/conversation.md @@ -91,8 +91,8 @@ | `participants` | array | v1 | v2 | **Removed** | | `guestList` | string | v1 | v2 | **Removed** | | `avatarUrl` | string | v4 | | Avatar URL of the conversation including a version flag `v=…` for easier expiration of the avatar in case a moderator updates it, since the avatar endpoint should be cached for 24 hours. | -| `callStartTime` | int | v4 | | Call start time | -| `callRecording` | int | v4 | | Call recording status | +| `callStartTime` | int | v4 | | Timestamp when the call was started (only available with `recording-v1` capability) | +| `callRecording` | int | v4 | | Type of call recording (see [Constants - Call recording status](constants.md#call-recording-status)) (only available with `recording-v1` capability) | ## Creating a new conversation diff --git a/lib/Controller/RoomController.php b/lib/Controller/RoomController.php index 11dfb46524..6f509c5daa 100644 --- a/lib/Controller/RoomController.php +++ b/lib/Controller/RoomController.php @@ -399,7 +399,7 @@ class RoomController extends AEnvironmentAwareController { 'hasPassword' => $room->hasPassword(), 'hasCall' => false, 'callStartTime' => 0, - 'callRecording' => 0, + 'callRecording' => Room::RECORDING_NONE, 'canStartCall' => false, 'lastActivity' => 0, 'lastReadMessage' => 0,