From 16e1d57136046fa64c0bb3d13203d76bddb1e2ea Mon Sep 17 00:00:00 2001 From: Vincent Petry Date: Wed, 28 Apr 2021 09:58:00 +0200 Subject: [PATCH] Remove store usage in settingsService Adjust setPlaySounds service function to not rely on the store. Signed-off-by: Vincent Petry --- src/services/settingsService.js | 5 ++--- src/store/soundsStore.js | 6 +++--- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/services/settingsService.js b/src/services/settingsService.js index c6f3bab20c..7dc80c8048 100644 --- a/src/services/settingsService.js +++ b/src/services/settingsService.js @@ -23,7 +23,6 @@ import axios from '@nextcloud/axios' import { generateOcsUrl } from '@nextcloud/router' import BrowserStorage from './BrowserStorage' -import store from '../store/index' /** * Sets the attachment folder setting for the user @@ -67,9 +66,9 @@ const setSIPSettings = async function(sipGroups, sharedSecret, dialInInfo) { }) } -const setPlaySounds = async function(enabled) { +const setPlaySounds = async function(isGuest, enabled) { const savableValue = enabled ? 'yes' : 'no' - if (store.getters.getUserId()) { + if (!isGuest) { return axios.post(generateOcsUrl('apps/spreed/api/v1/settings', 2) + 'user', { key: 'play_sounds', value: savableValue, diff --git a/src/store/soundsStore.js b/src/store/soundsStore.js index 41cb057120..cf295b57a5 100644 --- a/src/store/soundsStore.js +++ b/src/store/soundsStore.js @@ -73,9 +73,9 @@ const actions = { * @param {object} context default store context; * @param {boolean} enabled Whether sounds should be played */ - async setPlaySounds({ commit }, enabled) { - await setPlaySounds(status) - commit('setPlaySounds', enabled) + async setPlaySounds(context, enabled) { + await setPlaySounds(!context.state.userId, status) + context.commit('setPlaySounds', enabled) }, }