Daniel Kesselberg
f8a45703d7
chore: remove scrutinizer
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
7 months ago
Ferdinand Thiessen
97ad171d32
refactor(IMimeTypeDetector): use consistent capitalization
- use consistantly `mimeType` as it is called MIME type
- fix issues where implementation and interface had different parameter
names (this is an issue since PHP has named parameters).
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
7 months ago
gavine99
ed6d76ec8d
fix(notifications): Change notification app orders
The notification manager always calls notify() of the 'main' notifications app
before other notify apps, and calls other functions for other notifications apps
before the 'main' notification app
Signed-off-by: gavine99 <github@xymail.tk>
7 months ago
dependabot[bot]
e9ec5d12c1
chore(deps-dev): bump guzzlehttp/guzzle in /build/integration
Bumps [guzzlehttp/guzzle](https://github.com/guzzle/guzzle ) from 7.9.2 to 7.9.3.
- [Release notes](https://github.com/guzzle/guzzle/releases )
- [Changelog](https://github.com/guzzle/guzzle/blob/7.9/CHANGELOG.md )
- [Commits](https://github.com/guzzle/guzzle/compare/7.9.2...7.9.3 )
---
updated-dependencies:
- dependency-name: guzzlehttp/guzzle
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
7 months ago
Côme Chilliet
da9b6e376d
fix(tests): Sort activities by id to get the last one
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
7 months ago
Côme Chilliet
140aba1f16
feat: Add context and test steps for activity in sharing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
7 months ago
Côme Chilliet
a57f694e8d
feat: add integration test for sharing activity
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
7 months ago
provokateurin
95df189595
feat(openapi): Generate merged spec for all apps
Signed-off-by: provokateurin <kate@provokateurin.de>
7 months ago
provokateurin
3732be59fd
fix(build): Also fail OpenAPI generation for untracked specs
Signed-off-by: provokateurin <kate@provokateurin.de>
7 months ago
Côme Chilliet
5ed5bef1ba
chore: Update OCP baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
7 months ago
Ferdinand Thiessen
92795b2091
chore(test): use consistent tabs for indention in behat tests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
7 months ago
Ferdinand Thiessen
251a19d6ea
chore(dev-deps): Drop dependency on jsdoc
It is not used anymore and it yields not usable documentation anymore.
This is a leftover from like 11 years ago.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
7 months ago
Ferdinand Thiessen
00d08a4f69
fix(lookup-server): disable lookup server for non-global scale setups
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
7 months ago
Côme Chilliet
253628ad5a
fix: Fix psalm issues and add missing methods to ITemplate interface
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
8 months ago
Côme Chilliet
71dc34c03c
fix: Deprecate OC_Template, add proper template manager instead
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
8 months ago
Louis Chemineau
c2f2f21673
feat: Support deleting metadata from WebDAV
The `$value` will be `null` if the update is wrapped inside a `<d:remove>...</d:remove>` block.
Signed-off-by: Louis Chemineau <louis@chmn.me>
8 months ago
provokateurin
eaa1b54d98
build(integration): Disable password_policy app
Signed-off-by: provokateurin <kate@provokateurin.de>
7 months ago
provokateurin
dd47daa4a8
fix(Share20): Convert broken hooks to IEventListener
Signed-off-by: provokateurin <kate@provokateurin.de>
8 months ago
provokateurin
8acfc0f0f2
refactor(TempManager): Simplify and unify implementations and remove legacy behavior
Signed-off-by: provokateurin <kate@provokateurin.de>
8 months ago
Ferdinand Thiessen
c82337f3b9
fix: incorrect types detected by updated stubs
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
8 months ago
Ferdinand Thiessen
0be4239c41
chore: Update php intl stub for PHP 8.0+
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
9 months ago
Côme Chilliet
485f3f495e
fix: Fix test by scanning group before using it
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
8 months ago
nextcloud-command
11d36e7607
fix(security): Update CA certificate bundle
Signed-off-by: GitHub <noreply@github.com>
8 months ago
Joas Schilling
0fc355aa1e
ci(autochecks): Run some autochecks also on non-PHP files
Signed-off-by: Joas Schilling <coding@schilljs.com>
8 months ago
dependabot[bot]
eb3c639c6b
bump behat/behat from 3.18.1 to 3.19.0 in /build/integration
---
updated-dependencies:
- dependency-name: behat/behat
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
8 months ago
Côme Chilliet
e757b649b7
fix: Fix psalm taint false-positives by small refactorings
Mostly make it clear that we trust admin input or that we correctly
escape strings.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
8 months ago
Côme Chilliet
640dbd0b5e
fix: Fix false-positive psalm taint errors when outputting plain text
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
8 months ago
Côme Chilliet
7c907223d2
fix: Fix psalm taint false-positive by escaping trusted input
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
8 months ago
Côme Chilliet
fa108d5b54
fix: Correctly tag json encoding in BaseResponse to fix false-positive
…in psalm taint analysis
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
8 months ago
Côme Chilliet
aac79bad9b
fix: Move config.php taint trust upstream directly in OC\Config class
This solves some false-positive psalm taint errors
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
8 months ago
Côme Chilliet
25f38883f1
fix: Work around false-positive psalm taint error calling print_r in admin_audit
Same issue as var_export, print_r is listed as sink but it’s not when
using return:true. Anyway, using the logger context feature is better.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
8 months ago
Côme Chilliet
fec865cc29
chore: Correctly flag json encoding methods as escaping html and quotes
Especially with JSON_HEX_TAG it’s perfectly fine to echo JSON, and we
only use it in JSON output anyway.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
8 months ago
Côme Chilliet
964bc960f8
chore: Update psalm-baseline-security.xml
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
8 months ago
Côme Chilliet
007335dadf
chore(rector): Enable Nextcloud 25 set for the apps folder
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
9 months ago
Joas Schilling
747bf1a241
fix(transifex): Adjust check for translation of apps
Signed-off-by: Joas Schilling <coding@schilljs.com>
8 months ago
Côme Chilliet
a4d7623ed7
chore: Update psalm baseline
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
8 months ago
Ferdinand Thiessen
2a0f81da53
fix(provisioning_api): Correct limit for `editUser`
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
8 months ago
Ferdinand Thiessen
729cdf6818
fix(FediverseAction): Ensure valid fediverse links are generated
Harden also for existing values of the profile.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
9 months ago
skjnldsv
6baafd82b6
fix: make sure we process mime extensions as string
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
8 months ago
Ferdinand Thiessen
73dc0f0f19
fix(sharing): Ensure download restrictions are not dropped
When a user receives a share with share-permissions but also with
download restrictions (hide download or the modern download permission attribute),
then re-shares of that share must always also include those restrictions.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
9 months ago
Ferdinand Thiessen
b48ee2e924
fix: Harden files scanner for invalid null access
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
9 months ago
Ferdinand Thiessen
0baab8fd98
test: Reset sharing app config after test
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
9 months ago
Ferdinand Thiessen
253f4345f1
fix(files_sharing): Respect permissions passed when creating link shares
Given:
User creates a link or email share with permissions=4 (create only = file drop).
Problem:
Currently the permissions are automatically extended to permissions = 5
(READ + CREATE). Work around was to create the share and directly update
it.
Solution:
Respect what the user is requesting, create a file drop share.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
9 months ago
Daniel Calviño Sánchez
b59c71ccf8
test: Add integration tests for moving a file from and to a shared folder
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
12 months ago
Joas Schilling
c1655bcde7
fix(ratelimit): Allow to bypass rate-limit from bruteforce allowlist
Signed-off-by: Joas Schilling <coding@schilljs.com>
9 months ago
Ferdinand Thiessen
eea91fa1ba
fix(TemplateLayout): `core` is not an app but the server itself
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
9 months ago
Richard Steinmetz
d3126cd1bb
fix(dav): default calendar and address book not created on first login
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
9 months ago
skjnldsv
abd3cb60fc
fix(files): more conversion tests and translate error messages
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
9 months ago
skjnldsv
19ce362896
chore: add file conversion integration tests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
9 months ago
Côme Chilliet
a741c6cfa1
chore(psalm): Update baseline to remove fixed errors
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
9 months ago