The XML data received from the comments endpoint has an inconsistent
encoding; some entities are encoded once and others are encoded twice.
When the comment list is loaded the comments are fetched using
GetComments, which handles all that, and therefore shows the messages
and author names as expected.
However, when a new comment is posted the list is not got again; instead
the new comment is loaded from the comment data returned after posting
it. This is done in NewComment, which did not decode the messages nor
the author names, and therefore showed, for example, "&" instead of
"&".
To solve that now the same decoding logic used in GetComments is applied
too in NewComment.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
- it is config specific and cannot be shared
- because the Access instance is bound later, it is not obvious from the
constructor
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Although the Files app creates the legacy sidebar (details view) it is
then replaced with the newer Vue app sidebar. Due to this ".detailsView"
no longer finds an element and therefore nothing was hidden when
"hideAppSidebar($('.detailsView'))" was called (for example, when
changing to another section).
However, "OC.Apps.hideAppSidebar()" does not properly work either with
the Vue sidebar used in the Files app (once hidden the sidebar is not
shown again). For simplicity, and to avoid any possible side effect in
other apps from changing "OC.Apps.hideAppSidebar", now
"OC.Files.Sidebar.close()" is used instead.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
and clean up the code a bit.
Added:
- author
Removed:
- unused imports
Changed:
- moved iMIP handling to new interface
- pointed code to new implementation
Signed-off-by: Anna Larch <anna@nextcloud.com>
Fixed visibility of the expiration date field for internal shares by
aligning the logic with the one from the public link shares.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
We remove all outdated sync tokens, based on their auto-incremented ID.
By default we only keep the last 10 000, but this can be configurable.
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Nextcloud bot
Daniel Calviño Sánchez
Arthur Schiwon
Richard Steinmetz
szaimen
Markus Zeller
Joas Schilling
Anna Larch
John Molakvoæ
Vincent Petry
Christopher Ng
Thomas Citharel
Julius Härtl
Côme Chilliet
Roeland Jago Douma