provokateurin
4b90a2c730
build(psalm): Raise PHP version to 8.2
Signed-off-by: provokateurin <kate@provokateurin.de>
4 months ago
Carl Schwan
324b54b863
refactor(preview): Cleanup the implementation of the new preview backend
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
5 months ago
Daniel Kesselberg
28dc3e2d85
chore: move smb package to 3rdparty
- Automated updates
- Easier maintenance
- Not having another copy of the streams packages
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
7 months ago
Edward Ly
86533681e8
fix(psalm): suppress UndefinedClass error for OCA\ContextChat\Public\ContentManager
Signed-off-by: Edward Ly <contact@edward.ly>
7 months ago
Jana Peper
603522a59c
test: fix tests
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
7 months ago
Ferdinand Thiessen
2986fead40
chore: ignore 3rdparty while psalm linting
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
9 months ago
provokateurin
0f2f4aab5c
feat(psalm): Mark all usage of deprecated code as error
Signed-off-by: provokateurin <kate@provokateurin.de>
9 months ago
Julius Knorr
3fc9a99521
perf: Add config options to trigger individual and sample profiling using excimer
Signed-off-by: Julius Knorr <jus@bitgrid.net>
10 months ago
Ferdinand Thiessen
4a64cf54ba
ci: test that all apps are enabled for psalm
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
10 months ago
Ferdinand Thiessen
c0212af7fa
chore: lint files_reminders using psalm
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
10 months ago
provokateurin
6fd17994fb
fix(psalm): Enable findUnusedBaselineEntry
Signed-off-by: provokateurin <kate@provokateurin.de>
1 year ago
Ferdinand Thiessen
2ec68b1eb9
refactor(Log): Use new in initializer instead of constructor body
PHP 8.1 allows us to now move the `new` into the initializer,
this makes the code a bit nicer (and 3 lines shorter).
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2 years ago
Robin Appelman
5490b12feb
chore: add psalm false positive to psalm.xml
Signed-off-by: Robin Appelman <robin@icewind.nl>
2 years ago
provokateurin
a94249d1d5
build(psalm): Enforce named attribute arguments
Signed-off-by: provokateurin <kate@provokateurin.de>
2 years ago
Côme Chilliet
19bc3ed1e3
chore(webhooks): Rename webhooks application to webhook_listeners
There is already a webhooks application in the appstore
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2 years ago
Andy Scherzinger
1df96b0417
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2 years ago
Côme Chilliet
9092dcfd41
chore: Fix psalm to use correct php version depending on branch
Needs to be adapted on each branch to reflect the used PHP version and
help with baseline updating.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2 years ago
Julius Härtl
c7813bfdaf
feat: Implement team provider api
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2 years ago
Côme Chilliet
05de5e27eb
chore(psalm): Include cron.php into psalm checked files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2 years ago
Joas Schilling
00acf1bae1
feat(CI): Add a stub for SensitiveParameter, so Psalm is not failing on Doctrine/DBAL
Signed-off-by: Joas Schilling <coding@schilljs.com>
3 years ago
Maxence Lange
8b9e7e235d
ocm controller
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2 years ago
Alexander Piskun
01a11641f4
new name of AppEcosystem is AppAPI
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
2 years ago
Andrey Borysenko
d3583d3f30
Fix psalm ci (stub). Wrap server container with try-catch
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
3 years ago
jld3103
cd91b77193
psalm: Enable more/less specific errors
Signed-off-by: jld3103 <jld3103yt@gmail.com>
3 years ago
Maxence Lange
d2efd0e03c
displayname on federated shares
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
3 years ago
jld3103
9fddbeaa54
Use psalm 5
Signed-off-by: jld3103 <jld3103yt@gmail.com>
3 years ago
jld3103
fa53c7c5a7
Set recommended psalm options
Signed-off-by: jld3103 <jld3103yt@gmail.com>
3 years ago
jld3103
4d390b5f54
Add stubs for Psr\Container to allow running psalm with multiple threads
Signed-off-by: jld3103 <jld3103yt@gmail.com>
3 years ago
Julius Härtl
cb30c81010
chore(psalm): Make psalm aware of sabre/uri
Signed-off-by: Julius Härtl <jus@bitgrid.net>
3 years ago
John Molakvoæ
1dee36c761
Remove accessibility
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
4 years ago
Côme Chilliet
139da41bd4
Add stubs for ZipArchive
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
4 years ago
Carl Schwan
aeecb72e96
Fix a few psalm issues and moved back to psalm/phar 4.18
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
4 years ago
Côme Chilliet
24e9a29b3c
Add PHP 8.1 LDAP classes to ignored missing classes in psalm for docblocks
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
4 years ago
Côme Chilliet
3631789651
Fix resource usages in OC_Image
This makes sure using resource or GdImage (PHP>=8) behaves the same.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
4 years ago
Joas Schilling
3710eca104
Allow "TwoFactor Nextcloud Notifications" to pull the state of the 2FA again
Signed-off-by: Joas Schilling <coding@schilljs.com>
4 years ago
Richard Steinmetz
8bd8e97181
Do not cache file ids in FileSystemTags inside group folders
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
4 years ago
Julius Härtl
2d932b6b86
Add whitelist for apps inside of the server repo
Signed-off-by: Julius Härtl <jus@bitgrid.net>
5 years ago
Julius Härtl
8286f46ab9
Suppress psalm warnings about app classes
Signed-off-by: Julius Härtl <jus@bitgrid.net>
5 years ago
Lukas Reschke
47ac8e0028
Add Psalm Taint Flow Analysis
This adds the Psalm Security Analysis, as described at
https://psalm.dev/docs/security_analysis/
It also adds a plugin for adding input into AppFramework.
The results can be viewed in the GitHub Security tab at
https://github.com/nextcloud/server/security/code-scanning
**Q&A:**
Q: Why do you not use the shipped Psalm version?
A: I do a lot of changes to the Psalm Taint behaviour. Using released
versions is not gonna get us the results we want.
Q: How do I improve false positives?
A: https://psalm.dev/docs/security_analysis/avoiding_false_positives/
Q: How do I add custom sources?
A: https://psalm.dev/docs/security_analysis/custom_taint_sources/
Q: We should run this on apps!
A: Yes.
Q: What will change in Psalm?
A: Quite some of the PHP core functions are not yet marked to propagate
the taint. This leads to results where the taint flow is lost. That's
something that I am currently working on.
Q: Why is the plugin MIT licensed?
A: Because its the first of its kind (based on GitHub Code Search) and
I want other people to copy it if they want to. Security is for all :)
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
5 years ago
Arthur Schiwon
86e5e7d927
LDAP simplify User_Proxy and Group_Proxy signatures
- make User_Proxy and Group_Proxy easy to instantiate
- simplify dependent code
- move commands to info.xml
- make UpdateGroups job class non-static
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
5 years ago
Morris Jobke
b70792aa6a
Add stubs for gd, intl, IntlChar, ldap, redis_cluster and xsl
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
6 years ago
Morris Jobke
4efca69f8d
Add psalm baseline
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
6 years ago
Daniel Kesselberg
8d18f0a7d7
Suppress warning for template functions.
6e8e34fef9/lib/private/legacy/template/functions.php
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
6 years ago
Daniel Kesselberg
90aa451447
Fix variable name for referenced variable.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
6 years ago
Daniel Kesselberg
fe3a628470
Supress UndefinedGlobalVariable for register_command.php
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
6 years ago
Daniel Kesselberg
568e1f6d3a
Remove directory/file element.
It will suppress any error of that kind in the file. That was not intended.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
6 years ago
Daniel Kesselberg
238f181dbf
Suppress warning for $_ and $l
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
6 years ago
Daniel Kesselberg
dd721fc5de
Fix: UndefinedFunction Function x does not exist in templates
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
6 years ago
Daniel Kesselberg
fd6cdbcb04
Add template functions
for some reason they are not loaded by default.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
6 years ago
Daniel Kesselberg
8b3b5ae5be
Add stubs for phpseclib
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
6 years ago