f5039750b3
chore: fix formatting
Signed-off-by: Josh <josh.t.richards@gmail.com>
5 months ago
5131897997
fix(workflowenigne): stricter length headler handling
Fixes #55276 and tidies things up a bit more for future maintenance.
Signed-off-by: Josh <josh.t.richards@gmail.com>
5 months ago
6154bfa823
chore(psalm): Fix most issues with the workflowengine
This found a real bug where we were catching an Doctrine exception
instead of a OCP\DB\Exception. This will be backported separately.
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
6 months ago
7e1c49ad9d
refactor: Port away from IQueryBuilder::execute in apps/
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
6 months ago
0e7d5dce1c
refactor: Port away from changeColumn
Replace by the drop-in replacement modifyColumn
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
6 months ago
78dcf3744d
Revert "feat: Implement Directory Check"
This reverts commit feae8ba16a
7 months ago
feae8ba16a
feat: Implement Directory Check
* Partially implements #27591
Signed-off-by: Robin Windey <ro.windey@gmail.com>
1 year ago
5981b7eb51
chore: apply new CSFixer rules
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
8 months ago
cd3a88805b
fix: Remove legacy hacky workaround in OCA\WorkflowEngine\Listener
It is not needed anymore since OCP\Util::addScript is used directly now,
and not the function "script" from template functions.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
1 year ago
64863c9d46
chore: Apply new rector configuration to apps folder
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
1 year ago
f25a71806b
fix(apps): Fix wrong or missing casts
Signed-off-by: provokateurin <kate@provokateurin.de>
1 year ago
381077028a
refactor(apps): Use constructor property promotion when possible
Signed-off-by: provokateurin <kate@provokateurin.de>
1 year ago
c254855222
chore(db): Correctly apply query types
fix: psalm
fix: error
fix: add batch
fix: fatal error
fix: add batch
chore: add batch
chore: add batch
fix: psalm
fix: typo
fix: psalm
fix: return bool
fix: revert Manager
1 year ago
1a4978c4ea
chore: Apply rector configuration to apps folder
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
1 year ago
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
Signed-off-by: provokateurin <kate@provokateurin.de>
1 year ago
c2fb7a72da
fix(psalm): Fix @throws annotations
Signed-off-by: provokateurin <kate@provokateurin.de>
1 year ago
af6de04e9e
style: update codestyle for coding-standard 1.2.3
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2 years ago
e64667df37
refactor(workflowengine): Replace security annotations with respective attributes
Signed-off-by: provokateurin <kate@provokateurin.de>
2 years ago
a2a0a5afcb
fix(workflows): Fix file systemtag cache
Signed-off-by: Joas Schilling <coding@schilljs.com>
2 years ago
cc1686dba9
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2 years ago
ec5133b739
fix: Apply new coding standard to all files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2 years ago
8bcc2d352e
chore: Fix missing template parameter for IEventListener
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2 years ago
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2 years ago
d8ffbed2c2
fix(workflows): Finish password confirmation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2 years ago
93505b2cdd
fix(workflowengine): use andWhere() not second where()
- an unconditional where() condition is added right before
- fixes also wrongly named methods in the Exception message
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2 years ago
997a1c46fb
fix(workflow): Fix "Call to a member function getUID() on null" with appdata
Signed-off-by: Joas Schilling <coding@schilljs.com>
2 years ago
7441ce2b11
enh(IMountManager): Add method to get MountPoint from CachedMountInfo
Signed-off-by: Jonas <jonas@freesources.org>
2 years ago
9193d8be40
fix(isLegitimatedForUserId): Setup mountpoints to check file access
This fixes workflows on groupfolders, as it will consider access to
files in groupfolders.
It also fixes false positives where access to files was limited by other
means not taken into account before, e.g. access control.
For postDelete events, check for permissions of the parent folder
instead, as the file itself no longer exists.
Fixes : nextcloud/flow_notifications#71
Signed-off-by: Jonas <jonas@freesources.org>
2 years ago
0a9371f99f
Migrate applications away from deprecated ILogger
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2 years ago
aa039c986a
fix(workflowengine): Remove legacy event (deprecated since 17)
Signed-off-by: Joas Schilling <coding@schilljs.com>
3 years ago
06d80ba809
fix: Avoid failing with duplicate checks
Signed-off-by: Julius Härtl <jus@bitgrid.net>
3 years ago
9d15e6e21d
Fixes "PossiblyFalseArgument" notices.
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
3 years ago
5db241b942
Refactors "strpos" calls in /apps/workflowengine to improve code readability.
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
3 years ago
efb7448cd2
workflowengine: Stop using a service alias for controller
Signed-off-by: jld3103 <jld3103yt@gmail.com>
3 years ago
9ba091b348
fix(workflow): Check tag attribute
Signed-off-by: Joas Schilling <coding@schilljs.com>
3 years ago
5bc86dd6ac
techdebt(workflowengine): Remove transition event classes
Signed-off-by: Joas Schilling <coding@schilljs.com>
3 years ago
15fc42966c
Also check the scope when reading operations from the database
Signed-off-by: Joas Schilling <coding@schilljs.com>
3 years ago
c6700150d5
Validate the scope when validating operations
Signed-off-by: Joas Schilling <coding@schilljs.com>
3 years ago
aebf654214
perf(workflowengine): Cache query that is performed on every request
Signed-off-by: Julius Härtl <jus@bitgrid.net>
3 years ago
83cc8202b8
remove file exists check from `cacheAndReturnMimeType`
the method is only called if the file exists already
a check against storing the fallback mimetype is added as a safety instead
Signed-off-by: Robin Appelman <robin@icewind.nl>
5 years ago
c5a8246742
use mimetype from cache for workflow if available
Signed-off-by: Robin Appelman <robin@icewind.nl>
5 years ago
a0f6a6545b
Use TimedJob from OCP instead of OC
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
3 years ago
9ba9f9a7dc
Make sure to not pass null to DateTime::createFromFormat
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
3 years ago
d5c23dbb9f
Move CappedMemoryCache to OCP
This is an helpful helper that should be used in more place than just
server and this is already the case with groupfodlers, deck, user_oidc
and more using it, so let's make it public
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
4 years ago
30d7763edc
Use SettingsSection in workflowengine settings
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
4 years ago
ec6b83cc18
Add stricter psalm type for CappedMemoryCache
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
4 years ago
64951ec14e
Change script loading order in worflowengine
Fix: https://github.com/nextcloud/server/issues/31709
Signed-off-by: Louis Chemineau <louis@chmn.me>
4 years ago
ccab35f23f
Fix similar potential problems with fetchOne loops
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
4 years ago
cbf9064b8e
Fix psalm issues
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
4 years ago
695165260f
Add helper method in Wrapper
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
4 years ago
Josh
Carl Schwan
Joas Schilling
Robin Windey
Ferdinand Thiessen
Côme Chilliet
provokateurin
Git'Fellow
Daniel Kesselberg
Andy Scherzinger
Arthur Schiwon
Jonas
Julius Härtl
Faraz Samapoor
Faraz Samapoor
jld3103
Robin Appelman
Carl Schwan
Louis Chemineau