Browse Source

feat(admin-delegation): add JSON output support with validation

- Add --output option supporting plain, json, and json_pretty formats
- Add validateOutputFormat() method for input validation
- Implement proper error handling for invalid output formats
- Support empty state handling for both plain and JSON outputs
- Use Base class writeArrayInOutputFormat() for consistent JSON output
- Maintain backward compatibility with plain format as default

Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
pull/55260/head
Misha M.-Kupriyanov 4 weeks ago
committed by Mikhailo Matiyenko-Kupriyanov
parent
commit
c04398c2bd
  1. 36
      apps/settings/lib/Command/AdminDelegation/Show.php

36
apps/settings/lib/Command/AdminDelegation/Show.php

@ -26,6 +26,7 @@ class Show extends Base {
}
protected function configure(): void {
parent::configure();
$this
->setName('admin-delegation:show')
->setDescription('show delegated settings')
@ -34,17 +35,37 @@ class Show extends Base {
protected function execute(InputInterface $input, OutputInterface $output): int {
$io = new SymfonyStyle($input, $output);
$outputFormat = $input->getOption('output');
// Validate output format
if (!$this->validateOutputFormat($outputFormat)) {
$io->error("Invalid output format: {$outputFormat}. Valid formats are: plain, json, json_pretty");
return 1;
}
// Collect delegation data
$delegationData = $this->collectDelegationData();
// Handle empty results
if (empty($delegationData)) {
$io->info('No delegated settings found.');
if ($outputFormat === self::OUTPUT_FORMAT_PLAIN) {
$io->info('No delegated settings found.');
} else {
$this->writeArrayInOutputFormat($input, $io, []);
}
return 0;
}
$this->outputPlainFormat($io, $delegationData);
// Output based on format
switch ($outputFormat) {
case self::OUTPUT_FORMAT_JSON:
case self::OUTPUT_FORMAT_JSON_PRETTY:
$this->writeArrayInOutputFormat($input, $io, $delegationData);
break;
default:
$this->outputPlainFormat($io, $delegationData);
break;
}
return 0;
}
@ -118,6 +139,17 @@ class Show extends Base {
}
}
/**
* Validate the output format parameter
*/
private function validateOutputFormat(string $format): bool {
return in_array($format, [
self::OUTPUT_FORMAT_PLAIN,
self::OUTPUT_FORMAT_JSON,
self::OUTPUT_FORMAT_JSON_PRETTY
], true);
}
/**
* @param IDelegatedSettings[] $settings
* @param array $innerSection

Loading…
Cancel
Save