Browse Source

chore(tests): Fix Router test by mocking AppManager methods correctly

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
pull/47927/head
Côme Chilliet 2 years ago
parent
commit
7a16d01ea7
No known key found for this signature in database GPG Key ID: A3E2F658B28C760A
  1. 14
      tests/lib/Route/RouterTest.php

14
tests/lib/Route/RouterTest.php

@ -13,6 +13,7 @@ use OCP\App\IAppManager;
use OCP\Diagnostics\IEventLogger; use OCP\Diagnostics\IEventLogger;
use OCP\IConfig; use OCP\IConfig;
use OCP\IRequest; use OCP\IRequest;
use PHPUnit\Framework\MockObject\MockObject;
use Psr\Container\ContainerInterface; use Psr\Container\ContainerInterface;
use Psr\Log\LoggerInterface; use Psr\Log\LoggerInterface;
use Test\TestCase; use Test\TestCase;
@ -26,6 +27,8 @@ use Test\TestCase;
*/ */
class RouterTest extends TestCase { class RouterTest extends TestCase {
private Router $router; private Router $router;
private IAppManager&MockObject $appManager;
protected function setUp(): void { protected function setUp(): void {
parent::setUp(); parent::setUp();
/** @var LoggerInterface $logger */ /** @var LoggerInterface $logger */
@ -36,13 +39,16 @@ class RouterTest extends TestCase {
$this->fail('Unexpected info log: '.(string)($data['exception'] ?? $message)); $this->fail('Unexpected info log: '.(string)($data['exception'] ?? $message));
} }
); );
$this->appManager = $this->createMock(IAppManager::class);
$this->router = new Router( $this->router = new Router(
$logger, $logger,
$this->createMock(IRequest::class), $this->createMock(IRequest::class),
$this->createMock(IConfig::class), $this->createMock(IConfig::class),
$this->createMock(IEventLogger::class), $this->createMock(IEventLogger::class),
$this->createMock(ContainerInterface::class), $this->createMock(ContainerInterface::class),
$this->createMock(IAppManager::class),
$this->appManager,
); );
} }
@ -51,6 +57,12 @@ class RouterTest extends TestCase {
} }
public function testGenerateConsecutively(): void { public function testGenerateConsecutively(): void {
$this->appManager->expects(self::atLeastOnce())
->method('cleanAppId')
->willReturnArgument(0);
$this->appManager->expects(self::atLeastOnce())
->method('getAppPath')
->willReturnCallback(fn (string $appid): string => \OC::$SERVERROOT . '/apps/' . $appid);
$this->assertEquals('/index.php/apps/files/', $this->router->generate('files.view.index')); $this->assertEquals('/index.php/apps/files/', $this->router->generate('files.view.index'));

Loading…
Cancel
Save