Browse Source
Add optional column oc_comments.reference_id
Add optional column oc_comments.reference_id
Signed-off-by: Joas Schilling <coding@schilljs.com>pull/19890/head
Joas Schilling
6 years ago
No known key found for this signature in database
GPG Key ID: 7076EA9751AACDDA
11 changed files with 216 additions and 1 deletions
-
11apps/settings/lib/Controller/CheckSetupController.php
-
1apps/settings/tests/Controller/CheckSetupControllerTest.php
-
18core/Application.php
-
105core/Command/Db/AddMissingColumns.php
-
2core/Command/Db/AddMissingIndices.php
-
4core/Migrations/Version13000Date20170718121200.php
-
15core/js/setupchecks.js
-
15core/js/tests/specs/setupchecksSpec.js
-
1core/register_command.php
-
43lib/private/DB/MissingColumnInformation.php
-
2lib/public/IDBConnection.php
@ -0,0 +1,105 @@ |
|||
<?php |
|||
|
|||
declare(strict_types=1); |
|||
|
|||
/** |
|||
* @copyright Copyright (c) 2020 Joas Schilling <coding@schilljs.com> |
|||
* |
|||
* @author Joas Schilling <coding@schilljs.com> |
|||
* |
|||
* @license GNU AGPL version 3 or any later version |
|||
* |
|||
* This program is free software: you can redistribute it and/or modify |
|||
* it under the terms of the GNU Affero General Public License as |
|||
* published by the Free Software Foundation, either version 3 of the |
|||
* License, or (at your option) any later version. |
|||
* |
|||
* This program is distributed in the hope that it will be useful, |
|||
* but WITHOUT ANY WARRANTY; without even the implied warranty of |
|||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|||
* GNU Affero General Public License for more details. |
|||
* |
|||
* You should have received a copy of the GNU Affero General Public License |
|||
* along with this program. If not, see <http://www.gnu.org/licenses/>. |
|||
* |
|||
*/ |
|||
|
|||
namespace OC\Core\Command\Db; |
|||
|
|||
use OC\DB\SchemaWrapper; |
|||
use OCP\IDBConnection; |
|||
use Symfony\Component\Console\Command\Command; |
|||
use Symfony\Component\Console\Input\InputInterface; |
|||
use Symfony\Component\Console\Output\OutputInterface; |
|||
use Symfony\Component\EventDispatcher\EventDispatcherInterface; |
|||
use Symfony\Component\EventDispatcher\GenericEvent; |
|||
|
|||
/** |
|||
* Class AddMissingColumns |
|||
* |
|||
* if you added a new lazy column to the database, this is the right place to add |
|||
* your update routine for existing instances |
|||
* |
|||
* @package OC\Core\Command\Db |
|||
*/ |
|||
class AddMissingColumns extends Command { |
|||
|
|||
/** @var IDBConnection */ |
|||
private $connection; |
|||
|
|||
/** @var EventDispatcherInterface */ |
|||
private $dispatcher; |
|||
|
|||
public function __construct(IDBConnection $connection, EventDispatcherInterface $dispatcher) { |
|||
parent::__construct(); |
|||
|
|||
$this->connection = $connection; |
|||
$this->dispatcher = $dispatcher; |
|||
} |
|||
|
|||
protected function configure() { |
|||
$this |
|||
->setName('db:add-missing-columns') |
|||
->setDescription('Add missing optional columns to the database tables'); |
|||
} |
|||
|
|||
protected function execute(InputInterface $input, OutputInterface $output) { |
|||
$this->addCoreColumns($output); |
|||
|
|||
// Dispatch event so apps can also update columns if needed
|
|||
$event = new GenericEvent($output); |
|||
$this->dispatcher->dispatch(IDBConnection::ADD_MISSING_COLUMNS_EVENT, $event); |
|||
} |
|||
|
|||
/** |
|||
* add missing indices to the share table |
|||
* |
|||
* @param OutputInterface $output |
|||
* @throws \Doctrine\DBAL\Schema\SchemaException |
|||
*/ |
|||
private function addCoreColumns(OutputInterface $output) { |
|||
|
|||
$output->writeln('<info>Check columns of the comments table.</info>'); |
|||
|
|||
$schema = new SchemaWrapper($this->connection); |
|||
$updated = false; |
|||
|
|||
if ($schema->hasTable('comments')) { |
|||
$table = $schema->getTable('comments'); |
|||
if (!$table->hasColumn('reference_id')) { |
|||
$output->writeln('<info>Adding additional reference_id column to the comments table, this can take some time...</info>'); |
|||
$table->addColumn('reference_id', 'string', [ |
|||
'notnull' => false, |
|||
'length' => 64, |
|||
]); |
|||
$this->connection->migrateToSchema($schema->getWrappedSchema()); |
|||
$updated = true; |
|||
$output->writeln('<info>Comments table updated successfully.</info>'); |
|||
} |
|||
} |
|||
|
|||
if (!$updated) { |
|||
$output->writeln('<info>Done.</info>'); |
|||
} |
|||
} |
|||
} |
|||
@ -0,0 +1,43 @@ |
|||
<?php |
|||
|
|||
declare(strict_types=1); |
|||
|
|||
/** |
|||
* @copyright Copyright (c) 2020 Joas Schilling <coding@schilljs.com> |
|||
* |
|||
* @author Joas Schilling <coding@schilljs.com> |
|||
* |
|||
* @license GNU AGPL version 3 or any later version |
|||
* |
|||
* This program is free software: you can redistribute it and/or modify |
|||
* it under the terms of the GNU Affero General Public License as |
|||
* published by the Free Software Foundation, either version 3 of the |
|||
* License, or (at your option) any later version. |
|||
* |
|||
* This program is distributed in the hope that it will be useful, |
|||
* but WITHOUT ANY WARRANTY; without even the implied warranty of |
|||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|||
* GNU Affero General Public License for more details. |
|||
* |
|||
* You should have received a copy of the GNU Affero General Public License |
|||
* along with this program. If not, see <http://www.gnu.org/licenses/>. |
|||
* |
|||
*/ |
|||
|
|||
namespace OC\DB; |
|||
|
|||
class MissingColumnInformation { |
|||
|
|||
private $listOfMissingColumns = []; |
|||
|
|||
public function addHintForMissingColumn(string $tableName, string $columnName): void { |
|||
$this->listOfMissingColumns[] = [ |
|||
'tableName' => $tableName, |
|||
'columnName' => $columnName, |
|||
]; |
|||
} |
|||
|
|||
public function getListOfMissingColumns(): array { |
|||
return $this->listOfMissingColumns; |
|||
} |
|||
} |
|||
Write
Preview
Loading…
Cancel
Save
Reference in new issue