From 51a493cbe7b282416c968fe384a0a1e49f234d2f Mon Sep 17 00:00:00 2001
From: provokateurin <kate@provokateurin.de>
Date: Wed, 1 Oct 2025 12:44:02 +0200
Subject: [PATCH] fix(IGroupManager): Use correct return type for search method

Signed-off-by: provokateurin <kate@provokateurin.de>
---
 apps/provisioning_api/lib/Controller/GroupsController.php | 8 ++++----
 build/psalm-baseline.xml                                  | 2 --
 lib/private/Group/Manager.php                             | 6 ------
 lib/public/IGroupManager.php                              | 2 +-
 4 files changed, 5 insertions(+), 13 deletions(-)

diff --git a/apps/provisioning_api/lib/Controller/GroupsController.php b/apps/provisioning_api/lib/Controller/GroupsController.php
index a1a94b56b43..62f639b48e4 100644
--- a/apps/provisioning_api/lib/Controller/GroupsController.php
+++ b/apps/provisioning_api/lib/Controller/GroupsController.php
@@ -78,10 +78,10 @@ class GroupsController extends AUserDataOCSController {
 	#[NoAdminRequired]
 	public function getGroups(string $search = '', ?int $limit = null, int $offset = 0): DataResponse {
 		$groups = $this->groupManager->search($search, $limit, $offset);
-		$groups = array_values(array_map(function ($group) {
+		$groups = array_map(function ($group) {
 			/** @var IGroup $group */
 			return $group->getGID();
-		}, $groups));
+		}, $groups);
 
 		return new DataResponse(['groups' => $groups]);
 	}
@@ -101,7 +101,7 @@ class GroupsController extends AUserDataOCSController {
 	#[AuthorizedAdminSetting(settings: Users::class)]
 	public function getGroupsDetails(string $search = '', ?int $limit = null, int $offset = 0): DataResponse {
 		$groups = $this->groupManager->search($search, $limit, $offset);
-		$groups = array_values(array_map(function ($group) {
+		$groups = array_map(function ($group) {
 			/** @var IGroup $group */
 			return [
 				'id' => $group->getGID(),
@@ -111,7 +111,7 @@ class GroupsController extends AUserDataOCSController {
 				'canAdd' => $group->canAddUser(),
 				'canRemove' => $group->canRemoveUser(),
 			];
-		}, $groups));
+		}, $groups);
 
 		return new DataResponse(['groups' => $groups]);
 	}
diff --git a/build/psalm-baseline.xml b/build/psalm-baseline.xml
index 92479b887aa..6dea3b11d9c 100644
--- a/build/psalm-baseline.xml
+++ b/build/psalm-baseline.xml
@@ -3701,8 +3701,6 @@
   <file src="lib/private/Group/Manager.php">
     <LessSpecificReturnStatement>
       <code><![CDATA[$groups]]></code>
-      <code><![CDATA[array_values($groups)]]></code>
-      <code><![CDATA[array_values($groups)]]></code>
     </LessSpecificReturnStatement>
     <MoreSpecificReturnType>
       <code><![CDATA[\OC\Group\Group[]]]></code>
diff --git a/lib/private/Group/Manager.php b/lib/private/Group/Manager.php
index 8feb027d180..1dcbcfd7a0c 100644
--- a/lib/private/Group/Manager.php
+++ b/lib/private/Group/Manager.php
@@ -264,12 +264,6 @@ class Manager extends PublicEmitter implements IGroupManager {
 		}
 	}
 
-	/**
-	 * @param string $search
-	 * @param ?int $limit
-	 * @param ?int $offset
-	 * @return \OC\Group\Group[]
-	 */
 	public function search(string $search, ?int $limit = null, ?int $offset = 0) {
 		$groups = [];
 		foreach ($this->backends as $backend) {
diff --git a/lib/public/IGroupManager.php b/lib/public/IGroupManager.php
index ee88990df79..eda95187f63 100644
--- a/lib/public/IGroupManager.php
+++ b/lib/public/IGroupManager.php
@@ -75,7 +75,7 @@ interface IGroupManager {
 	 * @param string $search
 	 * @param ?int $limit
 	 * @param ?int $offset
-	 * @return \OCP\IGroup[]
+	 * @return list<IGroup>
 	 * @since 8.0.0
 	 */
 	public function search(string $search, ?int $limit = null, ?int $offset = 0);